< >
Hello, guest! Please log in or register.

The PokéCommunity

Go Back     The PokéCommunity Forums > Members List Mateo's Profile

Notices

Mateo Mateo is online now

Johto Region Champion

Visitor Messages

Showing Visitor Messages 61 to 75 of 604
  1. Crystal_
    January 5th, 2016 3:41 PM
    Crystal_
    ah no, nevermind, the version of the hack i got is the older one. im just very confused lol
  2. Crystal_
    January 5th, 2016 3:39 PM
    Crystal_
    lol, so then the bug I've indentified in GetName is just a bug you accidentally introduced 4 hours ago then? Because the real bug could be completely unrelated to this (and chances are, it is, since the way you had GetName 4 hours ago looks good).
  3. Crystal_
    January 5th, 2016 3:34 PM
    Crystal_
    and the way it was before that commit was buggy too? looks fine to me
  4. Crystal_
    January 5th, 2016 3:29 PM
    Crystal_
    the register a, which took its value from d0b5, that is.
  5. Crystal_
    January 5th, 2016 3:28 PM
    Crystal_
    lol forget about what i just said. I'm getting confused with the addresses because I'm looking at both repos at once. wNameListType indeed contains a list id which is 04. The problem as you just said, is that it overwrites wd0b5.
  6. Crystal_
    January 5th, 2016 3:21 PM
    Crystal_
    i dont think i was clear enough, sorry. The issue is that what wNameListType actually holds at that point is the item id, not a list id (at least when using tm/hm).
  7. Crystal_
    January 5th, 2016 3:19 PM
    Crystal_
    basically you are treating any item that has no id 4 (i think id 4 is pokeball) as NOT an item, because ITEM_NAME is 4. You were basically depending on the buffer containing a terminator character from a previous string/data to make TM/HMs not crash the game. Or a terminator character close enough to the buffer in RAM so that not too much gets corrupted.

    Is there any reason you added that lines?
  8. Crystal_
    January 5th, 2016 3:12 PM
    Crystal_
    lol

    Quote:
    ld a,[wNameListType]
    cp ITEM_NAME
    jr nz, .noItem
    This is broken and you added it! I've been thinking all this time it was in original pokered too but opened up a clean rom and noticed the GetName functions didn't match...
  9. Crystal_
    January 5th, 2016 2:46 PM
    Crystal_
    It seems to me that it could be that the TM doesn't get caught here (https://github.com/TheFakeMateo/RedP...home.asm#L3268) after GetName was called here (https://github.com/TheFakeMateo/redp...home.asm#L1509). TM/HM don't have hardcoded names, they generate their names based on their number instead. If it doesn't get caught as a TM/HM it basically ends up with no name and no terminator character (https://github.com/TheFakeMateo/RedP...home.asm#L1985).

    If I'm right in this supposition it's either that wd0b5 or wNameListType have the wrong value when GetName is called (line 1509 in home.asm) (the former should be the item id latter should be ITEM_NAME = $03).
  10. Crystal_
    January 5th, 2016 2:23 PM
    Crystal_
    I managed to fix it in that very save state by adding a little hack that copies 50 to wcd6d before calling CopyStringToCF4B, but surely there has to be a better solution. But I really can't do much else without being able to debug it, so hopefully this solution suffices and doesn't break anything else. If you do this don't write 50 to wcd6d, but to the end of the buffer which is cd80 at most (so that it doesn't possibly terminate any other string that might pass through there).
  11. Crystal_
    January 5th, 2016 1:59 PM
    Crystal_
    It crashes here and exactly here: https://github.com/TheFakeMateo/redp...home.asm#L1523
    Calls CopyStringToCF4B but never comes back which probably will be because the string (name) at wcd6d is not terminated.

    Will keep looking into it.
  12. TyHawk4501
    January 4th, 2016 5:58 PM
    TyHawk4501
    Hey Mateo! How are you today?
  13. Crystal_
    January 4th, 2016 3:06 AM
    Crystal_
    I honestly don't know. Since he claimed that he was able to make the game crash 100% maybe you can ask him for a save state of that point? I could try blindly testing the game to try to make it crash but I probably won't be able to if it never ever happened to you. If you can manage to isolate the bug in a save state I guess I can help debugging it if you need it.

    I remember I had an issue in Pokemon Pyrite and it was because the properities of an item (not a TM) were accidentally shifted one byte but it makes little sense to have a similar bug like this since you didn't do it with hex editing.
  14. Crystal_
    January 3rd, 2016 12:41 PM
    Crystal_
    Not really, that would only disable input during the negligible amount of time the game is executing your FaceEnemyTrainer function. You'd have to disable it whenever the trainer notices you, before they start walking to you. That being said, that was just my assumption. I know it has to be related to the clash with the index item address but everything else was just assumptions. If you could test it yourself with that trainer and try pressing the A button right after the '!' displays, to see if the facing became wrong would be preferable. The hidden item in viridian happens to be exactly in the spot where the wrongly facing sprite was in that pic, which might or might not be related (probably not).

    Rather than disabling player input anyway, what I did was calling the equivalent to your FaceEnemyTrainer function just after coming back from EngageMapTrainer (https://github.com/xCrystal/pokered/...db7b146169ed88). It seems to always work fine for me as I in fact test all the battle stuff with regular trainers in viridian forest and never had the player look to the wrong direction. That also makes the player start looking to the trainer before they walk to you.
  15. TheRealOCD
    December 6th, 2015 3:34 PM
    TheRealOCD
    Yo

About Me

  • About Mateo
    Biography
    Hey guys, I'm Mateo. I was the co-founder of the Skeetendo Inc. Hacking Group (before it was a community, when it was just me and Pyro). I'm still a huge fan of Gen II, and so I still enjoy playing and hacking those games. I'm currently working on a "Johto Legacy" series that continues the story of G/S/C that consists of the "Pokémon Christmas" hack, and an upcoming prequel called "Pokémon Spirits and Legends" (that currently has no thread here).
    Interests
    Rom Hacking, Internetting, Cooking, The Sims 2, Music, Random things, Etc.
    Location
    Willow Creek, Sims 4
    Occupation
    Romhacker
    Nature
    Quiet
    Also Known As
    Luna
    Favorite Pokémon
    Lugia, Mewtwo, Zigzagoon, Eevee, Espeon, Umbreon, Suicune, Charmander
    Twitter
    RomhackerMateo
  • Signature
    mateo.





    "I'm gonna, uh, demonstrate the hot moves..." - Flannery

Statistics

Total Posts
Activity by Forum
Visitor Messages
Blog
General Information
  • Last Activity: 1 Minute Ago 4:48 PM
  • Join Date: June 8th, 2005
  • Referrals: 10

Friends

Showing Friends 1 to 20 of 54

  All times are GMT -8. The time now is 4:49 PM.


Contact Us Archive Privacy Statement Terms of Service Top