My least memorable would be trading a Shiny Zubat for a lvl. 96 Eevee. I didn't have all the badges at the time so I couldn't use the pokemon for awhile.
My most memorable trade is trading a lvl. 18 Absol for a lvl. 65 Shiny Japanese Ditto. After trading for that pokemon I had so many shinies it was ridiculous.