I can't remember where I battle mostly in FR/LG. I did use the VS Seeker a handful of times to grind Pomemon up to a more sustained and suitable level for the Elite Four.
In the other 3 games, the Elite Four gets my vote. I grind there regularly, but once your Pokemon reach 80+, it begins to get a little bit more challenging to get that Swampert to level 100
