[Discussion] Sorting out held items

• User takes the target's held item.
• Fails if user is holding an item, or if the target isn't. Fails if the item is mail or a special item. Fails if the item would be a special item when taken.
• Wild Pokémon using this move never take an item. A player's Pokémon using this move against a wild Pokémon will keep the taken item after the battle.
• Items taken from/by the player in trainer battles are returned to their original owners after the battle.

• User and target swap their held items.
• Fails if nether has an item, but works if just one does. Fails if either item is mail or a special item. Fails if either item would be a special item when swapped. Fails if target has a Substitute.
• Items switched in wild battles remain switched after the battle.
• Items switched in trainer battles are returned to their original owners after the battle.

• Target loses its held item for the rest of the battle (even if switched out later).
• Fails if the target isn't holding an item. Fails if the item is mail or a special item. Fails if target has a Substitute.
• Target gets its item back before the final Exp gain/money calculation.

• User gives its held item to the target.
• Fails if the user isn't holding an item, or if the target is. Fails if the item is mail or a special item. Fails if the item would be a special item when given. Fails if target has a Substitute.
• Items given in wild battles remain given after the battle.
• Items given in trainer battles are returned to their original owners after the battle.

• User consumes target's Berry and gains its effect (regardless of activation conditions).
• Fails if the target isn't holding a Berry. Fails if target has a Substitute.
• The Berry is lost forever, and cannot be regained by any method.

• Power and effect depend on the user's held item.
• The user's held item is consumed (but doesn't gain its effect). The consumed item can be Recycled.
• Some items can't be Flung.

• Power and type depend on the user's held Berry.
• The user's held Berry is consumed (but doesn't gain its effect). The consumed item can be Recycled.

• For 5 turns, target's held item cannot be consumed, and its effects are negated.
• Exp Share/Power Weight/Amulet Coin and similar are unaffected. Iron Ball still lowers Speed.
• Target cannot use Fling. If target uses Bug Bite/Pluck, it destroys the item but doesn't gain the effect.
• For 5 turns, target's owner cannot use any items on the target.
• Effect wears off if target switches out. Effect can be Baton Passed.

• User regains the last held item it consumed (i.e. by its own effect or used by Fling/Natural Gift only).
• Works even if the consumed item was not originally the user's.
• Fails if the user is holding an item. Fails if the consumed item was Pickup'd first.
• The consumed item is remembered even while the consumer is switched out. Only the one most recently-consumed item of each Pokémon is remembered.

• Bearer's held item cannot be taken by Covet, Thief, Trick, Switcheroo or Knock Off.

• Same as Thief/Covet, but occurs when bearer is hit by a move that makes contact.

• Bearer gains another battler's item (but not the bearer's item) when that battler consumes it, immediately after the consuming event.
• If there are several Pickup-ers, the fastest one gets the item.
• All items that can be Recycled can be Pickup'd (they are then denied from being Recycled).

• Same as Recycle, but only for Berries.
• Occurs once per turn at the end of each turn (before the end-of-turn Berry consuming). 50% chance of Harvesting the Berry each time (or 100% in sunny weather).

• Same as Embargo, but affects the bearer forever.
• Bearer's trainer can still use items on it.

Maruno said:

Then tell me what happens in those scenarios. I don't have any experience using any of these moves/abilities.

Click to expand...

FL . said:

Nothing different that you describe in topic. You probably won't have trouble with this, but with the way that you coded may create situations when the item is duplicated, so I warning you. Example: Using Thief into a Wild Pokémon in Wild Double battle, and after using Thief from the partner that uses Thief.

Click to expand...

Maruno said:

In that example (where player's Pokémon A stole player Pokémon B's item, then B stole a wild Pokémon's item), I would say that the items being held originally take priority over new items stolen and obtained. A would get its original item back from B, B would have no item, and the wild Pokémon's item is lost.

I intend to have an array created at the start of battle which records the held items of all player's Pokémon. During battle items may be shifted around/lost/consumed/whatever. At those times, the array is updated accordingly if it needs to be (i.e. remove a consumed/Plucked/Pickup'd item). At the end of the battle, this array is used to reset the held items. I think that's sufficient for everything above (Recycle works differently, but already exists).

Click to expand...

Maruno said:

As yes, I see what you meant now. I'd say the first Thief would get the wild Pokémon's item.

An extra variable in the battler's class wouldn't work, because battlers are only the Pokémon currently in battle. If you switched Pokémon around a bit during battle, there'd be no way of tracking which items were which. I'm under the impression that you could Thief an item, withdraw the Pokémon then send it out later, and it would still have the Thief'd item (and that items are sorted out at the very end).

Click to expand...