Ho-oh 112's mySQL Trade System

pokemonmasteraaron · Mar 28, 2012

You needed to relax anyway.

btw, I'm the 2012th viewer of this thread :P

Ho-oh 112 · Mar 28, 2012

pokemonmasteraaron said:
You needed to relax anyway.

btw, I'm the 2012th viewer of this thread :P

sorry I'm taking a few off of this I really gotta relax rather than script myself out.

overstood · Mar 29, 2012

i knew it. u cant script. copiing the script failed and youhave no idea what to do.
my opinion cya

Ho-oh 112 · Mar 29, 2012

overstood said:
i knew it. u cant script. copiing the script failed and youhave no idea what to do.
my opinion cya

????? I'm taking a break because I found a new game called edgeworld you dope AND WHERE DID I COPY THIS FROM?? I MADE IT FROM SCRATCH!!!!

Note: Scripting myself out for a week can be tiring so DON'T SAY IT'S NOT HARD WORK!

MaTe9usz6 · Mar 29, 2012

I can't wait to php file, please make it quickly.

Ho-oh 112 · Mar 29, 2012

MaTe9usz6 said:
I can't wait to php file, please make it quickly.

I'm starting to script again tommorow or next monday. so it'll be done before long.

Ho-oh 112 · Apr 2, 2012

UPDATES:

Hey people I got the base structure of the php file ready! It's only a very unstable base but if you can improve fix any errors I didn't find then please do so.

Code:

<?php
$host="Localhost";
$user="root";
$pass="";
$base="pokemon";
$port=3306;
$sql=mysql_connect($host,$user,$pass,$base,$port) or die("Cannot connect to MySQL");
$request = $_GET['Request'];

if ($request == "delete_pokemon") {
$code = $_GET['Code'];
mysql_query("DELETE FROM Trades WHERE Code=$code") or die("Cannot delete".$code."From Trades");
}

if ($request == "taken_pokemon") {
$poke=$_GET['Pokemon'];
$ech=mysql_query("FROM Trades SELECT Taken WHERE Pokemon=$poke") or die("Cannot Select".$Poke."From Trades");
}

if ($request == "send_pokemon") {
$code=$_GET['Code'];
$poke=$_GET['Pokemon'];
$level=$_GET['Level'];
$level1=$_GET['Level1'];
$level2=$_GET['Level2'];
$wanted=$_GET['Wanted'];
mysql_query("INSERT INTO Trades Code=$code,Pokemon=$poke,Level=$level,Wanted=$wanted,Level1=$level1,Level2=$level2,Taken='No'") or die("Cannot insert Query.");
}

if ($request == "get_pokemon") {
$poke=$_GET['Pokemon'];
$level1=$_GET['Level1'];
$levle2=$_GET['Level2'];
$ech=mysql_query("FROM Trades SELECT * WHERE Pokemon=$poke and Level>$level1 and Level<$level2") or die("None");
}

if ($request == "get_all") {
$ech=mysql_query("FROM Trades SELECT *") or die("Error!");
}
die($ech);
$sql_close;

?>

venom12 · Apr 2, 2012

Ok so i tested it, i got few errors, pokemon stores online but cant finish trade + some bugs. here are screens.
First screen Pokemon is stored but is not on the lsit but when i press space it continue.
http://dl.dropbox.com/u/4212314/Gts errpr/capture018.png

And here is something messed
http://dl.dropbox.com/u/4212314/Gts errpr/capture019.png

and error when want to finish trade.

Spoiler:

Ho-oh 112 · Apr 2, 2012

venom12 said:
Ok so i tested it, i got few errors, pokemon stores online but cant finish trade + some bugs. here are screens.
First screen Pokemon is stored but is not on the lsit but when i press space it continue.
http://dl.dropbox.com/u/4212314/Gts errpr/capture018.png

And here is something messed
http://dl.dropbox.com/u/4212314/Gts errpr/capture019.png

and error when want to finish trade.

Spoiler:

Exception: RuntimeError
Message: Script error within event 18, map 11 (Pokój Simona):
Exception: NoMethodError
Message: Section171:88:in `pbCompleteTradeGTS'undefined method `ConvertToString' for 0:Fixnum
***Full script:
pbStartGTS()

Interpreter:243:in `pbExecuteScript'
PokemonGts:474:in `pbGetTradeResults'
PokemonGts:421:in `pbStartSearchGTS'
PokemonGts:406:in `pbSearchListGTS'
PokemonGts:349:in `loop'
PokemonGts:409:in `pbSearchListGTS'
PokemonGts:56:in `pbStartGTS'
PokemonGts:36:in `loop'
PokemonGts:58:in `pbStartGTS'
(eval):1:in `pbExecuteScript'

AHHHH I Forgot to add the new version of the trade system....

EDIT: I'm fixing up some more bugs I found + making the php file better.

charizard124 · Apr 2, 2012

Thankyou for this awesome feature
Can you help me? after pressing search for pokemon and put the pokemon i want i get this error:

Spoiler:

Ho-oh 112 · Apr 2, 2012

charizard124 said:
Thankyou for this awesome feature
Can you help me? after pressing search for pokemon and put the pokemon i want i get this error:

Spoiler:

---------------------------
Pokemon Essentials
---------------------------
Exception: RuntimeError

Message: Script error within event 32, map 25 (Test Map 2):

Exception: TypeError

Message: Section143:434:in `+'cannot convert Fixnum into Array

***Full script:

pbStartGTS()

Interpreter:243:in `pbExecuteScript'

tra:434:in `pbGetGTSTradeListing'

tra:417:in `pbStartSearchGTS'

tra:406:in `pbSearchListGTS'

tra:349:in `loop'

tra:409:in `pbSearchListGTS'

tra:56:in `pbStartGTS'

tra:36:in `loop'

tra:58:in `pbStartGTS'

(eval):1:in `pbExecuteScript'

Interpreter:276:in `pbExecuteScript'

Interpreter:1593:in `command_355'

Interpreter:494:in `execute_command'

Interpreter:193:in `update'

Interpreter:106:in `loop'

Interpreter:198:in `update'

Scene_Map:103:in `update'

Scene_Map:101:in `loop'

Scene_Map:114:in `update'

Scene_Map:68:in `main'

still working on a huge fix I noticed a small complicated error that'll take me a few to fix...

venom12 · Apr 3, 2012

Hope it will be out soon.

Ho-oh 112 · Apr 3, 2012

venom12 said:
Hope it will be out soon.

Yeah I'm going to start working on this before H-Mode 7 until this works I just realized I can't compile the pokemon but I need to instead send all the different values of the pokemon...

desbrina · Apr 3, 2012

A few comments about your php script. Bolded is how to improve/fix the issue

First off, pbpPostData in essentials sends requests using $_POST not $_GET.
Any $_GET should be $_POST

Also, any variables you send from the essentials script need to be sanitised before use in php otherwise you'll be open to sql injection which could potentially wipe out your database or have others insert unauthorised data into it if they managed to get hold of the url, which is pretty easy to do
You need to use mysql_real_escape_string() on all variables
e.g.
$ech=mysql_query("FROM Trades SELECT * WHERE Pokemon=".mysql_real_escape_string($poke)." and Level>".mysql_real_escape_string($level1)." and Level<".mysql_real_escape_string($level2)."") or die("None");

Your final $sql_close; at the end won't do anything since anything after a die() call isn't executed. You shouldn't be using die() to output data anyway.
Change the die to an echo or print

Its better to use elseif statements not several ifs since you're only going to be sending one request at once, and for each request its going to go through the whole script each time, which takes more time in the long run than elseif. With elseif it'd go through only until the criteria is met.
Use elseifs
e.g.
if(this>1){
do this
} elseif (this>2) {
do this
} else
do this
}

Ho-oh 112 · Apr 3, 2012

desbrina said:
A few comments about your php script. Bolded is how to improve/fix the issue

First off, pbpPostData in essentials sends requests using $_POST not $_GET.
Any $_GET should be $_POST

Also, any variables you send from the essentials script need to be sanitised before use in php otherwise you'll be open to sql injection which could potentially wipe out your database or have others insert unauthorised data into it if they managed to get hold of the url, which is pretty easy to do
You need to use mysql_real_escape_string() on all variables
e.g.
$ech=mysql_query("FROM Trades SELECT * WHERE Pokemon=".mysql_real_escape_string($poke)." and Level>".mysql_real_escape_string($level1)." and Level<".mysql_real_escape_string($level2)."") or die("None");

Your final $sql_close; at the end won't do anything since anything after a die() call isn't executed. You shouldn't be using die() to output data anyway.
Change the die to an echo or print

Its better to use elseif statements not several ifs since you're only going to be sending one request at once, and for each request its going to go through the whole script each time, which takes more time in the long run than elseif. With elseif it'd go through only until the criteria is met.
Use elseifs
e.g.
if(this>1){
do this
} elseif (this>2) {
do this
} else
do this
}

EDIT:
Fixed up the problems with the scripts now I gotta test/make sql file...

Ho-oh 112 · Apr 5, 2012

UPDATES:
Fixed the PHP file and improved it to what Desbrina said
Fixed some errors with the Main script

Version: 2.0 Full

EDIT:
sql configuration table:

Table Name: trades
Column1: Code, Varchar(45)
Column2: Pokemon, Varchar(45)
Column3: Level, smallInt
Column4: Wanted, Varchar(45)
Column5: Level1, smallInt
Column6: Level2, smallInt
COlumn7: Taken, Varchar(45)

MaTe9usz6 · Apr 5, 2012

I don't know what I do bad, but when i call script pbStartGTS() and choose my Pokemon to trade nad press "Trade" i have an error: No pokemon chosen. This is screen for this error:

Ho-oh doy you know, what i do bad?

Ho-oh 112 · Apr 5, 2012

MaTe9usz6 said:
I don't know what I do bad, but when i call script pbStartGTS() and choose my Pokemon to trade nad press "Trade" i have an error: No pokemon chosen. This is screen for this error:

Ho-oh doy you know, what i do bad?

Did you click trade on the storage screen?

MaTe9usz6 · Apr 5, 2012

Yes, after click "Trade" i have this message.

Ho-oh 112 · Apr 5, 2012

I don't know then It works fine for me...

Ho-oh 112's mySQL Trade System

More options

pokemonmasteraaron

The blind Pokémon Master!

Ho-oh 112

Advance Scripter

overstood

Ho-oh 112

Advance Scripter

MaTe9usz6

Ho-oh 112

Advance Scripter

Ho-oh 112

Advance Scripter

venom12

Pokemon Crystal Rain Relased

Ho-oh 112

Advance Scripter

charizard124

Ho-oh 112

Advance Scripter

venom12

Pokemon Crystal Rain Relased

Ho-oh 112

Advance Scripter

desbrina

Ho-oh 112

Advance Scripter

Ho-oh 112

Advance Scripter

MaTe9usz6

Ho-oh 112

Advance Scripter

MaTe9usz6

Ho-oh 112

Advance Scripter