Script Help Thread (DO NOT REQUEST SCRIPTS) - Page 300

TrjanFaic · #**7476** December 11th, 2012, 05:17 PM

Quote:

Originally Posted by itman

(I assume you're using pokescript due to the use of '$', so I wrote this assuming it's for pokescript)

#org $script
lock
faceplayer
message $example
boxset 6
release
end

#org $example
= Hello there!

I have no idea what is wrong but now it will not react whenever i try to talk to the guy, I'm using pokescript and Advance map to put the script in, could anyone also explain some stuff about the script?
I know lock locks the player and faceplayer makes him look at the main character, but can you change the: $script part in the #org $script?
I'm just wondering, seems like most people use their own little text there, like this: #org $lolfaic
But anyhow, if you need me to show you what is happening i could easily upload a video of it on youtube if you would like that?

itman · #**7477** December 11th, 2012, 05:56 PM

Quote:

Originally Posted by TrjanFaic

I have no idea what is wrong but now it will not react whenever i try to talk to the guy, I'm using pokescript and Advance map to put the script in, could anyone also explain some stuff about the script?
I know lock locks the player and faceplayer makes him look at the main character, but can you change the: $script part in the #org $script?
I'm just wondering, seems like most people use their own little text there, like this: #org $lolfaic
But anyhow, if you need me to show you what is happening i could easily upload a video of it on youtube if you would like that?

Try it now...I haven't used pokescript in like 3 years xD

#org $script
lock
faceplayer
message $example
boxset 6
release
end

#org $example
$example 1 = Hello there!

TrjanFaic · #**7478** December 12th, 2012, 04:50 PM

Quote:

Originally Posted by itman

Try it now...I haven't used pokescript in like 3 years xD

#org $script
lock
faceplayer
message $example
boxset 6
release
end

#org $example
$example 1 = Hello there!

Do I add the last bit at the end or what?
Heh heh.

Noossab Blue · #**7479** December 13th, 2012, 04:56 AM

I've only been scripting a few weeks, and I'm trying to make a relatively simple script where a man checks if you have a badge and moves if you do. I used the pallet town sign girl as a model. Currently he talks but doesn't move...help?

Spoiler:

miksy91 · #**7480** December 13th, 2012, 07:23 AM

Quote:

Originally Posted by Noossab Blue

I've only been scripting a few weeks, and I'm trying to make a relatively simple script where a man checks if you have a badge and moves if you do. I used the pallet town sign girl as a model. Currently he talks but doesn't move...help?

Spoiler:

I won't be much of help saying specifically what to fix and where (never used XSE to hack 3rd gen) but by the looks of it, you've got something here written wrong:

callstd 0x4
closeonkeypress
compare PLAYERFACING 0x4
if 0x1 call @move1

If "closeonkeypress" stands for closing the text box after A button is displayed then that's not the problem. What's "callstd 0x4" for? If you're simply going to load the variable "PLAYERFACING" somewhere in ram and compare it to 0x1 (with "if 0x1 then..."), I don't see a point in having that kind of command there.

In GSC, "if codes" cannot be used to call anything so that may be your problem as well. In GSC, they're type "if 0x1 "pointer" (or instead of "pointer", put that jump @move1 here).
Try ending the scripts without "if call" codes by replacing them to "jumps". Also that way, if the person can only be talked from two directions like I assume by your script, you should change the ending of the script a little bit (this time, I made an assumption that subscripts are ended with "return" while the main scripts ends with "end"):

Code:

compare PLAYERFACING 0x4
if 0x1 @move1 (not sure if this instruction is now right or not)
applymovement 0x16 @movetwo
waitmovement 0x0
release
end
 
@move1
applymovement 0x16 @moveone
waitmovement 0x0
release
end

And if the upper doesn't solve the problem, try what happens if you take out that "0x4" next to PLAYERFACING (it can be right to have it there but doesn't sound right to me, really depends on how "compare" command works).

TrjanFaic · #**7481** December 13th, 2012, 06:00 PM

Could someone help me?
Really new at scripting and such so i am confused, but anyhow, it would be a problem i have never confronted in all my days of scripting xD

Noossab Blue · #**7482** December 13th, 2012, 09:57 PM

Quote:

Originally Posted by miksy91

I won't be much of help saying specifically what to fix and where (never used XSE to hack 3rd gen) but by the looks of it, you've got something here written wrong:

callstd 0x4
closeonkeypress
compare PLAYERFACING 0x4
if 0x1 call @move1

If "closeonkeypress" stands for closing the text box after A button is displayed then that's not the problem. What's "callstd 0x4" for? If you're simply going to load the variable "PLAYERFACING" somewhere in ram and compare it to 0x1 (with "if 0x1 then..."), I don't see a point in having that kind of command there.

In GSC, "if codes" cannot be used to call anything so that may be your problem as well. In GSC, they're type "if 0x1 "pointer" (or instead of "pointer", put that jump @move1 here).
Try ending the scripts without "if call" codes by replacing them to "jumps". Also that way, if the person can only be talked from two directions like I assume by your script, you should change the ending of the script a little bit (this time, I made an assumption that subscripts are ended with "return" while the main scripts ends with "end"):

Code:

compare PLAYERFACING 0x4
if 0x1 @move1 (not sure if this instruction is now right or not)
applymovement 0x16 @movetwo
waitmovement 0x0
release
end
 
@move1
applymovement 0x16 @moveone
waitmovement 0x0
release
end

And if the upper doesn't solve the problem, try what happens if you take out that "0x4" next to PLAYERFACING (it can be right to have it there but doesn't sound right to me, really depends on how "compare" command works).

-callstd 0x4 I believe just assigns the correct text box to the above message.
-When I remove call from the if command and debug it it says it assumes call, and when I reopen the script it adds call back in.
-When I removed 0x4 from compare PLAYERFACING it gives me an error saying I'm missing a parameter.

I think I might need to use a different command than compare PLAYERFACING. The man with this script is standing directly infront of a gym door, so he can be approached from 3 sides. From below or from the left I want him to move right and from the right I want him to move left. I believe the script I modeled this after is the same, so I don't know why it isn't working...

Here's the original again:

Spoiler:

miksy91 · #**7483** December 14th, 2012, 05:40 AM

Then I believe the problem is with the parameter adjusted to the PLAYERFACING command there. Also are you certain the values with if commands have to be certainly 0x1 and 0x5 there?

Personally, I'd assume the four directions would be numbered from 00 to 03 or from 01 to 04. Again I'm talking about G/S/C here but in it, Gamefreak programmed facing values so that when you were facing down, your facing in ram would be set to 00, if up 01, if left 02 and if right 03. If this is the case in the game you're hacking, the values would most likely be 01 and 03 (because you can approach him from below making you face up and from the left making you face right).

Also one thing to note would be that you don't need to compare PLAYERFACING twice. This is how the coding works out; compare PLAYERFACING actually (very likely) moves a byte from certain ram address, "PLAYERFACING", to another ram location, let's call this "RAM". "if" instructions are made to check whether "RAM" is set to a certain value and if it is, then continue interpreting after the pointer (like you have here, 0x8801135 and 0x8801141).
Because "if" insctructions don't affect "RAM" in any way, you can have a multiply of them in an order if you're using them for checking the exactly same thing (like is done here).

But yeah, try changing the values followed by "if" and if that doesn't work, check what XSE has told about PLAYERFACING command and its usage.
Also as it's not a problem with this script, you don't have to change it but it's often simplifies stuff a lot if you use "if" instructions to jump to another part of that main-/subscript instead of calling anything. As you said it didn't work out by removing the "call" part, try re-writing it with jump and see if something else happens (or check what XSE has written about this instruction as well).

Hopefully this will work out

Saigyouji Yuyuko · #**7484** December 14th, 2012, 01:24 PM

;Notes
;Placeholders will be, of course, replaced by proper pointers when empty regions that fit their size requirements are found.
;Pokemart sales will be divided by three clerks.
;Only samples to showcase my theory will be posted here; I wouldn't bother with the complete code as of yet.
;Please tell me if there is something wrong with anything within this theory. I would love to have the layout perfected before I start bothering with actually finding the free space and creating the actual scripts.
;If it is alright, can someone give me estimations as to the total space needed for the entire codeset [or at least tell me how to estimate]? I have a hundred and ten megabytes free space in my ROM.
;---------------------------------------------
#org [Placeholder_Masterscriptclerk1]
lock
faceplayer
msgbox 0x81A6211
checkflag FR_BADGE_8
if true jump [Placeholder_Mart8Clerk1]
checkflag FR_BADGE_7
if true jump [Placeholder_Mart7Clerk1]
checkflag FR_BADGE_6
if true jump [Placeholder_Mart6Clerk1]
checkflag FR_BADGE_5
if true jump [Placeholder_Mart5Clerk1]
checkflag FR_BADGE_4
if true jump [Placeholder_Mart4Clerk1]
checkflag FR_BADGE_3
if true jump [Placeholder_Mart3Clerk1]
checkflag FR_BADGE_2
if true jump [Placeholder_Mart2Clerk1]
checkflag FR_BADGE_1
if true jump [Placeholder_Mart1Clerk1]
mart [Placeholder_Mart0Clerk1Mart]
msgbox 0x81A5190
callstd MSG_NOCLOSE
release
end
;---------------------------------------------
;Clerk 2 cannot be unlocked until the 3rd badge and 3 until the 5rd badge, so their codes will follow this pattern:
'-----------------------------------
#org [Placeholder_Masterscriptclerk3]
lock
faceplayer
checkflag FR_BADGE_5
if false jump [Placeholder_DiaUnavailableClerk]
msgbox 0x81A6211
checkflag FR_BADGE_8
if true jump [Placeholder_Mart8Clerk3]
checkflag FR_BADGE_7
if true jump [Placeholder_Mart7Clerk3]
checkflag FR_BADGE_6
if true jump [Placeholder_Mart6Clerk3]
mart [Placeholder_Mart5Clerk3Mart]
msgbox 0x81A5190
callstd MSG_NOCLOSE
release
end
;------------------------------
#org [Placeholder_DiaUnavailableClerk]
msgbox [Placeholder_Unavailableclerk]
end
;-------------------------------
#org [Placeholder_Mart1Clerk1]
showmsg
pokemart [Placeholder_Mart1Clerk1Mart]
msgbox 0x81A5190
callstd MSG_NOCLOSE
release
end
;------------------------------------
#org [Placeholder_Mart4Clerk1]
showmsg
pokemart [Placeholder_Mart4Clerk1Mart]
msgbox 0x81A5190
callstd MSG_NOCLOSE
release
end
;------------------------------------

#org 0x81A6211
= Hi, there!\nMay I help you?

#org 0x81A5190
= Please come again!

#org [Placeholder_Unavailableclerk]
= I am sorry, but you may not buy wares\nfrom me until you gain more\lbadges.

#org [Placeholder_Mart0Clerk1Mart]
item POKEBALL
item POTION
item ANTIDOTE
item PARLYZHEAL
item AWAKENING
endmart

#org [Placeholder_Mart1Clerk1Mart]
item POKEBALL
item POTION
item ANTIDOTE
item PARLYZHEAL
item AWAKENING
item BURNHEAL
item ICEHEAL
endmart

#org [Placeholder_Mart4Clerk1Mart] [is retaining the pokeballs, basic status healers and basic potions a good idea?]
item POKEBALL
item GREATBALL
item ULTRABALL
item POTION
item SUPERPOTION
item ANTIDOTE
item PARLYZHEAL
item AWAKENING
item BURNHEAL
item ICEHEAL
item FULLHEAL
endmart

;I want to know if there's anything wrong with this and if it will work.

metalflygon08 · #**7485** December 14th, 2012, 02:50 PM

I've been scripting for a while now, but never have figured out how to do this.

(Scripting in HGSS fyi)

How do you do the scripts where you step somewhere and an event happens from that? (like the oak before you can leave Pallet town in 1st gen)

TrjanFaic · #**7486** December 14th, 2012, 05:10 PM

RAWR!
Canz someon halp me?
This would be a very helpful forum if someone did.
LOL, it already is quite helpful, but still, need that script helped on.
Just a basic script making a guy talk to you, that is it, just like the fat guy in PKMN Sapphire, i am using Advance Map 1.95 and poke script.

Noossab Blue · #**7487** December 15th, 2012, 01:05 AM

Quote:

Originally Posted by miksy91

Then I believe the problem is with the parameter adjusted to the PLAYERFACING command there. Also are you certain the values with if commands have to be certainly 0x1 and 0x5 there?

Personally, I'd assume the four directions would be numbered from 00 to 03 or from 01 to 04. Again I'm talking about G/S/C here but in it, Gamefreak programmed facing values so that when you were facing down, your facing in ram would be set to 00, if up 01, if left 02 and if right 03. If this is the case in the game you're hacking, the values would most likely be 01 and 03 (because you can approach him from below making you face up and from the left making you face right).

Also one thing to note would be that you don't need to compare PLAYERFACING twice. This is how the coding works out; compare PLAYERFACING actually (very likely) moves a byte from certain ram address, "PLAYERFACING", to another ram location, let's call this "RAM". "if" instructions are made to check whether "RAM" is set to a certain value and if it is, then continue interpreting after the pointer (like you have here, 0x8801135 and 0x8801141).
Because "if" insctructions don't affect "RAM" in any way, you can have a multiply of them in an order if you're using them for checking the exactly same thing (like is done here).

But yeah, try changing the values followed by "if" and if that doesn't work, check what XSE has told about PLAYERFACING command and its usage.
Also as it's not a problem with this script, you don't have to change it but it's often simplifies stuff a lot if you use "if" instructions to jump to another part of that main-/subscript instead of calling anything. As you said it didn't work out by removing the "call" part, try re-writing it with jump and see if something else happens (or check what XSE has written about this instruction as well).

Hopefully this will work out

Here's what I did try to fix this script:

Spoiler:

----------------------------------------
EDIT: OK I decided to try a door unlocked/locked script instead, which turns out to be seemingly much simpler. This is my script:

Spoiler:

...all it does is lock you and never let you go...

The win part was just me trying to fix the lock-up, but it should really work without that part...
---------------------------------------
EDIT 2.0: Fixed the door lock script! Here's my solution in case anyone else wants to do the same thing

Spoiler:

mefh · #**7488** December 16th, 2012, 10:08 PM

Nevermind fixed it myself...

raging-inferno-1986 · #**7489** December 17th, 2012, 04:05 PM

Hi, i made the following code to get the AuroraTicket and clear the flag (so that the Vermillion sailor will let me go to Birth Island). However it didn't work.

Code:

#dynamic 0x800000

#org @start
lock
faceplayer
checkflag 0x200
if 0x1 goto @done
msgbox @1 0x5
compare 0x800D 0x1
if 0x1 goto @take
msgbox @2 0x6
release
end

#org @done
msgbox @3 0x6
release
end

#org @take
giveitem 0x173 0x1 MSG_OBTAIN
msgbox @3 0x6
setflag 0x200
clearflag 0x2F1
release
end

#org @1
= Hi!\pWould you like an AURORA TICKET?.\pIt will allow access to BIRTH ISLAND. 

#org @2
= That's okay. I'm sure someone\nelse will enjoy it.

#org @3
= I knew you would want it.

What did i do wrong? Thanks.

robosllim · #**7490** December 18th, 2012, 05:10 PM

I'm trying to do a wild Pokemon script and everything seems to be right, based on what I've read. However, this script will make a message box pop up, then the box and the sprite will disappear without a wild battle ever happening.

Code:

'-----------------------
#org 0x71B8C9
lock
faceplayer
msgbox 0x871B959 '"GRAAAAK!!"
callstd 0x2
startwildbattle 0x1 0x32 0x0
hidesprite LASTTALKED
setflag 0x999
release
end


'---------
' Strings
'---------
#org 0x71B959
= GRAAAAK!!

Munsie · #**7491** December 21st, 2012, 02:28 AM

Game: LeafGreen
Type: Person Event
Editor: NotePad / PokeScript
Script: Trade a Rare Candy for a Lapras
This is the first script I've written, so I hope it isn't too afwul. Any advice on getting it to work (properly) would be great. In-game it gives you a Lapras, but doesn't properly check if you have a Rare Candy, nor does it take it from your bag. He won't talk to you afterwards either. :x

Spoiler:

After compiling it (to 800000, this is the first script I've made for the ROM), it seems to be a bit ****ed up... Not exactly sure why-- If it was my fault, or something with the compiler, or something else. I dunno.

Spoiler:

divinemamgai · #**7492** December 24th, 2012, 11:11 AM

Hi, I'm pretty new to these Pokemon Scripting so I guess the problem I'm having isn't going to be a big trouble for you.
So, I tried to create a simple script just to test. But I guess it didn't worked well. The script has to executed when the player steps on a script box. So I created the following script:

Code:

#org 0x8740040
'-----------------------------------
lock
checkflag 0x250
if true jump 0x8740058 ' Flag is set
msgbox 0x8740062 ' OAK: Hey! Wait!\nDon...
callstd MSG_NORMAL
setflag 0x250
releaseend

#org 0x8740058
'-----------------------------------
msgbox 0x8740095 ' OAK: Hey! Wait!\nDon...
callstd MSG_NORMAL
release
end


#org 0x8740062
= Hey, wait! You should first \nget your own pokemon!

#org 0x8740095
= Oh, so you have got your Pokemon, that's great!\p You should take this too.

I have not set any VAR Number or VAR Value. Also for Unknown I have just kept it to 03 and 0003
Also I'm using Pokemon Script Editor(PKSV) and Advanced Map 1.5 and for rom Pokemon Fire Red.

The script works with the spirit but not with the plain script boxes, why?
Please help me with this I really want to make my own hacked rom.

vitamurmillo · #**7493** December 26th, 2012, 11:00 PM

I wrote this script in PKSV, its meant to check if someone has beaten Brock, and turn them back if they haven't yet, but all it does is just freeze the screen. What's wrong with the script?

Its based on the policeman script from the Saffron city gatehouses in FR when you need the Tea.

#org 0x87404CC
'-----------------------------------
lockall
textcolor BLUE
applymovement PLAYER 0x81A75E7 ' look_left_delayed en...
pauseevent 0x0
checkflag FR_BADGE_1
if true jump 0x874054D ' Flag is set
msgbox 0x819E04B ' I think you still ha...
callstd MSG_NOCLOSE ' Non-closing message
closemsg
applymovement PLAYER 0x816F9C4 ' walk_down end
pauseevent 0x0
releaseall
end

#org 0x874054D
'-----------------------------------
msgbox 0x8740559 ' Well done on beating...
callstd MSG_NOCLOSE ' Non-closing message
closemsg
releaseall
end

#org 0x819E04B
= I think you still have\n something left to do.

#org 0x8740559
= Well done on beating Brock.

#org 0x81A75E7
M look_left_delayed end

#org 0x816F9C4
M walk_down end

FrozenInfernoZX · #**7494** December 27th, 2012, 03:36 AM

Does anybody know the command to use to continue the script after a battle? No matter what I do, my script always ends after the battle.

Here's my script:

Spoiler:

I want him to say, "Don't talk to me!" right after the battle.

CrystalStatic · #**7495** December 27th, 2012, 04:28 AM

Quote:

Originally Posted by FrozenInfernoZX

Does anybody know the command to use to continue the script after a battle? No matter what I do, my script always ends after the battle.

Here's my script:

Spoiler:

I want him to say, "Don't talk to me!" right after the battle.

There are many tutorials on trainerbattle commands. You can find your answer here:
http://www.pokecommunity.com/showthread.php?t=164276

vitamurmillo · #**7496** December 27th, 2012, 12:57 PM

I have a basic generate givepokemon script made by pksv. What do I need to add to that to make the pokeball (the sprite I gave the event using A-map) disappear?

aljohnston112 · #**7497** December 27th, 2012, 09:02 PM

Whenever I save my game and load it. Both the variables and the flags are reset back to 0 even though I set them both to 1 in my script. I'm using pksv, but that shouldn't make a difference as far as I know.

Spoiler:

Quote:

Originally Posted by vitamurmillo

I have a basic generate givepokemon script made by pksv. What do I need to add to that to make the pokeball (the sprite I gave the event using A-map) disappear?

You need to set a flag in your script (you should start flags around 1000). Then you need to set the person id of the pokeball to the same number as the flag (if you setflag 1000 then the person id of the pokeball should be 1000).

Spherical Ice · #**7498** December 27th, 2012, 09:33 PM

the variables in the 8000 range are temporary. they get reset so they can be used over and over. use variables in the 4000 range. davidjcobb has a list of the actually safe variables but the 4000 range in general is okay

aljohnston112 · #**7499** December 27th, 2012, 09:43 PM

Quote:

Originally Posted by Spherical Ice

the variables in the 8000 range are temporary. they get reset so they can be used over and over. use variables in the 4000 range. davidjcobb has a list of the actually safe variables but the 4000 range in general is okay

Could you give me the link? Oh and what about the flags? 1000 is checked for in the script, that has to be getting reset too

Alright. Now my game doesn't even start up. I started from a backup that does start and used the dynamic 740000 and I even looked in a hex editor to be sure it was writing in the right place, and it was. I am now using variable 4050, though it hasn't had a chance to set the variable, so that shouldn't be the problem. Anyway why is it when my script is added after 740000 that it causes my game to stop loading?

Alright. Now my game doesn't even start up. I started from a backup that does start and used the dynamic 740000 and I even looked in a hex editor to be sure it was writing in the right place, and it was. I am now using variable 4050, though it hasn't had a chance to set the variable, so that shouldn't be the problem. Anyway why is it when my script is added after 740000 that it causes my game to stop loading?

Kyouhei_ii00 · #**7500** December 29th, 2012, 08:36 AM

I made a trainer but I need to talk to it to battle.

Script:

Spoiler:

Here are the AMap settings:

Spoiler:

I want it so that the trainer walks up to the player then battles

Blogs
Recent Entries	Best Entries
Best Blogs	Blog List
Search Blogs

Tag Search
Advanced Search