Oh that's really good news. I'm not sure I have the time though, unfortunately I rarely have time to spend hacking these days :(

Great. I myself have forgot about this lol
Thank you for the fix and join us on pokefirered if you have time (It's about to hit 60%)!

Hey, I'm just the most late one can be. But I found a fix to this issue, it's unfortunately a typo in the way I did the logic. The fix is here:
https://github.com/EternalCode/Dark-Wish/commit/1329ddaeb16e98c5fbabd30da0462d5f221d21b9

I'll take a look at it in the up coming days, thanks.

It crashed on vanilla firered.
I don't think it can be an issue in the link process, as all the hooks look okay.

What I did was:
1. (Say, we use mGBA here) I load the game without a save file and play until the protagonist saw his mom the first time and talked to her.
2. Save.
3. Quit mGBA.
4. Reopen mGBA and Load the game. It will crash after start menu.

This is my output.txt:
00000000 0
030030F0 .byt:043C
030030F0 gmain
03005008 gsaveblock1ptr
0300500C .byt:0004
0300500C gsaveblock2ptr
03005380 .byt:0004
03005380 gfirstsavesector
03005390 .byt:0004
03005390 gsavecounter
03005394 .byt:0004
03005394 gfastsavesection
030053B0 .byt:0070
030053B0 gramsavesectionlocations
08000545 setmaincallback2
080006F5 setvblankcallback
08000701 sethblankcallback
0800070D setvcountcallback
08000719 setserialcallback
08002B81 malloc_init
08002B9D malloc
08002BB1 malloc_and_clear
08002BC5 free
0804C301 saveserializedgame
080565E1 setmaincallback
080D97D1 save_write_to_flash
080D9874 .dbl:0004
080D9874 .pool
080D99D9 trywritesector
080D9E58 .dbl:0004
080D9E58 .pool
080DA191 doreadflashwholesection
080DA1A9 calculatechecksum
080DA1D5 updatesaveaddresses
080DA23C .dbl:0004
080DA24C .dbl:0004
080DA24C .pool
0813B8C2 .byt:0002
081E3B69 __aeabi_idiv
081E3B69 __aeabi_idivmod
081E3B69 __aeabi_uidiv
081E3B69 __aeabi_uidivmod
081E5E79 memcpy
081E5ED9 memset
08830018 __text_start
08830018 loadsector30and31
0883008C savesector30and31
08830100 saveparasite
0883015C loadparasite
088301B8 handleloadsector
0883028C handlewritesector
08830364 call_something
0883036C handlesavingdata
08830464 dprint
08830484 mini_strlen
08830498 mini_itoa
08830568 mini_vsnprintf
08830688 dprintf
088306D0 .byt:0006
088306D0 saveblockparasitesizes
088306D8 .byt:0038
088306D8 savesectionoffsets
08830710 .byt:0004
08830710 parasitesizeindex
08830798 __bss_end__
08830798 __bss_start__
08830798 __end__
08830798 __text_end
08830798 _end
30050010 gsaveblock3ptr

close + re-open

It's also possible that something goes wrong in the compiling process tho, like, some symbol's value is not correctly assigned when the object gets linked
I can test it tomorrow on a clean firered ROM and tell you the result.

Hmm, testing on a clean ROM and my hack I'm able to get it to work on both mgba and vbam. Restart as in restart without closing the emulator? Or close and re-open?
I'd like to test on hardware but I haven't got it :(

Hi, I tested your save expansion on shiny gold. But if I save the game and restart the emulator (mgba/no$gba/vbam), it will crash and try to jump to bios (0x00000000). JPAN's vanilla hack worked.

Actually it's hard to decide what to do at this point except contributing to PRET projects. Development is more like non sense because with pokeemerald documentation (and some easy function port if we still want to work on FR) it's way too easy and can only encourage people to apply this kind of stuff blindly. For research and documentation PRET people and egg has already did great work and we'd better rely on those information

I haven't hacked for a few months now, I'm on my seasonal demotivation break atm

Are you still hacking now? I can see you committed a lot this year

Awesome, best of luck on that stuff. Hopefully it'll be useable soon!

Yes, I've contributed like 15 source files. I'm only doing source code decompiling and some directly related data decomp stuff (but obviously not too much).

oh I see. And now you are contributing too?

Many files can be directly ported from pokeem (like, 50% functions in those files with a EM counterpart are direct copy (with some renaming tho) 30% need some tweaks and 20% need a complete rewrite or is tossed in emerald)
The real problem is that (almost) only pikalax and garak were contributing to the repo :/