The PokéCommunity Forums

The PokéCommunity Forums (https://www.pokecommunity.com/index.php)
-   Binary ROM Hacking (https://www.pokecommunity.com/forumdisplay.php?f=284)
-   -   Other Issue when trying to use HMS (https://www.pokecommunity.com/showthread.php?t=379515)

Joexv September 30th, 2016 4:03 PM

Issue when trying to use HMS
 
So every time I try and use an HM the player just freezes when doing the animation. I've checked in IDB and clean ROMS to find any issues with the HM routines but have found none. The only thing I can think of is the animation that loads the black bar on the screen, but I haven't found that routine yet. I can upload a patch if it's needed.

Any help would be much appreciated!
http://i.imgur.com/GEsrcUu.pnghttp://i.imgur.com/DJDvvo0.png

EDIT: Removed the black bar completely and no change.

BluRose October 1st, 2016 4:57 AM

Quote:

Originally Posted by Joexv (Post 9431630)
So every time I try and use an HM the player just freezes when doing the animation. I've checked in IDB and clean ROMS to find any issues with the HM routines but have found none. The only thing I can think of is the animation that loads the black bar on the screen, but I haven't found that routine yet. I can upload a patch if it's needed.

Any help would be much appreciated!
http://i.imgur.com/GEsrcUu.pnghttp://i.imgur.com/DJDvvo0.png

EDIT: Removed the black bar completely and no change.

it's probably because the water is actually red, not blue
what do you mean by "when doing the animation?"

Joexv October 1st, 2016 8:11 AM

Quote:

Originally Posted by BluRose (Post 9432051)
it's probably because the water is actually red, not blue
what do you mean by "when doing the animation?"

The animation that the player does when HMS are used
https://youtu.be/TQa6ZbV0lyY?t=211

^This animation. it freezes right when that starts so I'm thinking thats the problem but haven't found the source.

PankajBlitz October 1st, 2016 8:15 AM

Maybe spherical ice know something because he has added dirty water and it is surfable too.

Joexv October 1st, 2016 8:19 AM

Quote:

Originally Posted by PankajBlitz (Post 9432223)
Maybe spherical ice know something because he has added dirty water and it is surfable too.

Well the problem isn't only when surfing, it's with ALL HMs. And the red water is literally just me editing the animation palette. Nothing special.

PankajBlitz October 1st, 2016 8:25 AM

Then it means theres a problem with the repointing?

Joexv October 1st, 2016 8:53 AM

Quote:

Originally Posted by PankajBlitz (Post 9432232)
Then it means theres a problem with the repointing?

I would say yes, but I haven't repointed anything related to HMs/Field Moves from what I remember.

Blah October 1st, 2016 8:57 AM

It's hard to deduce from just that information. Is it a soft lock, or is it frozen in a specific instruction?

Open the game in VBA/VBM something with a disassembler -> check what R14 is

What changes have you made to HMs/TMs, have you changed/repointed the item table? There's a lot that could be wrong.

Pleasure October 1st, 2016 9:15 AM

Are you using JPANs hacked engine?

Joexv October 1st, 2016 9:17 AM

Quote:

Originally Posted by FBI (Post 9432270)
It's hard to deduce from just that information. Is it a soft lock, or is it frozen in a specific instruction?

Open the game in VBA/VBM something with a disassembler -> check what R14 is

What changes have you made to HMs/TMs, have you changed/repointed the item table? There's a lot that could be wrong.

r14 is set to 4AB

AFAIK none, other than the flag check for HMs.

I did enter the surf script and change doanimation to 0x8 and there was no freeze, so its animation 9 thats causing it?

Quote:

Originally Posted by Pleasure (Post 9432302)
Are you using JPANs hacked engine?

Hell nah

Blah October 1st, 2016 9:19 AM

Quote:

Originally Posted by Joexv (Post 9432307)
r14 is set to 4AB

AFAIK none, other than the flag check for HMs.

I did enter the surf script and change doanimation to 0x8 and there was no freeze, so its animation 9 thats causing it?

wait. It works when you use animation 0x8 but not 0x9?

Joexv October 1st, 2016 9:20 AM

Quote:

Originally Posted by FBI (Post 9432312)
wait. It works when you use animation 0x8 but not 0x9?

Well it doesn't make me surf but it doesn't freeze the game

Blah October 1st, 2016 9:23 AM

Quote:

Originally Posted by Joexv (Post 9432315)
Well it doesn't make me surf but it doesn't freeze the game

callasm 0x8086945

tell me if it freezes

Joexv October 1st, 2016 9:30 AM

Quote:

Originally Posted by FBI (Post 9432323)
callasm 0x8086945

tell me if it freezes

It does indeed. But looking at that with a hex editor compare to a clean ROM, they are identical so its not overwritten or anything there.

Blah October 1st, 2016 9:43 AM

Quote:

Originally Posted by Joexv (Post 9432334)
It does indeed. But looking at that with a hex editor compare to a clean ROM, they are identical so its not overwritten or anything there.

Yeah, the animation itself is causing the bug you're experiencing.

Check if 083CC154 - 083CC168, bytes are identical. If they are, notice that this is a table of functions, you should check each function and see if any of them have been modified.

Joexv October 1st, 2016 10:24 AM

Quote:

Originally Posted by FBI (Post 9432354)
Yeah, the animation itself is causing the bug you're experiencing.

Check if 083CC154 - 083CC168, bytes are identical. If they are, notice that this is a table of functions, you should check each function and see if any of them have been modified.

Looking through the functions they are all the same, I remembered I do have the dynamic palettes installed so I tried removing it and it made no changes to the freeze.

Heres a ups file and save file https://www.mediafire.com/?cmw3t5e17nbs3s7

Blah October 1st, 2016 11:59 AM

Quote:

Originally Posted by Joexv (Post 9432387)
Looking through the functions they are all the same, I remembered I do have the dynamic palettes installed so I tried removing it and it made no changes to the freeze.

Heres a ups file and save file https://www.mediafire.com/?cmw3t5e17nbs3s7

I'm too lazy to DL a patcher :(

Disclaimer: I am not implying or forcing anyone to break any rules by PMing me a ROM instead.

Joexv October 1st, 2016 12:05 PM

Quote:

Originally Posted by FBI (Post 9432484)
I'm too lazy to DL a patcher :(

Disclaimer: I am not implying or forcing anyone to break any rules by PMing me a ROM instead.

Oh no! Why would you even suggest such a thing you monster! What has this community gone to????

Blah October 1st, 2016 2:27 PM

So I downloaded the patch and patched it, like a normal person would.

I don't have the time to invest in discovering the source of the issue, but the issue is that the game is freezing on 08063D7C. The bit should be cleared when an animation has finished, but it's not. I believe one of your movement commands are bugged, or some hack effecting NPCs has been hacked incorrectly or poorly.

I tried to nop the function in my debugger, as well as a couple more things and the animation played fine. This suggests there is nothing wrong with the animation in general, but the NPC_states bitfield is not being reset correctly. Please review any new hacks you've inserted that effect NPC animations, repointing any gender determined tables and anything effecting the NPC states bitfield. While you could nop these out yourself, it's obviously not a healthy solution, as it breaks other parts of the game.

Joexv October 1st, 2016 5:39 PM

Quote:

Originally Posted by FBI (Post 9432593)
So I downloaded the patch and patched it, like a normal person would.

I don't have the time to invest in discovering the source of the issue, but the issue is that the game is freezing on 08063D7C. The bit should be cleared when an animation has finished, but it's not. I believe one of your movement commands are bugged, or some hack effecting NPCs has been hacked incorrectly or poorly.

I tried to nop the function in my debugger, as well as a couple more things and the animation played fine. This suggests there is nothing wrong with the animation in general, but the NPC_states bitfield is not being reset correctly. Please review any new hacks you've inserted that effect NPC animations, repointing any gender determined tables and anything effecting the NPC states bitfield. While you could nop these out yourself, it's obviously not a healthy solution, as it breaks other parts of the game.

Ok well I've been digging into all my backups and such and no luck finding one that works yet. BUT I did learn at one point in time I did in fact use jpans hacked engine, which is weird because I made sure I did not want that in this game. But it is possible that that is actually causing the issue. I'm reading through Karatekid552's fixes for the engine and so far haven't really found anything that fixes it yet. I would like to remove the entirety of the Player OW swap if possible but idk how much its been edited already.

Blah October 1st, 2016 7:55 PM

Quote:

Originally Posted by Joexv (Post 9432786)
Ok well I've been digging into all my backups and such and no luck finding one that works yet. BUT I did learn at one point in time I did in fact use jpans hacked engine, which is weird because I made sure I did not want that in this game. But it is possible that that is actually causing the issue. I'm reading through Karatekid552's fixes for the engine and so far haven't really found anything that fixes it yet. I would like to remove the entirety of the Player OW swap if possible but idk how much its been edited already.

I'm completely clueless about the implementations or methods behind JPANs patches. The bitfield is read to indicate when an animation is done, and it doesn't seem to be setting the right value for the routine sequence to continue on to the next step. The problem persists in animation 0x45.

Try to do applymovement 0x45 and see if it works. This is the movement which the player does the Pokeball effect I believe.

Joexv October 3rd, 2016 10:48 AM

Quote:

Originally Posted by FBI (Post 9432912)
I'm completely clueless about the implementations or methods behind JPANs patches. The bitfield is read to indicate when an animation is done, and it doesn't seem to be setting the right value for the routine sequence to continue on to the next step. The problem persists in animation 0x45.

Try to do applymovement 0x45 and see if it works. This is the movement which the player does the Pokeball effect I believe.

Well 0x45 doesn't seem to be the right movement, and I've been going through some of them to find it but with no luck.

I've managed to completely remove Jpan's OW hack but that hasn't changed anything.

Blah October 3rd, 2016 10:55 AM

Quote:

Originally Posted by Joexv (Post 9434865)
Well 0x45 doesn't seem to be the right movement, and I've been going through some of them to find it but with no luck.

I've managed to completely remove Jpan's OW hack but that hasn't changed anything.

Does movement 0x45 break on your ROM? Can you try it on a clean ROM?

Joexv October 3rd, 2016 11:04 AM

Quote:

Originally Posted by FBI (Post 9434875)
Does movement 0x45 break on your ROM? Can you try it on a clean ROM?

movement 0x45 just makes the player walks up in place, it works just fine.

Blah October 3rd, 2016 11:22 AM

Quote:

Originally Posted by Joexv (Post 9434883)
movement 0x45 just makes the player walks up in place, it works just fine.

Weird, that's the movement its stuck on during your surf animation.


All times are GMT -8. The time now is 9:11 AM.


Like our Facebook Page Follow us on Twitter © 2002 - 2018 The PokéCommunity™, pokecommunity.com.
Pokémon characters and images belong to The Pokémon Company International and Nintendo. This website is in no way affiliated with or endorsed by Nintendo, Creatures, GAMEFREAK, The Pokémon Company or The Pokémon Company International. We just love Pokémon.
All forum styles, their images (unless noted otherwise) and site designs are © 2002 - 2016 The PokéCommunity / PokéCommunity.com.
PokéCommunity™ is a trademark of The PokéCommunity. All rights reserved. Sponsor advertisements do not imply our endorsement of that product or service. User generated content remains the property of its creator.

Acknowledgements
Use of PokéCommunity Assets
vB Optimise by DragonByte Technologies Ltd © 2023.