The PokéCommunity Forums

The PokéCommunity Forums (https://www.pokecommunity.com/index.php)
-   Binary ROM Hacking (https://www.pokecommunity.com/forumdisplay.php?f=284)
-   -   Other Shiny sprites at pokédex entries? (https://www.pokecommunity.com/showthread.php?t=410374)

gerff July 4th, 2018 2:52 PM

Shiny sprites at pokédex entries?
 
For some reason, while I was doing my hack, I must have done something wrong and now my pokédex entries have all pokémon with their shiny sprites. I could go back to a previous backup, but I have changed the whole habitat table which was A LOT of work and I don't want to do that again. Is there a way to change the sprites back to normal? I'm using BPRE (1.0).

DrFuji July 4th, 2018 4:26 PM

Did you change the shiny chance? This post explains why its happening and how to fix it if you did.

BirdstarCat13 July 5th, 2018 9:02 AM

DrFuji pretty much beat me to it - if you have increased the shiny encounter rate via a direct hex edit, then there is another byte you must edit or else all Pokémon in the Dex will use their shiny sprite regardless of whether or not you've seen, encountered, or caught the shiny. If you used TSK's Chiny Chance Changer, then the PokéDex doing that is a known glitch.

gerff July 5th, 2018 10:46 AM

In fact, that's what I did. Didn't even occur me that this would be what caused it. Thanks!

gerff July 5th, 2018 11:09 AM

Quote:

Originally Posted by BirdstarCat13 (Post 9897567)
DrFuji pretty much beat me to it - if you have increased the shiny encounter rate via a direct hex edit, then there is another byte you must edit or else all Pokémon in the Dex will use their shiny sprite regardless of whether or not you've seen, encountered, or caught the shiny. If you used TSK's Chiny Chance Changer, then the PokéDex doing that is a known glitch.

I just cheked the post and I can't seem to find the offset 0x08044120, is that really the right offset? It seems to have too many numbers.

DrFuji July 5th, 2018 2:51 PM

Remove '08' from the beginning of that offset to get the correct one.

gerff July 5th, 2018 9:45 PM

Quote:

Originally Posted by DrFuji (Post 9897663)
Remove '08' from the beginning of that offset to get the correct one.

Thank you. I did everything the post says, but the sprites are still shiny, I even put the same bytes as the original ROM and they're still showing up as shiny, I don't know what else to do. :/

BirdstarCat13 July 6th, 2018 1:30 AM

Quote:

Originally Posted by gerff (Post 9897750)
Thank you. I did everything the post says, but the sprites are still shiny, I even put the same bytes as the original ROM and they're still showing up as shiny, I don't know what else to do. :/

Did you use TSK's Shiny Chance Changer?

gerff July 6th, 2018 5:03 AM

Quote:

Originally Posted by BirdstarCat13 (Post 9897799)
Did you use TSK's Shiny Chance Changer?

Yes...

BirdstarCat13 July 6th, 2018 5:25 PM

Quote:

Originally Posted by gerff (Post 9897831)
Yes...

...

...

Well...that's the problem. Like I said, that's a known bug with TSK's tool.

What TSK's ShinyCC does is it writes an ASM routine into the ROM using the values you give it to set up a custom shiny chance. It doesn't "just modify the vanilla chance" like what the answers in my thread would do (however someone did bring up an ASM routine there, which happens to be identical to what ShinyCC does) so trying the vanilla fix will have absolutely no effect. You should always just use a direct hex edit with changing the shiny chance.

gerff July 7th, 2018 7:20 PM

Quote:

Originally Posted by BirdstarCat13 (Post 9898027)
...

...

Well...that's the problem. Like I said, that's a known bug with TSK's tool.

What TSK's ShinyCC does is it writes an ASM routine into the ROM using the values you give it to set up a custom shiny chance. It doesn't "just modify the vanilla chance" like what the answers in my thread would do (however someone did bring up an ASM routine there, which happens to be identical to what ShinyCC does) so trying the vanilla fix will have absolutely no effect. You should always just use a direct hex edit with changing the shiny chance.

Does that mean there's no fix at all? Or is there a way to restore the shiny chance back to original and then fix the offsets?

BirdstarCat13 July 7th, 2018 10:27 PM

Quote:

Originally Posted by gerff (Post 9898322)
Does that mean there's no fix at all? Or is there a way to restore the shiny chance back to original and then fix the offsets?

No fix - you have to go back to a backup befoe the change and do the hex edits to change the shiny chance.


All times are GMT -8. The time now is 9:11 AM.


Like our Facebook Page Follow us on Twitter © 2002 - 2018 The PokéCommunity™, pokecommunity.com.
Pokémon characters and images belong to The Pokémon Company International and Nintendo. This website is in no way affiliated with or endorsed by Nintendo, Creatures, GAMEFREAK, The Pokémon Company or The Pokémon Company International. We just love Pokémon.
All forum styles, their images (unless noted otherwise) and site designs are © 2002 - 2016 The PokéCommunity / PokéCommunity.com.
PokéCommunity™ is a trademark of The PokéCommunity. All rights reserved. Sponsor advertisements do not imply our endorsement of that product or service. User generated content remains the property of its creator.

Acknowledgements
Use of PokéCommunity Assets
vB Optimise by DragonByte Technologies Ltd © 2023.