The PokéCommunity Forums

The PokéCommunity Forums (https://www.pokecommunity.com/index.php)
-   Binary ROM Hacking (https://www.pokecommunity.com/forumdisplay.php?f=284)
-   -   Script Pokemon Fire Red - Scripting Help Needed (https://www.pokecommunity.com/showthread.php?t=443697)

JayMastro December 29th, 2020 7:08 AM

Pokemon Fire Red - Scripting Help Needed
 
2 Attachment(s)
Hello,

I am currently hacking Fire Red for the first time in a very long time and have encountered an issue while interacting with new person event's and sign posts that I have added.
I have marked this as a script issue but I think it is possible that I am messing something up on the AdvanceMap end as I had another member confirm that my script is indeed correct.

When I interact with the person event or signpost that I have assigned the new script to I can hear that interaction sound play, but nothing else happens.
The screen does not lock, the sprite does not face my player, and no dialogue box appears.

I distinctly remembering encountering this exact same issue years and years ago when I first discovered this hobby, and remember the fix being relatively simple, but am at a loss this time.

Any input would be greatly appreciated as I would like to get past this little issue and get the show on the road.

I have provided attachments of both the script as well as the compiled script that shows when opened via AdvanceMap.

Also, I have double checked to ensure that I am indeed using AdvanceMap 1.92 and FireRed v1.0.

Thank you!

mcferaligatr December 29th, 2020 7:14 AM

Try checking if the script offset is correct (if the script compiled well - chose the right rom in XSE to compile to), check if there are NPC's (person events) that have overlapping person event numbers and if there are change the numbers, try assigning this script to a NPC on a different map and see if that makes a difference.

Also, using save states on emulators can cause some issues if you saved on a map where you added/changed the script for the NPC, so use in game save and reset instead.

JayMastro December 29th, 2020 7:23 AM

Quote:

Originally Posted by mcferaligatr (Post 10252417)
Try checking if the script offset is correct (if the script compiled well - chose the right rom in XSE to compile to), check if there are NPC's (person events) that have overlapping person event numbers and if there are change the numbers, try assigning this script to a NPC on a different map and see if that makes a difference.

Also, using save states on emulators can cause some issues if you saved on a map where you added/changed the script for the NPC, so use in game save and reset instead.

I have indeed tried multiple different offsets starting at 800000 so I do not think that is the issue. I am testing the event in Pallet Town, the person event number is different from Oak's, the girl in front of the sign, and the technology is great guy's so I think I am good to go in that aspect.

I have not used any save states with the ROM, so it looks like the last thing to do is test the event out on a different map like you suggested!

I will post the results of that at some point today as I am currently at work, and I really appreciate the help so far!

JayMastro December 29th, 2020 10:09 AM

Quote:

Originally Posted by mcferaligatr (Post 10252417)
Try checking if the script offset is correct (if the script compiled well - chose the right rom in XSE to compile to), check if there are NPC's (person events) that have overlapping person event numbers and if there are change the numbers, try assigning this script to a NPC on a different map and see if that makes a difference.

Also, using save states on emulators can cause some issues if you saved on a map where you added/changed the script for the NPC, so use in game save and reset instead.

I tried it on Route 1 as well but sadly I encountered the same issue.
I can hear the sound that plays during dialogue, but nothing else happens.

mcferaligatr December 29th, 2020 12:14 PM

I had (I think) similar issue, and it only happened once. All of a sudden, XSE stopped working and whenever a script was compiled, it would ignore the rom it was compiling to. I just deleted old XSE and redownloaded a new one, so if all else fails, maybe that wouldn't be a bad idea to try out and see if it makes a difference.

JayMastro December 29th, 2020 2:17 PM

I tried a different XSE, sadly the issue was not fixed.

JayMastro December 29th, 2020 2:37 PM

1 Attachment(s)
Quote:

Originally Posted by mcferaligatr (Post 10252536)
I had (I think) similar issue, and it only happened once. All of a sudden, XSE stopped working and whenever a script was compiled, it would ignore the rom it was compiling to. I just deleted old XSE and redownloaded a new one, so if all else fails, maybe that wouldn't be a bad idea to try out and see if it makes a difference.

I installed a new AdvanceMap and when linking XSE this prompt popped up, is it possible I hit the wrong option last time? and what would the correct one be?

mcferaligatr December 29th, 2020 2:59 PM

Quote:

Originally Posted by JayMastro (Post 10252577)
I installed a new AdvanceMap and when linking XSE this prompt popped up, is it possible I hit the wrong option last time? and what would the correct one be?

I'm pretty sure I clicked yes every time I would set up XSE and Advance Map, but if it doesn't end up working after some trial and error, you can always reinstall and choose no.

JayMastro December 30th, 2020 8:47 AM

Quote:

Originally Posted by mcferaligatr (Post 10252586)
I'm pretty sure I clicked yes every time I would set up XSE and Advance Map, but if it doesn't end up working after some trial and error, you can always reinstall and choose no.

I tried hitting no as well, but now I can't even see the sprite I assigned the script to when I load the rom.

This has become quite frustrating. I've had this issue since I redownloaded the tools last week and have made no progress with my hack.

I really do appreciate the help so far Mcferaligatr.

If anybody else has any suggestions or ideas I'm willing to try anything at this point.

Meister_anon~Master_o f_None December 30th, 2020 3:49 PM

Quote:

Originally Posted by JayMastro (Post 10252826)
I tried hitting no as well, but now I can't even see the sprite I assigned the script to when I load the rom.

This has become quite frustrating. I've had this issue since I redownloaded the tools last week and have made no progress with my hack.

I really do appreciate the help so far Mcferaligatr.

If anybody else has any suggestions or ideas I'm willing to try anything at this point.

Could this be a flag issue?
I only know theory right now, but the only thing I can come up with is a flag isn't being set or cleared which causes the npc to be hidden.
Or the wrong flag is referenced in your script causing the sound command to play but the rest of the script fails?

here, this is what I use to learn scripting.
https://www.youtube.com/watch?v=wJw4tz0kcAI&list=PLfI5DBI4tNyLBYGNhf1Ee8cgdmMtiilps&index=8

Good luck.

Asith December 31st, 2020 12:47 AM

Instead of creating a new NPC, could you try assigning this script offset to an NPC that already works (eg: the technology is great guy). That would help narrow down the issue.

Pyxal December 31st, 2020 12:54 AM

Quote:

Originally Posted by JayMastro (Post 10252416)
<snip>

I remember this being an issue as well; the fix was that I had another ROM I was compiling the script into and was putting empty offsets in the NPC's. Try selecting your ROM again in XSE, and also check whether the script is okay in the ROM by opening it in A-Map.

JayMastro December 31st, 2020 5:19 AM

Quote:

Originally Posted by Asith (Post 10253168)
Instead of creating a new NPC, could you try assigning this script offset to an NPC that already works (eg: the technology is great guy). That would help narrow down the issue.

I have indeed and sadly it didn't work, and I also but his script on the NPC, which did work.

My script is attached above, in theory everything should be working unless I'm messing something up on the Advance Map end

JayMastro December 31st, 2020 5:22 AM

The compiled script does indeed show when opened via AdvanceMap (view attachment 2 above) which is another reason why I am confused as to why this isn't working

Anon822 December 31st, 2020 6:11 AM

Could you maybe post a patch of your rom?

JayMastro December 31st, 2020 7:23 AM

Quote:

Originally Posted by Anon822 (Post 10253309)
Could you maybe post a patch of your rom?

It's been a while since I had to do anything involving patching but I will figure it out and post it.
I'm at work right now but will give this a go when I get out.

Thank's for the suggestion, is this so that you, and anybody else who cares to, can troubleshoot it on your end I'm assuming?


All times are GMT -8. The time now is 9:19 AM.


Like our Facebook Page Follow us on Twitter © 2002 - 2018 The PokéCommunity™, pokecommunity.com.
Pokémon characters and images belong to The Pokémon Company International and Nintendo. This website is in no way affiliated with or endorsed by Nintendo, Creatures, GAMEFREAK, The Pokémon Company or The Pokémon Company International. We just love Pokémon.
All forum styles, their images (unless noted otherwise) and site designs are © 2002 - 2016 The PokéCommunity / PokéCommunity.com.
PokéCommunity™ is a trademark of The PokéCommunity. All rights reserved. Sponsor advertisements do not imply our endorsement of that product or service. User generated content remains the property of its creator.

Acknowledgements
Use of PokéCommunity Assets
vB Optimise by DragonByte Technologies Ltd © 2023.