BlazikenXY said:

Anyone know an ASM code where I can name the player from the Overworld?

Click to expand...

Aruaruu said:

I found this somewhere for Emerald
callasm 0xE5075

Click to expand...

LCCoolJ95 said:

I did some research into TM extension in Emerald. It seems that the TMs are located at 616040. When I looked at the data, they were two bytes long each. It was a move IDs, in hex, FLIPPED. I used a Pokémon Ruby Gameshark Codes listing to prove it (Here's the link: http://www.ign.com/faqs/2004/pokemon-battle-e-gameshark-sp-codes-list-541208). For example, the move ID for Focus Punch, or or Fighting Punch as the rough Japanese to English translation, in hex would be 108. However, within the TM Data,
it is actually 08 01. It just flipped the first number, 01, with the two other numbers, 08.

The TMs in hex are:

Spoiler:

08 01 51 01 60 01 5B 01 2E 00 5C 00 02 01 53 01 4B 01 ED 00 F1 00 0D 01 3A 00 3B 00 3F 00 71 00 B6 00 F0 00 CA 00 DB 00 DA 00 4C 00 E7 00 55 00 57 00 59 00 D8 00 5B 00 5E 00 F7 00 18 01 68 00 73 00 5F 01 35 00 BC 00 C9 00 7E 00 3D 01 4C 01 03 01 07 01 22 01 9C 00 D5 00 A8 00 D3 00 1D 01 21 01 3B 01

But what about the HMs? They follow right after:

Spoiler:

0F 00 13 00 39 00 46 00 94 00 F9 00 7F 00 23 01

I asked someone about this, and they stated that, no matter what, if the move IDs (in hex) are added BEFORE the HM data, this would be the beginning of the expansion of TMs in the game. HMs, however, will always be the last 8 move IDs (in hex).

Here, I just did an example of doing this process, using an expanded moves table:

Spoiler:

08 01 51 01 60 01 5B 01 2E 00 5C 00 02 01 53 01 4B 01 ED 00 F1 00 0D 01 3A 00 3B 00 3F 00 71 00 B6 00 F0 00 CA 00 DB 00 DA 00 4C 00 E7 00 55 00 57 00 59 00 D8 00 5B 00 5E 00 F7 00 18 01 68 00 73 00 5F 01 35 00 BC 00 C9 00 7E 00 3D 01 4C 01 03 01 07 01 22 01 9C 00 D5 00 A8 00 D3 00 1D 01 21 01 3B 01 AE 01 63 01 B4 01 B8 01 BA 01 83 01 84 01 C0 01 A7 01 C3 01 05 01 C4 01 8D 01 6A 01 C5 01 88 01 75 01 A2 01 65 01 C7 01 C8 01 C9 01 7C 01 CA 01 E7 01 76 01 A5 01 96 01 CC 01 D6 01 77 01 E8 01 E4 01 68 01 79 01 54 01 57 01 7E 01 81 01 CD 01 86 01 BC 01 9F 01 A0 01 C8 00 7A 01 44 01 14 01 94 01 8B 01 0F 00 13 00 39 00 46 00 94 00 F9 00 7F 00 23 01

If you compare it to the original, there are an extra 50 TMs added. Now, I just need to know how to make the legitimate TM item work. If someone were to look into that, that would be awesome.

Click to expand...

sonicfan7895 said:

I think if we need to make more legitimate TM items work, we would first need to take a large chunk of data starting at wherever the item table starts (which in this case is at 0x5839A0), and take the entire item table (plus a larger chunk of data in order to account for how many more TMs we may need (in this case, 50)), and copy & paste it into free space, change all pointers to the NEW item table, and give respective item stats (sell price, mystery values, etc.). Judging from a certain hex viewer, the item data should last anywhere from 20-34 bytes long, but I can't tell for sure. The hex viewer I'm looking through is called ps2dis, which is actually a hex viewer for handling files specifically for PS2 games, but it works in a pinch (it also views hex in NORMAL hex order, not REVERSE hex order). For actually teaching the new TMs, I believe we would also have to repoint the TM/HM compatibility table within the game (located at 0x252BC8), so that the entire table accounts for the new TMs being able to be taught to a Pokemon. Not only that, but we would also have to put the TM data (starting at 0x616040, ending at 0x6160b0 with Dive), and put new data in between Overheat and Cut (if there are 50 new TMs you want to insert (at least two bytes per new TM), we would have to insert 100 new bytes of data for all the new TMs, which would result in the table ending later. Say the new TMs table was at something like 0xE40000, and I added 100 bytes to the already present bytes for the TMs, that would mean that the new table would end at 0xE4006C. In themselves, they would be pointers to the moves being taught in question (if I'm not mistaken). There's so much to do that it might take a while before expanding on the amount of TMs could even come close to working for Emerald. Anyone want to help in furthering our understanding on item data, and more importantly, come up with a more viable solution to expanding on the amount of TMs within Emerald? I kind of sound like I don't know what I'm talking about, but I think you could see where I'm going with this?

Click to expand...

HidoranBlaze said:

With TM expansion, the compatibility table can't be extended with a simple repoint, since the structure is limited to 8 bytes per mon. Luckily, I've found the routine that reads this table (and optimized it, actually), so expanding the structure to 16 bytes per mon, which should be more than enough, won't be hard.

Click to expand...

Emerald Encounter Music

• 0x0: The Youngster encounter theme which music number is 0x17C
• 0x1: The Lass encounter theme which music number is 0x197
• 0x2: The Tuber encounter theme which music number is 0x17B
• 0x3: The Bug Maniac encounter theme which music number is 0x1A7
• 0x4: The Black Belt encounter theme which music number is 0x1A0
• 0x5: The Cool Trainer (now Ace Trainer) encounter theme which music number is 0x1A1
• 0x6: The Team Aqua encounter theme which music number is 0x1A3
• 0x7: The Team Magma encounter theme which music number is 0x1B9
• 0x8: The Swimmer encounter theme which music number is 0x181 (edit at 0xB1C30 to change song number 81 01 00 00)
• 0x9: The Kid encounter theme which music number is 0x1C1
• 0xA: The Elite Four encounter theme which music number is 0x1C2
• 0xB: The Hiker encounter theme which music number is 0x1C3
• 0xC: The Reporters Gabby and Ty encounter theme which music number is 0x1C5
• 0xD: The Gentleman encounter theme which music number is 0x18D

Emerald Overworld and Battle Textboxes

Tlachtli said:

Spoiler:

I think I've finally worked the bugs out of Protean, and I'm 96% sure it'll work with no problem now. As promised here's the (Emerald BPEE) ASM for it, so hold on to your butts:

Code:

.align 2
.thumb

GetPokeTypes:
    push {r0-r5}
    ldr r1, .BattleData
    ldr r0, .CurPokeIndex
    ldrb r0, [r0]
    mov r2, #0x58
    mul r2, r0
    add r1, #0x21
    add r1, r2
    ldrh r0, [r1]
    mov r2, r0
    lsr r0, #2
    lsl r2, #24
    lsr r2, #24

GetMoveType:
    ldr r3, .CurMoveIndex
    ldrh r3, [r3]
    ldr r4, .MoveData
    mov r5, #0xC
    mul r5, r3
    add r4, r5
    add r4, #0x2
    ldrb r4, [r4]

ChangePokeType:
    cmp r0, r4
    beq End
    cmp r2, r4
    beq End
    lsl r4, #2
    ldr r5, .TypeList1
    add r5, r4
    mov r0, r5
    mov r2, #0x2
    sub r1, #0x1
    swi #0x0B
    ldr r0, .TypeList1
    ldr r1, .CheckForChange
    mov r2, #0x1
    swi #0x0B
    ldr r0, .TypeList2
    add r0, r4
    ldr r1, .TypeBuffer
    mov r2, #0x2
    swi #0x0B

End:
    pop {r0-r5}
    bx lr

.align 2
.BattleData:        .word 0x02024084
.CurPokeIndex:        .word 0x0202420B
.CurMoveIndex:        .word 0x020241EA
.MoveData:        .word 0x08E3E680
.CheckForChange:    .word 0x02024200
.TypeBuffer:        .word 0x02022F58
.TypeList1:        .word 0x[address1]
.TypeList2:        .word 0x[address2]

For TypeList1, copy this hex somewhere and use its start as address1:

Code:

6A 00 00 00 6A 01 01 00 6A 02 02 00 6A 03 03 00 6A 04 04 00 6A 05 05 00  6A 06 06 00 6A 07 07 00 6A 08 08 00 6A 09 09 00 6A 0A 0A 00 6A 0B 0B 00  6A 0C 0C 00 6A 0D 0D 00 6A 0E 0E 00 6A 0F 0F 00 6A 10 10 00 6A 11 11 00

For TypeList2, copy this hex somewhere and use its start as address2

Code:

FD 03 00 FF FD 03 01 FF FD 03 02 FF FD 03 03 FF FD 03 04 FF FD 03 05 FF  FD 03 06 FF FD 03 07 FF FD 03 08 FF FD 03 09 FF FD 03 0A FF FD 03 0B FF  FD 03 0C FF FD 03 0D FF FD 03 0E FF FD 03 0F FF FD 03 10 FF FD 03 11 FF

Now actually implementing it is the tricky part, it won't be a simple copy/paste job; you'll need some insight on what the battle scripts for different moves are actually doing to decide the appropriate place(s) to put ability checks. For any move you want to be affected by Protean you'll need to add a check for it somewhere in the battle script before calculatedamage. In order for a notification string to print out correctly callasm must be before printstring 0x49, and the printstring must be before attackcanceller. You should add a check to see if the user's ability is Protean, if so execute the ASM and optionally print a message if the type is changed, then jump back to the right point in the script. A potential script segment would look something like:

Code:

... (move script stuff is here) ...
jumpifability BANK_USER ABILITY_PROTEAN @Protean        /Note 1
goto 0x082D8A26                                         /Note 2

#org @Protean
callasm [address of Protean asm, plus 0x1]
jumpifbyte B_!= 0x02024200 0x0 @Change                  /Note 3
jumpifbyte B_= 0x02024200 0x0 @AttackCanceller

#org @Change
setbyte 0x02024200 0x0
printstring 0x49                                        /Note 4
waitmessage 0x40
goto @AttackCanceller

#org @AttackCanceller
attackcanceler
accuracycheck 0x82D8A5E 0x0
attackstring
ppreduce
calculatedamage
goto 0x82D8A34

Note 1: You'll either need to define ABILITY_PROTEAN in BSP's abilities.bsh, or just use the hex for the ability here instead.
Note 2: A goto jump to an address somewhere in the area of 0x082D8A26 usually signifies the end of a moves' unique scripting, as that jumps to a segment of script shared by nearly all damaging moves. In damaging moves I'd suggest putting the check for Protean before that jump. In status moves the jump may be different.
Note 3: The ASM for Protean does the following: gets the type of the move being used, checks it against the user's type(s), and if necessary changes type to match the move. If there is a type change it will always result in a monotype, if one is not needed though the Poke can retain a dual typing. If a type change is done the byte at 0x02024200 is set to a non-zero garbage byte (in this case 0x6A). This can be used to decide whether or not to display a message, and should be reset to 0x0 somewhere in the battle script.
Note 4: String 0x49 is "[User] transformed into the [Type] type!". This is the string used in Gen 6 games.

As a demo, here's the script I used while testing it. It changes Psybeam, Feint Attack, and Slash (all moves known by the Kecleon I was testing with). After compiling the test script change Psybeam's move effect (effect 76) pointer to match @Psybeam, and change Slash and Feint Attack (effects 43 and 17) to both match @Slash. You'll also need Jambo's callasm for BSP and to define Protean in abilities.bsh.

Spoiler:

Code:

#dynamic 0xE446B0
#freespace 0xFF
#include abilities.bsh

#org @Psybeam
setbyte 0x2024335 0x7
goto @Slash

#org @Slash
jumpifhalfword 0x1 0x20241EA 0x39 @ProteanCheck
jumpifspecialstatusflag 0x0 0x40000 0x1 @ProteanCheck
orword 0x2024280 0x40000
setbyte 0x2024482 0x2
jumpifability BANK_USER ABILITY_PROTEAN @Protean
goto 0x082D8A26

#org @ProteanCheck
jumpifability 0x1 0x6A @Protean
goto 0x82D8A26

#org @Protean
setbyte 0x02024200 0x0
callasm 0x08E44621
jumpifbyte 0x1 0x02024200 0x0 @Change
goto @AttackCanceller

#org @Change
printstring 0x49
waitmessage 0x40
goto @AttackCanceller

#org @AttackCanceller
setbyte 0x02024200 0x0
attackcanceler
accuracycheck 0x82D8A5E 0x0
attackstring
ppreduce
calculatedamage
goto 0x82D8A34

Even though it seems complicated and may not be the most concise or elegant way to add Protean, it does indeed work. The only known issue is that when using Hidden Power it will change to Normal instead of the hidden type, but honestly it seems like a small issue and writing more asm to fix that is fairly low on my priority list.

Click to expand...

kleenexfeu said:

I think there is an issue in the routine because everytime I use a move it says "Scizor transform into the type!" what type ?
Maybe a wrong argument is used or a bad address because every moves have a correct STAB, but the defense part won't work. I mean if I'm transformed in dark type, dark moves are neutral for exemple.
Any clue ?

EDIT : Nevermind I am a dumb, it works perfectly.. Except for a pokemon that is double type, scizor for exemple. If I use bullet punch and receive a fight move, it's supper effective
And for the type list one, it a weird coincidence that it shares the same number of the ability (6A). It has something to do with the ability's number ou simple coincidence ? Not sure
Don't forget to change .MoveData: .word 0x08E3E680 into your actual move data location. It took me one hour to figure out why it did not work x)

EDIT 2 : Protean seems to work just one time
Seems to be fixed if I change 6A to 51 in my first typelist

Click to expand...

KDS said:

I

Protean always changes the pokemon to a monotype regardless of the initial typing. So a surf using protean greninja changes to a mono water type.

Click to expand...