Report bugs and errors in unmodified Essentials version 21

ptisnjunk95 said:

I made some results at Hoopa/Furfrou bug
I finally manage to add a Hoopa. However, you can't use Unbound form and Furfrou. And you still can't Debug -> Fill Storage Boxes
If you are looking for the final fix, it isn't. Don't use this code!!!!!
I only made changes on Pokemon_MultipleForms.

I tried adding a Hoopa without debugging. I get this error.

Spoiler:

---------------------------
Tears of Vengeance
---------------------------
Script 'Interpreter' line 276: RuntimeError occurred.

Script error within event 1, map 3 (MAP003):

Exception: SystemStackError

Message: Section110:5:in `pbGetTimeNow'stack level too deep

***Full script:

pbAddPokemon(:HOOPA,5)


Interpreter:243:in `pbExecuteScript'

Pokemon_MultipleForms:867

Pokemon_MultipleForms:866:in `call'

Pokemon_MultipleForms:185:in `call'

Pokemon_MultipleForms:6:in `form'

Pokemon_MultipleForms:868

Pokemon_MultipleForms:866:in `call'

Pokemon_MultipleForms:185:in `call'

Pokemon_MultipleForms:6:in `form'

Pokemon_MultipleForms:868


---------------------------
OK
---------------------------

As you can see it starts looping in those lines. Those lines are Furfrou's lines. Since the Form Changing is similar (The forms only last for limited time), I decided to add a Furfrou. You can Add a Furfrou without getting this error. But if you try Debug -> Change Form, appears another error that led me to line 5:

Original Essentials v16.1 Code (line 4)

Spoiler:

Code:

def form
    return @forcedform if @forcedform!=nil #this is line 5
    v=MultipleForms.call("getForm",self)
    if v!=nil
      self.form=v if !@form || v!=@form
      return v
    end
    return @form || 0
  end

I went to Hoopa and Furfrou's "Multiforms.register" and i added some parentheses to see that it could help:

Original Essentials v16.1 Code (Furfrou "getForm" Section):

Spoiler:

Code:

"getForm"=>proc{|pokemon|
   timenow=pbGetTimeNow
   if pokemon.form>0 && (!pokemon.formTime ||
                         timenow.to_i>pokemon.formTime.to_i+60*60*24*5) # 5 days
     next 0
   end
   next
}

My Edit (at red)

Spoiler:

Code:

"getForm"=>proc{|pokemon|
   timenow=pbGetTimeNow
   if pokemon.form>0 && (!pokemon.formTime ||
                         [COLOR="red"]([/COLOR]timenow.to_i>(pokemon.formTime.to_i+60*60*24*5[COLOR="Red"]))[/COLOR]) # 5 days
     next 0
   end
   next
}

And the same on Hoopa's:

Original Essentials v16.1 Code (Hoopa's "getForm" Section):

Spoiler:

Code:

"getForm"=>proc{|pokemon|
   timenow=pbGetTimeNow
   if pokemon.form>0 && (!pokemon.formTime ||
                         timenow.to_i>pokemon.formTime.to_i+60*60*24*3) # 3 days
     next 0
   end
   next
}

My Edit:

Spoiler:

Code:

"getForm"=>proc{|pokemon|
   timenow=pbGetTimeNow
   if pokemon.form>0 && (!pokemon.formTime ||
                         [COLOR="red"]([/COLOR]timenow.to_i>(pokemon.formTime.to_i+60*60*24*3[COLOR="Red"]))[/COLOR]) # 3 days
     next 0
     end
   next
}

Then I edited form at line 4, replacing nil for a "0" (Original code shown above):

Spoiler:

Code:

def form
    return @forcedform if @forcedform!=[COLOR="Red"]0[/COLOR]
    v=MultipleForms.call("getForm",self)
    if v!=nil
      self.form=v if !@form || v!=@form
      return v
    end
    return @form || 0
  end

And I successfully added a Hoopa.

Spoiler:

Then I tested the Prison Bottle to change his form, it says that Hoopa changed form, but it didn't. Then tried changing the form through Debug and gave this error:

Spoiler:

Also ocurred with Furfrou.

Click to expand...