Code: Ability Resource Thread

PufferJumps said:

hello. i just wanna ask how to properly implement a new ability.

i'm kind of new to asm hacking and so far i think i'm doing well (just a thought, though)
i successfully added some into my rom like the BW2 Repel system, gain-exp-on-catch, fix sturdy, color codes on nature and IV indicator. since i've done it pretty well i just thought maybe i'd try adding a new ability.

the ability i was trying to add is this protean:

because greninja is a thing, but whenever i tried to use it on battle, it doesn't work.

now the problem is, when i paste this ( 00 49 08 47 01 7B 77 08 ) to 1D7D8 (as instructed) nothing happens. i tried to not to add 1 on the "00" (last) part of the hex where i insert the asm but the screen just stuck after an attack. then i even tried not to reverse the hex and it called a rain, then crash >___<

the part (offset?) where i inserted the asm was on 777B00. i can't really figure out where did i got it wrong, but i really want to learn how to add it because it's a good feature. i hope someone could tell me my mistake. and lastly, sorry for a long reply, plus the bad english since it's not my mother language.

ps: i'm using mrds patch

Click to expand...

ShyRayq said:

Okay, I'm not really good at ASM, but I picked up a few things.
1st, in the ASM code, there is a section near the start called 'Proteancheck'.
In this section there's a bit of code that says:
cmp r0, #0xA9.
The A9 represents the index for the ability Protean in the table of abilities. This will not be exactly the same as in your rom. Assuming this is the only ability you have added, it should be 0x4E.
If you have added more, then it should be 0x4D + NN + 0x01 where NN is the number of abilities you have added before protean in hex.

2nd, I believe there is a string that prints that the user has changed type that you have to insert as well, but I'm not entirely sure.

Click to expand...

AtecainCorp. said:

Excuse me. But any of this abilities have porting to Pokemon Ruby?

Click to expand...

Lance32497 said:

I'm trying to duplicate Victory Star

Will this code work?

Spoiler:

.text
.text
.align 2
.thumb
.thumb_func
.global victorystar

CheckBattleType:
ldr r0, .BattleType
ldrb r0, [r0]
mov r1, #0x1
and r0, r1
cmp r0, #0x0
bne DoubleBattle
SingleBattle:
ldr r0, .Bank
ldrb r0, [r0]
mov r5, #0x58
mul r0, r5
add r0, r0, r7
add r0, #0x20
ldrb r0, [r0]
b VictoryStarCheck
DoubleBattle:
ldr r0, .Bank
ldrb r0, [r0]
and r0, r1
cmp r0, #0x0
bne CheckFoeTeam
CheckUserTeam:
mov r0, #0x0
b DoupleLoop
CheckFoeTeam:
mov r0, #0x1
DoupleLoop:
mov r5, #0x58
mul r0, r5
add r1, r0, r7
add r1, #0x20
ldrb r0, [r1]
cmp r0, #0xA3
beq VictoryStar
cmp r0, #C1
beq VictoryStar
add r1, r1, #0xB0
ldrb r0, [r1]
VictoryStarCheck:
cmp r0, #0xA3
bne BufferAbility
cmp r0, #0xC1
bne BufferAbility
VictoryStar:
mov r0, #0x6E
mov r1, #0x64
mul r0, r4
bl Divide
lsl r0, r0, #0x10
lsr r4, r0, #0x10
BufferAbility:
ldr r0, .Bank
ldrb r0, [r0]
mov r5, #0x58
mul r0, r5
add r0, r0, r7
add r0, #0x20
ldrb r0, [r0]
CompoundEyesCheck:
cmp r0, #0xE
bne Return
CompoundEyes:
ldr r0, .Return
bx r0
Return:
ldr r0, .Return2
bx r0
Divide:
ldr r2, .DivideBL
bx r2

.align 2

.BattleType: .word 0x2022B4C
.Bank: .word 0x02023D6B
.Return: .word 0x0801E041
.Return2: .word 0x0801E051
.DivideBL: .word 0x081E4019

Insert 01 48 00 47 00 00 xx xx xx 08 at 0801E02E

The bolded lines indicate my additions. Let's say C1 is the ability index, will this work?

Click to expand...

MrDollSteak said:

Here's Snow Warning for Fire Red! I'll update this and port it to Emerald. I'm going to edit it slightly in the future to account for the new weather abilities too that Kleenex has already written routines for.

Snow Warning

Spoiler:

Fire Red

Spoiler:

Code:

.text
.text
.align 2
.thumb
.thumb_func
.global snowwarning

BufferAbility:
	ldrb r0, [r1]
	cmp r0, #0xSnowWarning
	beq SnowWarning
SandStreamCheck:
	cmp r0, #0x2D
	bne ReturnChecks
SandStream:
	ldr r2, .Return
	bx r2
ReturnChecks:
	ldr r4, .Return2
	bx r4
SnowWarning:
CheckWeather:
	ldr r2, .WeatherLoc
	ldrh r1, [r2]
	mov r0, #0x80
	and r0, r1
CheckHail:
	cmp r0, #0x0
	beq Continue
	bl EndScript
SetHail:
	mov r0, #0x80
	strh r0, [r2]
	ldr r2, .Place
	mov r0, #0x0
	strb r0, [r2]
	ldr r0, .SnowWarningBS
	bl PlayScript
	ldr r0, .Place2
	mov r1, r10
	strb r1, [r0, #0x17]
	bl OtherBL
EndScript:
	ldr r4, .EndScriptBL
	bx r4
PlayScript:
	ldr r2, .PlayScriptBL
	bx r2
OtherBL:
	ldr r0, .OtherBL
	bx r0
.align 2

.Return: .word 0x0801A2AD
.Return2: .word 0x0801A149
.WeatherLoc: .word 0x02023F1C
.Place: .word 0x02023F48
.SnowWarningBS: .word 0x08CCCCCC
.Place2: .word 0x02023FC4
.EndScriptBL: .word 0x0801BBAB
.PlayScriptBL: .word 0x0801BC25
.OtherBL: .word 0x0801BB5B

#Insert 00 48 00 47 xx xx xx 08 at 1A140

Click to expand...

08 78 2D 28 01 D1 10 4A 10 47 6F 28 01 D0 0F 4C 20 47 0F 4A 11 88 80 20 08
40 00 28 01 D0 00 F0 0D F8 80 20 10 80 0B 4A 00 20 10 70 0A 48 00 F0 07 F8
0A 48 51 46 C1 75 00 F0 04 F8 08 4C 20 47 08 4A 10 47 08 48 00 47 AD A2 01
08 49 A1 01 08 1C 3F 02 02 48 3F 02 02 D0 9A 90 08 C4 3F 02 02 AB BB 01 08 
25 BC 01 08 5B BB 01 08

	cmp r0, #0x8B @8B is the index ID of Snow Warning Duplicate
	beq SnowWarning

08 78 2D 28 01 D1 10 4A 10 47 6F 28 01 D0 [B]8B 28 03 D0[/B] 0F 4C 20 47 0F 
4A 11 88 80 20 08 40 00 28 01 D0 00 F0 0D F8 80 20 10 80 0B 4A 00 20 10 70 
0A 48 00 F0 07 F8 0A 48 51 46 C1 75 00 F0 04 F8 08 4C 20 47 08 4A 10 47 08 
48 00 47 AD A2 01 08 49 A1 01 08 1C 3F 02 02 48 3F 02 02 D0 9A 90 08 C4 3F 
02 02 AB BB 01 08 25 BC 01 08 5B BB 01 08

KDS said:

There was a report mentioning problems with the Magic Bounce Ability in MrDS's Rombase, so I decided it to implement this myself from scratch, and it is working fine in Trainer Battles and Doubles.
Here it is posted with Moxie.

Magic Bounce

Spoiler:

Fire Red

For MrDS's base 1.5a at x1D8D6 insert, 18 01 80 18 00 78 C0 06 88 46 before applying the new routines to remove branch to the old routine.

Spoiler:

Routine At XXXXXX:

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global magicbounce
.align 2
     
        mov r9, r2
        ldr r1, freeRAMLoc
        ldrb r1, [r1, #0x0]
        cmp r1, #0x0
        bne nobouncing
        cmp r0, #0x0
        bge magicbouncecheck
        
        ldr r2, moveTable
        ldr r1, =0x0801D8E9
        bx r1

magicbouncecheck:
        ldr r2, =0x02023C04
        ldr r1, =0x02023D6C
        ldrb r3, [r1, #0x0]
        mov r1, #0x58
        mul r1, r3
        add r1, r1, r2
        ldrb r1, [r1, #0x0]
        cmp r1, [U]#0x9D[/U]
        bne nobouncing

        ldr r2, =0x02023DFC
        lsl r1, r3, #0x02
        add r1, r1, r2
        ldr r1, [r1, #0x0]
        ldr r0, =0x000400C0
        and r0, r1
        cmp r0, #0x0
        bne nobouncing

        ldr r2, moveTable
        ldr r0, =0x02023D4A
        ldrh r1, [r0, #0x0]
        lsl r0, r1, #0x01
        add r0, r0, r1
        lsl r0, r0, #0x02
        add r0, r0, r2
        ldrb r1, [r0, #0x8]
        mov r0, #0x4
        and r0, r1
        cmp r0, #0x0
        beq nobouncing 

        ldr r0, =0x02023D6B
        ldrb r0, [r0, #0x0]
        ldr r2, =0x00000115
        add r1, r3, #0x0
        bl pressure

        bl returnSetter

        ldr r1, =0x02023D74
        ldr r0, MBScript
        str r0, [r1, #0x0]
        ldr r0, =0x0801DAFD
        bx r0

nobouncing:
        ldr r1, =0x0801D94D
        bx r1

pressure:
        ldr r3, =0x08016EC9
        bx r3

returnSetter:
        ldr r1, =0x08017545
        bx r1

.align 2
freeRAMLoc: .word 0x0203C030
moveTable: .word 0x08250C04
MBScript: .word [B]0x08VVVVVV[/B]

@At 1D8E0, insert: 00 49 08 47 XX+1 XX XX 08

Routine At YYYYYY:

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global bounceflagclear
.align 2

ldr r3, freeRAMLoc
ldrb r0, [r3, #0x0]
cmp r0, #0x0
beq exit
sub r0, r0, #0x1
strb r0, [r3, #0x0]

exit:
add sp, #0x4
pop {r3, r4}
mov r8, r3
mov r9, r4
pop {r4-r7}
pop {r0}
bx r0

.align 2
freeRAMLoc: .word 0x0203C030

@At 1DAFC, insert: 00 48 00 47 YY+1 YY YY 08

Routine At ZZZZZZ:

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global setbouncereflectionflag

main:    
    push {lr}
    ldr r0, freeRAMLoc
    ldr r1, =0x02023BCC
    ldrb r1, [r1, #0x0]
    cmp r1, #0x2
    beq oneexit

    ldr r2, =0x02023D4A
    ldr r1, moveTable
    mov r3, #0xC
    ldrb r2, [r2, #0x0]
    mul r3, r2
    add r1, r1, r3
    ldrb r1, [r1, #0x6]
    cmp r1, #0x8
    bne oneexit

    ldr r2, =0x02023D6D
    ldrb r2, [r2, #0x0]
    mov r1, #0x58
    mul r1, r2
    ldr r3, =0x02023C0C
    add r3, r3, r1
    ldrh r3, [r3, #0x0]
    cmp r3, #0x0
    beq oneexit

    mov r1, #0x2
    strb r1, [r0, #0x0]
    pop {r0}
    bx r0

oneexit:
    mov r1, #0x1
    strb r1, [r0, #0x0]
    pop {r0}
    bx r0

.align 2
freeRAMLoc: .word 0x0203C030
moveTable: .word 0x08250C04

Magic Coat Script (At UUUUUU):

Spoiler:

At x1D934, insert in reverse hex: UU UU UU 08

Code:

02 03 39 20 00 10 BE 00 12 40 00 F8 [B]ZZ+1 ZZ ZZ 08[/B] 35 D0 3D 02 02 00 0C 80 00 76 01 01 3C

Magic Bounce Script (At VVVVVV):

Spoiler:

Code:

02 03 39 20 00 FA 20 C0 03 02 [B]SS SS SS 08[/B] 10 84 01 12 40 00 F8 [B]ZZ+1 ZZ ZZ 08[/B] 35 D0 3D 02 02 00 0C 80 00 76 01 01 3C

String At SSSSSS:

Code:

FD 13 B4 E7 00 FD 14 FE EB D5 E7 00 D6 E3 E9 E2 D7 D9 D8 00 D6 D5 D7 DF 00 D6 ED 00 FD 1B AB FF

Notes to understand this:

Spoiler:

+ If for some stupid reason, Magic Coat is used on a Magic Bounce pokemon, then Magic coat activates before Magic bounce.
+ Magic Bounce does not activate, if the mon with Magic Bounce is in a semi-invulnerable state (fly, dive etc.).
+ Added a special Flag to ensure that Magic Bounce does not re-reflect a move reflected by Magic Bounce/Magic Coat. Otherwise, a infinite ping-pong loop happens between two Magic Bounce pokemon.
+ A free RAM location is used for this Flag. Initially, it is set to 0. When the condition for Magic Coat or Magic Bounce is met, it is set to 1 (e.g, always the case in singles, reflected spore in doubles) or 2 (e.g reflected growl in doubles), according to the no. of mons the rebounded Move can affect, and then the Rebound is executed.
+ If the value of the Flag is non-zero, the Magic Bounce and Magic Coat checks are automatically skipped to avoid the re-reflection situation and the Flag is decremented by 1 and this Step is repeated until the Flag is cleared to 0.
+ This to try to ensure that during the Rebound itself, the Flag is successfully cleared to 0.
+ The free RAM location refered in the 3 routines MUST BE SAME.
+ Will port to Emerald soon.

Moxie

Spoiler:

Fire Red

Spoiler:

At x213DC, insert in reverse hex: XX XX XX 08

Battle Script at XXXXXX:

Spoiler:

Code:

56 00
39 40 00
1A 00
1B 00
10 1D 00
10 30 01
1E 01 [U]9A[/U] [B]YY YY YY 08[/B]
3C

Battle Script at YYYYYY:

Spoiler:

Code:

E3 01 [B]ZZ ZZ ZZ 08[/B]
20 01 00 01 0C [B]ZZ ZZ ZZ 08[/B]
39 20 00
2E DF 3F 02 02 00
48 01 02 00
2E DE 3F 02 02 11
89 41 [B]ZZ ZZ ZZ 08[/B]
FA 20 C0 03 02 [B]SS SS SS 08[/B] 
10 84 01
12 40 00
3C

Battle Script at ZZZZZZ:

Code:

3C

String at SSSSSS:

Code:

FD 0F B4 E7 00 C7 E3 EC DD D9 FE E6 D5 DD E7 D9 D8 00 DD E8 E7 00 BB E8 E8 D5 D7 DF AB FF

Emerald

Spoiler:

At x49C8C insert in reverse hex: XX XX XX 08

Battle Script at XXXXXX:

Spoiler:

Code:

56 00
39 40 00
1A 00
1B 00
10 1D 00
10 30 01
1E 01 [U]9A[/U] [B]YY YY YY 08[/B]
3C

Battle Script at YYYYYY:

Spoiler:

Code:

E3 01 [B]ZZ ZZ ZZ 08[/B]
20 01 00 01 0C [B]ZZ ZZ ZZ 08[/B]
39 20 00
2E 8F 44 02 02 00
48 01 02 00
2E 8E 44 02 02 11
89 41 [B]ZZ ZZ ZZ 08[/B]
FB 20 E3 03 02 [B]SS SS SS 08[/B] //Assuming that setword command is at FB, and the RAM location for the string pointer is at 0x203E320. If not, then change this line accordingly
10 84 01
12 40 00
3C

Battle Script at ZZZZZZ:

Code:

3C

String At SSSSSS:

Code:

FD 0F B4 E7 00 C7 E3 EC DD D9 FE E6 D5 DD E7 D9 D8 00 DD E8 E7 00 BB E8 E8 D5 D7 DF AB FF

Also, these require Jambo's Callasm and Setword commands, and his Battle String Loader Hack.

Click to expand...

The_learner said:

I expanded the table...
I think it has f7(starting from 00) commands.... so I inserted the jambo's callasm at f8 and setword command at f9 is it ok ????
also
1E 01 9A YY YY YY 08
what about that underlined 9A
do it needs to be changed or is something special there ???

hoping to get answer :)

Click to expand...

KDS said:

Yes, its good to go.
9A is the ability index for moxie. So if you have an index other than 9A for moxie then you will have to change this.

Click to expand...

MrDollSteak said:

To start off here are a few damage-calc related abilities as well as an update Sturdy effect!

These abilities require Doesnt's PSS Split, because of a few shifting bytes.

Sniper, Technician, Defeatist and the Slow Start Attack Drop

Spoiler:

Fire Red

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global snipertechnicianandslowstartattackdrop
 
Main:
	cmp r4, #0x37
	bne Sniper
HustleBoost:
	lsr r0, r7, #0x1
	add r7, r0, r7
Sniper:
	cmp r4, #0x62
	bne Technician
CheckCrit:
	ldr r0, .CritLoc
	ldrb r0, [r0]
	cmp r0, #0x2
	bne Return
	b Boost
Technician:
	cmp r4, #066
	bne Defeatist
CheckBasePower:
	ldr r0, .BasePower
	ldrb r0, [r0]
	cmp r0, #0x3D
	bge Return
Boost:
	lsr r0, r7, #0x1
	add r7, r0, r7
	mov r2, r8
	lsr r0, r2, #0x1
	add r0, r0, r2
	mov r8, r0
Defeatist:
	cmp r4, #066
	bne SlowStart
CheckHP:
	ldrh r2, [r0, #0xC]
	lsr r2, r2, #0x1
	ldrh r0, [r0, #0x8]
	cmp r0, r2
	bgt Return
	mov r2, r8
	lsr r0, r2, #0x1
	mov r8, r0
	b AttackDrop
SlowStart:
	cmp r4, #0x71
	bne Return
CheckCounter:
	ldr r0, .SlowStartLoc
	ldr r2, [sp, #0xC]
	add r0, r0, r2
	ldrb r0, [r0]
	cmp r0, #0x0
	beq Return
AttackDrop:
	lsr r7, r7, #0x1
Return:
	ldr r0, .Return
	bx r0

.align 2
.CritLoc: .word 0x02023D71
.BasePower: .word 0x02024020
.SlowStartLoc: .word 0x0203C024
.Return: .word 0x0803F065

#Insert 00 48 00 47 xx xx xx 08 at 03F05C

.SlowStartLoc is a free ram location that you can use to have the counter for slow start.

It has come to my attention that Technician can apply some unwanted boosts to Revenge and a few other moves, so the code will be amended in the future.

Emerald

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global damagecalchalve
 
Main:
	cmp r4, #0x37
	bne Sniper
HustleBoost:
	lsr r0, r7, #0x1
	add r7, r0, r7
Sniper:
	cmp r4, #0x62
	bne Technician
CheckCrit:
	ldr r0, .CritLoc
	ldrb r0, [r0]
	cmp r0, #0x2
	bne Return
	b Boost
Technician:
	cmp r4, #066
	bne Defeatist
CheckBasePower:
	ldr r0, .BasePower
	ldrb r0, [r0]
	cmp r0, #0x3D
	bge Return
Boost:
	lsr r0, r7, #0x1
	add r7, r0, r7
	mov r2, r8
	lsr r0, r2, #0x1
	add r0, r0, r2
	mov r8, r0
Defeatist:
	cmp r4, #066
	bne SlowStart
CheckHP:
	ldrh r2, [r0, #0xC]
	lsr r2, r2, #0x1
	ldrh r0, [r0, #0x8]
	cmp r0, r2
	bgt Return
	mov r2, r8
	lsr r0, r2, #0x1
	mov r8, r0
	b AttackDrop
SlowStart:
	cmp r4, #0x71
	bne Return
CheckCounter:
	ldr r0, .SlowStartLoc
	ldr r2, [sp, #0x10]
	add r0, r0, r2
	ldrb r0, [r0]
	cmp r0, #0x0
	beq Return
AttackDrop:
	lsr r7, r7, #0x1
Return:
	ldr r0, .Return
	bx r0

.align 2
.CritLoc: .word 0x02024211
.BasePower: .word 0x020244E0
.SlowStartLoc: .word 0x0203E324
.Return: .word 0x0806989B

#Insert 00 48 00 47 xx xx xx 08 at 069888

.SlowStartLoc is a free ram location that you can use to have the counter for slow start.

It has come to my attention that Technician can apply some unwanted boosts to Revenge and a few other moves, so the code will be amended in the future.

Toxic Boost and Flare Boost

Spoiler:

Fire Red

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global statusboostabilities
 
Main:
  	ldr r1, [sp, #0x24]
	ldrb r0, [r1]
	cmp r0, #0x8A
	beq ToxicBoost
	cmp r0, #0x8B
	beq FlareBoost
	cmp r0, #0x3E
	bne MarvelScaleCheck
GutsReturn:
	ldr r0, .Return
	bx r0
ToxicBoost:
	ldr r0, [r6, #0x4C]
CheckPoison:
	cmp r0, #0x8
	beq AttackBoost
	cmp r0, #0x80
	bne MarvelScaleCheck
AttackBoost:
	lsr r0, r7, #0x1
	add r7, r0, r7
	b MarvelScaleCheck
FlareBoost:
	ldr r0, [r6, #0x4C]
CheckBurn:
	cmp r0, #0x10
	bne MarvelScaleCheck
SpAtkBoost:
	mov r2, r8
	lsr r0, r2, #0x1
	add r2, r0, r2
	mov r8, r2
MarvelScaleCheck:
	ldr r0, .Return2
	bx r0
 
.align 2
.Return: .word 0x0803F0CD
.Return2: .word 0x0803F0E1

#insert 00 48 00 47 xx xx xx 08 at 03F0C4

Emerald

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global statusboostabilities
 
Main:
	ldrb r0, [r1]
	cmp r0, #0x8A
	beq ToxicBoost
	cmp r0, #0x8B
	beq FlareBoost
	cmp r0, #0x3E
	bne MarvelScaleCheck
Guts:
CheckStatus:
	ldr r0, [r6, #0x4C]
	cmp r0, #0x0
	beq MarvelScaleCheck
GutsReturn:
	ldr r0, .Return
	bx r0
ToxicBoost:
	ldr r0, [r6, #0x4C]
CheckPoison:
	cmp r0, #0x8
	beq AttackBoost
	cmp r0, #0x80
	bne MarvelScaleCheck
AttackBoost:
	lsr r0, r7, #0x1
	add r7, r0, r7
	b MarvelScaleCheck
FlareBoost:
	ldr r0, [r6, #0x4C]
CheckBurn:
	cmp r0, #0x10
	bne MarvelScaleCheck
SpAtkBoost:
	mov r2, r8
	lsr r0, r2, #0x1
	add r2, r0, r2
	mov r8, r2
MarvelScaleCheck:
	ldr r0, .Return2
	bx r0
 
.align 2
.Return: .word 0x08069909
.Return2: .word 0x08069917

#insert 00 48 00 47 xx xx xx 08 at 0698FC

Multiscale and Fur Coat

Spoiler:

Fire Red

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global multiscaleandfurcoat
 
Main:
	ldr r2, [sp, #0x28]
	ldrb r0, [r2]
	cmp r0, #0x3F
	bne Multiscale
	ldr r0, .Return
	bx r0
Multiscale:
	cmp r0, #0x89
	bne FurCoat
CheckHP:
	ldr r1, [sp, #0x4]
	ldrh r0, [r1, #0x28]
	ldrh r1, [r1, #0x2C]
	cmp r1, r0
	bne Return
HalveDamage:
	lsr r7, r7, #0x1
	mov r0, r8
	lsr r0, r0, #0x1
	mov r8, r0
FurCoat:
	ldrb r0, [r2]
	cmp r0, #0xAA
	bne Return
DefenseBoost:
	ldr r1, [sp, #0x14]
	mov r0, r1
	add r1, r0, r0
	str r1, [sp, #0x14]
Return:
	ldr r2, .Return2
	bx r2

.align 2
.Return: .word 0x0803F0E9
.Return2: .word 0x0803F103

#insert 00 48 00 47 xx xx xx 08 at 03F0E0

Emerald

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global multiscaleandfurcoat
 
Main:
	ldrb r0, [r2]
	cmp r0, #0x3F
	bne Multiscale
	ldr r3, [sp, #0x4]
	ldr r0, .Return
	bx r0
Multiscale:
	cmp r0, #0x89
	bne FurCoat
CheckHP:
	ldr r1, [sp, #0x4]
	ldrh r0, [r1, #0x28]
	ldrh r1, [r1, #0x2C]
	cmp r1, r0
	bne Return
HalveDamage:
	lsr r7, r7, #0x1
	mov r0, r8
	lsr r0, r0, #0x1
	mov r8, r0
FurCoat:
	ldrb r0, [r2]
	cmp r0, #0xAA
	bne Return
DefenseBoost:
	ldr r1, [sp, #0x18]
	mov r0, r1
	add r1, r0, r0
	str r1, [sp, #0x18]
Return:
	ldr r2, .Return2
	bx r2

.align 2
.Return: .word 0x08069921
.Return2: .word 0x08069939

#insert 00 48 00 47 xx xx xx 08 at 069918

Sturdy

Spoiler:

Fire Red

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global sturdyupdate
 
Sturdy:
	ldrb r0, [r3]
	mov r1, #0x58
	mul r0, r1
	add r0, r0, r2
	add r0, #0x20
	ldrb r1, [r0]
	cmp r1, #0x5
	bne FalseSwipeCheck
CheckHP:
	ldrh r1, [r0, #0xC]
	ldrh r0, [r0, #0x8]
	cmp r0, r1
	beq SturdySuccess
FalseSwipeCheck:
	ldr r0, .MoveLoc
	ldrh r1, [r0]
	lsl r0, r1, #0x1
	add r0, r0, r1
	ldr r2, .Return
	bx r2
SturdySuccess:
DisplayEndureMessage:
	mov r0, #0x56
	ldr r1, .Index
	ldrb r2, [r3]
	lsl r0, r2, #0x4
	add r0, r0, r1
	mov r1, #0x2
	strb r1, [r0]
Return:
	ldr r0, .Return2
	bx r0

.align 2

.MoveLoc: .word 0x02023D4A
.Return: .word 0x0801F1ED
.Index: .word 0x02023E8C
.Return2: .word 0x0801F217

#insert 01 48 00 47 00 00 xx xx xx 08 1A 4A at 01F1E2

It should be noted that this doesn't work fully with Multi-hit moves, in that they do not break Sturdy. I am planning on rewriting the entire Multi-hit system to make Parental Bond.

Emerald

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global sturdyupdate
 
Sturdy:
	ldrb r0, [r3]
	mov r1, #0x58
	mul r0, r1
	add r0, r0, r2
	add r0, #0x20
	ldrb r1, [r0]
	cmp r1, #0x5
	bne FalseSwipeCheck
CheckHP:
	ldrh r1, [r0, #0xC]
	ldrh r0, [r0, #0x8]
	cmp r0, r1
	beq SturdySuccess
FalseSwipeCheck:
	ldr r0, .MoveLoc
	ldrh r1, [r0]
	lsl r0, r1, #0x1
	add r0, r0, r1
	ldr r2, .Return
	bx r2
SturdySuccess:
DisplayEndureMessage:
	mov r0, #0x56
	ldr r1, .Index
	ldrb r2, [r3]
	lsl r0, r2, #0x4
	add r0, r0, r1
	mov r1, #0x2
	strb r1, [r0]
Return:
	ldr r0, .Return2
	bx r0

.align 2

.MoveLoc: .word 0x020241EA
.Return: .word 0x080479DD
.Index: .word 0x0202433C
.Return2: .word 0x08047A07

#insert 01 48 00 47 00 00 xx xx xx 08 1A 4A at 0479D2

It should be noted that this doesn't work fully with Multi-hit moves, in that they do not break Sturdy. I am planning on rewriting the entire Multi-hit system to make Parental Bond.

Click to expand...

VeryBestRogue said:

Hey guys! I am finding it hard to insert the abilities in my ROM is there any one who could be willing to help out? I expand the Ability Table and then insert the ASM then what do i Have to do ??? I dont want to rely on MrDs' Patch (no offence) as it is not dynamic...

Click to expand...

BluRose said:

insert the asm routines and make the necessary byte changes, and all should be outlined in the post :P

edit: and mrds' patch is rather fine to use unless if you're using that space starting at 0x900000

Click to expand...

MrDollSteak said:

Skill Link

Spoiler:

Fire Red

Spoiler:

Search for the pointer D9 6C 1D 08 in your rom, and replace it with a pointer to free space XX XX XX 08.

Battle Script at XX XX XX

Code:

1E 01 5D [B]YY YY YY[/B] 08
28 D9 6C 1D 08

Battle Script at YY YY YY

Code:

00
01 5E 69 1D 08
00 00 02 03
8D 05 
8E 2E
2E DA 3F 02 02 00
28 EC 6C 1D 08

Emerald

Spoiler:

Search for the pointer EA 8D 2D 08 in your rom, and replace it with a pointer to free space XX XX XX 08.

Battle Script at XX XX XX

Code:

1E 01 5D YY YY YY 08 
28 EA 8D 2D 08

Battle Script at YY YY YY

Code:

00 
01 5E 8A 2D 08 
00 00 02 03
8D 05 
8E 2E 
2E 8A 44 02 02 00 
28 FD 8D 2D 08

Click to expand...

KDS said:

There was a report mentioning problems with the Magic Bounce Ability in MrDS's Rombase, so I decided it to implement this myself from scratch, and it is working fine in Trainer Battles and Doubles.
Here it is posted with Moxie.

Magic Bounce

Spoiler:

Fire Red

For MrDS's base 1.5a at x1D8D6 insert, 18 01 80 18 00 78 C0 06 88 46 before applying the new routines to remove branch to the old routine.

Spoiler:

Routine At XXXXXX:

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global magicbounce
.align 2
     
        mov r9, r2
        ldr r1, freeRAMLoc
        ldrb r1, [r1, #0x0]
        cmp r1, #0x0
        bne nobouncing
        cmp r0, #0x0
        bge magicbouncecheck
        
        ldr r2, moveTable
        ldr r1, =0x0801D8E9
        bx r1

magicbouncecheck:
        ldr r2, =0x02023C04
        ldr r1, =0x02023D6C
        ldrb r3, [r1, #0x0]
        mov r1, #0x58
        mul r1, r3
        add r1, r1, r2
        ldrb r1, [r1, #0x0]
        cmp r1, [U]#0x9D[/U]
        bne nobouncing

        ldr r2, =0x02023DFC
        lsl r1, r3, #0x02
        add r1, r1, r2
        ldr r1, [r1, #0x0]
        ldr r0, =0x000400C0
        and r0, r1
        cmp r0, #0x0
        bne nobouncing

        ldr r2, moveTable
        ldr r0, =0x02023D4A
        ldrh r1, [r0, #0x0]
        lsl r0, r1, #0x01
        add r0, r0, r1
        lsl r0, r0, #0x02
        add r0, r0, r2
        ldrb r1, [r0, #0x8]
        mov r0, #0x4
        and r0, r1
        cmp r0, #0x0
        beq nobouncing 

        ldr r0, =0x02023D6B
        ldrb r0, [r0, #0x0]
        ldr r2, =0x00000115
        add r1, r3, #0x0
        bl pressure

        bl returnSetter

        ldr r1, =0x02023D74
        ldr r0, MBScript
        str r0, [r1, #0x0]
        ldr r0, =0x0801DAFD
        bx r0

nobouncing:
        ldr r1, =0x0801D94D
        bx r1

pressure:
        ldr r3, =0x08016EC9
        bx r3

returnSetter:
        ldr r1, =0x08017545
        bx r1

.align 2
freeRAMLoc: .word 0x0203C030
moveTable: .word 0x08250C04
MBScript: .word [B]0x08VVVVVV[/B]

@At 1D8E0, insert: 00 49 08 47 XX+1 XX XX 08

Routine At YYYYYY:

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global bounceflagclear
.align 2

ldr r3, freeRAMLoc
ldrb r0, [r3, #0x0]
cmp r0, #0x0
beq exit
sub r0, r0, #0x1
strb r0, [r3, #0x0]

exit:
add sp, #0x4
pop {r3, r4}
mov r8, r3
mov r9, r4
pop {r4-r7}
pop {r0}
bx r0

.align 2
freeRAMLoc: .word 0x0203C030

@At 1DAFC, insert: 00 48 00 47 YY+1 YY YY 08

Routine At ZZZZZZ:

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global setbouncereflectionflag

main:    
    push {lr}
    ldr r0, freeRAMLoc
    ldr r1, =0x02023BCC
    ldrb r1, [r1, #0x0]
    cmp r1, #0x2
    beq oneexit

    ldr r2, =0x02023D4A
    ldr r1, moveTable
    mov r3, #0xC
    ldrb r2, [r2, #0x0]
    mul r3, r2
    add r1, r1, r3
    ldrb r1, [r1, #0x6]
    cmp r1, #0x8
    bne oneexit

    ldr r2, =0x02023D6D
    ldrb r2, [r2, #0x0]
    mov r1, #0x58
    mul r1, r2
    ldr r3, =0x02023C0C
    add r3, r3, r1
    ldrh r3, [r3, #0x0]
    cmp r3, #0x0
    beq oneexit

    mov r1, #0x2
    strb r1, [r0, #0x0]
    pop {r0}
    bx r0

oneexit:
    mov r1, #0x1
    strb r1, [r0, #0x0]
    pop {r0}
    bx r0

.align 2
freeRAMLoc: .word 0x0203C030
moveTable: .word 0x08250C04

Magic Coat Script (At UUUUUU):

Spoiler:

At x1D934, insert in reverse hex: UU UU UU 08

Code:

02 03 39 20 00 10 BE 00 12 40 00 F8 [B]ZZ+1 ZZ ZZ 08[/B] 35 D0 3D 02 02 00 0C 80 00 76 01 01 3C

Magic Bounce Script (At VVVVVV):

Spoiler:

Code:

02 03 39 20 00 FA 20 C0 03 02 [B]SS SS SS 08[/B] 10 84 01 12 40 00 F8 [B]ZZ+1 ZZ ZZ 08[/B] 35 D0 3D 02 02 00 0C 80 00 76 01 01 3C

String At SSSSSS:

Code:

FD 13 B4 E7 00 FD 14 FE EB D5 E7 00 D6 E3 E9 E2 D7 D9 D8 00 D6 D5 D7 DF 00 D6 ED 00 FD 1B AB FF

Notes to understand this:

Spoiler:

+ If for some stupid reason, Magic Coat is used on a Magic Bounce pokemon, then Magic coat activates before Magic bounce.
+ Magic Bounce does not activate, if the mon with Magic Bounce is in a semi-invulnerable state (fly, dive etc.).
+ Added a special Flag to ensure that Magic Bounce does not re-reflect a move reflected by Magic Bounce/Magic Coat. Otherwise, a infinite ping-pong loop happens between two Magic Bounce pokemon.
+ A free RAM location is used for this Flag. Initially, it is set to 0. When the condition for Magic Coat or Magic Bounce is met, it is set to 1 (e.g, always the case in singles, reflected spore in doubles) or 2 (e.g reflected growl in doubles), according to the no. of mons the rebounded Move can affect, and then the Rebound is executed.
+ If the value of the Flag is non-zero, the Magic Bounce and Magic Coat checks are automatically skipped to avoid the re-reflection situation and the Flag is decremented by 1 and this Step is repeated until the Flag is cleared to 0.
+ This to try to ensure that during the Rebound itself, the Flag is successfully cleared to 0.
+ The free RAM location refered in the 3 routines MUST BE SAME.
+ Will port to Emerald soon.

Moxie

Spoiler:

Fire Red

Spoiler:

At x213DC, insert in reverse hex: XX XX XX 08

Battle Script at XXXXXX:

Spoiler:

Code:

56 00
39 40 00
1A 00
1B 00
10 1D 00
10 30 01
1E 01 [U]9A[/U] [B]YY YY YY 08[/B]
3C

Battle Script at YYYYYY:

Spoiler:

Code:

E3 01 [B]ZZ ZZ ZZ 08[/B]
20 01 00 01 0C [B]ZZ ZZ ZZ 08[/B]
39 20 00
2E DF 3F 02 02 00
48 01 02 00
2E DE 3F 02 02 11
89 41 [B]ZZ ZZ ZZ 08[/B]
FA 20 C0 03 02 [B]SS SS SS 08[/B] 
10 84 01
12 40 00
3C

Battle Script at ZZZZZZ:

Code:

3C

String at SSSSSS:

Code:

FD 0F B4 E7 00 C7 E3 EC DD D9 FE E6 D5 DD E7 D9 D8 00 DD E8 E7 00 BB E8 E8 D5 D7 DF AB FF

Emerald

Spoiler:

At x49C8C insert in reverse hex: XX XX XX 08

Battle Script at XXXXXX:

Spoiler:

Code:

56 00
39 40 00
1A 00
1B 00
10 1D 00
10 30 01
1E 01 [U]9A[/U] [B]YY YY YY 08[/B]
3C

Battle Script at YYYYYY:

Spoiler:

Code:

E3 01 [B]ZZ ZZ ZZ 08[/B]
20 01 00 01 0C [B]ZZ ZZ ZZ 08[/B]
39 20 00
2E 8F 44 02 02 00
48 01 02 00
2E 8E 44 02 02 11
89 41 [B]ZZ ZZ ZZ 08[/B]
FB 20 E3 03 02 [B]SS SS SS 08[/B] //Assuming that setword command is at FB, and the RAM location for the string pointer is at 0x203E320. If not, then change this line accordingly
10 84 01
12 40 00
3C

Battle Script at ZZZZZZ:

Code:

3C

String At SSSSSS:

Code:

FD 0F B4 E7 00 C7 E3 EC DD D9 FE E6 D5 DD E7 D9 D8 00 DD E8 E7 00 BB E8 E8 D5 D7 DF AB FF

Also, these require Jambo's Callasm and Setword commands, and his Battle String Loader Hack.

Click to expand...

Chaotix said:

Not sure why I am having a tough time getting Moxie to work. When I KO a pokemon in the wild the attack boost animation plays then the game gets stuck there.

I put the pointer to where I inserted script XXXXXX at 0x08213DC;
changed the ability index to 4E from 9A since I only added Moxie;
added callasm to the command table at F8;
added battle string loader exactly as Jambo posted it here https://www.pokecommunity.com/showpost.php?p=7101031&postcount=230 do I need to change it at all?;
added setword command KDS posted on page 3 and added a pointer to it at FA in the command table.

What could be wrong?

Edit: For Fire Red

Click to expand...

FB 20 E3 03 02 SS SS SS 08