Decomp & Disassembly Tutorials
Simple Modifications Directory Page 20
Started by Hiroshi Sotomura December 30th, 2018 2:48 PM- 249080 views
- 477 replies
[PokeEmerald] A Personal Fix for the 16x16 doors anim tutorial
Just a personal & unproven discovery which posted here for anyone that needs it. Although I don't know whether it is WRONG or NOT until NOW. So please forgive my ignorance.
So, Several days ago, I accidentally found there was something wrong with the "16x16 door animation tutorial" (which enables PokeEmerald itself to display the 16x16 doors animations from PokeFirered) for the updated PokeEmerald, which was distributed here long time ago.
The Original Tutorial is here for anyone not knowing what I'm talking about:
https://github.com/scizz/darkfire/commit/b666ad85d3e22ac134fd24ce0bfe84f0e1e4a773
Well, I did nothing but just copied the original lines provided by that tutorial. And here is a picture of what had happened: When a single door was open or closed, only 1/4 of its original animation graphic was shown properly. And, moreover, the other part became glitchly pixels, for sure
I had checked the code over and over again, and made sure there was no mistake in my copy & paste process. And the animation of my newly added door was nothing but a graphic file grabbed directly & straightly from the original PokeFirered.
Luckily, I was happened to be lucky enough to find one possible solution. For anyone interested in it, here it is:
First, after implementing the codes from the tutorial, jump to the function named "CopyDoorTilesToVram", and change the lines below:
From:
to:
Then, add one completely new definition before that function itself:
Here is a picture of what it looked like after being fixed:
And that's pretty much of it, I wonder whether anyone here trying port the door animation of FRLG has met the same problem. Also, if there is anything wrong, please forgive my ignorance & leave a message to me.
Thanks.
Just a personal & unproven discovery which posted here for anyone that needs it. Although I don't know whether it is WRONG or NOT until NOW. So please forgive my ignorance.
So, Several days ago, I accidentally found there was something wrong with the "16x16 door animation tutorial" (which enables PokeEmerald itself to display the 16x16 doors animations from PokeFirered) for the updated PokeEmerald, which was distributed here long time ago.
The Original Tutorial is here for anyone not knowing what I'm talking about:
https://github.com/scizz/darkfire/commit/b666ad85d3e22ac134fd24ce0bfe84f0e1e4a773
Well, I did nothing but just copied the original lines provided by that tutorial. And here is a picture of what had happened: When a single door was open or closed, only 1/4 of its original animation graphic was shown properly. And, moreover, the other part became glitchly pixels, for sure
Spoiler:
I had checked the code over and over again, and made sure there was no mistake in my copy & paste process. And the animation of my newly added door was nothing but a graphic file grabbed directly & straightly from the original PokeFirered.
Luckily, I was happened to be lucky enough to find one possible solution. For anyone interested in it, here it is:
First, after implementing the codes from the tutorial, jump to the function named "CopyDoorTilesToVram", and change the lines below:
From:
Spoiler:
to:
Spoiler:
Then, add one completely new definition before that function itself:
Spoiler:
Here is a picture of what it looked like after being fixed:
Spoiler:
And that's pretty much of it, I wonder whether anyone here trying port the door animation of FRLG has met the same problem. Also, if there is anything wrong, please forgive my ignorance & leave a message to me.
Thanks.
"Many years later, as he standed in front of the hall of fame alone, the boy coming from Littleroot Town was to remember that distant summer's day when Prof. Birch gave him a little Mudkip."
Enable the usage of the SPECIES_UNOWN_(LETTER) constants for party creation [Em]
Earlier today, someone in Pret's Discord server talked about how they wanted to assign specific Unown letter forms to a trainer, and I took a shot at it because I was bored.
I didn't put this on a branch because I did it very quickly and it's simple to do too. It's not worth the hassle.
Like a handful of things in the game, the Unown letters are tied to the Pokémon's Personality ID.
With that in mind and focusing on the chunk of
Here's a code diff.
With these changes, you can easily drop in a
Note: This is specifically aimed towards people who don't use the Pokeemerald-expansion, which already separated each Unown letter into their own individual species.
Note2: Functionally speaking, this makes
And that's pretty much it.
Earlier today, someone in Pret's Discord server talked about how they wanted to assign specific Unown letter forms to a trainer, and I took a shot at it because I was bored.
I didn't put this on a branch because I did it very quickly and it's simple to do too. It's not worth the hassle.
Like a handful of things in the game, the Unown letters are tied to the Pokémon's Personality ID.
With that in mind and focusing on the chunk of
CreateBoxMonthat assigns the PID to a Pokémon it's generating, we can easily mod that PID to match whatever Unown form we want based on conditions.
Here's a code diff.
diff --git a/src/pokemon.c b/src/pokemon.c
index 7bc9f3bee3..d6dc7d8565 100644
--- a/src/pokemon.c
+++ b/src/pokemon.c
@@ -2195,6 +2195,24 @@ void CreateMon(struct Pokemon *mon, u16 species, u8 level, u8 fixedIV, u8 hasFix
CalculateMonStats(mon);
}
+static u32 UpdatePIDForUnownForms(u16 species, u32 ogPersonalityValue)
+{
+ u32 newPersonalityValue;
+ u32 actualLetter;
+ u16 nature, gender;
+
+ do
+ {
+ newPersonalityValue = Random32();
+ actualLetter = GET_UNOWN_LETTER(newPersonalityValue);
+ }
+ while (actualLetter != (species - NUM_SPECIES)
+ && nature != GetNatureFromPersonality(ogPersonalityValue)
+ && gender != GetGenderFromSpeciesAndPersonality(SPECIES_UNOWN, ogPersonalityValue));
+
+ return newPersonalityValue;
+}
+
void CreateBoxMon(struct BoxPokemon *boxMon, u16 species, u8 level, u8 fixedIV, u8 hasFixedPersonality, u32 fixedPersonality, u8 otIdType, u32 fixedOtId)
{
u8 speciesName[POKEMON_NAME_LENGTH + 1];
@@ -2205,9 +2223,21 @@ void CreateBoxMon(struct BoxPokemon *boxMon, u16 species, u8 level, u8 fixedIV,
ZeroBoxMonData(boxMon);
if (hasFixedPersonality)
- personality = fixedPersonality;
+ {
+ if (species >= SPECIES_UNOWN_B && species <= SPECIES_UNOWN_QMARK)
+ {
+ personality = UpdatePIDForUnownForms(species, fixedPersonality);
+ species = SPECIES_UNOWN;
+ }
+ else
+ {
+ personality = fixedPersonality;
+ }
+ }
else
+ {
personality = Random32();
+ }
SetBoxMonData(boxMon, MON_DATA_PERSONALITY, &personality);With these changes, you can easily drop in a
SPECIES_UNOWN_Fin Youngster Calvin's party data, or a
SPECIES_UNOWN_Xin the wild encounters list of Route 101, and they'll work as expected.
Note: This is specifically aimed towards people who don't use the Pokeemerald-expansion, which already separated each Unown letter into their own individual species.
Note2: Functionally speaking, this makes
CreateMonWithGenderNatureLetterobsolete.
And that's pretty much it.
