Simple Modifications Directory

Meister_anon~Master_o f_None · May 11, 2021

mgriffin said:
I might be mistaken, but won't this basically replace Hidden Power Dark with Fairy?

But now that you've replaced ++ (i.e. + 1) with turning TYPE_MYSTERY (8) into TYPE_FAIRY (18) you get this:

Code:

i | i == 8 ? 18 : i 9 | TYPE_FAIRY (18) 10 | TYPE_FIRE (10) 11 | TYPE_WATER (11) 12 | TYPE_GRASS (12) 13 | TYPE_ELECTRIC (13) 14 | TYPE_PSYCHIC (14) 15 | TYPE_ICE (15) 16 | TYPE_DRAGON (16)

I think you both need to generate a number that's 1 bigger and remap TYPE_MYSTERY to TYPE_FAIRY to have all the types. This might actually be working on your thread? I saw you and Buffel Saft made some changes to how dynamicMoveType was calculated.

possibly, I'm sending you a message from my thread now. but if it means anything type mystery is actually 0x9, not 0x8.

edit:
looked through things, mgriffin is right, there's one other change that needs to be made for this to work correctly.

This is the original.

Code:

gBattleStruct->dynamicMoveType = (15 * typeBits) / 63 + 1;
if (gBattleStruct->dynamicMoveType >= TYPE_MYSTERY)
++gBattleStruct->dynamicMoveType;

This is what it needs to be changed to.

Code:

gBattleStruct->dynamicMoveType = (16 * typeBits) / 63 + 1;
if (gBattleStruct->dynamicMoveType == TYPE_MYSTERY)
gBattleStruct->dynamicMoveType = TYPE_FAIRY;

Pretty confident about that, if you want to go over the explanations yourself you can check out my thread on the topic Here.

also making this change *may* affect the odds/conditions for certain types appearing I can't confirm that as its theory and I'm not good with bitwise anyway.

And a last note to cover all the bases , while the theory for this is sound, I haven't been able to test yet, so I don't recommend using the trick to try to add any more than
1 type.

Because of the way types have to be added, I am unsure if increasing the number would cause you to run afoul of the non-battle types.
There could be simple ways around that, if you're knowledgeable/savvy but I just didn't feel comfortable leaving people without that warning.

surskitty · May 12, 2021

Curve low-leveled wild Pokemon (PokeEmerald)

The level-scaling logic I used is in `src/pokemon.c` in GetPartyMonCurvedLevel(). You will probably want to edit it; the logic I have here was to demonstrate it works, not designed around game balance.

Locations that can have pokemon with a very wide range of levels will continue to do so; the level ranges are moved up so that the maximum level for wild pokemon is now either the max level in the encounter table, or (2 * curvedLevel + max)/3, whichever is higher. This weights the levels closer to the curve than the original, while maintaining a distinction between low-level areas and high-level ones.

https://github.com/surskitty/pokeemerald/commit/192bc233a0ef7523289a0314946e9b0af23aac83

Code:

git remote add surskitty https://github.com/surskitty/pokeemerald
git cherry-pick 192bc233a0ef7523289a0314946e9b0af23aac83

ETA: Vital Spirit et al weren't functioning correctly. That's fixed now. Adjusted level scaling logic for slightly better scaling.

Lunos · May 14, 2021

Wonder Trade (Em)
I've been working on this for the past 8 days or so, and after so many small issues that I solved thanks to the help of the gang at ROM Hacking Hideout, I think it's finally good to go.
This is a Pokeemerald port of Deokishisu's Wonder Trade system for Pokeruby, modified to suit my personal tastes and made compatible with the Pokeemerald-expansion.
Everything is pretty easy to modify as there's a handful of comments here and there, and the code in itself is easy to read too, so y'all can edit the whole thing as you see fit.

To incorporate this into a project automatically, you'll have to track my repository via git remote and pull my wonder_trade branch using git pull.
In other words:

Code:

git remote add lunos https://github.com/LOuroboros/pokeemerald
git pull lunos wonder_trade

Alternatively, you can implement this manually:
https://github.com/pret/pokeemerald/compare/master...LOuroboros:pokeemerald:wonder_trade

Video:

I tried to test it as thoroughly as I could, but I wouldn't be surprised if for whatever reason invalid species or items could be generated.
I appreciate any and all tests.

Bugs:
-~~Pokémon who can Mega Evolve or who can evolve into a species that can Mega Evolve, can't carry Y Mega Stones. Yes, this only applies to the Charmander Line, but still~~. (Fixed!)

And that's pretty much it.

surskitty · May 16, 2021

surskitty said:
Improved Editing Trainer Parties [EM]

Provides control over most aspects of NPC trainers and homogenizes party types. Based off part of Syreldar's hack. Thanks to UltimaSoul for helping me get it to work.

How to use:

Code:

git remote add surskitty https://github.com/surskitty/pokeemerald git pull surskitty trainer_control

src/data/trainer_parties.h will need all structs changed to TrainerMon and src/data/trainers.h needs to have .TrainerMon instead of .NoItemDefaultMoves et al. Those are both already applied to vanilla, but if you've done substantial edits, keep your versions and then do the find-replace to change structs and .party type.

More detailed usage notes are over here.

This has recently had some refactoring to save space and fix bugs.

I also have made a simpler version that's more space-efficient and does not involve manually selecting IVs and EVs. Instead, you set .build, .hiddenPower, and .difficulty to get an effort and IV setup that does roughly what you want. It's more limited but I'm personally finding it much better suited to my needs.

.build can be TRAINER_MON_DEFENSES, TRAINER_MON_SPEED_PHYS, TRAINER_MON_SPEED_SPEC, TRAINER_MON_HP_DEF, TRAINER_MON_HP_SPDEF, TRAINER_MON_PHYS, TRAINER_MON_SPEC, and determines EV allocation. Both of the speed options raise the corresponding attack stat. A default build at high difficulty allocates effort points evenly.
.difficulty TRAINER_EASIEST, TRAINER_EASY, TRAINER_MEDIUM only decide amount of IVs; TRAINER_MEDIUM is maxed. TRAINER_HARD, TRAINER_HARDER, and TRAINER_HARDEST allocate EVs and have maxed IVs. TRAINER_MAX is not player legal and assigns 255 EVs to each stat.
.hiddenPower takes TYPE_ constants. TYPE_NORMAL is default and gives either worst, best, or average IVs, depending on difficulty. The IV spreads used can be found in include/pokemon_iv_spreads.h .

Code:

git remote add surskitty https://github.com/surskitty/pokeemerald
git pull surskitty trainer_control_v2

Lunos · May 29, 2021

Evolution moves (FR)
I ported UltimaSoul and Sagiri/Zeturic's implementation of the evolution moves mechanic which I brought here sometime ago to Pokefirered because I was bored.

The changes can be checked in this commit:
https://github.com/LOuroboros/pokefirered/commit/c5c27fe5838e10af7bdd9d85cf5f3cd4dc08aba7

To quickly incorporate it into a project, you just have to track my repository via git remote and pull the branch where I did the modifications using git pull, like so:

Code:

git remote add lunos https://github.com/LOuroboros/pokefirered
git pull lunos evo_moves

Pic:

And that's pretty much it.

Robinlukke · May 29, 2021

[pokeemerald] Feed any number of pokéblocks

All changes are made at src/use_pokeblock.c:

From the following code, delete what is in RED:

Spoiler:

Code:

[B]static void UsePokeblockMenu(void)[/B]
{
    bool8 loading;

    switch (sInfo->mainState)
    {
    case STATE_HANDLE_INPUT:
        if (JOY_HELD(DPAD_UP))
        {
            PlaySE(SE_SELECT);
            UpdateSelection(TRUE);
            DestroyConditionSparkleSprites(sMenu->sparkles);
            sInfo->mainState = STATE_UPDATE_SELECTION;
        }
        else if (JOY_HELD(DPAD_DOWN))
        {
            PlaySE(SE_SELECT);
            UpdateSelection(FALSE);
            DestroyConditionSparkleSprites(sMenu->sparkles);
            sInfo->mainState = STATE_UPDATE_SELECTION;
        }
        else if (JOY_NEW(B_BUTTON))
        {
            PlaySE(SE_SELECT);
            sInfo->mainState = STATE_CLOSE;
        }
        else if (JOY_NEW(A_BUTTON))
        {
            PlaySE(SE_SELECT);

            // If last item, selected Cancel. Otherwise selected mon
            if (sMenu->info.curSelection == sMenu->info.numSelections - 1)
                sInfo->mainState = STATE_CLOSE;
            else
                sInfo->mainState = STATE_CONFIRM_SELECTION;
        }
        break;
    case STATE_UPDATE_SELECTION:
        loading = sMenu->info.loadNewSelection();
        if (!loading)
            sInfo->mainState = STATE_HANDLE_INPUT;
        break;
    case STATE_2:
        break;
    case STATE_CLOSE:
        SetUsePokeblockCallback(CloseUsePokeblockMenu);
        break;
    case STATE_4:
        break;
    case STATE_CONFIRM_SELECTION:
        AskUsePokeblock();
        sInfo->mainState++;
        break;
    case STATE_HANDLE_CONFIRMATION:
        switch (HandleAskUsePokeblockInput())
        {
        case 1: // NO
        case MENU_B_PRESSED:
            sInfo->mainState = STATE_HANDLE_INPUT;
            break;
        case 0: // YES
            [COLOR="Red"]if (IsSheenMaxed())
            {
                PrintWontEatAnymore();
                sInfo->mainState = STATE_WAIT_MSG;
            }
            else
            {[/COLOR]
                SetUsePokeblockCallback(FeedPokeblockToMon);
            [COLOR="Red"]}[/COLOR]
            break;
        }
        break;
    case STATE_WAIT_MSG:
        if (JOY_NEW(A_BUTTON | B_BUTTON))
        {
            EraseMenuWindow();
            sInfo->mainState = STATE_HANDLE_INPUT;
        }
        break;
    }
}

Code:

[B]static void AddPokeblockToConditions(struct Pokeblock *pokeblock, struct Pokemon *mon)[/B]
{
    u16 i;
    s16 cstat;
    u8 data;

    [COLOR="Red"]if (GetMonData(mon, MON_DATA_SHEEN) != 255)
    {[/COLOR]
        CalculatePokeblockEffectiveness(pokeblock, mon);
        for (i = 0; i < FLAVOR_COUNT; i++)
        {
            data = GetMonData(mon, sMonDataConditions[i]);
            cstat = data +  sInfo->pokeblockStatBoosts[i];
            if (cstat < 0)
                cstat = 0;
            if (cstat > 255)
                cstat = 255;
            data = cstat;
            SetMonData(mon, sMonDataConditions[i], &data);
        }

        cstat = (u8)(GetMonData(mon, MON_DATA_SHEEN)) + pokeblock->feel;
        if (cstat > 255)
            cstat = 255;

        data = cstat;
        SetMonData(mon, MON_DATA_SHEEN, &data);
    [COLOR="Red"]}[/COLOR]
}

Meister_anon~Master_o f_None · Jun 4, 2021

probably not something many would want to use, but if you want to remove all instances of critical hits, you can do so with 1 change.

https://github.com/pret/pokefirered/blob/master/src/battle_script_commands.c#L1219

this is from pokefirered but the same change can be made in other decomps,

in the critcalc function make sure gCritMultiplier is set to 1 for both cases.

That one change prevents crits altogether, that includes bypassing the damage increase, the crit stat bypass, & avoiding the crit message popup.

Since all of those things, check for if the multiplier is equal to 2.

takyon · Jun 10, 2021

Zeturic said:

Move Item [EM]

Spoiler:

Adds a MOVE option to the ITEM menu which allows you to move held items directly between Pokémon in your party, instead of having to use the bag as a middle man.

I've had this up in my pokeemerald fork for a while, but I never got around to writing it up here. Since I originally made it, the relevant functions got actual names in pokeemerald, so I'm taking this as an opportunity to update it and post it here.

There's going to be multiple changes required across multiple files, so I'm going to try to keep them in a logical order that minimizes jumping between files. Also, at the end of each step, pokeemerald will still be in a compilable state if done properly.

In the code blocks throughout this post, new lines of code are highlighted with the color green. Red highlights denote deleted lines of code. If a line of code isn't highlighted either color, it is only included for context.

Adding the strings

In include/strings.h, add the following to the end of the file:

Spoiler:

In src/strings.c, add the following to the end of the file:

Spoiler:

Adding the code

You'll need to add a forward declaration for CursorCb_MoveItem in src/party_menu.c, like so:

Spoiler:

At the end of src/party_menu.c, add the following:

Spoiler:

Code:

[span="background-color:green"]
void CursorCb_MoveItemCallback(u8 taskId)
{
    u16 item1, item2;
    u8 buffer[100];

    if (gPaletteFade.active || sub_81221EC())
        return;

    switch (PartyMenuButtonHandler(&gPartyMenu.slotId2))
    {
    case 2:     // User hit B or A while on Cancel
        HandleChooseMonCancel(taskId, &gPartyMenu.slotId2);
        break;
    case 1:     // User hit A on a Pokemon
        // Pokemon can't give away items to eggs or themselves
        if (GetMonData(&gPlayerParty[gPartyMenu.slotId2], MON_DATA_IS_EGG)
            || gPartyMenu.slotId == gPartyMenu.slotId2)
        {
            PlaySE(SE_HAZURE);
            return;
        }

        PlaySE(SE_SELECT);
        gPartyMenu.action = PARTY_ACTION_CHOOSE_MON;

        // look up held items
        item1 = GetMonData(&gPlayerParty[gPartyMenu.slotId], MON_DATA_HELD_ITEM);
        item2 = GetMonData(&gPlayerParty[gPartyMenu.slotId2], MON_DATA_HELD_ITEM);

        // swap the held items
        SetMonData(&gPlayerParty[gPartyMenu.slotId], MON_DATA_HELD_ITEM, &item2);
        SetMonData(&gPlayerParty[gPartyMenu.slotId2], MON_DATA_HELD_ITEM, &item1);

        // update the held item icons
        UpdatePartyMonHeldItemSprite(
            &gPlayerParty[gPartyMenu.slotId],
            &sPartyMenuBoxes[gPartyMenu.slotId]
        );

        UpdatePartyMonHeldItemSprite(
            &gPlayerParty[gPartyMenu.slotId2],
            &sPartyMenuBoxes[gPartyMenu.slotId2]
        );

        // create the string describing the move
        if (item2 == ITEM_NONE)
        {
            GetMonNickname(&gPlayerParty[gPartyMenu.slotId2], gStringVar1);
            CopyItemName(item1, gStringVar2);
            StringExpandPlaceholders(gStringVar4, gText_PkmnWasGivenItem);
        }
        else
        {
            GetMonNickname(&gPlayerParty[gPartyMenu.slotId], gStringVar1);
            CopyItemName(item1, gStringVar2);
            StringExpandPlaceholders(buffer, gText_XsYAnd);

            StringAppend(buffer, gText_XsYWereSwapped);
            GetMonNickname(&gPlayerParty[gPartyMenu.slotId2], gStringVar1);
            CopyItemName(item2, gStringVar2);
            StringExpandPlaceholders(gStringVar4, buffer);
        }

        // display the string
        DisplayPartyMenuMessage(gStringVar4, TRUE);

        // update colors of selected boxes
        AnimatePartySlot(gPartyMenu.slotId2, 0);
        AnimatePartySlot(gPartyMenu.slotId, 1);

        // return to the main party menu
        schedule_bg_copy_tilemap_to_vram(2);
        gTasks[taskId].func = Task_UpdateHeldItemSprite;
        break;
    }
}

void CursorCb_MoveItem(u8 taskId)
{
    struct Pokemon *mon = &gPlayerParty[gPartyMenu.slotId];

    PlaySE(SE_SELECT);

    // delete old windows
    PartyMenuRemoveWindow(&sPartyMenuInternal->windowId[1]);
    PartyMenuRemoveWindow(&sPartyMenuInternal->windowId[0]);

    if (GetMonData(mon, MON_DATA_HELD_ITEM) != ITEM_NONE)
    {
        gPartyMenu.action = PARTY_ACTION_SWITCH;

        // show "Move item to where" in bottom left
        DisplayPartyMenuStdMessage(PARTY_MSG_MOVE_ITEM_WHERE);
        // update color of first selected box
        AnimatePartySlot(gPartyMenu.slotId, 1);

        // set up callback
        gPartyMenu.slotId2 = gPartyMenu.slotId;
        gTasks[taskId].func = CursorCb_MoveItemCallback;
    }
    else
    {
        // create and display string about lack of hold item
        GetMonNickname(mon, gStringVar1);
        StringExpandPlaceholders(gStringVar4, gText_PkmnNotHolding);
        DisplayPartyMenuMessage(gStringVar4, TRUE);

        // return to the main party menu
        schedule_bg_copy_tilemap_to_vram(2);
        gTasks[taskId].func = Task_UpdateHeldItemSprite;
    }
}
[/span]

Open include/constants/party_menu.h, and look for #defines of the form PARTY_MSG_WHATEVER. We need to add a #define for PARTY_MSG_MOVE_ITEM_WHERE like so:

Spoiler:

Updating relevant data

Everything from here on will be in src/data/party_menu.h.

Look for an unnamed enum with values such as MENU_SUMMARY. Add MENU_MOVE_ITEM to the enum's list of values, like so:

Spoiler:

Now, we need to add an entry to the sCursorOptions array. Add an entry for MENU_MOVE_ITEM like so:

Spoiler:

Code:

struct
{
    const u8 *text;
    TaskFunc func;
} static const sCursorOptions[] =
{
    [MENU_SUMMARY] = {gText_Summary5, CursorCb_Summary},
    [MENU_SWITCH] = {gText_Switch2, CursorCb_Switch},
    [MENU_CANCEL1] = {gText_Cancel2, CursorCb_Cancel1},
    [MENU_ITEM] = {gText_Item, CursorCb_Item},
    [MENU_GIVE] = {gMenuText_Give, CursorCb_Give},
    [MENU_TAKE_ITEM] = {gText_Take, CursorCb_TakeItem},
    [span="background-color:green"][MENU_MOVE_ITEM] = {gMenuText_Move, CursorCb_MoveItem},[/span]
    [MENU_MAIL] = {gText_Mail, CursorCb_Mail},
    [MENU_TAKE_MAIL] = {gText_Take2, CursorCb_TakeMail},
    [MENU_READ] = {gText_Read2, CursorCb_Read},
    [MENU_CANCEL2] = {gText_Cancel2, CursorCb_Cancel2},
    [MENU_SHIFT] = {gText_Shift, CursorCb_SendMon},
    [MENU_SEND_OUT] = {gText_SendOut, CursorCb_SendMon},
    [MENU_ENTER] = {gText_Enter, CursorCb_Enter},
    [MENU_NO_ENTRY] = {gText_NoEntry, CursorCb_NoEntry},
    [MENU_STORE] = {gText_Store, CursorCb_Store},
    [MENU_REGISTER] = {gText_Register, CursorCb_Register},
    [MENU_TRADE1] = {gText_Trade4, CursorCb_Trade1},
    [MENU_TRADE2] = {gText_Trade4, CursorCb_Trade2},
    [MENU_TOSS] = {gMenuText_Toss, CursorCb_Toss},
    [MENU_FIELD_MOVES + FIELD_MOVE_CUT] = {gMoveNames[MOVE_CUT], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_FLASH] = {gMoveNames[MOVE_FLASH], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_ROCK_SMASH] = {gMoveNames[MOVE_ROCK_SMASH], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_STRENGTH] = {gMoveNames[MOVE_STRENGTH], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_SURF] = {gMoveNames[MOVE_SURF], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_FLY] = {gMoveNames[MOVE_FLY], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_DIVE] = {gMoveNames[MOVE_DIVE], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_WATERFALL] = {gMoveNames[MOVE_WATERFALL], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_TELEPORT] = {gMoveNames[MOVE_TELEPORT], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_DIG] = {gMoveNames[MOVE_DIG], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_SECRET_POWER] = {gMoveNames[MOVE_SECRET_POWER], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_MILK_DRINK] = {gMoveNames[MOVE_MILK_DRINK], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_SOFT_BOILED] = {gMoveNames[MOVE_SOFT_BOILED], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_SWEET_SCENT] = {gMoveNames[MOVE_SWEET_SCENT], CursorCb_FieldMove},
};

Next, find the definition of sActionStringTable. Add an entry to the end like so:

Spoiler:

And finally, we need to adjust the ITEM menu so that it actually includes our new menu option.

Find the definition of sPartyMenuAction_GiveTakeItemCancel, and modify it:

Spoiler:

Find the definition of sItemGiveTakeWindowTemplate and modify it:

Spoiler:

And that's it. Let me know if you have problems.

Edit: Oh, since I forgot to mention, my code here is licensed under the 0BSD license. In short, use it for whatever. Attribution is appreciated, but not required.

I'd like to point out that sub_81221EC is now called MenuHelpers_CallLinkSomething()
(this change was in https://github.com/pret/pokeemerald/commit/74edaed4265cc7e964a5383c3e0fb8ef256f2bf8)
and SE_HAZURE is now called SE_FAILURE
and 2 instances of schedule_bg_copy_tilemap_to_vram should be ScheduleBgCopyTilemapToVram (https://github.com/pret/pokeemerald/commit/da3062097a2372539dd7d4b5a43a2098deafc1cb)

Pyredrid said:
[PokeEmerald] Surfboard instead of HM Surf

Spoiler:

Adds in a Surfboard that lets the player just walk into water.
No long, annoying animations~

How to use:

Add the code to your pokeemerald decomp as described below.

Give the player the item ITEM_SURFBOARD

Have the player walk into water

The player will now be surfing on the water

How to add:

git remote add pyredrid https://github.com/Pyredrid/pokeemerald.git

git pull pyredrid surfboard

Same case for this, MUS_NAMINORI is now MUS_RG_SURF
The changes for music file names are here: https://github.com/pret/pokeemerald/commit/30142411799650c17367ce4652269e8ecca7ceef

For future reference for pret renaming, use git log -n 1 -S <insert your problem function/variable here>

If this shouldn't be here I apologise but these need to be updated to current pret naming conventions.

Lunos · Jun 13, 2021

Preset Playable Character Name (Em)
I was bored, so after seeing a post presenting a different way to achieve this result in "Whack a Hack", I was inspired to come up with a variant of it myself.
As the title suggests, this makes it so the game won't let you select a name for the playable characters of the game.
Instead, their names are forced set by us.

To incorporate this into a project automatically, you'll have to track my repository via git remote and pull my preset_player_name branch using git pull.
In other words:

Code:

git remote add lunos https://github.com/LOuroboros/pokeemerald
git pull lunos preset_player_name

Showcase:

I think it's fairly obvious by just looking at the code, but the strings that manage the playable characters' names are gText_DefaultMaleName and gText_DefaultFemaleName.

And that's pretty much it.

ghoulslash · Jun 16, 2021

[Pokeemerald] Remove warp's fadescreen effect

There might come a day where you want to fade the screen to black in a script and play a fanfare, print a message, or do something else, and immediately warp. If you try this in vanilla emerald, the screen will fade FROM black, and then back TO black. Instead, let's create a flag that removes the fadescreen part of the warp script commands and we can do something like this:

Before:

After:

Here's a wiki post with the simple instructions.

ghoulslash · Jun 17, 2021

[Pokeemerald] Flag to force Shiny Pokemon

This lets you create a flag that, when set, will cause newly created pokemon (with the player's OTID) to be shiny.

Check out the wiki post for information

Example script:

Code:

givemon SPECIES_TORCHIC, 13, 0
givemon SPECIES_ARON, 12, 0
setflag FLAG_SHINY_CREATION
givemon SPECIES_MUDKIP, 15, 0
clearflag FLAG_SHINY_CREATION

Lunos · Jun 18, 2021

Global Field Tints (Em)
I was bored, so I ported what in Pokefirered is known as gGlobalFieldTintMode.
What does this let you do? It allows you to put a tint on the elements shown on screen.
It should be a nice complement for flashback scenes and stuff like that.
Normally, in FRLG it's purely used in the flashbacks of the Quest Log feature of the game, which plays when you resume a savefile.

To incorporate this into a project automatically, you'll have to track my repository via git remote and pull my global_field_tints branch using git pull.
In other words:

Code:

git remote add lunos https://github.com/LOuroboros/pokeemerald
git pull lunos global_field_tints

Showcase:

To cast a tint, simply call either Script_SetGrayscaleTint or Script_SetSepiaTint in your script.
Once you're done, call Script_RemoveTint to remove the tint.

Bugs:
-Palette glitches when walking in the tall grass
Fixed.

-The rain looks black in game
I've no idea how to solve this and I also don't feel like working on this any longer.
Any valuable information on how to fix this or ideas about what to try would be well received.

And that's pretty much it.

TheXaman · Jun 20, 2021

[Pokeemerald] Updated debug menu!

Now with:
-SOUND!!!
-easy way to run custom scripts
-poison all party mons
-max money & max coins
-trigger daycare egg (no more running like crazy to test daycare changes)
-completly fill pc with pokemon

Also lots of small fixes!

Credits for the additions:
Sierraffinity
Jaizu

Spoiler:

Meister_anon~Master_o f_None · Jun 22, 2021

Emerald Style Gender Select Intro, in FireRed

In pokemon emerald, if you chose the no option on the name confirmation menu in the intro,
it will set you back to where you select your player gender.

In firered that doesn't exist, instead, you only go back to the naming screen.

And if you typically fast forward through the intro like I do, there are times, where you accidentally skip
through the gender select screen without realizing it.

With a small change to the section of code shown below from the oak_speech.c file, that'll never be a problem again.

Spoiler:

All that's needed is replacing Task_OakSpeech24 with OakSpeech16,
and it'll smoothly transition back to the gender select screen.

Jaizu · Jun 23, 2021

ghoulslash said:
[Pokeemerald] New Movement Actions

This adds new scripting movements, including walking and jumping backwards. See asm/macros/movement.inc for the names to use in scripts. New diagonal movements were not added since some diagonal movements already exist in emerald. This should also be relatively easy to add to pokefirered, if there are interested parties.

Here is the repo.

How to Add:

git remote add ghoulslash https://github.com/ghoulslash/pokeemerald

git pull ghoulslash new_movement_actions

Credits:
jiangzhengwenjzw for the source

If someone is looking for this, it got removed!
Those actions are actually not needed since we can use lock_facing_direction, like it's used in the Petalburg Woods when the aqua member backs off

Code:

PetalburgWoods_Movement_AquaBackOff: @ 822E1F9
	lock_facing_direction
	walk_up
	unlock_facing_direction
	step_end

Syreldar · Jun 27, 2021

[Pokeemerald] Fix critical bug with wild land Pokemon encounter ratio

Long time no see guys!
Thanks to @Axis & @MandL27 from the RomHack Hideout Discord, a critical bug within the calculation of the chance for the land encounters has been discovered, I'm here to share the fix with you guys.

Short explanation.
Let's say you have 12 different pokemons in your Map, and you want to evenly distribute their encounter ratios to make them equally rare, the correct thing to do is to set each individual slot's index to the total number of the mons in that zone:

This will result in all of mons having a 100/12 (8.33%) chance of appearing, which results in a 99.96/100 overall chance, not perfect, but it works perfectly since the way it works is summing all of the indexes and calculating the random for each slot, resulting in a fair calculation. (in out case the sum is 144 (12 mons * 12 value each), so each mon has a 12/144 chances of appearing)

But it has a critical flaw: The way it's coded.
This is the current wildmon encounter calc for each index.

Code:

static u8 ChooseWildMonIndex_Land(void)
{
    u8 rand = Random() % ENCOUNTER_CHANCE_LAND_MONS_TOTAL; // 0 to (ENCOUNTER_CHANCE_LAND_MONS_TOTAL-1) [143]

    if (rand < ENCOUNTER_CHANCE_LAND_MONS_SLOT_0) // if number (0-11) 0 (12 out of 143)
        return 0;
    else if (rand >= ENCOUNTER_CHANCE_LAND_MONS_SLOT_0 && rand < ENCOUNTER_CHANCE_LAND_MONS_SLOT_1) // if number (12-23) 1 (12 out of 143)
        return 1;
    else if (rand >= ENCOUNTER_CHANCE_LAND_MONS_SLOT_1 && rand < ENCOUNTER_CHANCE_LAND_MONS_SLOT_2) // if number (24-35) 2 (12 out of 143)
        return 2;
    else if (rand >= ENCOUNTER_CHANCE_LAND_MONS_SLOT_2 && rand < ENCOUNTER_CHANCE_LAND_MONS_SLOT_3) // if number (36-47) 3 (12 out of 143)
        return 3;
    else if (rand >= ENCOUNTER_CHANCE_LAND_MONS_SLOT_3 && rand < ENCOUNTER_CHANCE_LAND_MONS_SLOT_4) // if number (48-59) 4 (12 out of 143)
        return 4;
    else if (rand >= ENCOUNTER_CHANCE_LAND_MONS_SLOT_4 && rand < ENCOUNTER_CHANCE_LAND_MONS_SLOT_5) // if number (60-71) 5 (12 out of 143)
        return 5;
    else if (rand >= ENCOUNTER_CHANCE_LAND_MONS_SLOT_5 && rand < ENCOUNTER_CHANCE_LAND_MONS_SLOT_6) // if number (72-83) 6 (12 out of 143)
        return 6;
    else if (rand >= ENCOUNTER_CHANCE_LAND_MONS_SLOT_6 && rand < ENCOUNTER_CHANCE_LAND_MONS_SLOT_7) // if number (84-95) 7 (12 out of 143)
        return 7;
    else if (rand >= ENCOUNTER_CHANCE_LAND_MONS_SLOT_7 && rand < ENCOUNTER_CHANCE_LAND_MONS_SLOT_8) // if number (96-107) 8 (12 out of 143)
        return 8;
    else if (rand >= ENCOUNTER_CHANCE_LAND_MONS_SLOT_8 && rand < ENCOUNTER_CHANCE_LAND_MONS_SLOT_9) // if number (108-119) 9 (12 out of 143)
        return 9;
    else if (rand == ENCOUNTER_CHANCE_LAND_MONS_SLOT_9) // if number == 120 10 (1 out of 143)
        return 10;
    else
        return 11; // if number (121-143) 11 (23 out of 143)
}

Notice anything weird? Yup, the slot of index 10 will be almost impossible to reach, and the pokemon on the slot of index 11 (the last one) will appear much more likely than it should.

Fixes:

Land:

Code:

static u8 ChooseWildMonIndex_Land(void)

Code:

[COLOR="Red"]else if (rand == ENCOUNTER_CHANCE_LAND_MONS_SLOT_9)[/COLOR]

Code:

[COLOR="Lime"]else if (rand >= ENCOUNTER_CHANCE_LAND_MONS_SLOT_9 && rand < ENCOUNTER_CHANCE_LAND_MONS_SLOT_10)[/COLOR]

This bug also exists within the Super rod's calculation, which in case of failure, will default to the first slot of the old rod. (Although this is impossible to reproduce on vanilla due to the slot limitations of the rods)

Fishing:

Code:

static u8 ChooseWildMonIndex_Fishing(u8 rod)

Code:

[COLOR="Red"]if (rand == ENCOUNTER_CHANCE_FISHING_MONS_SUPER_ROD_SLOT_8)[/COLOR]

Code:

[COLOR="Lime"]if (rand >= ENCOUNTER_CHANCE_FISHING_MONS_SUPER_ROD_SLOT_8 && rand < ENCOUNTER_CHANCE_FISHING_MONS_SUPER_ROD_SLOT_9)[/COLOR]

"Why has no one discovered this before?"

Truth is Vanilla never had a land zone containing 12 different mons with evenly-distributed chances of appearing, thus this was impossible to notice and reproduce; the only way to notice the issue is inserting 12 different pokemons in a single zone and evenly distribute their chances of appearing, this way you would notice how rare the pokemon on the slot index 10 and how common the mon on the slot index 11 would be compared to all the others

TheXaman · Jun 29, 2021

[Pokeemerald] Only change nicknames of self caught mons!
This is a super simple addition which limits the nickname changing to Pokemon caught by the player.
In src/party_menu.c in the function SetPartyMonFieldSelectionActions change it to:

Code:

if (!IsTradedMon(&mons[slotId]))
{
    AppendToList(sPartyMenuInternal->actions, &sPartyMenuInternal->numActions, MENU_NICKNAME);
}

Lunos said:
Nicknaming as an option in the Pokémon Party Screen (Emerald)

Spoiler:

This code allows you to change the nickname of a Pokémon in your party on the Pokémon Party Screen with a new option called "Nickname".
Honestly, the idea of requiring the service of an NPC in X Town or City to change a Pokémon's nickname is silly.
You should always be able to nickname your own Pokémon, in my opinion.

The code can be found in this commit, it's super easy stuff.
https://github.com/shinny456/pokeemerald/commit/c92e5861e3ba85abaf53af81aa0bb70acae505af

Quick demonstration:

Bugs:

Spoiler:

-You can't nickname a Pokémon that knows 4 Field Moves.
To fix this, simply change u8 actions[8]; in the Line 123 of src/party_menu.c to u8 actions[9]; instead.
Credits to Ghoulslash for this fix.

The credits for this feature go to Shinny456. I'm just reposting it here because he wanted to share it with y'all.

And that's pretty much it.

Spoiler:

TheXaman · Jul 4, 2021

[Pokeemerald] TM Case ported from FR and custom one!

Base version (fr_tm_case_port):
I ported the TM Case from Firered over to Emerald:

This branch is meant as a starting point and basically "only" adds the functionality to the case. The original TM/HM pocket still exits.

Improved version (tx_ui_TmCase):
I also created an improved version:

This version adds the party Pokemon icons and grays them out, when the Pokemon cannot learn the currently selected move.
Additionally it gets rid of the TM/HM pocket and makes sure the player has 1 TM Case, if they find or receive a TM.

How to add:

Code:

git remote add xaman https://github.com/TheXaman/pokeemerald/
git pull xaman fr_tm_case_port

OR

Code:

git remote add xaman https://github.com/TheXaman/pokeemerald/
git pull xaman tx_ui_TmCase

I hope you like it and if you find any bugs please let me know!

Special thanks to:
Jaizu for all the feedback

Credits:
TheXaman

Jaizu · Jul 8, 2021

ghoulslash said:
[Pokeemerald] Plural giveitem

Currently the game only properly converts giveitem to a plural string if you are receiving a berry or a poke ball. So I fixed it for all items.

Here is the repo to pull from. Alternatively, follow the wiki guide

How to pull from the repo:

Spoiler:

git remote add ghoul https://github.com/ghoulslash/pokeemerald

git pull ghoul plural-giveitem

Updated the wiki article to give support to found items.

KrustyKong · Jul 9, 2021

Buffel Saft said:
Remove the need to water berries on rainy Routes (Emerald)

Ever watered berry trees in the thunderstorm on Route 119 and thought "this makes no sense"?

This little tweak will make any berry trees on specified routes give out their maximum number of berries all the time, as if the weather watered them for you!

Go to src\berry.c and find the function named CalcBerryYieldInternal.
Add this code below the existing variable declarations:

Code:

u16 currentMap = ((gSaveBlock1Ptr->location.mapGroup) << 8 | gSaveBlock1Ptr->location.mapNum); if (currentMap == MAP_ROUTE119 || currentMap == MAP_ROUTE120 || currentMap == MAP_ROUTE123) return max;

The maps used here are just examples, so you can change them to whatever you want. Also, this won't affect trees that have already grown - you'll need to plant new ones to see the effect.

also have to have "#include "constants/map_groups.h" at the top of src\berry.c, or else it gives an error about the maps being undeclared in that function.

Simple Modifications Directory

More options

Meister_anon~Master_o f_None

surskitty

Lunos

Random Uruguayan User

surskitty

Lunos

Random Uruguayan User

Robinlukke

...

Meister_anon~Master_o f_None

takyon

Villain

Move Item [EM]

Adding the strings

Adding the code

Updating relevant data

Lunos

Random Uruguayan User

ghoulslash

ghoulslash

Lunos

Random Uruguayan User

TheXaman

Meister_anon~Master_o f_None

Jaizu

Average rom hacker

Syreldar

TheXaman

TheXaman

Jaizu

Average rom hacker

KrustyKong