The PokéCommunity Forums Fan Games ROM Hacking Tools, Tutorials & Resources
Resource [EM] Battle Engine Upgrade (On Halt, Will undergo reboot!)

Tools, Tutorials & Resources Various tools to help you develop your hacks can be found here.

Reply
 
Thread Tools
  #101    
Old August 14th, 2016 (12:49 AM).
Chacha Dinosaur's Avatar
Chacha Dinosaur Chacha Dinosaur is offline
Adamant and adaptive dinosaur.
     
    Join Date: Jul 2013
    Age: 24
    Gender: Male
    Posts: 453
    Quote:
    Originally Posted by jeauhervil View Post
    If I install this to a unmodified Rombase, there wouldnt be any problem right? i mean installing this to the 1.0 emerald rom...
    Nope. No problem at all.

    Quote:
    Originally Posted by i0Bjhansen0 View Post
    Hey KDS, Lava Plume is missing it's description bytes so it and every move after it uses the move description that comes after it. Also, PGE keeps throwing out errors when certain moves from gen 4-6 are selected. DizzyEgg told me to ask you about it.
    Thanks for taking time to spot these! The contest data was misaligned a bit. So the errors were coming from the contest tab. It is fixed now except for Grass Knot and Bestow.
    Though you can still alter their move data but not the contest data.
    Also added the Lava Plume description.

    Quote:
    Originally Posted by odoodo View Post
    i dont know what i'm doing wrong but i tried to do mega-evolution in a vanilla rom and set the keystone to be potion(0x0D),blue shard as the mega stone and set 1/2 to 139 and extra to kyogre(404), and set mega for mudkip to kyogre and revert kyogre to mudkip, but nothing seems to be happening in battle when i let mudkip hold the blue shard and press the start button . i even made potion a key item but it still doesnt work.
    I forget to mention this thing. The pokemon index in the extra field should be hex (i.e 00000194 in your case)

    Quote:
    Originally Posted by Hiraethe View Post
    Just an appreciation post.
    Thank you.

    I'll help this project tangentially by starting to contribute to the emerald Sprite base with MrDs and I will try to do some animations if I have time.

    Thank you
    Thanks! If you want to contribute to animations, try to get in touch with MrDS before attempting an animation. Otherwise what will happen that both of you and MrDS might start working on an animation for the same move individually, which will waste effort and time.


    Also, I've got the Mega Trigger to light up on pressing the Start button, thanks to Touched's code. Download the latest build to see the effect.
    Reply With Quote
      #102    
    Old August 14th, 2016 (1:09 AM).
    MrDollSteak's Avatar
    MrDollSteak MrDollSteak is online now
    Formerly known as 11bayerf1
       
      Join Date: Dec 2008
      Location: Hong Kong
      Age: 23
      Gender: Male
      Posts: 842
      Quote:
      Originally Posted by Hiraethe View Post
      Just an appreciation post.
      Thank you.

      I'll help this project tangentially by starting to contribute to the emerald Sprite base with Mr Ds and I will try to do some animations if I have time.

      Thank you
      I'm not sure what you mean by Emerald sprite base.
      If you want to do move animations, contact me saying which ones you want to do. I would say not to bother with Gen 4, because I'll finish it soon. So probably focus on Gens 5 and 6.
      __________________
      Reply With Quote
        #103    
      Old August 14th, 2016 (1:13 AM).
      MrDollSteak's Avatar
      MrDollSteak MrDollSteak is online now
      Formerly known as 11bayerf1
         
        Join Date: Dec 2008
        Location: Hong Kong
        Age: 23
        Gender: Male
        Posts: 842
        Quote:
        Originally Posted by SBird View Post
        Edit: Another thing I don't quite get is why you need a hook for the animation of power trick etc. Is there anything special I don't get about those types of moves, sure you need to hardcoded the effect but the animation?
        I believe its for Power Swap, Guard Swap and Skill Swap. Basically certain move animations have branches to ASM code that loads their palettes instead of just buffering them correctly in the move animation format. So what I've done is just add a custom branch to the ASM routine called by Skill Swap so that I can load the modified palettes for Power Swap and Guard Swap.

        I'll be doing the same thing for Sludge Wave as well.
        __________________
        Reply With Quote
          #104    
        Old August 14th, 2016 (1:47 AM).
        odoodo odoodo is offline
        School Kid
           
          Join Date: Sep 2010
          Age: 24
          Posts: 32
          Quote:
          Originally Posted by KDS View Post
          I forget to mention this thing. The pokemon index in the extra field should be hex (i.e 00000194 in your case)
          still doesnt work for me :(
          Reply With Quote
            #105    
          Old August 14th, 2016 (2:15 AM).
          Chacha Dinosaur's Avatar
          Chacha Dinosaur Chacha Dinosaur is offline
          Adamant and adaptive dinosaur.
             
            Join Date: Jul 2013
            Age: 24
            Gender: Male
            Posts: 453
            Quote:
            Originally Posted by odoodo View Post
            still doesnt work for me :(
            Then try disabling the key stone by changing line 65 of mega_activation.c in the src folder to:
            return (res && check_megastone(bank));

            Hence, removing the keystone check.
            Reply With Quote
              #106    
            Old August 14th, 2016 (2:32 AM).
            xerveltal's Avatar
            xerveltal xerveltal is offline
               
              Join Date: Mar 2014
              Gender: Male
              Posts: 45
              Mega Evolution worked for me Perfectly, I'd like to ask if Primal Reversion Is implemented here?
              Reply With Quote
                #107    
              Old August 14th, 2016 (2:43 AM).
              Chacha Dinosaur's Avatar
              Chacha Dinosaur Chacha Dinosaur is offline
              Adamant and adaptive dinosaur.
                 
                Join Date: Jul 2013
                Age: 24
                Gender: Male
                Posts: 453
                Quote:
                Originally Posted by xerveltal View Post
                Mega Evolution worked for me Perfectly, I'd like to ask if Primal Reversion Is implemented here?
                Not now, but will be added soon.
                Reply With Quote
                  #108    
                Old August 14th, 2016 (6:06 AM).
                odoodo odoodo is offline
                School Kid
                   
                  Join Date: Sep 2010
                  Age: 24
                  Posts: 32
                  ok.. it works now. but only up until the mega species is celebi, the ? pokes seems to mess up the index in g3t thats why i cant mega evolve to kyogre earlier.
                  Reply With Quote
                    #109    
                  Old August 14th, 2016 (8:28 AM). Edited August 14th, 2016 by Chacha Dinosaur.
                  Chacha Dinosaur's Avatar
                  Chacha Dinosaur Chacha Dinosaur is offline
                  Adamant and adaptive dinosaur.
                     
                    Join Date: Jul 2013
                    Age: 24
                    Gender: Male
                    Posts: 453
                    Quote:
                    Originally Posted by odoodo View Post
                    ok.. it works now. but only up until the mega species is celebi, the ? pokes seems to mess up the index in g3t thats why i cant mega evolve to kyogre earlier.
                    Thanks for spotting this. G3T works fine. There was some problem in the code that mega evolution can only happen if the mega species has an index less than 256 (a byte). Now it is resolved. Redownload.
                    Reply With Quote
                      #110    
                    Old August 14th, 2016 (4:34 PM). Edited August 14th, 2016 by Hiraethe.
                    Hiraethe's Avatar
                    Hiraethe Hiraethe is offline
                       
                      Join Date: Oct 2015
                      Location: Berkeley, California
                      Gender: Male
                      Nature: Bold
                      Posts: 36
                      Looking at the damagecalc.c, wouldnt it make sense to check for supereffective reducing berries right before critical hits? Maybe like:

                      case ITEM_EFFECT_ROSELI_BERRY:
                      if (move_type == TYPE_FAIRY && (battle_participants[def_bank].item_id == item_roseli_berry))
                      {
                      modifier = chain_modifier(modifier, quality_atk_modifier);
                      }
                      break;

                      Where the attack modifier decreases the modifier by 1/2?
                      Forgive me if I don't understand, this is my first comb through of the code.
                      Reply With Quote
                        #111    
                      Old August 14th, 2016 (10:29 PM).
                      Chacha Dinosaur's Avatar
                      Chacha Dinosaur Chacha Dinosaur is offline
                      Adamant and adaptive dinosaur.
                         
                        Join Date: Jul 2013
                        Age: 24
                        Gender: Male
                        Posts: 453
                        Quote:
                        Originally Posted by Hiraethe View Post
                        Looking at the damagecalc.c, wouldnt it make sense to check for supereffective reducing berries right before critical hits? Maybe like:

                        case ITEM_EFFECT_ROSELI_BERRY:
                        if (move_type == TYPE_FAIRY && (battle_participants[def_bank].item_id == item_roseli_berry))
                        {
                        modifier = chain_modifier(modifier, quality_atk_modifier);
                        }
                        break;

                        Where the attack modifier decreases the modifier by 1/2?
                        Forgive me if I don't understand, this is my first comb through of the code.
                        It is not implemented yet. It will go after the life orb modifier. Acc, to this link which we are following:
                        http://www.smogon.com/bw/articles/bw_complete_damage_formula
                        Reply With Quote
                          #112    
                        Old August 14th, 2016 (10:47 PM).
                        Hiraethe's Avatar
                        Hiraethe Hiraethe is offline
                           
                          Join Date: Oct 2015
                          Location: Berkeley, California
                          Gender: Male
                          Nature: Bold
                          Posts: 36
                          So how would I contribute to the codebase? Because I do know C, albeit very little assembly
                          Reply With Quote
                            #113    
                          Old August 14th, 2016 (11:45 PM).
                          Chacha Dinosaur's Avatar
                          Chacha Dinosaur Chacha Dinosaur is offline
                          Adamant and adaptive dinosaur.
                             
                            Join Date: Jul 2013
                            Age: 24
                            Gender: Male
                            Posts: 453
                            Quote:
                            Originally Posted by Hiraethe View Post
                            So how would I contribute to the codebase? Because I do know C, albeit very little assembly
                            Contact me or Dizzy via PM.
                            Reply With Quote
                              #114    
                            Old August 15th, 2016 (5:47 AM). Edited August 15th, 2016 by odoodo.
                            odoodo odoodo is offline
                            School Kid
                               
                              Join Date: Sep 2010
                              Age: 24
                              Posts: 32
                              so i tried mega evolution in link battle and it seems to only work in the server side, the client doesnt even see the poke mega evolve. also, explosion seems to prevent the opp from moving when i switch to another poke when im faster. odd

                              edit: tried it in a vanilla rom, it does prevent the opp from moving. but not in oras, the opp would miss atk or hav free setup, might be a glitch in gen3 games
                              Reply With Quote
                                #115    
                              Old August 15th, 2016 (7:02 AM).
                              LCCoolJ95's Avatar
                              LCCoolJ95 LCCoolJ95 is offline
                              Limited Capacity
                                 
                                Join Date: May 2009
                                Location: The World That Never Was
                                Age: 23
                                Gender: Male
                                Nature: Naive
                                Posts: 574
                                Decided to download this, and it looks pretty cool. But I'm just wondering about how to edit the movesets of Pokémon. I wanted to edit some of them, but this happened (I'm using the latest version of Pokémon Game Editor):
                                Spoiler:


                                Is there any way I can go about fixing this?
                                __________________
                                "The greatest obstacle in life is Yourself. Overcome it, and you will achieve the greatest accomplishment of all." -Art Beins, 1982

                                Pokémon Theta Emerald EX: https://www.pokecommunity.com/showthread.php?t=386240
                                Reply With Quote
                                  #116    
                                Old August 15th, 2016 (8:19 AM).
                                Megax Rocker's Avatar
                                Megax Rocker Megax Rocker is offline
                                   
                                  Join Date: Jan 2016
                                  Posts: 125
                                  Quote:
                                  Originally Posted by LCCoolJ95 View Post
                                  Decided to download this, and it looks pretty cool. But I'm just wondering about how to edit the movesets of Pokémon. I wanted to edit some of them, but this happened (I'm using the latest version of Pokémon Game Editor):
                                  Spoiler:


                                  Is there any way I can go about fixing this?
                                  How about you try using G3T, I always use it when PGE doesn't.
                                  Reply With Quote
                                    #117    
                                  Old August 15th, 2016 (10:02 AM).
                                  Chacha Dinosaur's Avatar
                                  Chacha Dinosaur Chacha Dinosaur is offline
                                  Adamant and adaptive dinosaur.
                                     
                                    Join Date: Jul 2013
                                    Age: 24
                                    Gender: Male
                                    Posts: 453
                                    Quote:
                                    Originally Posted by odoodo View Post
                                    so i tried mega evolution in link battle and it seems to only work in the server side, the client doesnt even see the poke mega evolve. also, explosion seems to prevent the opp from moving when i switch to another poke when im faster. odd

                                    edit: tried it in a vanilla rom, it does prevent the opp from moving. but not in oras, the opp would miss atk or hav free setup, might be a glitch in gen3 games
                                    Currently, the Mega Evolution does not work for link battles properly.
                                    Is the explosion bug present in link battles or normal battle too?

                                    Quote:
                                    Originally Posted by LCCoolJ95 View Post
                                    Decided to download this, and it looks pretty cool. But I'm just wondering about how to edit the movesets of Pokémon. I wanted to edit some of them, but this happened (I'm using the latest version of Pokémon Game Editor):
                                    [spoiler]
                                    Is there any way I can go about fixing this?
                                    Quote:
                                    Originally Posted by Megax Rocker View Post
                                    How about you try using G3T, I always use it when PGE doesn't.
                                    http://www.pokecommunity.com/showpost.php?p=9345450&postcount=35

                                    --------------------------------------------------------------------------
                                    Okay, so fixed some graphical issues and one button issue. Re-download.
                                    Reply With Quote
                                      #118    
                                    Old August 15th, 2016 (10:24 AM).
                                    sonicfan7895's Avatar
                                    sonicfan7895 sonicfan7895 is offline
                                    Lead Programmer and Composer
                                       
                                      Join Date: Dec 2010
                                      Location: Akala Island, Alola
                                      Age: 21
                                      Gender: Male
                                      Nature: Serious
                                      Posts: 96
                                      I'm loving the changes to the engine! It's truly what I feel has been missing in Emerald for a very long time.

                                      I have a couple of n00b questions, though I think they are legitimate:

                                      1) Will this work with any rombase that has expanded mons and Dexes? I feel like this would be amazing and give more of a "feel" as though I were playing a "Delta Emerald" of sorts, and

                                      2) Will this (and any extended mon/dex rombase combined) work with the Universal Pokemon Randomizer? I am genuinely curious; I feel it wouldn't work because it would mean editing the program in itself, but could it potentially work? Plus, it would be interesting to see what moves come about in a Randomizer Locke challenge, considering all the new options available in the latest version.
                                      __________________
                                      Check out my band: Sliver!
                                      On Facebook
                                      Reply With Quote
                                        #119    
                                      Old August 15th, 2016 (12:19 PM).
                                      DizzyEgg's Avatar
                                      DizzyEgg DizzyEgg is offline
                                         
                                        Join Date: Feb 2014
                                        Location: Poland
                                        Age: 21
                                        Gender: Male
                                        Nature: Quiet
                                        Posts: 748
                                        Quote:
                                        Originally Posted by sonicfan7895 View Post
                                        I'm loving the changes to the engine! It's truly what I feel has been missing in Emerald for a very long time.
                                        Glad you liked it. :)

                                        Quote:
                                        Originally Posted by sonicfan7895 View Post
                                        1) Will this work with any rombase that has expanded mons and Dexes? I feel like this would be amazing and give more of a "feel" as though I were playing a "Delta Emerald" of sorts, and
                                        Yes, it will. The only thing that you have to do is to change pointers in the bpee or defines file. Not sure which one it is, because KDS has recently changed it. :P
                                        Gonna update the OP to make it clear.

                                        Quote:
                                        Originally Posted by sonicfan7895 View Post
                                        2) Will this (and any extended mon/dex rombase combined) work with the Universal Pokemon Randomizer? I am genuinely curious; I feel it wouldn't work because it would mean editing the program in itself, but could it potentially work? Plus, it would be interesting to see what moves come about in a Randomizer Locke challenge, considering all the new options available in the latest version.
                                        I'm not exactly sure how the tool works, but my guess is, it could work to an extent, basically randomizing only abilities and moves from gen3 and not higher. If it's possible, I would contact the creator and ask him if he could implement a feature to allow randomization of expanded roms.

                                        Also, I love all Locke challenges, so if you ever make a run using this Engine, let me know how it goes haha
                                        Reply With Quote
                                          #120    
                                        Old August 15th, 2016 (12:45 PM). Edited August 15th, 2016 by sonicfan7895.
                                        sonicfan7895's Avatar
                                        sonicfan7895 sonicfan7895 is offline
                                        Lead Programmer and Composer
                                           
                                          Join Date: Dec 2010
                                          Location: Akala Island, Alola
                                          Age: 21
                                          Gender: Male
                                          Nature: Serious
                                          Posts: 96
                                          Quote:
                                          Originally Posted by DizzyEgg View Post
                                          The only thing that you have to do is to change pointers in the bpee or defines file. Not sure which one it is, because KDS has recently changed it. :P
                                          Gonna update the OP to make it clear.

                                          I'm not exactly sure how the tool works, but my guess is, it could work to an extent, basically randomizing only abilities and moves from gen3 and not higher. If it's possible, I would contact the creator and ask him if he could implement a feature to allow randomization of expanded roms.

                                          Also, I love all Locke challenges, so if you ever make a run using this Engine, let me know how it goes haha
                                          Ahh. I'll make a copy of test.gba and see if I can get that to work.

                                          I just sent the creator of UPR a message from his website, so hopefully I'll get a reply soon.

                                          You actually just gave me the idea to do a run like this. Challenge accepted, my friend!

                                          I think I shall coin the term "Expandlocke". :P

                                          EDIT: I think I may want to wait until the creator of UPR decides if he wants to implement ROM base options or expanded ROM options before I do this run. I kinda wanted to see how moves outside of Gen 3 would do in this type of run. However, if you're not worried about that, I can still go ahead with the run, if you want. :)
                                          __________________
                                          Check out my band: Sliver!
                                          On Facebook
                                          Reply With Quote
                                            #121    
                                          Old August 15th, 2016 (3:29 PM). Edited August 15th, 2016 by odoodo.
                                          odoodo odoodo is offline
                                          School Kid
                                             
                                            Join Date: Sep 2010
                                            Age: 24
                                            Posts: 32
                                            Quote:
                                            Originally Posted by KDS View Post
                                            Is the explosion bug present in link battles or normal battle too?
                                            its in both, and not just explosion. self-destruct and memento as well. might be because gen3 games resets turn when opp faints. i think what you can do here is if the poke faints before opp makes a move(might die due to confusion as well), then make them like fly/dig/dive(edit: semi-invulnerable) after they die where they cant be targeted and switch after the opp move?

                                            edit 2: so it does it with recoils as well, might just be how gen3 games are programmed but not really that big of a deal as most players would hardly notice it. i think
                                            Reply With Quote
                                              #122    
                                            Old August 16th, 2016 (1:14 AM).
                                            DizzyEgg's Avatar
                                            DizzyEgg DizzyEgg is offline
                                               
                                              Join Date: Feb 2014
                                              Location: Poland
                                              Age: 21
                                              Gender: Male
                                              Nature: Quiet
                                              Posts: 748
                                              Quote:
                                              Originally Posted by odoodo View Post
                                              its in both, and not just explosion. self-destruct and memento as well. might be because gen3 games resets turn when opp faints. i think what you can do here is if the poke faints before opp makes a move(might die due to confusion as well), then make them like fly/dig/dive(edit: semi-invulnerable) after they die where they cant be targeted and switch after the opp move?

                                              edit 2: so it does it with recoils as well, might just be how gen3 games are programmed but not really that big of a deal as most players would hardly notice it. i think
                                              This is something I noticed a while ago while making Lunar Dance. The problem is a bit more complicated due to how GF programmed the whole battle system. Fixing that would require changing a lot of stuff. We may do it, but it's very low priority for now.
                                              Reply With Quote
                                                #123    
                                              Old August 16th, 2016 (2:05 AM).
                                              Chacha Dinosaur's Avatar
                                              Chacha Dinosaur Chacha Dinosaur is offline
                                              Adamant and adaptive dinosaur.
                                                 
                                                Join Date: Jul 2013
                                                Age: 24
                                                Gender: Male
                                                Posts: 453
                                                Quote:
                                                Originally Posted by sonicfan7895 View Post
                                                I'm loving the changes to the engine! It's truly what I feel has been missing in Emerald for a very long time.

                                                I have a couple of n00b questions, though I think they are legitimate:

                                                1) Will this work with any rombase that has expanded mons and Dexes? I feel like this would be amazing and give more of a "feel" as though I were playing a "Delta Emerald" of sorts, and
                                                Quote:
                                                Originally Posted by DizzyEgg View Post
                                                Glad you liked it. :)

                                                Yes, it will. The only thing that you have to do is to change pointers in the bpee or defines file. Not sure which one it is, because KDS has recently changed it. :P
                                                Gonna update the OP to make it clear.
                                                I actually made the engine (mainly the mega evolution) compatible with dex and item expansion such that you do not need to manually mention the offsets for evolution data, basestats data, and the item table. You'll only need to change the no of evolutions per pokemon in the battle_structs.h if you have increased the no. of evolutions per pokemon.
                                                Reply With Quote
                                                  #124    
                                                Old August 16th, 2016 (4:26 AM).
                                                sonicfan7895's Avatar
                                                sonicfan7895 sonicfan7895 is offline
                                                Lead Programmer and Composer
                                                   
                                                  Join Date: Dec 2010
                                                  Location: Akala Island, Alola
                                                  Age: 21
                                                  Gender: Male
                                                  Nature: Serious
                                                  Posts: 96
                                                  Quote:
                                                  Originally Posted by KDS View Post
                                                  I actually made the engine (mainly the mega evolution) compatible with dex and item expansion such that you do not need to manually mention the offsets for evolution data, basestats data, and the item table. You'll only need to change the no of evolutions per pokemon in the battle_structs.h if you have increased the no. of evolutions per pokemon.
                                                  I assume this is to be set to a maximum of 8 (as per Eevee and the Eeveelutions (including Sylveon))?

                                                  Plus, I think I will re-do my "Expand-locke" in the future with all Pokemon in the dex. Right now I've got two more episodes recorded w/o, so I think it's best to stick with this current run and then do another one in the future. Should be fun!
                                                  __________________
                                                  Check out my band: Sliver!
                                                  On Facebook
                                                  Reply With Quote
                                                    #125    
                                                  Old August 16th, 2016 (5:04 AM).
                                                  Chacha Dinosaur's Avatar
                                                  Chacha Dinosaur Chacha Dinosaur is offline
                                                  Adamant and adaptive dinosaur.
                                                     
                                                    Join Date: Jul 2013
                                                    Age: 24
                                                    Gender: Male
                                                    Posts: 453
                                                    Quote:
                                                    Originally Posted by sonicfan7895 View Post
                                                    I assume this is to be set to a maximum of 8 (as per Eevee and the Eeveelutions (including Sylveon))?

                                                    Plus, I think I will re-do my "Expand-locke" in the future with all Pokemon in the dex. Right now I've got two more episodes recorded w/o, so I think it's best to stick with this current run and then do another one in the future. Should be fun!
                                                    Yes. That depends on that you followed karatekid's evolution expansion tutorual or not.
                                                    Reply With Quote
                                                    Reply

                                                    Quick Reply

                                                    Join the conversation!

                                                    Create an account to post a reply in this thread, participate in other discussions, and more!

                                                    Create a PokéCommunity Account
                                                    Thread Tools

                                                    Posting Rules
                                                    You may not post new threads
                                                    You may not post replies
                                                    You may not post attachments
                                                    You may not edit your posts

                                                    BB code is On
                                                    Smilies are On
                                                    [IMG] code is On
                                                    HTML code is Off

                                                    Forum Jump


                                                    All times are GMT -8. The time now is 4:47 AM.