[PBS] Gen 7 PBS, Scripts, Graphics and more

Pokemon Gen 7 script error...plz help

Some are the custom script, which is not gen 7 (they are my custom script...)
but when I starts the game, the game stops with the unknown error.

If you help me fixing the bug, then I will show you in my pokemon game, "Pokemon Procyon and Deneb" in the ending credit.
(My blog is blog.naver.com/jooys2001 there will be pokemon procyon and deneb. (You have to translate the language.))

post your error ..

Jooys2001 said:

Some are the custom script, which is not gen 7 (they are my custom script...)
but when I starts the game, the game stops with the unknown error.

If you help me fixing the bug, then I will show you in my pokemon game, "Pokemon Procyon and Deneb" in the ending credit.
(My blog is blog.naver.com/jooys2001 there will be pokemon procyon and deneb. (You have to translate the language.))

Click to expand...

First of all, I haven't used any scripts from people I haven't credited. Therefore, your name is not in the credits. This sounds rude, but I've never even seen your name before.

As for you error, I'm not going to spit through your scripts to find the issue in probably near 15.000 lines if I don't know where the error is supposed to be. I need to see what error comes up, but it's probably a syntax error somewhere (which would lead me to believe you pasted something in improperly, or that there's a bug in my pack, but I doubt that, since all worked good for me).

As for the crediting, by adding the people in who worked on this pack/gen 7 scripts on their own I used (because I did), you deserving respect towards those people. Some of the scripts are originally from other people, like Rot8er_CoNeX. They had released working gen 7 scripts for either abilities or moves, so instead of coding those myself and end up having it look nearly the same but possibly with errors, I may as well use them and give them credit. I expect you to do the same. I haven't explicitly said you have to credit, but not crediting anyone is plain rude. I'm also not sure about people who made stuff I included require credits or just appreciate them, so I recommend not taking the risk. As for crediting me, I put stuff together, created the PBS, creating missing abilities and items, so the same would go for me. I'm not above others, but I'm also not below others.

M3rein said:

First of all, I haven't used any scripts from people I haven't credited. Therefore, your name is not in the credits. This sounds rude, but I've never even seen your name before.

Click to expand...

Originally his post was an own thread, so someone merged both threads together. I think he is not referring to your scripts, but rather to his own changes.

Obito Uchiha said:

Originally his post was an own thread, so someone merged both threads together. I think he is not referring to your scripts, but rather to his own changes.

Click to expand...

If that is indeed the case, whoever I may have (according to him) got it from, did not feel the need to credit. (Again, this sounds rude, but) recreating working code is pointless since you get the same result, because you know how you can do it. Then trying to recode that usually ends up very similar, from my experience at least.

I haven't read through all of the thread, only the first post, so I apologize if this was already brought up, but I think it would be helpful if you mentioned which specific moves, abilities, items, etc. are in the download.

TISSUEPAPERGHOST said:

I haven't read through all of the thread, only the first post, so I apologize if this was already brought up, but I think it would be helpful if you mentioned which specific moves, abilities, items, etc. are in the download.

Click to expand...

I might make a quick pastebin with stuff done and stuff to do. I don't think I'll be doing any more moves or abilities, because I'm not feeling like it. Others can use that as a reference, if they'd like. I'll see if I can edit the main post later today.

About Water Bubble, is the double Water-type move power in the script ?

I dont know much about scripting, but it seems to only currently contain the burn prevention and the reduced Fire damage.

Hi, I liked your project more in my game. This error is appearing.

Exception: RuntimeError
Message: Invalid quoted field (in: 1,0,0,
)
File PBS/items.txt, line 638
1,0,0,


Compiler:369:in `csvfield!'
Compiler:517:in `pbGetCsvRecord'
Compiler:490:in `each'
Compiler:490:in `pbGetCsvRecord'
Compiler:1612:in `pbCompileItems'
Compiler:1611:in `pbCompilerEachCommentedLine'
Compiler:271:in `each_line'
Compiler:271:in `pbCompilerEachCommentedLine'
Compiler:268:in `open'
Compiler:268:in `pbCompilerEachCommentedLine'

Please help me

Alex362 said:

Hi, I liked your project more in my game. This error is appearing.

Exception: RuntimeError
Message: Invalid quoted field (in: 1,0,0,
)
File PBS/items.txt, line 638
1,0,0,


Compiler:369:in `csvfield!'
Compiler:517:in `pbGetCsvRecord'
Compiler:490:in `each'
Compiler:490:in `pbGetCsvRecord'
Compiler:1612:in `pbCompileItems'
Compiler:1611:in `pbCompilerEachCommentedLine'
Compiler:271:in `each_line'
Compiler:271:in `pbCompilerEachCommentedLine'
Compiler:268:in `open'
Compiler:268:in `pbCompilerEachCommentedLine'

Please help me

Click to expand...

If that's this line:

645,DECIDIUMZ,Decidium Z,Decidium Z,1,0,"It converts Z-Power into crystals that upgrade Decidueye's Spirit Shackle to an exclusive Z-Move."1,0,0,

...Then add another comma between the zero and the last quote. My bad.

M3rein said:

If that's this line:

645,DECIDIUMZ,Decidium Z,Decidium Z,1,0,"It converts Z-Power into crystals that upgrade Decidueye's Spirit Shackle to an exclusive Z-Move."1,0,0,

...Then add another comma between the zero and the last quote. My bad.

Click to expand...

Thanks but no and this line, and line 638 but thanks for the help.

Alex362 said:

Thanks but no and this line, and line 638 but thanks for the help.

Click to expand...

Could you then be as smart as to link me that line? It's probably the same error, just before or after.

Now a new error has appeared ;-;

Exception: RuntimeError
Message: Invalid quoted field (in: 1,0,0,
)
File PBS/items.txt, line 645
1,0,0,


Compiler:369:in `csvfield!'
Compiler:517:in `pbGetCsvRecord'
Compiler:490:in `each'
Compiler:490:in `pbGetCsvRecord'
Compiler:1612:in `pbCompileItems'
Compiler:1611:in `pbCompilerEachCommentedLine'
Compiler:271:in `each_line'
Compiler:271:in `pbCompilerEachCommentedLine'
Compiler:268:in `open'
Compiler:268:in `pbCompilerEachCommentedLine'

Alex362 said:

Now a new error has appeared ;-;

Exception: RuntimeError
Message: Invalid quoted field (in: 1,0,0,
)
File PBS/items.txt, line 645
1,0,0,


Compiler:369:in `csvfield!'
Compiler:517:in `pbGetCsvRecord'
Compiler:490:in `each'
Compiler:490:in `pbGetCsvRecord'
Compiler:1612:in `pbCompileItems'
Compiler:1611:in `pbCompilerEachCommentedLine'
Compiler:271:in `each_line'
Compiler:271:in `pbCompilerEachCommentedLine'
Compiler:268:in `open'
Compiler:268:in `pbCompilerEachCommentedLine'

Click to expand...

I see you've completely disregarded my last post. I asked for the line in the PBS file "items.txt". It's likely the same issue, having put "1,0,0, If I did, then that's my bad but I typically assume you guys are smart enough to read error messages and fix stuff like this.

M3rein said:

I see you've completely disregarded my last post. I asked for the line in the PBS file "items.txt". It's likely the same issue, having put "1,0,0, If I did, then that's my bad but I typically assume you guys are smart enough to read error messages and fix stuff like this.

Click to expand...

But i did what you said

Whilst updating my game to include moves/abilities form your pack this error happens:

Script 'PokeBattle_Move' line 1344: SyntaxError occurred.

This is how it looks in Essentials:
1341:def pbMoveFailed(attacker,opponent)
1342: # Called to determine whether the move failed
1343: return false
1344: end

I had another end there at line 1345 that also causes the error, but for line 1345. What am I doing wrong?

Not using vanilla essentials obviously, no mods to these scripts bar your pack

That's a great pack, thanks for sharing it with the community, I hope you update it soon, but when you do that, please upload to another server, I suffer to download on that dumb Dropbox. ;-;

Azurestonedog said:

Whilst updating my game to include moves/abilities form your pack this error happens:

Script 'PokeBattle_Move' line 1344: SyntaxError occurred.

This is how it looks in Essentials:
1341:def pbMoveFailed(attacker,opponent)
1342: # Called to determine whether the move failed
1343: return false
1344: end

I had another end there at line 1345 that also causes the error, but for line 1345. What am I doing wrong?

Not using vanilla essentials obviously, no mods to these scripts bar your pack

Click to expand...

Can you post a few lines above and under? Put [ CODE ] before it and [ /CODE ] after it, without spaces. And this happened during startup, yes?

yes, occurs during startup, the final end is the end of the code section completely. Lines 1318 - 1345, copied the section from vanilla essentials into my project to see if that fixed the error and it doesn't, so that is why the end has reappeared at line 1345

Azurestonedog said:

yes, occurs during startup, the final end is the end of the code section completely. Lines 1318 - 1345, copied the section from vanilla essentials into my project to see if that fixed the error and it doesn't, so that is why the end has reappeared at line 1345

Code:

  def pbOnDamageLost(damage,attacker,opponent)
    # Used by Counter/Mirror Coat/Revenge/Focus Punch/Bide
    type=@type
    type=pbType(type,attacker,opponent)
    if opponent.effects[PBEffects::Bide]>0
      opponent.effects[PBEffects::BideDamage]+=damage
      opponent.effects[PBEffects::BideTarget]=attacker.index
    end
    if @function==0x90 # Hidden Power
      type=getConst(PBTypes,:NORMAL) || 0
    end
    if pbIsPhysical?(type)
      opponent.effects[PBEffects::Counter]=damage
      opponent.effects[PBEffects::CounterTarget]=attacker.index
    elsif pbIsSpecial?(type)
      opponent.effects[PBEffects::MirrorCoat]=damage
      opponent.effects[PBEffects::MirrorCoatTarget]=attacker.index
    end
    opponent.lastHPLost=damage # for Revenge/Focus Punch/Metal Burst
    opponent.tookDamage=true if damage>0 # for Assurance
    opponent.lastAttacker.push(attacker.index) # for Revenge/Metal Burst
  end

  def pbMoveFailed(attacker,opponent)
    # Called to determine whether the move failed
    return false
  end
end

Click to expand...

The issue isn't in this piece of code. My guess would be that you pasted something in improperly or that I made a mistake somewhere, which I don't think since I don't think anyone else has gotten this issue yet. Your best bet is probably to look at the lines you added new and see if every "if" and "def" gets "ended" properly.