Patch MrDollSteak's Decap. and Attack Rombase Page 14

Started by MrDollSteak September 2nd, 2013 7:51 AM
  • 361827 views
  • 929 replies

MrDollSteak

Formerly known as 11bayerf1

Age 28
Male
Hong Kong
Seen March 16th, 2023
Posted September 26th, 2022
859 posts
14.4 Years
Now would be a great time to cool it and not derail the thread any further.
Could we go ahead and delete all these comments?
Maybe get the thread locked too?

It's probably for the best if the thread is closed for a while.

Blah

Free supporter

Male
Unknown Island
Seen 3 Weeks Ago
Posted February 28th, 2023
1,924 posts
10.3 Years
- In Game Trades and the Day Care apparently freeze the game
Ingame trades don't freeze the game. Mine worked fine. If someone has these problems, please repatch/learn to apply patches.

I also took a look at the daycare thing. I can't say I'm impressed at how long this bug's been around for what it is (and whoever reported this didn't bother to decompile the script?). It turned out to be just that the script at the daycare guy was overwritten in places, you can just assign him a copied script from a fresh ROM...
Spoiler:

#dyn 0x740000
#org @start
'-----------------------------------
special INIT_STEPCOUNT
compare LASTRESULT 0x2
if == jump @00D0 ' Equal To
lock
faceplayer
showmoney 0x0 0x0
special2 LASTRESULT 0x178
compare LASTRESULT 0x1
if == jump @00D2 ' Equal To
msgbox @0239 ' I run the DAY-CARE s...
callstd MSG_YESNO ' Yes/No message
compare LASTRESULT YES
if == jump @011F ' Equal To
msgbox @0285 ' Come again.
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @00D0
'-----------------------------------
release
end

#org @00D2
'-----------------------------------
setvar 0x8004 0x0
special2 LASTRESULT 0x179
compare LASTRESULT 0x0
if != call @010D ' Not Equal To
compare LASTRESULT 0x0
if == call @0116 ' Equal To
special 0x177
msgbox @0291 ' You owe me [p]\v\h03...
callstd MSG_YESNO ' Yes/No message
compare LASTRESULT YES
if == jump @01B1 ' Equal To
jump @0197

#org @010D
'-----------------------------------
msgbox @02C0 ' Your \v\h02 has grow...
callstd MSG_NOCLOSE ' Non-closing message
return

#org @0116
'-----------------------------------
msgbox @032C ' You're back already?...
callstd MSG_NOCLOSE ' Non-closing message
return

#org @011F
'-----------------------------------
special2 LASTRESULT 0x84
compare LASTRESULT 0x1
if == jump @0185 ' Equal To
msgbox @0370 ' Which POK\eMON shoul...
callstd MSG_NOCLOSE ' Non-closing message
fadescreen FADEOUT_BLACK
hidemoney 0x0 0x0
special 0xBC
waitspecial
showmoney 0x0 0x0
compare 0x8004 0x6
if >= jump @0197 ' Larger Than or Equal To
special2 LASTRESULT 0x85
compare LASTRESULT 0x0
if == jump @01A4 ' Equal To
special2 0x8005 0xBA
msgbox @038E ' Fine, I'll look afte...
callstd MSG_NOCLOSE ' Non-closing message
checksound
cry 0x8005 0x0
msgbox @03B9 ' Come see me in a whi...
callstd MSG_NOCLOSE ' Non-closing message
waitcry
special 0x176
CMD_C3 0x2F
jump @0192

#org @0185
'-----------------------------------
msgbox @03D1 ' Oh? You only have on...
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @0192
'-----------------------------------
hidemoney 0x0 0x0
release
end

#org @0197
'-----------------------------------
msgbox @03F9 ' Fine.\nCome anytime ...
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @01A4
'-----------------------------------
msgbox @0416 ' If you leave me that...
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @01B1
'-----------------------------------
special2 LASTRESULT 0x83
compare LASTRESULT 0x6
if == jump @01DE ' Equal To
special2 LASTRESULT 0xC5
compare LASTRESULT 0x1
if == jump @01EB ' Equal To
msgbox @044F ' You don't have enoug...
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @01DE
'-----------------------------------
msgbox @046C ' You can't take this ...
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @01EB
'-----------------------------------
setvar 0x8004 0x0
special2 LASTRESULT 0x17A
special 0xC6
updatemoney 0x0 0x0 0x0
copyvar 0x8008 LASTRESULT
countpokemon
subtractvar LASTRESULT 0x1
storepartypokemon 0x0 0x800D
copyvar LASTRESULT 0x8008
msgbox @04AB ' Thank you!\nHere's y...
callstd MSG_NOCLOSE ' Non-closing message
textcolor GRAY
checksound
cry 0x800D 0x0
msgbox @04CB ' \v\h01 got \v\h02 ba...
callstd MSG_NOCLOSE ' Non-closing message
call @0233
waitcry
jump @0192

#org @0233
'-----------------------------------
copyvar 0x8012 0x8013
return


#org @0239
= I run the DAY-CARE service.\pWould you like me to raise one of\nyour POK\eMON?

#org @0285
= Come again.

#org @0291
= You owe me [p]\v\h03 for the return\nof this POK\eMON.

#org @02C0
= Your \v\h02 has grown a lot.\nYes, quite a lot, I'd say.\pLet me see[.]\nBy level, it's grown by \v\h03.\pAren't I great?

#org @032C
= You're back already?\pYour \v\h02 needs to spend\nsome more time with me.

#org @0370
= Which POK\eMON should I raise?

#org @038E
= Fine, I'll look after your\n\v\h02 for a while.

#org @03B9
= Come see me in a while.

#org @03D1
= Oh? You only have one POK\eMON\nwith you.

#org @03F9
= Fine.\nCome anytime you like.

#org @0416
= If you leave me that POK\eMON,\nwhat will you battle with?

#org @044F
= You don't have enough money.

#org @046C
= You can't take this POK\eMON back\nif you've got no room for it.

#org @04AB
= Thank you!\nHere's your POK\eMON.

#org @04CB
= \v\h01 got \v\h02 back\nfrom the DAY-CARE MAN.


I was expecting a more interesting problem, but this was kinda a let down :P
...

MrDollSteak

Formerly known as 11bayerf1

Age 28
Male
Hong Kong
Seen March 16th, 2023
Posted September 26th, 2022
859 posts
14.4 Years
Ingame trades don't freeze the game. Mine worked fine. If someone has these problems, please repatch/learn to apply patches.

I also took a look at the daycare thing. I can't say I'm impressed at how long this bug's been around for what it is (and whoever reported this didn't bother to decompile the script?). It turned out to be just that the script at the daycare guy was overwritten in places, you can just assign him a copied script from a fresh ROM...
Cheers FBI, and as I said in the IRC, I'd been aware of that potential fix, but was told it didn't work, for whatever reason.

This does raise a good point. I'd just like to ask people that when reporting bugs, you are absolutely sure they are problems with the rombase, and not modified hacks (ie. the in-game trade issue, which a few people reported, but FBI or I could never replicate).

Good news, this means that 1.5a will be out shortly. I'm thinking the start of the new year,
once I'm back home.
Male
Seen May 3rd, 2016
Posted January 12th, 2015
43 posts
14 Years
When I use U-turn in your rombase, it works a little different from the official games.
  • In the main games, if your party have more than one Pokemon and your leading 'mon uses U-turn to KO a foe, it will gain full Exp and won't switch.
  • Same situation but in the rombase, after KOing a foe, your leading 'mon will switch to another and the Exp is split between them.
If I use U-turn the way it is now, I'll be forced to share Exp with another Pokemon even if I don't want to, like when grinding. Out of curiosity, I tried the U-turn script (in the Move Resource thread) with a regular FR rom; it also has the same problem.

And this is a minor typo: the "t" in U-turn isn't capitalized in the main games, unlike the rombase.
Seen February 22nd, 2015
Posted January 1st, 2015
152 posts
14.7 Years
Cheers FBI, and as I said in the IRC, I'd been aware of that potential fix, but was told it didn't work, for whatever reason.

This does raise a good point. I'd just like to ask people that when reporting bugs, you are absolutely sure they are problems with the rombase, and not modified hacks (ie. the in-game trade issue, which a few people reported, but FBI or I could never replicate).

Good news, this means that 1.5a will be out shortly. I'm thinking the start of the new year,
once I'm back home.
Hey, not to be up your *** about this, but what's the status on you implementing Imposter? I'm only bothering you about this because you told DaniilS not to work on it for me because you apparently had it done. Is it going to be in this update? Or if not can you just tell me how to do it? I've been holding off progress on my hack waiting for this Ditto thing.

The ???

The one true question mark

Male
???
Seen December 10th, 2020
Posted January 14th, 2017
289 posts
10.2 Years
Hello Mr.DollSteak!
I would like to ask some questions / suggest something :
- Since you are adding lots of new moves and items, would you add 100 Tms as well?

Many regards and thanks for this :) It really helps for people who don't have knowledge of HACKING but still wants to enjoy, and I owe this to each n everyone who helped with this!
Hey there I am a budding YouTuber and make funny Pokemon Videos, check me out >>HERE<<

LCCoolJ95

Limited Capacity

Age 28
Male
The World That Never Was
Seen 13 Hours Ago
Posted March 25th, 2023
629 posts
14 Years
Good news, this means that 1.5a will be out shortly. I'm thinking the start of the new year,
once I'm back home.
So, that means the Emerald is almost done as well? Since you said you release both at the same time.
"The greatest obstacle in life is Yourself. Overcome it, and you will achieve the greatest accomplishment of all." -Art Beins, 1982

Pokémon Theta Emerald EX: https://www.pokecommunity.com/showthread.php?t=386240

MrDollSteak

Formerly known as 11bayerf1

Age 28
Male
Hong Kong
Seen March 16th, 2023
Posted September 26th, 2022
859 posts
14.4 Years
When I use U-turn in your rombase, it works a little different from the official games.
  • In the main games, if your party have more than one Pokemon and your leading 'mon uses U-turn to KO a foe, it will gain full Exp and won't switch.
  • Same situation but in the rombase, after KOing a foe, your leading 'mon will switch to another and the Exp is split between them.
If I use U-turn the way it is now, I'll be forced to share Exp with another Pokemon even if I don't want to, like when grinding. Out of curiosity, I tried the U-turn script (in the Move Resource thread) with a regular FR rom; it also has the same problem.

And this is a minor typo: the "t" in U-turn isn't capitalized in the main games, unlike the rombase.
Thanks for the typo thing!
As for the Exp. bug, that'll be difficult to solve, because if we want it to get the exp. after switching it'll split it. If we put it before, then it could lead to other problems. I'll look into it.

Hey, not to be up your *** about this, but what's the status on you implementing Imposter? I'm only bothering you about this because you told DaniilS not to work on it for me because you apparently had it done. Is it going to be in this update? Or if not can you just tell me how to do it? I've been holding off progress on my hack waiting for this Ditto thing.
Well I haven't got it done, but it isn't hard to do. I can put that on the list for 1.5a.
Basically I can hook it into my switch-in abilities table. I don't think you'd be able to
do it (not for lack of ability) but because it has to interact with some other pre-requisites
that are in the rombase.

I wouldn't put off hacking. It'll be in the next update.

Hello Mr.DollSteak!
I would like to ask some questions / suggest something :
- Since you are adding lots of new moves and items, would you add 100 Tms as well?

Many regards and thanks for this It really helps for people who don't have knowledge of HACKING but still wants to enjoy, and I owe this to each n everyone who helped with this!
Short answer, No.

Long answer, it'll be very difficult to do because of the ram allocated to the bag.

So, that means the Emerald is almost done as well? Since you said you release both at the same time.
No. Not even close. My original plan was to do them both, but since people have been getting impatient, I'd rather release the FR one first.

Sefuree

Canada Goose

Age 22
Male
Canada
Seen February 19th, 2023
Posted July 6th, 2021
if i want to apply MrDs's Rom base (Version 1.5) and this titlescreen patch, which to i patch first?

MrDs's patch: http://www.pokecommunity.com/showthread.php?t=326301

Titlescreen Patch: http://www.pokecommunity.com/showthread.php?t=341174

Thanks!

:)
Male
India
Seen November 9th, 2016
Posted September 11th, 2016
44 posts
8.6 Years
Bug Fixes
Spoiler:
2579A6 - Replace E9 F5 with 1D F6 (Fixes Toxic Spikes)

90BBE8 - Insert the following (Fixes Aftermath)

1F B4 13 20 00 21 06 22 03 23 00 F0 27 F8 00 28 21 D1 1F BC 14 49 60 00 00 19 80 00 40 18 00 7A 01 21 08 40 00 28 17 D0 10 48 40 78 58 21 48 43 0F 49 40 18 01 8D 00 29 0E D1 0C 48 00 78 58 21 48 43 0B 49 40 18 80 8D 80 08 0A 49 08 60 00 F0 07 F8 09 49 08 47 1F BC 00 F0 04 F8 07 4C 20 47 07 48 00 47 07 4C 20 47 00 00 90 08 6B 3D 02 02 E4 3B 02 02 50 3D 02 02 E9 AA 01 08 19 9F 01 08 45 75 01 08 AB BB 01 08 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF

90C118 - Replace FE with 0D (Fixes Motor Drive)
90C4DE - Replace 3F with 03 (Fixes Choice Items)
90C504 - Replace EC with E8 (Fixes Aftermath)
90C51C - Replace 70 with 72 (Fixes Mummy)
About the bug fixes, I made all the changes mentioned above, but when I start my ROM in VBA, it doesn't work. The title screen doesn't load. From what I've found, the second bug fix, the Aftermath fix, is the problem. The ROM works fine when I change everything else, but once I insert those 136 bytes, it freezes.

Am I the only one with this problem?

BLAx501!

Pokemon Flux

Male
Madrid, Spain
Seen September 4th, 2020
Posted February 5th, 2019
80 posts
9.6 Years
About the bug fixes, I made all the changes mentioned above, but when I start my ROM in VBA, it doesn't work. The title screen doesn't load. From what I've found, the second bug fix, the Aftermath fix, is the problem. The ROM works fine when I change everything else, but once I insert those 136 bytes, it freezes.

Am I the only one with this problem?
Maybe the problem is the way you are "inserting" those bytes. The proper way is selecting all the bytes in HEX MrDollSteak gave us and then you copy the selection. After that you open your patched ROM with an Hexadecimal Editor such as HxD and you go to the ROM offset he gave us; 90BBE8. Here is the problem. If you just paste the bytes with Ctrl+V, it will expand the ROM and if it happens yhe final size is not a multiple of 4, the emulator won't be able to read the data from it. The solution?? Paste inserting by pressing Ctrl+B or by selecting an amount of bytes from the ROM of the same size you arre going to paste.

If your problem is this, don't worry because it is easy to solve ;)


if i want to apply MrDs's Rom base (Version 1.5) and this titlescreen patch, which to i patch first?

MrDs's patch: http://www.pokecommunity.com/showthread.php?t=326301

Titlescreen Patch: http://www.pokecommunity.com/showthread.php?t=341174

Thanks!
If the Titlescreen doesn't change anything on the ROM that MrDollSteak Patch does, it wouldn't mind the order, but just to make sure I'll say that I prefer to patch MrDollSteak's first because inserting a titlescreen is not that difficult after all xD

Sefuree

Canada Goose

Age 22
Male
Canada
Seen February 19th, 2023
Posted July 6th, 2021
Spoiler:
Maybe the problem is the way you are "inserting" those bytes. The proper way is selecting all the bytes in HEX MrDollSteak gave us and then you copy the selection. After that you open your patched ROM with an Hexadecimal Editor such as HxD and you go to the ROM offset he gave us; 90BBE8. Here is the problem. If you just paste the bytes with Ctrl+V, it will expand the ROM and if it happens yhe final size is not a multiple of 4, the emulator won't be able to read the data from it. The solution?? Paste inserting by pressing Ctrl+B or by selecting an amount of bytes from the ROM of the same size you arre going to paste.

If your problem is this, don't worry because it is easy to solve ;)




If the Titlescreen doesn't change anything on the ROM that MrDollSteak Patch does, it wouldn't mind the order, but just to make sure I'll say that I prefer to patch MrDollSteak's first because inserting a titlescreen is not that difficult after all xD


Well, Thanks for the help!

:)
Male
Seen May 3rd, 2022
Posted March 23rd, 2022
491 posts
12.3 Years
Have the in-game trainers whos' pokemon have custom movesets been edited to reflect the new movesets?

And related to that, which trainer editor works with this base anyway? Advance and Unnamed are both a no-go for me.
Nope!

I have an INI file for unnamed trainer editor and (an earlier version of) G3T earlier in the thread.
Age 22
Female
Seen 2 Days Ago
Posted August 22nd, 2021
105 posts
9 Years
Could you possibly put a link in the OP to both where the tables you posted for the abilities (Mega Launcher, Reckless, etc.) are located, as well as where the type chart is? As it is right now, it seems that Fairy-types are not weak to Steel (tested this myself- they're still weak to Poison and resist Bug and all that).

Also, you gave Arm Thrust 25 BP, while it should be 15, and Bullet Seed is still 10 BP, while it should be 25.

EDIT: I believe you stated somewhere where the Soundproof table was located, but I can't seem to find it.

Exodrake

The Manliest Chick that Ever Manlied

Age 29
Female
Seen November 30th, 2016
Posted July 24th, 2016
163 posts
10 Years
Found some quirks with Sticky Web.

-If White Herb negates the speed drop, the other player's turn will be skipped, giving a free turn to the sticky webbed monster.

-If Sticky Web and Stealth Rock are both up at once, Stealth Rock won't hurt Levitators or Flying-types.

I'M A WITCH THAT'S HOW

MrDollSteak

Formerly known as 11bayerf1

Age 28
Male
Hong Kong
Seen March 16th, 2023
Posted September 26th, 2022
859 posts
14.4 Years
I can't wait for the release of 1.5a!
And I'd like to ask if you'd be able to add the item "focus sash" to the patch. If not, is there a way I could do it by myself?
I've written it up, but it probably won't be in for 1.5a, because clearing the item is damned annoying.

Could you possibly put a link in the OP to both where the tables you posted for the abilities (Mega Launcher, Reckless, etc.) are located, as well as where the type chart is? As it is right now, it seems that Fairy-types are not weak to Steel (tested this myself- they're still weak to Poison and resist Bug and all that).

Also, you gave Arm Thrust 25 BP, while it should be 15, and Bullet Seed is still 10 BP, while it should be 25.

EDIT: I believe you stated somewhere where the Soundproof table was located, but I can't seem to find it.
I'm thinking that for 1.5a I'll include a text file with all the offsets for the expanded tables.
Also thanks for spotting the Fairy type bug (though it's already been fixed because someone reported it earlier)

Thanks for those BP things. I think I must have updated Arm Thrust instead of Bullet Seed.

Found some quirks with Sticky Web.

-If White Herb negates the speed drop, the other player's turn will be skipped, giving a free turn to the sticky webbed monster.

-If Sticky Web and Stealth Rock are both up at once, Stealth Rock won't hurt Levitators or Flying-types.
Thanks for finding those. I'll look into those routines, though I can't guarantee they'll be fixed for 1.5a.

--------------

UPDATE 1.5a is officially ready!

Check the OP for the Download link and details.

There are now AFAIK 0 game breaking bugs, but there are still a few errors with a few moves and abilities.
These are all relatively minor, but surprisingly difficult to locate, and I should hopefully have cleared most of
these up for 1.5b or 1.6, whichever I choose to name it.

Hey, not to be up your *** about this, but what's the status on you implementing Imposter? I'm only bothering you about this because you told DaniilS not to work on it for me because you apparently had it done. Is it going to be in this update? Or if not can you just tell me how to do it? I've been holding off progress on my hack waiting for this Ditto thing.
Also I'd like to apologise, although I said I'd have Imposter ready for 1.5a, it's actually proven to be difficult.
I've got most of it working except for the actual animation changing you into the opponent.
Once I finish it I can send you the instructions for how to insert it, or you can wait for the next update which
should have it.

The ???

The one true question mark

Male
???
Seen December 10th, 2020
Posted January 14th, 2017
289 posts
10.2 Years
Hey! I noticed some very minor mistakes and stuff here and there, let me point them out :
- the move set isn't accurate for Gen VI, you had given Staryu 'RECYcle' in his learn set but it never.learns that in any generation
- you have mr. Mime and Jynx Nasty plot though they don't learn that, ever. Mr. Mime learns magical leaf, but it wasn't really there. Also the level at which mime learns were also bit bugged.
That's all I noticed so far, also, I know you dont really take requests but can you add gooey ability next version? I believe it will be easy to implement as the logic/condition for it is pretty simple. (Reduces speed on physical contact)
Hey there I am a budding YouTuber and make funny Pokemon Videos, check me out >>HERE<<
Seen February 22nd, 2015
Posted January 1st, 2015
152 posts
14.7 Years
Also I'd like to apologise, although I said I'd have Imposter ready for 1.5a, it's actually proven to be difficult.
I've got most of it working except for the actual animation changing you into the opponent.
Once I finish it I can send you the instructions for how to insert it, or you can wait for the next update which
should have it.
No problem, thanks for working on it. I think I may just start working without the base and add Imposter later as a lone new ability (it's the only one I truly care about). So yeah if you could give me instructions when the time comes I'd definitely appreciate it.

The ???

The one true question mark

Male
???
Seen December 10th, 2020
Posted January 14th, 2017
289 posts
10.2 Years
With the new version, this bug appears when I try to load my ROM in G3HS.. Didn't happen earlier btw.



Yes I'm using the 1.5a INI with the changed number of Pokemons that I made.

It was working fine earlier. HELP :/
Hey there I am a budding YouTuber and make funny Pokemon Videos, check me out >>HERE<<

MrDollSteak

Formerly known as 11bayerf1

Age 28
Male
Hong Kong
Seen March 16th, 2023
Posted September 26th, 2022
859 posts
14.4 Years
With the new version, this bug appears when I try to load my ROM in G3HS.. Didn't happen earlier btw.



Yes I'm using the 1.5a INI with the changed number of Pokemons that I made.

It was working fine earlier. HELP :/
I'm sorry, I think I moved the rom name back to BPRE from MrDS because
I was getting a lot of complaints about people not being able to use tools.

Also Gooey is already in the rombase.

And in answer to your pointing out of movesets, there are some moves that
are not in my rombase, and I replaced them with moves that were either
Egg Moves, Dream World moves or just to me would appear logical.
Age 22
Female
Seen 2 Days Ago
Posted August 22nd, 2021
105 posts
9 Years
There are a couple move issues-

-Moonblast has 40 PP and a 0% chance to lower Sp. Attack.

-Shift Gear's description claims that it raises Attack and Sp. Attack, while it should raise Attack and Speed.

-Fly is 70 power.

Also, throughout the newer descriptions there are commas missing in a couple places, such as Quiver Dance and Coil, but these are minor and they start new lines anyway.

EDIT: So, Assault Vest. For some reason, whenever I attack something holding it, it gives me the message "Assault Vest prevents the use of status moves!" and then gives me an error message. It doesn't actually break anything, but it's odd.

I'm also a bit upset that Sturdy doesn't seem to have its Gen 5 effect, but whatever. Take your time with it.