The PokéCommunity Forums  

Go Back   The PokéCommunity Forums > Fan Games > Binary ROM Hacking
Reload this Page Other Pksv Scripting Help

Notices
For all updates, view the main page.

Binary ROM Hacking Need a helping hand or just want to talk about binary ROM hacks? Get comments and answers to any ROM Hacking-related problems, questions or thoughts you have here.

Ad Content
Reply
 
Thread Tools
  #1   Link to this post, but load the entire thread.  
Old September 29th, 2014 (4:24 AM).
Taconinja's Avatar
Taconinja Taconinja is offline
 
Join Date: Aug 2014
Posts: 35
So I've been trying to get this script to work, but every time i click compile, it gets filled with raw data and stuff, and the setflag and disappear go away. Does anyone know why this may be happening?


#org 0x874018E
'-----------------------------------
lock
faceplayer
checkflag FR_BADGE_1
message 0x874019A ' \v\h01 found the Bou...
callstd MSG_LOCK ' Built-in lock command
setflag FR_BADGE_1
disappear 0x5
release
end


#org 0x874019A
= \v\h01 found the Boulder Badge!
Reply With Quote
  #2   Link to this post, but load the entire thread.  
Old September 30th, 2014 (3:09 PM).
Percy's Avatar
Percy Percy is offline
 
Join Date: Sep 2014
Location: Asia
Gender: Male
Nature: Quiet
Posts: 3,045
Quote:
Originally Posted by Taconinja View Post
So I've been trying to get this script to work, but every time i click compile, it gets filled with raw data and stuff, and the setflag and disappear go away. Does anyone know why this may be happening?


#org 0x874018E
'-----------------------------------
lock
faceplayer
checkflag FR_BADGE_1
message 0x874019A ' \v\h01 found the Bou...
callstd MSG_LOCK ' Built-in lock command
setflag FR_BADGE_1
disappear 0x5
release
end


#org 0x874019A
= \v\h01 found the Boulder Badge!
Wait, are you using PKSV?
I suggest you use XSE 1.1.1, destinedjagold may help you find the link..
__________________
i don't want to have a signature
Reply With Quote
  #3   Link to this post, but load the entire thread.  
Old September 30th, 2014 (4:15 PM).
Taconinja's Avatar
Taconinja Taconinja is offline
 
Join Date: Aug 2014
Posts: 35
Quote:
Originally Posted by BlazikenXY View Post
Wait, are you using PKSV?
I suggest you use XSE 1.1.1, destinedjagold may help you find the link..
Yea i know, people have suggested it to me before, but I don't like having to write things myself, and pksv has the script generator

EDIT: Also, I have XSE
__________________
My hack: Pokemon Nidokingdom


Reply With Quote
  #4   Link to this post, but load the entire thread.  
Old September 30th, 2014 (5:46 PM).
HidoranBlaze's Avatar
HidoranBlaze HidoranBlaze is offline
 
Join Date: Apr 2013
Age: 26
Gender: Male
Posts: 252
Quote:
Originally Posted by Taconinja View Post
Yea i know, people have suggested it to me before, but I don't like having to write things myself, and pksv has the script generator

EDIT: Also, I have XSE
You don't like writing scripts, so that's why you're using PKSV? Sorry, but that's a really lazy attitude you have there, regardless of which script editor you're using. You're never going to get far if you rely on a script generator. Practice makes perfect, and it's especially true in rom hacking. Once you script yourself, you will naturally get better, and learn how to make more advanced scripts.
Also, XSE has more support and tutorials, so I recommend switching. It's just more practical that way.
Reply With Quote
  #5   Link to this post, but load the entire thread.  
Old October 1st, 2014 (4:38 AM).
Taconinja's Avatar
Taconinja Taconinja is offline
 
Join Date: Aug 2014
Posts: 35
Quote:
Originally Posted by HidoranBlaze View Post
You don't like writing scripts, so that's why you're using PKSV? Sorry, but that's a really lazy attitude you have there, regardless of which script editor you're using. You're never going to get far if you rely on a script generator. Practice makes perfect, and it's especially true in rom hacking. Once you script yourself, you will naturally get better, and learn how to make more advanced scripts.
Also, XSE has more support and tutorials, so I recommend switching. It's just more practical that way.
What, exactly, about XSE makes it better? Everyone tells me i should switch, but they don't say why.
__________________
My hack: Pokemon Nidokingdom


Reply With Quote
  #6   Link to this post, but load the entire thread.  
Old October 1st, 2014 (5:32 AM).
Percy's Avatar
Percy Percy is offline
 
Join Date: Sep 2014
Location: Asia
Gender: Male
Nature: Quiet
Posts: 3,045
Quote:
Originally Posted by Taconinja View Post
What, exactly, about XSE makes it better? Everyone tells me i should switch, but they don't say why.
I'm just saying, I do not hate you...xD
Well, you should switch to XSE because, first, has many features, number two, um, ..., mental block! Just remember its the best scripting program around.
Its really up to you, you can use XSE or Pksv, its not a law to use XSE...:)
__________________
i don't want to have a signature
Reply With Quote
  #7   Link to this post, but load the entire thread.  
Old October 1st, 2014 (12:20 PM).
HidoranBlaze's Avatar
HidoranBlaze HidoranBlaze is offline
 
Join Date: Apr 2013
Age: 26
Gender: Male
Posts: 252
Quote:
Originally Posted by Taconinja View Post
What, exactly, about XSE makes it better? Everyone tells me i should switch, but they don't say why.
I gave my reasons. Better support and more tutorials. You'll see a lot more people using XSE than PKSV, and there's more tutorials on XSE than PKSV, so naturally you'll get more help with XSE than PKSV.
That being said however, I don't necessarily care if you use XSE or PKSV. What I do care about is your attitude. "I don't like having to write things myself, and pksv has the script generator" is a pretty bad excuse to use PKSV in my opinion. If you'd said something along the lines of "PKSV is easier for me to understand, and I can code better in it", then I would've been more sympathetic. You however, are using PKSV because it has a script generator, which will be bad for you in the long run. Doing things yourself is often the best way to learn, and scripting is no different. If you're going to use PKSV, ditch the script generator, and code things yourself.
Reply With Quote
  #8   Link to this post, but load the entire thread.  
Old October 1st, 2014 (4:00 PM).
AkameTheBulbasaur's Avatar
AkameTheBulbasaur AkameTheBulbasaur is offline
Akame Marukawa of Iyotono
 
Join Date: May 2013
Location: A place :D
Age: 25
Gender: Male
Nature: Docile
Posts: 408
Okay, I'm actually going to try to help instead of getting into pointless arguments about nothing.

I tried it in my PKSV and it compiled correctly, (no #RAWs all over the place).

That said, there are a couple things you should probably change.

After the "checkflag FR_BADGE_1", you should have a line that says "if true jump @xxx", the xxx being another section of the script. There you put what you want to happen the next time the player interacts with the object giving the badge.

You also seem to have the "disappear" command ing our script too. If you have the "disappear" command, and the sprite is going to be gone from the game forever, then it's pointless to have the "check flag" command. If you won't interact with the sprite again, you won't need to have a script defining your next interaction, right?

When you use the "disappear" command, you need to have another "set flag" after it. It can be any flag that is safe and isn't being used for something else. Once you have that, go to the "Person ID" in AdvanceMap (or it's equivalent in whatever you use) and change it to the flag that you set in the script. That way the sprite won't appear again one step later.

So in conclusion, pick either the "check flag" option OR the "disappear" option, but having both isn't needed.

(Also, it might help to use Dynamic Offsets if you're not already. I don't know, since your original script you posted doesn't have them.)
__________________
"The human sacrificed himself, to save the Pokemon. I pitted them against each other, but not until they set aside their differences did I see the true power they all share deep inside. I see now that the circumstances of one's birth are irrelevant; it is what you do with the gift of life that determines who you are." -Mewtwo
Reply With Quote
  #9   Link to this post, but load the entire thread.  
Old October 1st, 2014 (5:36 PM).
Taconinja's Avatar
Taconinja Taconinja is offline
 
Join Date: Aug 2014
Posts: 35
Quote:
Originally Posted by AkameTheBulbasaur View Post
Okay, I'm actually going to try to help instead of getting into pointless arguments about nothing.

I tried it in my PKSV and it compiled correctly, (no #RAWs all over the place).

That said, there are a couple things you should probably change.

After the "checkflag FR_BADGE_1", you should have a line that says "if true jump @xxx", the xxx being another section of the script. There you put what you want to happen the next time the player interacts with the object giving the badge.

You also seem to have the "disappear" command ing our script too. If you have the "disappear" command, and the sprite is going to be gone from the game forever, then it's pointless to have the "check flag" command. If you won't interact with the sprite again, you won't need to have a script defining your next interaction, right?

When you use the "disappear" command, you need to have another "set flag" after it. It can be any flag that is safe and isn't being used for something else. Once you have that, go to the "Person ID" in AdvanceMap (or it's equivalent in whatever you use) and change it to the flag that you set in the script. That way the sprite won't appear again one step later.

So in conclusion, pick either the "check flag" option OR the "disappear" option, but having both isn't needed.

(Also, it might help to use Dynamic Offsets if you're not already. I don't know, since your original script you posted doesn't have them.)
Thanks for your help. And yea, it did have dynamic offsets, but i had compiled it already.
__________________
My hack: Pokemon Nidokingdom


Reply With Quote
Reply

Quick Reply

Join the conversation!

Create an account to post a reply in this thread, participate in other discussions, and more!

Create a PokéCommunity Account
Ad Content

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -8. The time now is 9:09 AM.