The PokéCommunity Forums  

Go Back   The PokéCommunity Forums > Fan Games > Binary ROM Hacking
Reload this Page Other Script being skipped?

Notices
For all updates, view the main page.

Binary ROM Hacking Need a helping hand or just want to talk about binary ROM hacks? Get comments and answers to any ROM Hacking-related problems, questions or thoughts you have here.

Ad Content
Reply
 
Thread Tools
  #1   Link to this post, but load the entire thread.  
Old May 16th, 2015 (8:41 PM). Edited May 17th, 2015 by ShadowSorcererX.
ShadowSorcererX's Avatar
ShadowSorcererX ShadowSorcererX is offline
 
Join Date: May 2015
Location: The Sky of course
Gender: Male
Nature: Calm
Posts: 60
Alright friends I'm here once again with another scripting issue. But instead of posting the entire script I'll just post what isn't working. Below is my script that isn't working and the person information. But anyways, what I want to happen is the screen to go black, and when it comes back up, there is mist, a music change, and a character has moved by the time the screen comes back up. Now the music and mist are alright, but for some odd reason the character moving is getting skipped. I even tried moving the character script to go after the screen face but to no avail, it fails. I have no idea why the character sprite won't move, I even have showsprite which was my last problem. Hopefully PC can lend me some answers again. (picture of advance map person event information has been added)

Person event info (char that wont move):
Person event
No: 7
Person event no: 8
Picture no: 187
Unknown: 00 00
Pos (X\Y): 0009 000C
Unknown: 00
Movement type:
Look down
Movement: 00
Unknown: 00
Trainer: No
Unknown: 00
View radius: 0000
Script offset: $000000
Person ID: 1290
Unknown: 00 00

Script that isn't woking:
fadescreen 0x1
setweather 0xA
doweather
playsong 0x166 0x0
showsprite 0x8
applymovement 0x8 0x8803643
waitmovement 0x0
fadescreen 0x0
setvar 0x4056 0x1
release
end
Attached Images
File Type: png whyyy.png‎ (77.8 KB, 7 views) (Save to Dropbox)
Reply With Quote
  #2   Link to this post, but load the entire thread.  
Old May 16th, 2015 (8:51 PM).
Le pug's Avatar
Le pug Le pug is offline
Creator of Pokémon: Discovery / Fat Kid
 
Join Date: Aug 2013
Location: Le bed
Age: 30
Gender: Male
Nature: Bold
Posts: 870
1) make sure the flag for the OW isn't set.
2) make sure no other OW has the same person event number on the map (in this case it's 8)
3) make sure the OW isn't too far off screen for the player to see. if it is about 11 tiles away it won't register the event and will skip the applymovement completely
4) make sure the applymovement movement is actually correct and ending with 0xFE
__________________
Retired. Thank you guys for a wonderful five years.
Reply With Quote
  #3   Link to this post, but load the entire thread.  
Old May 17th, 2015 (6:27 AM).
ShadowSorcererX's Avatar
ShadowSorcererX ShadowSorcererX is offline
 
Join Date: May 2015
Location: The Sky of course
Gender: Male
Nature: Calm
Posts: 60
Quote:
Originally Posted by Le pug View Post
1) make sure the flag for the OW isn't set.
2) make sure no other OW has the same person event number on the map (in this case it's 8)
3) make sure the OW isn't too far off screen for the player to see. if it is about 11 tiles away it won't register the event and will skip the applymovement completely
4) make sure the applymovement movement is actually correct and ending with 0xFE
I followed all of your steps but nothing changed. I even remove all of the person events and replaced them, changed the script to recognize the right ID's, and nothing happened. Still the same result. I'm going to post the entire script below, maybe I messed up with something in the beginning? But the only thing that isn't working is the last applymovement.

'---------------
#org 0x803648
playsong 0x1D3 0x0
applymovement 0x8 0x8803348
waitmovement 0x0
applymovement 0x7 0x880334B
waitmovement 0x0
applymovement 0x1 0x880334E
waitmovement 0x0
applymovement 0x4 0x8803351
waitmovement 0x0
msgbox 0x88032D7 0x6 '"Grunt Girl: Who is this kid?!"
applymovement 0x4 0x8803354
applymovement 0x1 0x8803357
waitmovement 0x0
msgbox 0x88032F7 0x6 '"Jasmine: [player], I told you not ..."
applymovement 0x4 0x8803354
applymovement 0x1 0x8803357
waitmovement 0x0
sound 0x6B
special 0x131
waitstate
fadescreen 0x1
setweather 0xA
doweather
playsong 0x166 0x0
showsprite 0x2
applymovement 0x2 0x880374A
waitmovement 0x0
fadescreen 0x0
setvar 0x4056 0x1
release
end


'---------
' Strings
'---------
#org 0x8032D7
= Grunt Girl: Who is this kid?!

#org 0x8032F7
= Jasmine: [player], I told you not to come \nhere!\pJasmine: Leave before it's to late!


'-----------
' Movements
'-----------
#org 0x803348
#raw 0x0 'Face Down
#raw 0xFE 'End of Movements

#org 0x80334B
#raw 0x0 'Face Down
#raw 0xFE 'End of Movements

#org 0x80334E
#raw 0x0 'Face Down
#raw 0xFE 'End of Movements

#org 0x803351
#raw 0x0 'Face Down
#raw 0xFE 'End of Movements

#org 0x803354
#raw 0x0 'Face Down
#raw 0xFE 'End of Movements

#org 0x803357
#raw 0x0 'Face Down
#raw 0xFE 'End of Movements

#org 0x80374A
#raw 0x25 'Step on the Spot Down (Fastest)
#raw 0x25 'Step on the Spot Down (Fastest)
#raw 0x25 'Step on the Spot Down (Fastest)
#raw 0x25 'Step on the Spot Down (Fastest)
#raw 0xFE 'End of Movements
Reply With Quote
  #4   Link to this post, but load the entire thread.  
Old May 17th, 2015 (9:35 AM).
C me's Avatar
C me C me is offline
Creator of Pokemon League Of Legends
 
Join Date: Jan 2014
Age: 26
Gender: Male
Posts: 681
You're missing lock at the start, unless this is a subscript, and the lock happened in the main script.
__________________
Check out my hack: Pokemon League of Legends.
Join the subreddit: https://www.reddit.com/r/PokemonLoL/
If you would like to give me money for no reason you can do so here
Reply With Quote
  #5   Link to this post, but load the entire thread.  
Old May 17th, 2015 (10:28 AM).
ShadowSorcererX's Avatar
ShadowSorcererX ShadowSorcererX is offline
 
Join Date: May 2015
Location: The Sky of course
Gender: Male
Nature: Calm
Posts: 60
Quote:
Originally Posted by C me View Post
You're missing lock at the start, unless this is a subscript, and the lock happened in the main script.
Put lock as the very first command. Froze the game. I have no idea why. I will tinker with lock and see what happens but putting it at the beginning froze my game when stepping on the script.
Reply With Quote
  #6   Link to this post, but load the entire thread.  
Old May 17th, 2015 (12:21 PM).
C me's Avatar
C me C me is offline
Creator of Pokemon League Of Legends
 
Join Date: Jan 2014
Age: 26
Gender: Male
Posts: 681
Quote:
Originally Posted by ShadowSorcererX View Post
Put lock as the very first command. Froze the game. I have no idea why. I will tinker with lock and see what happens but putting it at the beginning froze my game when stepping on the script.
I don't know why that would happen. Also person ID 1290 seems really high, you can't even set flags that high.
Reply With Quote
  #7   Link to this post, but load the entire thread.  
Old May 17th, 2015 (12:43 PM).
ShadowSorcererX's Avatar
ShadowSorcererX ShadowSorcererX is offline
 
Join Date: May 2015
Location: The Sky of course
Gender: Male
Nature: Calm
Posts: 60
Quote:
Originally Posted by C me View Post
I don't know why that would happen. Also person ID 1290 seems really high, you can't even set flags that high.
Set the PID to 1205 and nothing happened, I still get the same result. Everything in the script works except the one NPC at the end.

showsprite 0x2
applymovement 0x2 0x880374A
waitmovement 0x0

#org 0x80374A
#raw 0x25 'Step on the Spot Down (Fastest)
#raw 0x25 'Step on the Spot Down (Fastest)
#raw 0x25 'Step on the Spot Down (Fastest)
#raw 0x25 'Step on the Spot Down (Fastest)
#raw 0xFE 'End of Movements

I don't see what is wrong with that...
(Also the NPC is 5 tiles away from the script the player steps on to activate the event.)
Reply With Quote
  #8   Link to this post, but load the entire thread.  
Old May 17th, 2015 (1:05 PM).
C me's Avatar
C me C me is offline
Creator of Pokemon League Of Legends
 
Join Date: Jan 2014
Age: 26
Gender: Male
Posts: 681
Isn't fadescreen 0x1 normal to black so he'll be moving while the screen is black.

Also for person ID I mean that's still high. Person ID is a flag and flags don't go that high. If you go over 900 it overlaps some RAM, I'm usually using 300 or less.
__________________
Check out my hack: Pokemon League of Legends.
Join the subreddit: https://www.reddit.com/r/PokemonLoL/
If you would like to give me money for no reason you can do so here
Reply With Quote
  #9   Link to this post, but load the entire thread.  
Old May 17th, 2015 (1:10 PM).
ShadowSorcererX's Avatar
ShadowSorcererX ShadowSorcererX is offline
 
Join Date: May 2015
Location: The Sky of course
Gender: Male
Nature: Calm
Posts: 60
Quote:
Originally Posted by C me View Post
Isn't fadescreen 0x1 normal to black so he'll be moving while the screen is black.

Also for person ID I mean that's still high. Person ID is a flag and flags don't go that high. If you go over 900 it overlaps some RAM, I'm usually using 300 or less.
Yes the plan is for the NPC to move into a specific place and appear when the screen comes back. My original plan was to have the movement type as hidden and then use showsprite to make the NPC appear. But neither of these worked. BUT, out of curiosity I decided to test the not working script on a new script tile. The result, it worked! But I had edited a few things. (script below) The following made the npc walk up to me when I stepped on the script. So something is making the first script not work but I'm not too sure what it is. I will do a bit more testing because I have a few ideas/edits I might be able to add to fix this.

'---------------
#org 0x800CC3
applymovement 0x2 0x8800CD5
waitmovement 0x0
setvar 0x4058 0x1
release
end


'-----------
' Movements
'-----------
#org 0x800CD5
#raw 0x8 'Step Down (Normal)
#raw 0x8 'Step Down (Normal)
#raw 0x8 'Step Down (Normal)
#raw 0xFE 'End of Movements
Reply With Quote
  #10   Link to this post, but load the entire thread.  
Old May 17th, 2015 (1:23 PM).
ShadowSorcererX's Avatar
ShadowSorcererX ShadowSorcererX is offline
 
Join Date: May 2015
Location: The Sky of course
Gender: Male
Nature: Calm
Posts: 60
Fixed it, so it turns out that the applymovement script 0x25 for latios/latias makes them jitter, not run down super fast like the applymovement offset name would make someone think. (Step on the Spot Down (Fastest)) So I decided to just switch it to 0x15 (Step Down (Fast)) and viola! As soon as the screen came up, BAM, a red latias was in front of me! Thanks for all of the help friends! :D
Reply With Quote
Reply

Quick Reply

Join the conversation!

Create an account to post a reply in this thread, participate in other discussions, and more!

Create a PokéCommunity Account
Ad Content

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -8. The time now is 9:11 AM.