The PokéCommunity Forums  

Go Back   The PokéCommunity Forums > Fan Games > Binary ROM Hacking
Reload this Page Other Issue when trying to use HMS

Notices
For all updates, view the main page.

Binary ROM Hacking Need a helping hand or just want to talk about binary ROM hacks? Get comments and answers to any ROM Hacking-related problems, questions or thoughts you have here.

Ad Content
Reply
 
Thread Tools
  #1   Link to this post, but load the entire thread.  
Old September 30th, 2016 (4:03 PM). Edited October 3rd, 2016 by Joexv.
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
So every time I try and use an HM the player just freezes when doing the animation. I've checked in IDB and clean ROMS to find any issues with the HM routines but have found none. The only thing I can think of is the animation that loads the black bar on the screen, but I haven't found that routine yet. I can upload a patch if it's needed.

Any help would be much appreciated!


EDIT: Removed the black bar completely and no change.
__________________
New living flesh vessel who dis?
Reply With Quote
  #2   Link to this post, but load the entire thread.  
Old October 1st, 2016 (4:57 AM).
BluRose BluRose is offline
blu rass
 
Join Date: Apr 2014
Location: michigan tech
Age: 22
Gender: Male
Nature: Timid
Posts: 812
Quote:
Originally Posted by Joexv View Post
So every time I try and use an HM the player just freezes when doing the animation. I've checked in IDB and clean ROMS to find any issues with the HM routines but have found none. The only thing I can think of is the animation that loads the black bar on the screen, but I haven't found that routine yet. I can upload a patch if it's needed.

Any help would be much appreciated!


EDIT: Removed the black bar completely and no change.
it's probably because the water is actually red, not blue
what do you mean by "when doing the animation?"
__________________
heyo check out my github:

BluRosie
highlights:
battle engine for heartgold
various feature branches in heart gold (fairy type, odd egg, mud slopes)

i'm a big part of the development team of pokemon firegold! all the code that i develop for that hack is also on my github

also on discord: BluRose#0412
Reply With Quote
  #3   Link to this post, but load the entire thread.  
Old October 1st, 2016 (8:11 AM).
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
Quote:
Originally Posted by BluRose View Post
it's probably because the water is actually red, not blue
what do you mean by "when doing the animation?"
The animation that the player does when HMS are used
https://youtu.be/TQa6ZbV0lyY?t=211

^This animation. it freezes right when that starts so I'm thinking thats the problem but haven't found the source.
__________________
New living flesh vessel who dis?
Reply With Quote
  #4   Link to this post, but load the entire thread.  
Old October 1st, 2016 (8:15 AM).
PankajBlitz's Avatar
PankajBlitz PankajBlitz is offline
Taiyoh!
 
Join Date: Jun 2015
Location: Reach
Age: 22
Gender: Male
Nature: Hardy
Posts: 216
Maybe spherical ice know something because he has added dirty water and it is surfable too.
__________________
Back from the dead
Reply With Quote
  #5   Link to this post, but load the entire thread.  
Old October 1st, 2016 (8:19 AM).
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
Quote:
Originally Posted by PankajBlitz View Post
Maybe spherical ice know something because he has added dirty water and it is surfable too.
Well the problem isn't only when surfing, it's with ALL HMs. And the red water is literally just me editing the animation palette. Nothing special.
__________________
New living flesh vessel who dis?
Reply With Quote
  #6   Link to this post, but load the entire thread.  
Old October 1st, 2016 (8:25 AM).
PankajBlitz's Avatar
PankajBlitz PankajBlitz is offline
Taiyoh!
 
Join Date: Jun 2015
Location: Reach
Age: 22
Gender: Male
Nature: Hardy
Posts: 216
Then it means theres a problem with the repointing?
__________________
Back from the dead
Reply With Quote
  #7   Link to this post, but load the entire thread.  
Old October 1st, 2016 (8:53 AM).
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
Quote:
Originally Posted by PankajBlitz View Post
Then it means theres a problem with the repointing?
I would say yes, but I haven't repointed anything related to HMs/Field Moves from what I remember.
__________________
New living flesh vessel who dis?
Reply With Quote
  #8   Link to this post, but load the entire thread.  
Old October 1st, 2016 (8:57 AM).
Blah's Avatar
Blah Blah is offline
Free supporter
 
Join Date: Jan 2013
Location: Unknown Island
Gender: Male
Posts: 1,924
It's hard to deduce from just that information. Is it a soft lock, or is it frozen in a specific instruction?

Open the game in VBA/VBM something with a disassembler -> check what R14 is

What changes have you made to HMs/TMs, have you changed/repointed the item table? There's a lot that could be wrong.
__________________
...
Reply With Quote
  #9   Link to this post, but load the entire thread.  
Old October 1st, 2016 (9:15 AM).
Pleasure's Avatar
Pleasure Pleasure is offline
 
Join Date: Apr 2015
Gender: Male
Nature: Timid
Posts: 113
Are you using JPANs hacked engine?
Reply With Quote
  #10   Link to this post, but load the entire thread.  
Old October 1st, 2016 (9:17 AM).
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
Quote:
Originally Posted by FBI View Post
It's hard to deduce from just that information. Is it a soft lock, or is it frozen in a specific instruction?

Open the game in VBA/VBM something with a disassembler -> check what R14 is

What changes have you made to HMs/TMs, have you changed/repointed the item table? There's a lot that could be wrong.
r14 is set to 4AB

AFAIK none, other than the flag check for HMs.

I did enter the surf script and change doanimation to 0x8 and there was no freeze, so its animation 9 thats causing it?

Quote:
Originally Posted by Pleasure View Post
Are you using JPANs hacked engine?
Hell nah
__________________
New living flesh vessel who dis?
Reply With Quote
  #11   Link to this post, but load the entire thread.  
Old October 1st, 2016 (9:19 AM).
Blah's Avatar
Blah Blah is offline
Free supporter
 
Join Date: Jan 2013
Location: Unknown Island
Gender: Male
Posts: 1,924
Quote:
Originally Posted by Joexv View Post
r14 is set to 4AB

AFAIK none, other than the flag check for HMs.

I did enter the surf script and change doanimation to 0x8 and there was no freeze, so its animation 9 thats causing it?
wait. It works when you use animation 0x8 but not 0x9?
__________________
...
Reply With Quote
  #12   Link to this post, but load the entire thread.  
Old October 1st, 2016 (9:20 AM).
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
Quote:
Originally Posted by FBI View Post
wait. It works when you use animation 0x8 but not 0x9?
Well it doesn't make me surf but it doesn't freeze the game
__________________
New living flesh vessel who dis?
Reply With Quote
  #13   Link to this post, but load the entire thread.  
Old October 1st, 2016 (9:23 AM).
Blah's Avatar
Blah Blah is offline
Free supporter
 
Join Date: Jan 2013
Location: Unknown Island
Gender: Male
Posts: 1,924
Quote:
Originally Posted by Joexv View Post
Well it doesn't make me surf but it doesn't freeze the game
callasm 0x8086945

tell me if it freezes
__________________
...
Reply With Quote
  #14   Link to this post, but load the entire thread.  
Old October 1st, 2016 (9:30 AM).
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
Quote:
Originally Posted by FBI View Post
callasm 0x8086945

tell me if it freezes
It does indeed. But looking at that with a hex editor compare to a clean ROM, they are identical so its not overwritten or anything there.
__________________
New living flesh vessel who dis?
Reply With Quote
  #15   Link to this post, but load the entire thread.  
Old October 1st, 2016 (9:43 AM).
Blah's Avatar
Blah Blah is offline
Free supporter
 
Join Date: Jan 2013
Location: Unknown Island
Gender: Male
Posts: 1,924
Quote:
Originally Posted by Joexv View Post
It does indeed. But looking at that with a hex editor compare to a clean ROM, they are identical so its not overwritten or anything there.
Yeah, the animation itself is causing the bug you're experiencing.

Check if 083CC154 - 083CC168, bytes are identical. If they are, notice that this is a table of functions, you should check each function and see if any of them have been modified.
__________________
...
Reply With Quote
  #16   Link to this post, but load the entire thread.  
Old October 1st, 2016 (10:24 AM). Edited October 1st, 2016 by Joexv.
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
Quote:
Originally Posted by FBI View Post
Yeah, the animation itself is causing the bug you're experiencing.

Check if 083CC154 - 083CC168, bytes are identical. If they are, notice that this is a table of functions, you should check each function and see if any of them have been modified.
Looking through the functions they are all the same, I remembered I do have the dynamic palettes installed so I tried removing it and it made no changes to the freeze.

Heres a ups file and save file https://www.mediafire.com/?cmw3t5e17nbs3s7
__________________
New living flesh vessel who dis?
Reply With Quote
  #17   Link to this post, but load the entire thread.  
Old October 1st, 2016 (11:59 AM).
Blah's Avatar
Blah Blah is offline
Free supporter
 
Join Date: Jan 2013
Location: Unknown Island
Gender: Male
Posts: 1,924
Quote:
Originally Posted by Joexv View Post
Looking through the functions they are all the same, I remembered I do have the dynamic palettes installed so I tried removing it and it made no changes to the freeze.

Heres a ups file and save file https://www.mediafire.com/?cmw3t5e17nbs3s7
I'm too lazy to DL a patcher :(

Disclaimer: I am not implying or forcing anyone to break any rules by PMing me a ROM instead.
__________________
...
Reply With Quote
  #18   Link to this post, but load the entire thread.  
Old October 1st, 2016 (12:05 PM).
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
Quote:
Originally Posted by FBI View Post
I'm too lazy to DL a patcher :(

Disclaimer: I am not implying or forcing anyone to break any rules by PMing me a ROM instead.
Oh no! Why would you even suggest such a thing you monster! What has this community gone to????
__________________
New living flesh vessel who dis?
Reply With Quote
  #19   Link to this post, but load the entire thread.  
Old October 1st, 2016 (2:27 PM).
Blah's Avatar
Blah Blah is offline
Free supporter
 
Join Date: Jan 2013
Location: Unknown Island
Gender: Male
Posts: 1,924
So I downloaded the patch and patched it, like a normal person would.

I don't have the time to invest in discovering the source of the issue, but the issue is that the game is freezing on 08063D7C. The bit should be cleared when an animation has finished, but it's not. I believe one of your movement commands are bugged, or some hack effecting NPCs has been hacked incorrectly or poorly.

I tried to nop the function in my debugger, as well as a couple more things and the animation played fine. This suggests there is nothing wrong with the animation in general, but the NPC_states bitfield is not being reset correctly. Please review any new hacks you've inserted that effect NPC animations, repointing any gender determined tables and anything effecting the NPC states bitfield. While you could nop these out yourself, it's obviously not a healthy solution, as it breaks other parts of the game.
__________________
...
Reply With Quote
  #20   Link to this post, but load the entire thread.  
Old October 1st, 2016 (5:39 PM).
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
Quote:
Originally Posted by FBI View Post
So I downloaded the patch and patched it, like a normal person would.

I don't have the time to invest in discovering the source of the issue, but the issue is that the game is freezing on 08063D7C. The bit should be cleared when an animation has finished, but it's not. I believe one of your movement commands are bugged, or some hack effecting NPCs has been hacked incorrectly or poorly.

I tried to nop the function in my debugger, as well as a couple more things and the animation played fine. This suggests there is nothing wrong with the animation in general, but the NPC_states bitfield is not being reset correctly. Please review any new hacks you've inserted that effect NPC animations, repointing any gender determined tables and anything effecting the NPC states bitfield. While you could nop these out yourself, it's obviously not a healthy solution, as it breaks other parts of the game.
Ok well I've been digging into all my backups and such and no luck finding one that works yet. BUT I did learn at one point in time I did in fact use jpans hacked engine, which is weird because I made sure I did not want that in this game. But it is possible that that is actually causing the issue. I'm reading through Karatekid552's fixes for the engine and so far haven't really found anything that fixes it yet. I would like to remove the entirety of the Player OW swap if possible but idk how much its been edited already.
__________________
New living flesh vessel who dis?
Reply With Quote
  #21   Link to this post, but load the entire thread.  
Old October 1st, 2016 (7:55 PM).
Blah's Avatar
Blah Blah is offline
Free supporter
 
Join Date: Jan 2013
Location: Unknown Island
Gender: Male
Posts: 1,924
Quote:
Originally Posted by Joexv View Post
Ok well I've been digging into all my backups and such and no luck finding one that works yet. BUT I did learn at one point in time I did in fact use jpans hacked engine, which is weird because I made sure I did not want that in this game. But it is possible that that is actually causing the issue. I'm reading through Karatekid552's fixes for the engine and so far haven't really found anything that fixes it yet. I would like to remove the entirety of the Player OW swap if possible but idk how much its been edited already.
I'm completely clueless about the implementations or methods behind JPANs patches. The bitfield is read to indicate when an animation is done, and it doesn't seem to be setting the right value for the routine sequence to continue on to the next step. The problem persists in animation 0x45.

Try to do applymovement 0x45 and see if it works. This is the movement which the player does the Pokeball effect I believe.
__________________
...
Reply With Quote
  #22   Link to this post, but load the entire thread.  
Old October 3rd, 2016 (10:48 AM).
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
Quote:
Originally Posted by FBI View Post
I'm completely clueless about the implementations or methods behind JPANs patches. The bitfield is read to indicate when an animation is done, and it doesn't seem to be setting the right value for the routine sequence to continue on to the next step. The problem persists in animation 0x45.

Try to do applymovement 0x45 and see if it works. This is the movement which the player does the Pokeball effect I believe.
Well 0x45 doesn't seem to be the right movement, and I've been going through some of them to find it but with no luck.

I've managed to completely remove Jpan's OW hack but that hasn't changed anything.
__________________
New living flesh vessel who dis?
Reply With Quote
  #23   Link to this post, but load the entire thread.  
Old October 3rd, 2016 (10:55 AM).
Blah's Avatar
Blah Blah is offline
Free supporter
 
Join Date: Jan 2013
Location: Unknown Island
Gender: Male
Posts: 1,924
Quote:
Originally Posted by Joexv View Post
Well 0x45 doesn't seem to be the right movement, and I've been going through some of them to find it but with no luck.

I've managed to completely remove Jpan's OW hack but that hasn't changed anything.
Does movement 0x45 break on your ROM? Can you try it on a clean ROM?
__________________
...
Reply With Quote
  #24   Link to this post, but load the entire thread.  
Old October 3rd, 2016 (11:04 AM).
Joexv's Avatar
Joexv Joexv is offline
ManMadeOfGouda
joexv.github.io
 
Join Date: Oct 2012
Location: Oregon
Age: 25
Gender: Male
Nature: Sassy
Posts: 1,035
Quote:
Originally Posted by FBI View Post
Does movement 0x45 break on your ROM? Can you try it on a clean ROM?
movement 0x45 just makes the player walks up in place, it works just fine.
__________________
New living flesh vessel who dis?
Reply With Quote
  #25   Link to this post, but load the entire thread.  
Old October 3rd, 2016 (11:22 AM).
Blah's Avatar
Blah Blah is offline
Free supporter
 
Join Date: Jan 2013
Location: Unknown Island
Gender: Male
Posts: 1,924
Quote:
Originally Posted by Joexv View Post
movement 0x45 just makes the player walks up in place, it works just fine.
Weird, that's the movement its stuck on during your surf animation.
__________________
...
Reply With Quote
Reply

Quick Reply

Join the conversation!

Create an account to post a reply in this thread, participate in other discussions, and more!

Create a PokéCommunity Account
Ad Content
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -8. The time now is 9:11 AM.