The PokéCommunity Forums  

Go Back   The PokéCommunity Forums > Fan Games > Binary ROM Hacking
Reload this Page Script How do I make the Elite Four in FR not stupid? (not the AI)

Notices
For all updates, view the main page.

Binary ROM Hacking Need a helping hand or just want to talk about binary ROM hacks? Get comments and answers to any ROM Hacking-related problems, questions or thoughts you have here.

Ad Content
Closed Thread
 
Thread Tools
  #1   Link to this post, but load the entire thread.  
Old June 17th, 2018 (4:18 PM). Edited November 15th, 2018 by BirdstarCat13.
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Long story short, I want the Elite Four's music to behave how it does in literally every game that isn't Gen 1/2, where they have their own music.

There are a few unused RSE tracks (one of them happens to be the RSE gym leader theme, which is the one I want to use) and after examining the script for Lorelei (just to check how they're made) There isn't a playsong command anywhere in their scripts, meaning that the music ID is hardcoded into the trainerbattle data. Fair enough. I checked a trainer editor, and sure enough, there's a slot for the Trainer's music, just like I remembered. But that's where the problem is: They don't use the hexadecimal IDs, but instead they use a base 10 ID, which isn't even the same value as the respective music to begin with! Basically, what I'm asking is, what are those base 10 IDs correspondent to? And which one is the RSE gym leader music? I'm honestly surprised something this simple has such a complex issue tied to it, and it's really frustrating because I know nothing about Sappy, and don't want to repoint a TON of vanilla data just to change the Elite Four's music to the RSE Gym theme. That could break compatibility with vanilla ROMs.

Edit: It also doesn't help that while the Elite Four have a base 10 music ID of "10", and Brock, Lt. Surge, Blaine, and Koga have "0" and Misty and Erika have "1". WTF?! The IDs they DO have aren't even consistent!
  #2   Link to this post, but load the entire thread.  
Old November 15th, 2018 (9:01 PM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Has anyone figured this out yet?
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
  #3   Link to this post, but load the entire thread.  
Old November 15th, 2018 (9:07 PM).
Sakib66's Avatar
Sakib66 Sakib66 is offline
 
Join Date: Jan 2017
Gender: Male
Nature: Adamant
Posts: 196
https://www.pokecommunity.com/showthread.php?t=293704
  #4   Link to this post, but load the entire thread.  
Old November 15th, 2018 (9:17 PM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Quote:
Originally Posted by Sakib66 View Post
"So, firstly, assemble and insert this routine, and note down the location of your insert."

You could have just said it's impossible y'know
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
  #5   Link to this post, but load the entire thread.  
Old November 15th, 2018 (9:51 PM).
Sakib66's Avatar
Sakib66 Sakib66 is offline
 
Join Date: Jan 2017
Gender: Male
Nature: Adamant
Posts: 196
Quote:
Originally Posted by BirdstarCat13 View Post
"So, firstly, assemble and insert this routine, and note down the location of your insert."

You could have just said it's impossible y'know
Its very very possible all you have to do is learn how to assemble a routine but guess what you are never gonna learn it and blame the entire community.

You are such a disaster.
  #6   Link to this post, but load the entire thread.  
Old November 16th, 2018 (4:29 AM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Quote:
Originally Posted by Sakib66 View Post
Its very very possible all you have to do is learn how to assemble a routine but guess what you are never gonna learn it and blame the entire community.

You are such a disaster.
Actually, YOU are the disaster. You didn't need to be a total asshole out of nowhere like that. MY post was CLEARLY a joke, and my hack is non-ASM, to avoid breaking compatibilities.
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
  #7   Link to this post, but load the entire thread.  
Old November 16th, 2018 (6:16 AM).
Delta231's Avatar
Delta231 Delta231 is offline
A noob
 
Join Date: May 2016
Location: India
Gender: Male
Nature: Bold
Posts: 682
Quote:
Originally Posted by BirdstarCat13 View Post
Actually, YOU are the disaster. You didn't need to be a total asshole out of nowhere like that. MY post was CLEARLY a joke, and my hack is non-ASM, to avoid breaking compatibilities.
Just saying if you need to add new mechanism then you need ASM and if you didn't know that hex edits you do is actually changing the functions of the rom in short you are changing in game functions and doing ASM.
__________________
HGSS OWs in FR Style
Fire Red NSE Bookmarks


A supporter of


  #8   Link to this post, but load the entire thread.  
Old November 16th, 2018 (6:20 AM).
Mystelex
Guest
 
Posts: n/a
Quote:
Originally Posted by BirdstarCat13 View Post
Actually, YOU are the disaster. You didn't need to be a total asshole out of nowhere like that. MY post was CLEARLY a joke, and my hack is non-ASM, to avoid breaking compatibilities.
What kind of compatibility?
  #9   Link to this post, but load the entire thread.  
Old November 16th, 2018 (7:14 AM). Edited November 16th, 2018 by DrFuji.
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Quote:
Originally Posted by Daman View Post
What kind of compatibility?
With a vanilla ROM

Quote:
Originally Posted by Delta231 View Post
Just saying if you need to add new mechanism then you need ASM and if you didn't know that hex edits you do is actually changing the functions of the rom in short you are changing in game functions and doing ASM.
k
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
  #10   Link to this post, but load the entire thread.  
Old November 16th, 2018 (8:09 AM). Edited November 16th, 2018 by Mystelex.
Mystelex
Guest
 
Posts: n/a
Quote:
Originally Posted by BirdstarCat13 View Post
With a vanilla ROM ffs
Can you elaborate?

Depends on what you're inserting. The routine Sakib provided causes no compatibility issues at all.
  #11   Link to this post, but load the entire thread.  
Old November 21st, 2018 (7:23 PM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Quote:
Originally Posted by Daman View Post
Can you elaborate?

Depends on what you're inserting. The routine Sakib provided causes no compatibility issues at all.
Would rather be safe than sorry and just not use custom ASM code altogether. If I don't insert any new ASM, then the chance that compatibility would break becomes significantly lower than if I used even a "harmless" routine.
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
  #12   Link to this post, but load the entire thread.  
Old November 21st, 2018 (7:25 PM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Quote:
Originally Posted by Delta231 View Post
Just saying if you need to add new mechanism then you need ASM and if you didn't know that hex edits you do is actually changing the functions of the rom in short you are changing in game functions and doing ASM.
Pretty goddamn obvious I was talking about custom routines that a hacker would insert, and yes, I already knew all of that, I'm not a complete degenerate.
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
  #13   Link to this post, but load the entire thread.  
Old November 21st, 2018 (8:10 PM).
PlayerIDE's Avatar
PlayerIDE PlayerIDE is offline
 
Join Date: Aug 2014
Gender: Male
Posts: 9
Quote:
Originally Posted by BirdstarCat13 View Post
Pretty goddamn obvious I was talking about custom routines that a hacker would insert, and yes, I already knew all of that, I'm not a complete degenerate.
If you ask for help, and then get upset when someone explains what to do, you're not going be helped again.


Link

That will work for the Elite 4 since they don't move towards the player, and must be interacted with. It says it doesn't work for trainers with a view radius, however.
  #14   Link to this post, but load the entire thread.  
Old November 24th, 2018 (9:40 PM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Quote:
Originally Posted by PlayerIDE View Post
Link

That will work for the Elite 4 since they don't move towards the player, and must be interacted with. It says it doesn't work for trainers with a view radius, however.
Thank you! This is almost precisely what I was looking for! :)
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
  #15   Link to this post, but load the entire thread.  
Old November 27th, 2018 (9:07 PM).
Mystelex
Guest
 
Posts: n/a
Quote:
Originally Posted by BirdstarCat13 View Post
Would rather be safe than sorry and just not use custom ASM code altogether. If I don't insert any new ASM, then the chance that compatibility would break becomes significantly lower than if I used even a "harmless" routine.
That's not how it works, lol
  #16   Link to this post, but load the entire thread.  
Old November 28th, 2018 (7:55 AM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Quote:
Originally Posted by Daman View Post
That's not how it works, lol
Except it is. If you spent even a split second reading my other replies, you'd know that I'm to counting basic hex edits (ie shiny chance, EV effectiveness, etc) as "true" ASM, since nothing had to be written and compiled for the modification to be implemented. I can make a fully-fledged hack without it.
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
  #17   Link to this post, but load the entire thread.  
Old November 28th, 2018 (2:59 PM). Edited November 30th, 2018 by Mystelex.
Mystelex
Guest
 
Posts: n/a
Quote:
Originally Posted by BirdstarCat13 View Post
Except it is. If you spent even a split second reading my other replies, you'd know that I'm to counting basic hex edits (ie shiny chance, EV effectiveness, etc) as "true" ASM, since nothing had to be written and compiled for the modification to be implemented. I can make a fully-fledged hack without it.
Look, I've read your gibberish already. 'True' ASM lol. Go read what Delta said again.

I'm using it for my hack, and it causes no compatibility issues with vanilla. Just admit that you don't know how to insert ASM, shove the crappy attitude away and ask if you need help with that.

Besides, the method PokeIDE linked doesn't work for scripts where you want the script to continue after the battle, from what I recall.
  #18   Link to this post, but load the entire thread.  
Old November 30th, 2018 (6:07 AM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Quote:
Originally Posted by Daman View Post
...where you want it to continue after the battle...
Proof you haven't read ANY of my other posts. I didn't say ANYWHERE that I wanted the music to continue after the battle, just that I wanted the E4 to use different music. Part of the point of my hack is to make something good WITHOUT inserting custom ASM routines, and I don't have to defend that to some condescending ass on a forum. I'm not responding to anything else you say until you actually say something coherent.
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
Closed Thread

Quick Reply

Join the conversation!

Create an account to post a reply in this thread, participate in other discussions, and more!

Create a PokéCommunity Account
Ad Content

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -8. The time now is 9:17 AM.