The PokéCommunity Forums  

Go Back   The PokéCommunity Forums > Fan Games > Binary ROM Hacking
Reload this Page Other Shiny sprites at pokédex entries?

Notices
For all updates, view the main page.

Binary ROM Hacking Need a helping hand or just want to talk about binary ROM hacks? Get comments and answers to any ROM Hacking-related problems, questions or thoughts you have here.

Ad Content
Reply
 
Thread Tools
  #1   Link to this post, but load the entire thread.  
Old July 4th, 2018 (2:52 PM).
gerff's Avatar
gerff gerff is offline
 
Join Date: Mar 2018
Posts: 43
For some reason, while I was doing my hack, I must have done something wrong and now my pokédex entries have all pokémon with their shiny sprites. I could go back to a previous backup, but I have changed the whole habitat table which was A LOT of work and I don't want to do that again. Is there a way to change the sprites back to normal? I'm using BPRE (1.0).
Reply With Quote
  #2   Link to this post, but load the entire thread.  
Old July 4th, 2018 (4:26 PM).
DrFuji's Avatar
DrFuji DrFuji is offline
Heiki Hecchara‌‌
 
Join Date: Sep 2009
Location: Aussie
Age: 30
Gender: Male
Nature: Jolly
Posts: 1,693
Did you change the shiny chance? This post explains why its happening and how to fix it if you did.
__________________
Reply With Quote
  #3   Link to this post, but load the entire thread.  
Old July 5th, 2018 (9:02 AM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
DrFuji pretty much beat me to it - if you have increased the shiny encounter rate via a direct hex edit, then there is another byte you must edit or else all Pokémon in the Dex will use their shiny sprite regardless of whether or not you've seen, encountered, or caught the shiny. If you used TSK's Chiny Chance Changer, then the PokéDex doing that is a known glitch.
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
Reply With Quote
  #4   Link to this post, but load the entire thread.  
Old July 5th, 2018 (10:46 AM).
gerff's Avatar
gerff gerff is offline
 
Join Date: Mar 2018
Posts: 43
In fact, that's what I did. Didn't even occur me that this would be what caused it. Thanks!
Reply With Quote
  #5   Link to this post, but load the entire thread.  
Old July 5th, 2018 (11:09 AM).
gerff's Avatar
gerff gerff is offline
 
Join Date: Mar 2018
Posts: 43
Quote:
Originally Posted by BirdstarCat13 View Post
DrFuji pretty much beat me to it - if you have increased the shiny encounter rate via a direct hex edit, then there is another byte you must edit or else all Pokémon in the Dex will use their shiny sprite regardless of whether or not you've seen, encountered, or caught the shiny. If you used TSK's Chiny Chance Changer, then the PokéDex doing that is a known glitch.
I just cheked the post and I can't seem to find the offset 0x08044120, is that really the right offset? It seems to have too many numbers.
Reply With Quote
  #6   Link to this post, but load the entire thread.  
Old July 5th, 2018 (2:51 PM).
DrFuji's Avatar
DrFuji DrFuji is offline
Heiki Hecchara‌‌
 
Join Date: Sep 2009
Location: Aussie
Age: 30
Gender: Male
Nature: Jolly
Posts: 1,693
Remove '08' from the beginning of that offset to get the correct one.
__________________
Reply With Quote
  #7   Link to this post, but load the entire thread.  
Old July 5th, 2018 (9:45 PM).
gerff's Avatar
gerff gerff is offline
 
Join Date: Mar 2018
Posts: 43
Quote:
Originally Posted by DrFuji View Post
Remove '08' from the beginning of that offset to get the correct one.
Thank you. I did everything the post says, but the sprites are still shiny, I even put the same bytes as the original ROM and they're still showing up as shiny, I don't know what else to do. :/
Reply With Quote
  #8   Link to this post, but load the entire thread.  
Old July 6th, 2018 (1:30 AM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Quote:
Originally Posted by gerff View Post
Thank you. I did everything the post says, but the sprites are still shiny, I even put the same bytes as the original ROM and they're still showing up as shiny, I don't know what else to do. :/
Did you use TSK's Shiny Chance Changer?
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
Reply With Quote
  #9   Link to this post, but load the entire thread.  
Old July 6th, 2018 (5:03 AM).
gerff's Avatar
gerff gerff is offline
 
Join Date: Mar 2018
Posts: 43
Quote:
Originally Posted by BirdstarCat13 View Post
Did you use TSK's Shiny Chance Changer?
Yes...
Reply With Quote
  #10   Link to this post, but load the entire thread.  
Old July 6th, 2018 (5:25 PM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Quote:
Originally Posted by gerff View Post
Yes...
...

...

Well...that's the problem. Like I said, that's a known bug with TSK's tool.

What TSK's ShinyCC does is it writes an ASM routine into the ROM using the values you give it to set up a custom shiny chance. It doesn't "just modify the vanilla chance" like what the answers in my thread would do (however someone did bring up an ASM routine there, which happens to be identical to what ShinyCC does) so trying the vanilla fix will have absolutely no effect. You should always just use a direct hex edit with changing the shiny chance.
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
Reply With Quote
  #11   Link to this post, but load the entire thread.  
Old July 7th, 2018 (7:20 PM).
gerff's Avatar
gerff gerff is offline
 
Join Date: Mar 2018
Posts: 43
Quote:
Originally Posted by BirdstarCat13 View Post
...

...

Well...that's the problem. Like I said, that's a known bug with TSK's tool.

What TSK's ShinyCC does is it writes an ASM routine into the ROM using the values you give it to set up a custom shiny chance. It doesn't "just modify the vanilla chance" like what the answers in my thread would do (however someone did bring up an ASM routine there, which happens to be identical to what ShinyCC does) so trying the vanilla fix will have absolutely no effect. You should always just use a direct hex edit with changing the shiny chance.
Does that mean there's no fix at all? Or is there a way to restore the shiny chance back to original and then fix the offsets?
Reply With Quote
  #12   Link to this post, but load the entire thread.  
Old July 7th, 2018 (10:27 PM).
BirdstarCat13 BirdstarCat13 is offline
 
Join Date: Nov 2017
Gender: Male
Posts: 476
Quote:
Originally Posted by gerff View Post
Does that mean there's no fix at all? Or is there a way to restore the shiny chance back to original and then fix the offsets?
No fix - you have to go back to a backup befoe the change and do the hex edits to change the shiny chance.
__________________
-------------------------
I hate signatures that are just a line of text without any clear division. You weirdos know who you are ;)
Reply With Quote
Reply

Quick Reply

Join the conversation!

Create an account to post a reply in this thread, participate in other discussions, and more!

Create a PokéCommunity Account
Ad Content
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -8. The time now is 9:11 AM.