The PokéCommunity Forums  

Go Back   The PokéCommunity Forums > Fan Games > Binary ROM Hacking
Reload this Page Script Issue with National Dex & Elite Four

Notices
For all updates, view the main page.

Binary ROM Hacking Need a helping hand or just want to talk about binary ROM hacks? Get comments and answers to any ROM Hacking-related problems, questions or thoughts you have here.

Ad Content
Reply
 
Thread Tools
  #1   Link to this post, but load the entire thread.  
Old November 6th, 2019 (5:42 PM).
ExamplePrime's Avatar
ExamplePrime ExamplePrime is offline
 
Join Date: Nov 2019
Location: Mississippi, USA
Gender: Male
Posts: 8
I just started ROM hacking the end of last week and to get used to it I decided to try make a Normal Only FireRed Rom with later Gen Mons.
I added in part of an old script which I tied to a Scientist in Pallet Town to let you receive the National Dex right at the beginning. I managed to change most things I wanted to and it seemed fully functional UNTIL... I had someone test it for me.
And they couldn't get into the Elite Four.
Because Lorlei isn't there, as the post-game has been activated.

I plan to use a new base for my next attempt now I've figured out the basics but I would like to be able to fix this ROM before I move on.

I saw several comments in other threads related to the National Dex and how to switch it on by default or simply allowing Evolving without receiving the Dex: (I have a link to the thread but I can't post it as it's first post)
I don't know if that would fix the issue I'm having but I tried to implement this fix and none of the tools I've been using let me view the code in a way that lines up with what's suggested here or in another similar thread.
I could remove the entire Post-game to solve the problem but that seems an extreme solution to what is likely an easy fix.

Also add I wanted to change the in-game trades and the XSE help recommended I find a tool for that, which I haven't been able to find either. Any help with that would also be appreciated.

Tools I've been using:
Advance Map, Gen 3 Tools (Moves, Trainer, Items, Pokemon Editor & Anti-Exploud), Gen III Suite, eXtreme Script Editor, PKSV.
I downloaded HxD to see if that would let me edit the code and I still didn't find anything that lines up with the linked fix above.

TL;DR: Broke Elite 4 with NatDex triggering post-game and can't find a tool to edit in-game trades. Send help.
Reply With Quote
  #2   Link to this post, but load the entire thread.  
Old November 6th, 2019 (6:35 PM).
kalarie kalarie is offline
 
Join Date: Jun 2008
Posts: 760
You should check the scripts of the NPC's you mention with XSE. You'll see that special 0x193 is used by the female cooltrainer blocking your path (and in the level script). That special checks whether the national dex is active or not.

In conclusion, you should rewrite those scripts to make them work with what you are intending to do;)
Reply With Quote
  #3   Link to this post, but load the entire thread.  
Old November 6th, 2019 (7:06 PM).
ExamplePrime's Avatar
ExamplePrime ExamplePrime is offline
 
Join Date: Nov 2019
Location: Mississippi, USA
Gender: Male
Posts: 8
Quote:
Originally Posted by kalarie View Post
You should check the scripts of the NPC's you mention with XSE. You'll see that special 0x193 is used by the female cooltrainer blocking your path (and in the level script). That special checks whether the national dex is active or not.

In conclusion, you should rewrite those scripts to make them work with what you are intending to do;)
I did have a look and saw the script where she tells you Lorelei is gone. If I straight up delete that script so she doesn't say anything, will it affect anything in the post-game? Or will it just stop her from blocking your path?
Or will I need to test it and find out?
Reply With Quote
  #4   Link to this post, but load the entire thread.  
Old November 7th, 2019 (3:57 AM). Edited November 7th, 2019 by kalarie.
kalarie kalarie is offline
 
Join Date: Jun 2008
Posts: 760
Quote:
Originally Posted by ExamplePrime View Post
I did have a look and saw the script where she tells you Lorelei is gone. If I straight up delete that script so she doesn't say anything, will it affect anything in the post-game? Or will it just stop her from blocking your path?
Or will I need to test it and find out?
That will probably mess it up, yes. You'll have to write your own script in which the national dex won't be checked and instead you'll have to set a flag at some other point in-game to check in that cooltrainer script instead.

And also in the (type 03) level script.
Reply With Quote
  #5   Link to this post, but load the entire thread.  
Old November 7th, 2019 (12:17 PM).
ExamplePrime's Avatar
ExamplePrime ExamplePrime is offline
 
Join Date: Nov 2019
Location: Mississippi, USA
Gender: Male
Posts: 8
I used Hex Helper Double Oh to change the evolution issue, removing the National Dex being given at the start so I don't have the issue with Lorelei at all.

I'm still unsure how to access the Hex Code in the way I've seen suggested in other posts (A lot to sift through for information) so if anyone can give me advice on changing the In-Game Trades that would solve the only issue I believe I have left.
Reply With Quote
  #6   Link to this post, but load the entire thread.  
Old November 8th, 2019 (7:15 AM).
concusstimized's Avatar
concusstimized concusstimized is offline
 
Join Date: Jun 2019
Posts: 21
For what it's worth, I ran into issues with just changing the evolutions (at the very least, I couldn't get item evolutions from the national dex). So I included a national dex script and ran into the same elite four issue. This thread helped me resolve it:

https://www.reddit.com/r/PokemonROMhacks/comments/3wa2gz/fire_red_national_pokedex_without_changing_the/
Reply With Quote
  #7   Link to this post, but load the entire thread.  
Old November 8th, 2019 (8:31 AM).
kalarie kalarie is offline
 
Join Date: Jun 2008
Posts: 760
Quote:
Originally Posted by ExamplePrime View Post
I used Hex Helper Double Oh to change the evolution issue, removing the National Dex being given at the start so I don't have the issue with Lorelei at all.

I'm still unsure how to access the Hex Code in the way I've seen suggested in other posts (A lot to sift through for information) so if anyone can give me advice on changing the In-Game Trades that would solve the only issue I believe I have left.
I think PGE has a built-in program to change the in-game trades. Alternatively you could use Trader Advanced.
Reply With Quote
  #8   Link to this post, but load the entire thread.  
Old November 8th, 2019 (6:28 PM).
ExamplePrime's Avatar
ExamplePrime ExamplePrime is offline
 
Join Date: Nov 2019
Location: Mississippi, USA
Gender: Male
Posts: 8
Quote:
Originally Posted by kalarie View Post
I think PGE has a built-in program to change the in-game trades. Alternatively you could use Trader Advanced.
Every link I've found for Trader Advanced has been dead links and I don't know what PGE stands for so can't find that either. I've heard them referenced before though would you know where to look?
Reply With Quote
  #9   Link to this post, but load the entire thread.  
Old November 8th, 2019 (6:31 PM).
ExamplePrime's Avatar
ExamplePrime ExamplePrime is offline
 
Join Date: Nov 2019
Location: Mississippi, USA
Gender: Male
Posts: 8
Quote:
Originally Posted by concusstimized View Post
For what it's worth, I ran into issues with just changing the evolutions (at the very least, I couldn't get item evolutions from the national dex). So I included a national dex script and ran into the same elite four issue. This thread helped me resolve it...
Thanks for the advice I'll try this later because I would prefer it over the current method.
Reply With Quote
Reply

Quick Reply

Join the conversation!

Create an account to post a reply in this thread, participate in other discussions, and more!

Create a PokéCommunity Account
Ad Content

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -8. The time now is 9:15 AM.