The PokéCommunity Forums  

Go Back   The PokéCommunity Forums > Fan Games > Binary ROM Hacking
Reload this Page Script Pokemon Fire Red - Scripting Help Needed

Notices
For all updates, view the main page.

Binary ROM Hacking Need a helping hand or just want to talk about binary ROM hacks? Get comments and answers to any ROM Hacking-related problems, questions or thoughts you have here.

Ad Content
Reply
 
Thread Tools
  #1   Link to this post, but load the entire thread.  
Old December 29th, 2020 (7:08 AM).
JayMastro JayMastro is offline
 
Join Date: Jun 2016
Gender: Male
Posts: 11
Hello,

I am currently hacking Fire Red for the first time in a very long time and have encountered an issue while interacting with new person event's and sign posts that I have added.
I have marked this as a script issue but I think it is possible that I am messing something up on the AdvanceMap end as I had another member confirm that my script is indeed correct.

When I interact with the person event or signpost that I have assigned the new script to I can hear that interaction sound play, but nothing else happens.
The screen does not lock, the sprite does not face my player, and no dialogue box appears.

I distinctly remembering encountering this exact same issue years and years ago when I first discovered this hobby, and remember the fix being relatively simple, but am at a loss this time.

Any input would be greatly appreciated as I would like to get past this little issue and get the show on the road.

I have provided attachments of both the script as well as the compiled script that shows when opened via AdvanceMap.

Also, I have double checked to ensure that I am indeed using AdvanceMap 1.92 and FireRed v1.0.

Thank you!
Attached Images
File Type: png Capture.PNG‎ (6.8 KB, 21 views) (Save to Dropbox)
File Type: png Capture2.PNG‎ (8.2 KB, 16 views) (Save to Dropbox)
Reply With Quote
  #2   Link to this post, but load the entire thread.  
Old December 29th, 2020 (7:14 AM).
mcferaligatr's Avatar
mcferaligatr mcferaligatr is offline
 
Join Date: Nov 2018
Posts: 120
Try checking if the script offset is correct (if the script compiled well - chose the right rom in XSE to compile to), check if there are NPC's (person events) that have overlapping person event numbers and if there are change the numbers, try assigning this script to a NPC on a different map and see if that makes a difference.

Also, using save states on emulators can cause some issues if you saved on a map where you added/changed the script for the NPC, so use in game save and reset instead.
__________________
Pokemon NeonBlue:
Reply With Quote
  #3   Link to this post, but load the entire thread.  
Old December 29th, 2020 (7:23 AM).
JayMastro JayMastro is offline
 
Join Date: Jun 2016
Gender: Male
Posts: 11
Quote:
Originally Posted by mcferaligatr View Post
Try checking if the script offset is correct (if the script compiled well - chose the right rom in XSE to compile to), check if there are NPC's (person events) that have overlapping person event numbers and if there are change the numbers, try assigning this script to a NPC on a different map and see if that makes a difference.

Also, using save states on emulators can cause some issues if you saved on a map where you added/changed the script for the NPC, so use in game save and reset instead.
I have indeed tried multiple different offsets starting at 800000 so I do not think that is the issue. I am testing the event in Pallet Town, the person event number is different from Oak's, the girl in front of the sign, and the technology is great guy's so I think I am good to go in that aspect.

I have not used any save states with the ROM, so it looks like the last thing to do is test the event out on a different map like you suggested!

I will post the results of that at some point today as I am currently at work, and I really appreciate the help so far!
Reply With Quote
  #4   Link to this post, but load the entire thread.  
Old December 29th, 2020 (10:09 AM).
JayMastro JayMastro is offline
 
Join Date: Jun 2016
Gender: Male
Posts: 11
Quote:
Originally Posted by mcferaligatr View Post
Try checking if the script offset is correct (if the script compiled well - chose the right rom in XSE to compile to), check if there are NPC's (person events) that have overlapping person event numbers and if there are change the numbers, try assigning this script to a NPC on a different map and see if that makes a difference.

Also, using save states on emulators can cause some issues if you saved on a map where you added/changed the script for the NPC, so use in game save and reset instead.
I tried it on Route 1 as well but sadly I encountered the same issue.
I can hear the sound that plays during dialogue, but nothing else happens.
Reply With Quote
  #5   Link to this post, but load the entire thread.  
Old December 29th, 2020 (12:14 PM).
mcferaligatr's Avatar
mcferaligatr mcferaligatr is offline
 
Join Date: Nov 2018
Posts: 120
I had (I think) similar issue, and it only happened once. All of a sudden, XSE stopped working and whenever a script was compiled, it would ignore the rom it was compiling to. I just deleted old XSE and redownloaded a new one, so if all else fails, maybe that wouldn't be a bad idea to try out and see if it makes a difference.
__________________
Pokemon NeonBlue:
Reply With Quote
  #6   Link to this post, but load the entire thread.  
Old December 29th, 2020 (2:17 PM).
JayMastro JayMastro is offline
 
Join Date: Jun 2016
Gender: Male
Posts: 11
I tried a different XSE, sadly the issue was not fixed.
Reply With Quote
  #7   Link to this post, but load the entire thread.  
Old December 29th, 2020 (2:37 PM).
JayMastro JayMastro is offline
 
Join Date: Jun 2016
Gender: Male
Posts: 11
Quote:
Originally Posted by mcferaligatr View Post
I had (I think) similar issue, and it only happened once. All of a sudden, XSE stopped working and whenever a script was compiled, it would ignore the rom it was compiling to. I just deleted old XSE and redownloaded a new one, so if all else fails, maybe that wouldn't be a bad idea to try out and see if it makes a difference.
I installed a new AdvanceMap and when linking XSE this prompt popped up, is it possible I hit the wrong option last time? and what would the correct one be?
Attached Images
File Type: png Capture3.PNG‎ (6.6 KB, 14 views) (Save to Dropbox)
Reply With Quote
  #8   Link to this post, but load the entire thread.  
Old December 29th, 2020 (2:59 PM).
mcferaligatr's Avatar
mcferaligatr mcferaligatr is offline
 
Join Date: Nov 2018
Posts: 120
Quote:
Originally Posted by JayMastro View Post
I installed a new AdvanceMap and when linking XSE this prompt popped up, is it possible I hit the wrong option last time? and what would the correct one be?
I'm pretty sure I clicked yes every time I would set up XSE and Advance Map, but if it doesn't end up working after some trial and error, you can always reinstall and choose no.
__________________
Pokemon NeonBlue:
Reply With Quote
  #9   Link to this post, but load the entire thread.  
Old December 30th, 2020 (8:47 AM).
JayMastro JayMastro is offline
 
Join Date: Jun 2016
Gender: Male
Posts: 11
Quote:
Originally Posted by mcferaligatr View Post
I'm pretty sure I clicked yes every time I would set up XSE and Advance Map, but if it doesn't end up working after some trial and error, you can always reinstall and choose no.
I tried hitting no as well, but now I can't even see the sprite I assigned the script to when I load the rom.

This has become quite frustrating. I've had this issue since I redownloaded the tools last week and have made no progress with my hack.

I really do appreciate the help so far Mcferaligatr.

If anybody else has any suggestions or ideas I'm willing to try anything at this point.
Reply With Quote
  #10   Link to this post, but load the entire thread.  
Old December 30th, 2020 (3:49 PM).
Meister_anon~Master_o f_None Meister_anon~Master_o f_None is offline
 
Join Date: Dec 2020
Posts: 852
Quote:
Originally Posted by JayMastro View Post
I tried hitting no as well, but now I can't even see the sprite I assigned the script to when I load the rom.

This has become quite frustrating. I've had this issue since I redownloaded the tools last week and have made no progress with my hack.

I really do appreciate the help so far Mcferaligatr.

If anybody else has any suggestions or ideas I'm willing to try anything at this point.
Could this be a flag issue?
I only know theory right now, but the only thing I can come up with is a flag isn't being set or cleared which causes the npc to be hidden.
Or the wrong flag is referenced in your script causing the sound command to play but the rest of the script fails?

here, this is what I use to learn scripting.
https://www.youtube.com/watch?v=wJw4tz0kcAI&list=PLfI5DBI4tNyLBYGNhf1Ee8cgdmMtiilps&index=8

Good luck.
Reply With Quote
  #11   Link to this post, but load the entire thread.  
Old December 31st, 2020 (12:47 AM).
Asith's Avatar
Asith Asith is offline
Uwao
 
Join Date: Nov 2020
Posts: 204
Instead of creating a new NPC, could you try assigning this script offset to an NPC that already works (eg: the technology is great guy). That would help narrow down the issue.
Reply With Quote
  #12   Link to this post, but load the entire thread.  
Old December 31st, 2020 (12:54 AM).
Pyxal's Avatar
Pyxal Pyxal is offline
It's pronounced pixel.
 
Join Date: Jul 2019
Location: Pakistan
Age: 17
Posts: 987
Quote:
Originally Posted by JayMastro View Post
<snip>
I remember this being an issue as well; the fix was that I had another ROM I was compiling the script into and was putting empty offsets in the NPC's. Try selecting your ROM again in XSE, and also check whether the script is okay in the ROM by opening it in A-Map.
__________________
Reply With Quote
  #13   Link to this post, but load the entire thread.  
Old December 31st, 2020 (5:19 AM).
JayMastro JayMastro is offline
 
Join Date: Jun 2016
Gender: Male
Posts: 11
Quote:
Originally Posted by Asith View Post
Instead of creating a new NPC, could you try assigning this script offset to an NPC that already works (eg: the technology is great guy). That would help narrow down the issue.
I have indeed and sadly it didn't work, and I also but his script on the NPC, which did work.

My script is attached above, in theory everything should be working unless I'm messing something up on the Advance Map end
Reply With Quote
  #14   Link to this post, but load the entire thread.  
Old December 31st, 2020 (5:22 AM).
JayMastro JayMastro is offline
 
Join Date: Jun 2016
Gender: Male
Posts: 11
The compiled script does indeed show when opened via AdvanceMap (view attachment 2 above) which is another reason why I am confused as to why this isn't working
Reply With Quote
  #15   Link to this post, but load the entire thread.  
Old December 31st, 2020 (6:11 AM).
Anon822 Anon822 is offline
 
Join Date: Nov 2017
Posts: 326
Could you maybe post a patch of your rom?
Reply With Quote
  #16   Link to this post, but load the entire thread.  
Old December 31st, 2020 (7:23 AM).
JayMastro JayMastro is offline
 
Join Date: Jun 2016
Gender: Male
Posts: 11
Quote:
Originally Posted by Anon822 View Post
Could you maybe post a patch of your rom?
It's been a while since I had to do anything involving patching but I will figure it out and post it.
I'm at work right now but will give this a go when I get out.

Thank's for the suggestion, is this so that you, and anybody else who cares to, can troubleshoot it on your end I'm assuming?
Reply With Quote
Reply

Quick Reply

Join the conversation!

Create an account to post a reply in this thread, participate in other discussions, and more!

Create a PokéCommunity Account
Ad Content
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -8. The time now is 9:19 AM.