The PokéCommunity Forums  

Go Back   The PokéCommunity Forums > Fan Games > Binary ROM Hacking
Reload this Page Script NPC Won't Respond

Notices
For all updates, view the main page.

Binary ROM Hacking Need a helping hand or just want to talk about binary ROM hacks? Get comments and answers to any ROM Hacking-related problems, questions or thoughts you have here.

Ad Content
Reply
 
Thread Tools
  #1   Link to this post, but load the entire thread.  
Old September 13th, 2021 (5:08 PM).
JustPollux JustPollux is offline
 
Join Date: Sep 2021
Posts: 3
Hi there,

I'm brand new to ROM hacking and have learned how to do basic dialogue in XSE and map editing in AM 1.92. I'm working in Fire Red right now. Today, I tried to learn how to do the "givepokemon" command, but for some reason, whatever NPC I put it on, they just... stop responding? I'll go up to them and hit A, and they don't move or anything. Everyone else is working fine, except the NPC I want giving the Pokemon. I don't think it's a problem with the script that I wrote, as I've copied and pasted directly from tutorials I've been looking at, and it yields the same results.

The only thing I can think of is that I took away Prof. Oak stopping the player from leaving Pallet, and that somewhere in his dialogue, he triggers a flag that allows you to get a Pokemon-- one other than 0x828, because I've tested that one, too.

These are the scripts I've put in so far:

My own, which I have done ~8 or 9 variations of that haven't worked (0x2, no 0x828 flag mention, no setvar, etc):
Quote:
#dynamic 0x71D572

#org @givepokemon
lock
faceplayer
setflag 0x828
checkflag 0x100
if 0x0 goto @give
msgbox @2 0x6
release
end

#org @give
msgbox @1 0x6
setvar 0x5000 0x85
givepokemon 0x5000 0x5 0x44 0x0 0x0 0x0
setflag 0x100
end

#org @1
= We have too many Eevee! Please\ntake one off of our hands!

#org @2
= How is that Eevee doing? Are you\ntaking good care of it?
1st Tutorial one I tried, from here:
Quote:
#dynamic 0x800000
#org @givepokemon
checkflag 0x100
if 0x0 goto @give
msgbox @2 0x2
end

#org @give
msgbox @1 0x2
givepokemon 0x7B 0x5 0x44 0x0 0x0 0x0
setflag 0x100
end

#org @1
= Please take care of my SCYTHER for\nme.

#org @2
= How is my Scyther doing [player]?
2nd, from the XSE Guide:

Quote:
#dynamic 0x800000

#org @start
checkflag 0x1019
if 0x1 call @nomore
givepokemon 0x19 0x5 0x0 0x0 0x0 0x0
setflag 0x1019
end

#org @nomore
msgbox @msg 0x2
end

#org @msg
= Sorry, no more Pikachus :P
If anyone knows how I can fix this, I'd really appreciate the help. My brain is melting trying to figure this out 😭
Reply With Quote
  #2   Link to this post, but load the entire thread.  
Old September 13th, 2021 (8:03 PM).
Cameo5958 Cameo5958 is offline
 
Join Date: Sep 2021
Posts: 3
I believe the problem may be with the NPC's configuration. Just to be sure, can you tell us all the different configurations on the NPC?

(It's the info that pops up when you select the NPC in AdvanceMap.)
Reply With Quote
  #3   Link to this post, but load the entire thread.  
Old September 14th, 2021 (11:53 AM).
JustPollux JustPollux is offline
 
Join Date: Sep 2021
Posts: 3
Yeah! The top bit is set to Person event, No. 6, and then under the delete event is Person event no. 7 (which none of the other person event numbers have matched up, either). Picture number is 26, and then everything except for Position and script offset is set to 0's. His movement type is Look Down
Reply With Quote
  #4   Link to this post, but load the entire thread.  
Old September 14th, 2021 (2:06 PM).
Cameo5958 Cameo5958 is offline
 
Join Date: Sep 2021
Posts: 3
Anything that looks down should (ideally) have movement 11. You should try changing that.

Also, there may be a chance that the "Talking Level" is wrong. Maybe check if the "talking level" and the movement permission of the tile that you stand on are correct.
Reply With Quote
  #5   Link to this post, but load the entire thread.  
Old September 14th, 2021 (3:38 PM).
JustPollux JustPollux is offline
 
Join Date: Sep 2021
Posts: 3
Quote:
Originally Posted by Cameo5958 View Post
Anything that looks down should (ideally) have movement 11. You should try changing that.

Also, there may be a chance that the "Talking Level" is wrong. Maybe check if the "talking level" and the movement permission of the tile that you stand on are correct.
Ok so I tried both, and neither worked... But, I noticed that when I click on the script for that NPC, this is all that comes up:

Quote:
'---------------
#org 0x71D669
I've tried it with multiple scripts, now, and they just... don't compile?
Reply With Quote
  #6   Link to this post, but load the entire thread.  
Old September 15th, 2021 (2:31 AM).
Mahian23's Avatar
Mahian23 Mahian23 is offline
Behold my Supreme Power!
 
Join Date: Mar 2020
Location: Asia
Gender: Male
Nature: Brave
Posts: 458
Did you put the correct offset on the NPC?Can you make a video or atleast some screenshots so we can learn your actual problem and solve it. and did you put the var value correctly in A-Map?I don't think you're using a safe var number!
__________________
Winning an arguement with an intellegent person might be hard,but winning one with a dumb person is impossible.


Name: Greninja
Reply With Quote
  #7   Link to this post, but load the entire thread.  
Old September 15th, 2021 (12:08 PM). Edited September 15th, 2021 by Asith.
Asith's Avatar
Asith Asith is offline
Uwao
 
Join Date: Nov 2020
Posts: 204
Quote:
Originally Posted by JustPollux View Post
Ok so I tried both, and neither worked... But, I noticed that when I click on the script for that NPC, this is all that comes up:

I've tried it with multiple scripts, now, and they just... don't compile?
1) Write a script in XSE
2) Press compile
3) XSE gives a dialog box on successful completion, with offsets for all your dynamic (@) labels. Copy the first one (just press the "copy" button right there in the dialog box)
4) Paste that offset into the NPC script offset box in advance map and hit save.

If the NPC script is still empty when you open it like you showed above, then there's a mismatch between what XSE is doing and what AMap is doing. It may seem stupid, but please make sure that both programs are accessing the same ROM. It's an easy mistake to have one accidentally be opening a backup or different ROM copy.
Reply With Quote
Reply

Quick Reply

Join the conversation!

Create an account to post a reply in this thread, participate in other discussions, and more!

Create a PokéCommunity Account
Ad Content
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -8. The time now is 9:16 AM.