The PokéCommunity Forums  

Go Back   The PokéCommunity Forums > Fan Games > Binary ROM Hacking
Reload this Page Script Pokemon emerald, tried changing dialogue in the pokemon catching tutorial and now the game soflocks

Notices
For all updates, view the main page.

Binary ROM Hacking Need a helping hand or just want to talk about binary ROM hacks? Get comments and answers to any ROM Hacking-related problems, questions or thoughts you have here.

Ad Content
Reply
 
Thread Tools
  #1   Link to this post, but load the entire thread.  
Old November 8th, 2021 (12:42 PM).
fat pepol fat pepol is offline
 
Join Date: Nov 2021
Posts: 4
i opened the script through the gym leader person event in the petalburg gym in advanced map
and then i changed some of the text in the msg boxes and i hit compile
and then when i booted up the game, wally just doesnt show up and the game wont let you out of petalburg.

i did a backup save of the rom first so i can fix, but whats like the correct way to edit the text so that doesnt happen?
Reply With Quote
  #2   Link to this post, but load the entire thread.  
Old November 8th, 2021 (2:10 PM).
kalarie kalarie is offline
 
Join Date: Jun 2008
Posts: 760
@fat pepol

Check a scripting tutorial like Avara's XSE Scripting Tutorials or Anthroyd's Gen III ROM Hacking Video Tutorials on Youtube. The part about dynamic offsets is what you should particularly look for.

If you work like the way you described, chances are you will overwrite other data. You need to implement your changes in free space.
Reply With Quote
  #3   Link to this post, but load the entire thread.  
Old November 8th, 2021 (3:12 PM).
fat pepol fat pepol is offline
 
Join Date: Nov 2021
Posts: 4
ok, so i tried copying the entire script and then doing #dyn 0x800000 at the top, changing the name of the main script to @start, then changing the text in the msg boxes at the bottom and replacing the offset in advanced map with what i got when i compiled the new script, and i still got the same result.

so i dont THINK overwriting other data is the issue?
Reply With Quote
  #4   Link to this post, but load the entire thread.  
Old November 8th, 2021 (3:36 PM).
kalarie kalarie is offline
 
Join Date: Jun 2008
Posts: 760
@fat pepol

You need to change every string of the script to a dynamic offset (like @message1) instead of a static one (like 0xXXXXXX). Not only the main string.
Reply With Quote
  #5   Link to this post, but load the entire thread.  
Old November 8th, 2021 (4:29 PM).
fat pepol fat pepol is offline
 
Join Date: Nov 2021
Posts: 4
i went through the entire script and replaced every part of the script that was declared like this "#org 0xXXXXXXX" with something like "#org @1" or "#org @2" and so on, making sure i used a new @name every time i replaced another part of the script that was like that.

and i still get the same issue unfortunately.
Reply With Quote
  #6   Link to this post, but load the entire thread.  
Old November 9th, 2021 (1:02 AM).
Asith's Avatar
Asith Asith is offline
Uwao
 
Join Date: Nov 2020
Posts: 204
Would help if you post the script here.
Also when testing script changes, things get messy if you try to load up a saved game with the event already loaded. Try using a save from a different map, and then head to the event
__________________
Spectrobes, anyone?
Reply With Quote
  #7   Link to this post, but load the entire thread.  
Old November 9th, 2021 (7:02 AM). Edited November 9th, 2021 by fat pepol.
fat pepol fat pepol is offline
 
Join Date: Nov 2021
Posts: 4
the scripts are pretty long so im gonna upload them to a file sharing site, and not just post them here directly. https://ufile.io/f/g141k
the only changes i did that wherent just switching a 0xXXXXX name for a @name, are some changes to a msg box i did at line 911 and 374

thanks for being patient with me btw.
Reply With Quote
Reply

Quick Reply

Join the conversation!

Create an account to post a reply in this thread, participate in other discussions, and more!

Create a PokéCommunity Account
Ad Content
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -8. The time now is 9:20 AM.