[Other✓] Nasty Nicknaming Crash Bug

[CloverCamerupt]

My team has recently discovered a major bug in our hack Pokemon Clover's newer builds:

Big image inside:

Spoiler:

This nasty, glitchy crash screen is what happens when you try to nickname a caught pokemon, then send it to the PC when you already have 6 pokemon in your party.

We have previously had issues with that bit of text in our demo version and we think the crash may be related to that.

What can we do? This looks like it might need an ASM wizard to fix, and any help would be greatly obliged.

 

[PurpleOrange]

My team has recently discovered a major bug in our hack Pokemon Clover's newer builds:

Big image inside:

Spoiler:

This nasty, glitchy crash screen is what happens when you try to nickname a caught pokemon, then send it to the PC when you already have 6 pokemon in your party.

We have previously had issues with that bit of text in our demo version and we think the crash may be related to that.

What can we do? This looks like it might need an ASM wizard to fix, and any help would be greatly obliged.

looks like you've over written some tiles somewhere, or maybe the special used in it the script has been corrupted, not too sure

 

[CloverCamerupt]

looks like you've over written some tiles somewhere, or maybe the special used in it the script has been corrupted, not too sure

It's not a graphical error, the crash occurs after clicking Ok on the nickname, hence the idea that the error is coming from the bit of text about sending the pokemon to the PC.

Here is the messed up bit of text in question, seen when you send a pokemon to the PC without nicknaming it:

Spoiler:

Now this issue does have a source that we can trace back: a botched script editing of the Magikarp Salesman at the route 4 Pokemon Center. If you have any idea on how to possible fix this, mabye by just putting the original script for that NPC back in it's right place along with the "Sent to box" script that was included with him, please tell us.

 

[PurpleOrange]

It's not a graphical error, the crash occurs after clicking Ok on the nickname, hence the idea that the error is coming from the bit of text about sending the pokemon to the PC.

Here is the messed up bit of text in question, seen when you send a pokemon to the PC without nicknaming it:

Spoiler:

Now this issue does have a source that we can trace back: a botched script editing of the Magikarp Salesman at the route 4 Pokemon Center. If you have any idea on how to possible fix this, mabye by just putting the original script for that NPC back in it's right place along with the "Sent to box" script that was included with him, please tell us.

the screenshot seems to show that you've botched up the buffereing of the box name, do you mind posting the script? than maybe we can figure it out

 

[CloverCamerupt]

the screenshot seems to show that you've botched up the buffereing of the box name, do you mind posting the script? than maybe we can figure it out

Sure

Here is The Botched edited version from Clover:

Spoiler:

'---------------
#org 0x16F75F
lock
faceplayer
checkflag 0x249
if 0x1 goto 0x816F8A2
showmoney 0x0 0x0 0x0
checkgender
compare LASTRESULT 0x0
if 0x1 goto 0x816F786
compare LASTRESULT 0x1
if 0x1 goto 0x816F794
end

'---------------
#org 0x16F8A2
msgbox 0x819DC9A MSG_KEEPOPEN '"Man: Well, I don't give refunds.\n..."
release
end

'---------------
#org 0x16F786
msgbox 0x819DA9A MSG_YESNO '"Man: Hello there, laddie!\nHave I ..."
goto 0x816F7A2

'---------------
#org 0x16F794
msgbox 0x819DB34 MSG_YESNO '"Man: Hello there, sweetie pie!\nHa..."
goto 0x816F7A2

'---------------
#org 0x16F7A2
compare LASTRESULT 0x0
if 0x1 goto 0x816F888
checkmoney 0x1F4 0x0
compare LASTRESULT 0x0
if 0x1 goto 0x816F895
textcolor 0x3
setvar 0x4001 0x81
givepokemon 0x29 0x5 0x0 0x0 0x0 0x0
compare LASTRESULT 0x0
if 0x1 goto 0x816F7F6
compare LASTRESULT 0x1
if 0x1 goto 0x816F822
compare LASTRESULT 0x2
if 0x1 goto 0x816F8AC
end

'---------------
#org 0x16F888
msgbox 0x819DC07 MSG_KEEPOPEN '"No? You say no? I'm only doing thi..."
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F895
msgbox 0x819DC78 MSG_KEEPOPEN '"You'll need more money than that!"
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F7F6
call 0x816F86F
msgbox 0x81A56A7 MSG_YESNO '"Do you want to give a nickname to\..."
compare LASTRESULT 0x0
if 0x1 goto 0x816F861
call 0x81A8C27
fadescreen 0x1
hidemoney 0x0 0x0
special 0x9E
waitstate
goto 0x816F86A

'---------------
#org 0x16F822
call 0x816F86F
msgbox 0x81A56A7 MSG_YESNO '"Do you want to give a nickname to\..."
compare LASTRESULT 0x0
if 0x1 goto 0x816F84B
fadescreen 0x1
hidemoney 0x0 0x0
special 0x166
waitstate
lock
faceplayer
goto 0x816F856

'---------------
#org 0x16F8AC
textcolor 0x0
msgbox 0x819DC3E MSG_KEEPOPEN '"There's no more room for any more\..."
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F86F
paymoney 0x1F4 0x0
updatemoney 0x0 0x0 0x0
fanfare 0x101
preparemsg 0x819DBD3 '"[player] took the Troubait[.]"
waitmsg
waitfanfare
bufferpokemon 0x0 0x81
return

'---------------
#org 0x16F861
hidemoney 0x0 0x0
goto 0x816F86A

'---------------
#org 0x1A8C27
countpokemon
subvar LASTRESULT 0x1
copyvar 0x8004 LASTRESULT
return

'---------------
#org 0x16F86A
setflag 0x249
release
end

'---------------
#org 0x16F84B
call 0x81A8C3C
goto 0x816F861

'---------------
#org 0x16F856
call 0x81A8C3C
goto 0x816F86A

'---------------
#org 0x1A8C3C
bufferboxname 0x0 0x4037
bufferpokemon 0x1 0x4001
checkflag 0x834
if 0x0 call 0x81A8C57
checkflag 0x834
if 0x1 call 0x81A8C82
return

'---------------
#org 0x1A8C57
special2 LASTRESULT 0x165
compare LASTRESULT 0x1
if 0x1 goto 0x81A8C70
msgbox 0x81A5CF1 MSG_KEEPOPEN '"Troubait was transferred to\nSomeo..."
return

'---------------
#org 0x1A8C82
special2 LASTRESULT 0x165
compare LASTRESULT 0x1
if 0x1 goto 0x81A8C9B
msgbox 0x81A5D31 MSG_KEEPOPEN '"Troubait was transferred to\nBill'..."
return

'---------------
#org 0x1A8C70
special2 LASTRESULT 0x18A
bufferboxname 0x2 LASTRESULT
msgbox 0x81A5D6E MSG_KEEPOPEN '"Box ["][buffer3]" on\nSomeone's PC..."
return

'---------------
#org 0x1A8C9B
special2 LASTRESULT 0x18A
bufferboxname 0x2 LASTRESULT
msgbox 0x81A5DB1 MSG_KEEPOPEN '"Box ["][buffer3]" on\nBill'S PC wa..."
return


'---------
' Strings
'---------
#org 0x19DC9A
= Man: Well, I don't give refunds.\nYou knew what you were getting!

#org 0x19DA9A
= Man: Hello there, laddie!\nHave I got a deal just for you!\pI'll let you have a secret Pokémon\n- a Troubait - for just [$]500!\pSo, you'll buy it, am I right?

#org 0x19DB34
= Man: Hello there, sweetie pie!\nHave I got a deal just for you!\pI'll let you have a secret Pokémon\n- a Troubait - for just [$]500!\pSo, you'll buy it, am I right?

#org 0x19DC07
= No? You say no? I'm only doing this\nas a favor to you!

#org 0x19DC78
= You'll need more money than that!

#org 0x1A56A7
= Do you want to give a nickname to\nthis [buffer1]?

#org 0x19DC3E
= There's no more room for any more\nPokémon, it looks like.

#org 0x19DBD3
= [player] took the Troubait[.]

#org 0x1A5CF1
= Troubait was transferred to\nSomeone's PC.\pIt was placed in \nBox Troubait was transferred to\nBill'S PC.\pIt was placed in \nBox Box ["][buffer3]" on\nSomeone's PC was full.\pTroubait was transferred to\nBox Box ["][buffer3]" on\nBill'S PC was full.\pTroubait was transferred to\nBox ["][buffer1]."

#org 0x1A5D31
= Troubait was transferred to\nBill'S PC.\pIt was placed in \nBox Box ["][buffer3]" on\nSomeone's PC was full.\pTroubait was transferred to\nBox Box ["][buffer3]" on\nBill'S PC was full.\pTroubait was transferred to\nBox ["][buffer1]."

#org 0x1A5D6E
= Box ["][buffer3]" on\nSomeone's PC was full.\pTroubait was transferred to\nBox Box ["][buffer3]" on\nBill'S PC was full.\pTroubait was transferred to\nBox ["][buffer1]."

#org 0x1A5DB1
= Box ["][buffer3]" on\nBill'S PC was full.\pTroubait was transferred to\nBox ["][buffer1]."

Now to compare, here is the original version of that script from vanilla Firered:

Spoiler:

'---------------
#org 0x16F75F
lock
faceplayer
checkflag 0x249
if 0x1 goto 0x816F8A2
showmoney 0x0 0x0 0x0
checkgender
compare LASTRESULT 0x0
if 0x1 goto 0x816F786
compare LASTRESULT 0x1
if 0x1 goto 0x816F794
end

'---------------
#org 0x16F8A2
msgbox 0x819DC9A MSG_KEEPOPEN '"MAN: Well, I don't give refunds.\n..."
release
end

'---------------
#org 0x16F786
msgbox 0x819DA9A MSG_YESNO '"MAN: Hello there, laddie!\nHave I ..."
goto 0x816F7A2

'---------------
#org 0x16F794
msgbox 0x819DB34 MSG_YESNO '"MAN: Hello there, sweetie pie!\nHa..."
goto 0x816F7A2

'---------------
#org 0x16F7A2
compare LASTRESULT 0x0
if 0x1 goto 0x816F888
checkmoney 0x1F4 0x0
compare LASTRESULT 0x0
if 0x1 goto 0x816F895
textcolor 0x3
setvar 0x4001 0x81
givepokemon 0x81 0x5 0x0 0x0 0x0 0x0
compare LASTRESULT 0x0
if 0x1 goto 0x816F7F6
compare LASTRESULT 0x1
if 0x1 goto 0x816F822
compare LASTRESULT 0x2
if 0x1 goto 0x816F8AC
end

'---------------
#org 0x16F888
msgbox 0x819DC07 MSG_KEEPOPEN '"No? You say no? I'm only doing thi..."
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F895
msgbox 0x819DC78 MSG_KEEPOPEN '"You'll need more money than that!"
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F7F6
call 0x816F86F
msgbox 0x81A56A7 MSG_YESNO '"Do you want to give a nickname to\..."
compare LASTRESULT 0x0
if 0x1 goto 0x816F861
call 0x81A8C27
fadescreen 0x1
hidemoney 0x0 0x0
special 0x9E
waitstate
goto 0x816F86A

'---------------
#org 0x16F822
call 0x816F86F
msgbox 0x81A56A7 MSG_YESNO '"Do you want to give a nickname to\..."
compare LASTRESULT 0x0
if 0x1 goto 0x816F84B
fadescreen 0x1
hidemoney 0x0 0x0
special 0x166
waitstate
lock
faceplayer
goto 0x816F856

'---------------
#org 0x16F8AC
textcolor 0x0
msgbox 0x819DC3E MSG_KEEPOPEN '"There's no more room for any more\..."
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F86F
paymoney 0x1F4 0x0
updatemoney 0x0 0x0 0x0
fanfare 0x101
preparemsg 0x819DBD3 '"[player] paid an outrageous [$]500..."
waitmsg
waitfanfare
bufferpokemon 0x0 0x81
return

'---------------
#org 0x16F861
hidemoney 0x0 0x0
goto 0x816F86A

'---------------
#org 0x1A8C27
countpokemon
subvar LASTRESULT 0x1
copyvar 0x8004 LASTRESULT
return

'---------------
#org 0x16F86A
setflag 0x249
release
end

'---------------
#org 0x16F84B
call 0x81A8C3C
goto 0x816F861

'---------------
#org 0x16F856
call 0x81A8C3C
goto 0x816F86A

'---------------
#org 0x1A8C3C
bufferboxname 0x0 0x4037
bufferpokemon 0x1 0x4001
checkflag 0x834
if 0x0 call 0x81A8C57
checkflag 0x834
if 0x1 call 0x81A8C82
return

'---------------
#org 0x1A8C57
special2 LASTRESULT 0x165
compare LASTRESULT 0x1
if 0x1 goto 0x81A8C70
msgbox 0x81A5CF1 MSG_KEEPOPEN '"[buffer2] was transferred to\nSome..."
return

'---------------
#org 0x1A8C82
special2 LASTRESULT 0x165
compare LASTRESULT 0x1
if 0x1 goto 0x81A8C9B
msgbox 0x81A5D31 MSG_KEEPOPEN '"[buffer2] was transferred to\nBILL..."
return

'---------------
#org 0x1A8C70
special2 LASTRESULT 0x18A
bufferboxname 0x2 LASTRESULT
msgbox 0x81A5D6E MSG_KEEPOPEN '"BOX ["][buffer3]" on\nSomeone's PC..."
return

'---------------
#org 0x1A8C9B
special2 LASTRESULT 0x18A
bufferboxname 0x2 LASTRESULT
msgbox 0x81A5DB1 MSG_KEEPOPEN '"BOX ["][buffer3]" on\nBILL'S PC wa..."
return


'---------
' Strings
'---------
#org 0x19DC9A
= MAN: Well, I don't give refunds.\nYou knew what you were getting!

#org 0x19DA9A
= MAN: Hello there, laddie!\nHave I got a deal just for you!\pI'll let you have a secret POKéMON\n- a MAGIKARP - for just [$]500!\pSo, you'll buy it, am I right?

#org 0x19DB34
= MAN: Hello there, sweetie pie!\nHave I got a deal just for you!\pI'll let you have a secret POKéMON\n- a MAGIKARP - for just [$]500!\pSo, you'll buy it, am I right?

#org 0x19DC07
= No? You say no? I'm only doing this\nas a favor to you!

#org 0x19DC78
= You'll need more money than that!

#org 0x1A56A7
= Do you want to give a nickname to\nthis [buffer1]?

#org 0x19DC3E
= There's no more room for any more\nPOKéMON, it looks like.

#org 0x19DBD3
= [player] paid an outrageous [$]500\nand bought the MAGIKARP[.]

#org 0x1A5CF1
= [buffer2] was transferred to\nSomeone's PC.\pIt was placed in \nBOX ["][buffer1]."

#org 0x1A5D31
= [buffer2] was transferred to\nBILL'S PC.\pIt was placed in \nBOX ["][buffer1]."

#org 0x1A5D6E
= BOX ["][buffer3]" on\nSomeone's PC was full.\p[buffer2] was transferred to\nBOX ["][buffer1]."

#org 0x1A5DB1
= BOX ["][buffer3]" on\nBILL'S PC was full.\p[buffer2] was transferred to\nBOX ["][buffer1]."

The guy who edited the script fugged with the box sent text buffers that are apparently used elsewhere besides this little Troubait (Magikarp) event.

 

[PurpleOrange]

Sure

Here is The Botched edited version from Clover:

Spoiler:

'---------------
#org 0x16F75F
lock
faceplayer
checkflag 0x249
if 0x1 goto 0x816F8A2
showmoney 0x0 0x0 0x0
checkgender
compare LASTRESULT 0x0
if 0x1 goto 0x816F786
compare LASTRESULT 0x1
if 0x1 goto 0x816F794
end

'---------------
#org 0x16F8A2
msgbox 0x819DC9A MSG_KEEPOPEN '"Man: Well, I don't give refunds.\n..."
release
end

'---------------
#org 0x16F786
msgbox 0x819DA9A MSG_YESNO '"Man: Hello there, laddie!\nHave I ..."
goto 0x816F7A2

'---------------
#org 0x16F794
msgbox 0x819DB34 MSG_YESNO '"Man: Hello there, sweetie pie!\nHa..."
goto 0x816F7A2

'---------------
#org 0x16F7A2
compare LASTRESULT 0x0
if 0x1 goto 0x816F888
checkmoney 0x1F4 0x0
compare LASTRESULT 0x0
if 0x1 goto 0x816F895
textcolor 0x3
setvar 0x4001 0x81
givepokemon 0x29 0x5 0x0 0x0 0x0 0x0
compare LASTRESULT 0x0
if 0x1 goto 0x816F7F6
compare LASTRESULT 0x1
if 0x1 goto 0x816F822
compare LASTRESULT 0x2
if 0x1 goto 0x816F8AC
end

'---------------
#org 0x16F888
msgbox 0x819DC07 MSG_KEEPOPEN '"No? You say no? I'm only doing thi..."
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F895
msgbox 0x819DC78 MSG_KEEPOPEN '"You'll need more money than that!"
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F7F6
call 0x816F86F
msgbox 0x81A56A7 MSG_YESNO '"Do you want to give a nickname to\..."
compare LASTRESULT 0x0
if 0x1 goto 0x816F861
call 0x81A8C27
fadescreen 0x1
hidemoney 0x0 0x0
special 0x9E
waitstate
goto 0x816F86A

'---------------
#org 0x16F822
call 0x816F86F
msgbox 0x81A56A7 MSG_YESNO '"Do you want to give a nickname to\..."
compare LASTRESULT 0x0
if 0x1 goto 0x816F84B
fadescreen 0x1
hidemoney 0x0 0x0
special 0x166
waitstate
lock
faceplayer
goto 0x816F856

'---------------
#org 0x16F8AC
textcolor 0x0
msgbox 0x819DC3E MSG_KEEPOPEN '"There's no more room for any more\..."
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F86F
paymoney 0x1F4 0x0
updatemoney 0x0 0x0 0x0
fanfare 0x101
preparemsg 0x819DBD3 '"[player] took the Troubait[.]"
waitmsg
waitfanfare
bufferpokemon 0x0 0x81
return

'---------------
#org 0x16F861
hidemoney 0x0 0x0
goto 0x816F86A

'---------------
#org 0x1A8C27
countpokemon
subvar LASTRESULT 0x1
copyvar 0x8004 LASTRESULT
return

'---------------
#org 0x16F86A
setflag 0x249
release
end

'---------------
#org 0x16F84B
call 0x81A8C3C
goto 0x816F861

'---------------
#org 0x16F856
call 0x81A8C3C
goto 0x816F86A

'---------------
#org 0x1A8C3C
bufferboxname 0x0 0x4037
bufferpokemon 0x1 0x4001
checkflag 0x834
if 0x0 call 0x81A8C57
checkflag 0x834
if 0x1 call 0x81A8C82
return

'---------------
#org 0x1A8C57
special2 LASTRESULT 0x165
compare LASTRESULT 0x1
if 0x1 goto 0x81A8C70
msgbox 0x81A5CF1 MSG_KEEPOPEN '"Troubait was transferred to\nSomeo..."
return

'---------------
#org 0x1A8C82
special2 LASTRESULT 0x165
compare LASTRESULT 0x1
if 0x1 goto 0x81A8C9B
msgbox 0x81A5D31 MSG_KEEPOPEN '"Troubait was transferred to\nBill'..."
return

'---------------
#org 0x1A8C70
special2 LASTRESULT 0x18A
bufferboxname 0x2 LASTRESULT
msgbox 0x81A5D6E MSG_KEEPOPEN '"Box ["][buffer3]" on\nSomeone's PC..."
return

'---------------
#org 0x1A8C9B
special2 LASTRESULT 0x18A
bufferboxname 0x2 LASTRESULT
msgbox 0x81A5DB1 MSG_KEEPOPEN '"Box ["][buffer3]" on\nBill'S PC wa..."
return


'---------
' Strings
'---------
#org 0x19DC9A
= Man: Well, I don't give refunds.\nYou knew what you were getting!

#org 0x19DA9A
= Man: Hello there, laddie!\nHave I got a deal just for you!\pI'll let you have a secret Pokémon\n- a Troubait - for just [$]500!\pSo, you'll buy it, am I right?

#org 0x19DB34
= Man: Hello there, sweetie pie!\nHave I got a deal just for you!\pI'll let you have a secret Pokémon\n- a Troubait - for just [$]500!\pSo, you'll buy it, am I right?

#org 0x19DC07
= No? You say no? I'm only doing this\nas a favor to you!

#org 0x19DC78
= You'll need more money than that!

#org 0x1A56A7
= Do you want to give a nickname to\nthis [buffer1]?

#org 0x19DC3E
= There's no more room for any more\nPokémon, it looks like.

#org 0x19DBD3
= [player] took the Troubait[.]

#org 0x1A5CF1
= Troubait was transferred to\nSomeone's PC.\pIt was placed in \nBox Troubait was transferred to\nBill'S PC.\pIt was placed in \nBox Box ["][buffer3]" on\nSomeone's PC was full.\pTroubait was transferred to\nBox Box ["][buffer3]" on\nBill'S PC was full.\pTroubait was transferred to\nBox ["][buffer1]."

#org 0x1A5D31
= Troubait was transferred to\nBill'S PC.\pIt was placed in \nBox Box ["][buffer3]" on\nSomeone's PC was full.\pTroubait was transferred to\nBox Box ["][buffer3]" on\nBill'S PC was full.\pTroubait was transferred to\nBox ["][buffer1]."

#org 0x1A5D6E
= Box ["][buffer3]" on\nSomeone's PC was full.\pTroubait was transferred to\nBox Box ["][buffer3]" on\nBill'S PC was full.\pTroubait was transferred to\nBox ["][buffer1]."

#org 0x1A5DB1
= Box ["][buffer3]" on\nBill'S PC was full.\pTroubait was transferred to\nBox ["][buffer1]."

Now to compare, here is the original version of that script from vanilla Firered:

Spoiler:

'---------------
#org 0x16F75F
lock
faceplayer
checkflag 0x249
if 0x1 goto 0x816F8A2
showmoney 0x0 0x0 0x0
checkgender
compare LASTRESULT 0x0
if 0x1 goto 0x816F786
compare LASTRESULT 0x1
if 0x1 goto 0x816F794
end

'---------------
#org 0x16F8A2
msgbox 0x819DC9A MSG_KEEPOPEN '"MAN: Well, I don't give refunds.\n..."
release
end

'---------------
#org 0x16F786
msgbox 0x819DA9A MSG_YESNO '"MAN: Hello there, laddie!\nHave I ..."
goto 0x816F7A2

'---------------
#org 0x16F794
msgbox 0x819DB34 MSG_YESNO '"MAN: Hello there, sweetie pie!\nHa..."
goto 0x816F7A2

'---------------
#org 0x16F7A2
compare LASTRESULT 0x0
if 0x1 goto 0x816F888
checkmoney 0x1F4 0x0
compare LASTRESULT 0x0
if 0x1 goto 0x816F895
textcolor 0x3
setvar 0x4001 0x81
givepokemon 0x81 0x5 0x0 0x0 0x0 0x0
compare LASTRESULT 0x0
if 0x1 goto 0x816F7F6
compare LASTRESULT 0x1
if 0x1 goto 0x816F822
compare LASTRESULT 0x2
if 0x1 goto 0x816F8AC
end

'---------------
#org 0x16F888
msgbox 0x819DC07 MSG_KEEPOPEN '"No? You say no? I'm only doing thi..."
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F895
msgbox 0x819DC78 MSG_KEEPOPEN '"You'll need more money than that!"
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F7F6
call 0x816F86F
msgbox 0x81A56A7 MSG_YESNO '"Do you want to give a nickname to\..."
compare LASTRESULT 0x0
if 0x1 goto 0x816F861
call 0x81A8C27
fadescreen 0x1
hidemoney 0x0 0x0
special 0x9E
waitstate
goto 0x816F86A

'---------------
#org 0x16F822
call 0x816F86F
msgbox 0x81A56A7 MSG_YESNO '"Do you want to give a nickname to\..."
compare LASTRESULT 0x0
if 0x1 goto 0x816F84B
fadescreen 0x1
hidemoney 0x0 0x0
special 0x166
waitstate
lock
faceplayer
goto 0x816F856

'---------------
#org 0x16F8AC
textcolor 0x0
msgbox 0x819DC3E MSG_KEEPOPEN '"There's no more room for any more\..."
hidemoney 0x0 0x0
release
end

'---------------
#org 0x16F86F
paymoney 0x1F4 0x0
updatemoney 0x0 0x0 0x0
fanfare 0x101
preparemsg 0x819DBD3 '"[player] paid an outrageous [$]500..."
waitmsg
waitfanfare
bufferpokemon 0x0 0x81
return

'---------------
#org 0x16F861
hidemoney 0x0 0x0
goto 0x816F86A

'---------------
#org 0x1A8C27
countpokemon
subvar LASTRESULT 0x1
copyvar 0x8004 LASTRESULT
return

'---------------
#org 0x16F86A
setflag 0x249
release
end

'---------------
#org 0x16F84B
call 0x81A8C3C
goto 0x816F861

'---------------
#org 0x16F856
call 0x81A8C3C
goto 0x816F86A

'---------------
#org 0x1A8C3C
bufferboxname 0x0 0x4037
bufferpokemon 0x1 0x4001
checkflag 0x834
if 0x0 call 0x81A8C57
checkflag 0x834
if 0x1 call 0x81A8C82
return

'---------------
#org 0x1A8C57
special2 LASTRESULT 0x165
compare LASTRESULT 0x1
if 0x1 goto 0x81A8C70
msgbox 0x81A5CF1 MSG_KEEPOPEN '"[buffer2] was transferred to\nSome..."
return

'---------------
#org 0x1A8C82
special2 LASTRESULT 0x165
compare LASTRESULT 0x1
if 0x1 goto 0x81A8C9B
msgbox 0x81A5D31 MSG_KEEPOPEN '"[buffer2] was transferred to\nBILL..."
return

'---------------
#org 0x1A8C70
special2 LASTRESULT 0x18A
bufferboxname 0x2 LASTRESULT
msgbox 0x81A5D6E MSG_KEEPOPEN '"BOX ["][buffer3]" on\nSomeone's PC..."
return

'---------------
#org 0x1A8C9B
special2 LASTRESULT 0x18A
bufferboxname 0x2 LASTRESULT
msgbox 0x81A5DB1 MSG_KEEPOPEN '"BOX ["][buffer3]" on\nBILL'S PC wa..."
return


'---------
' Strings
'---------
#org 0x19DC9A
= MAN: Well, I don't give refunds.\nYou knew what you were getting!

#org 0x19DA9A
= MAN: Hello there, laddie!\nHave I got a deal just for you!\pI'll let you have a secret POKéMON\n- a MAGIKARP - for just [$]500!\pSo, you'll buy it, am I right?

#org 0x19DB34
= MAN: Hello there, sweetie pie!\nHave I got a deal just for you!\pI'll let you have a secret POKéMON\n- a MAGIKARP - for just [$]500!\pSo, you'll buy it, am I right?

#org 0x19DC07
= No? You say no? I'm only doing this\nas a favor to you!

#org 0x19DC78
= You'll need more money than that!

#org 0x1A56A7
= Do you want to give a nickname to\nthis [buffer1]?

#org 0x19DC3E
= There's no more room for any more\nPOKéMON, it looks like.

#org 0x19DBD3
= [player] paid an outrageous [$]500\nand bought the MAGIKARP[.]

#org 0x1A5CF1
= [buffer2] was transferred to\nSomeone's PC.\pIt was placed in \nBOX ["][buffer1]."

#org 0x1A5D31
= [buffer2] was transferred to\nBILL'S PC.\pIt was placed in \nBOX ["][buffer1]."

#org 0x1A5D6E
= BOX ["][buffer3]" on\nSomeone's PC was full.\p[buffer2] was transferred to\nBOX ["][buffer1]."

#org 0x1A5DB1
= BOX ["][buffer3]" on\nBILL'S PC was full.\p[buffer2] was transferred to\nBOX ["][buffer1]."

The guy who edited the script fugged with the box sent text buffers that are apparently used elsewhere besides this little Troubait (Magikarp) event.

found your problem, the text at 0x1A5CF1, 0x1A5D6E and 0x1A5D6E is completely f*****. it was probably a better idea to repoint the text scripts rather than editing them, it's overwritten other stuff and caused it to go into a mess

 

[CloverCamerupt]

found your problem, the text at 0x1A5CF1, 0x1A5D6E and 0x1A5D6E is completely f*****. it was probably a better idea to repoint the text scripts rather than editing them, it's overwritten other stuff and caused it to go into a mess

In that case can i fix the bug by simply bringing back the old version of the script from Firered? If the original text is put back it should re-overwrite everything back into place yes?

 

[PurpleOrange]

In that case can i fix the bug by simply bringing back the old version of the script from Firered? If the original text is put back it should re-overwrite everything back into place yes?

yes but best do it by hex, type this at 0x1A5CF1 in a hex editor

Spoiler:

FD 03 00 EB D5 E7 00 E8 E6 D5 E2 E7 DA D9 E6 E6 D9 D8 00 E8 E3 FE CD E3 E1 D9 E3 E2 D9 B4 E7 00 CA BD AD FB C3 E8 00 EB D5 E7 00 E4 E0 D5 D7 D9 D8 00 DD E2 00 FE BC C9 D2 00 B1 FD 02 AD B2 FF FD 03 00 EB D5 E7 00 E8 E6 D5 E2 E7 DA D9 E6 E6 D9 D8 00 E8 E3 FE BC C3 C6 C6 B4 CD 00 CA BD AD FB C3 E8 00 EB D5 E7 00 E4 E0 D5 D7 D9 D8 00 DD E2 00 FE BC C9 D2 00 B1 FD 02 AD B2 FF BC C9 D2 00 B1 FD 04 B2 00 E3 E2 FE CD E3 E1 D9 E3 E2 D9 B4 E7 00 CA BD 00 EB D5 E7 00 DA E9 E0 E0 AD FB FD 03 00 EB D5 E7 00 E8 E6 D5 E2 E7 DA D9 E6 E6 D9 D8 00 E8 E3 FE BC C9 D2 00 B1 FD 02 AD B2 FF BC C9 D2 00 B1 FD 04 B2 00 E3 E2 FE BC C3 C6 C6 B4 CD 00 CA BD 00 EB D5 E7 00 DA E9 E0 E0 AD FB FD 03 00 EB D5 E7 00 E8 E6 D5 E2 E7 DA D9 E6 E6 D9 D8 00 E8 E3 FE BC C9 D2 00 B1 FD 02 AD B2 FF FD 01 00

this should fix the text errors, and hopefully fix the script overrunning into other stuff

 

[CloverCamerupt]

yes but best do it by hex, type this at 0x1A5CF1 in a hex editor

Spoiler:

FD 03 00 EB D5 E7 00 E8 E6 D5 E2 E7 DA D9 E6 E6 D9 D8 00 E8 E3 FE CD E3 E1 D9 E3 E2 D9 B4 E7 00 CA BD AD FB C3 E8 00 EB D5 E7 00 E4 E0 D5 D7 D9 D8 00 DD E2 00 FE BC C9 D2 00 B1 FD 02 AD B2 FF FD 03 00 EB D5 E7 00 E8 E6 D5 E2 E7 DA D9 E6 E6 D9 D8 00 E8 E3 FE BC C3 C6 C6 B4 CD 00 CA BD AD FB C3 E8 00 EB D5 E7 00 E4 E0 D5 D7 D9 D8 00 DD E2 00 FE BC C9 D2 00 B1 FD 02 AD B2 FF BC C9 D2 00 B1 FD 04 B2 00 E3 E2 FE CD E3 E1 D9 E3 E2 D9 B4 E7 00 CA BD 00 EB D5 E7 00 DA E9 E0 E0 AD FB FD 03 00 EB D5 E7 00 E8 E6 D5 E2 E7 DA D9 E6 E6 D9 D8 00 E8 E3 FE BC C9 D2 00 B1 FD 02 AD B2 FF BC C9 D2 00 B1 FD 04 B2 00 E3 E2 FE BC C3 C6 C6 B4 CD 00 CA BD 00 EB D5 E7 00 DA E9 E0 E0 AD FB FD 03 00 EB D5 E7 00 E8 E6 D5 E2 E7 DA D9 E6 E6 D9 D8 00 E8 E3 FE BC C9 D2 00 B1 FD 02 AD B2 FF FD 01 00

this should fix the text errors, and hopefully fix the script overrunning into other stuff

Having some trouble with this, do i overwrite starting from that offset or do i just paste it at that offset? I have never done Hex editing before and my editor won;t seem to let me replace starting from an offset. Is there a specific editor that is commonly used around here?

 

[PurpleOrange]

Having some trouble with this, do i overwrite starting from that offset or do i just paste it at that offset? I have never done Hex editing before and my editor won;t seem to let me replace starting from an offset. Is there a specific editor that is commonly used around here?

overwrite it, hxd is usually the most used, you can copy and paste it as long as when you paste use ctrl+b at 0x1A5CF1 instead of ctrl-v

 

[CloverCamerupt]

overwrite it, hxd is usually the most used, you can copy and paste it as long as when you paste use ctrl+b at 0x1A5CF1 instead of ctrl-v

Awesome, everything works now! Me and my hacking newbie team cannot thank you enough!

 

[PurpleOrange]

Awesome, everything works now! Me and my hacking newbie team cannot thank you enough!

no probs, feel free to message me if you have any other problems :)

 

[CloverCamerupt]

no probs, feel free to message me if you have any other problems :)

The team is getting very close to finishing up maps, and the next step in our development plan is to do the event scripts. We are actually looking for a scripter now if you want to hop on board.