My favorites from R/B/Y include: Vermillion City, Final Battle theme, route 25 theme, Pewter City and the Gym theme (the music that plays when you're inside a gym, not the gym leader battle).
My favorites from G/S/C include: Rocket Battle theme, Final Battle Theme, Goldenrod City, The lake of...