Code: Ability Resource Thread

[Trainer 781]

Thank you.I find it.
Now I have another problem.

No1:About Prankster ability
This link is about Prankster
http://m.ign.com/wikis/pokemon-x-y/Prankster
And I do not know how to make the move quick guard.Could you write a ASM code for EM

And No2:How to change the weather ability round to 5 (like gen6)

Lost problem:About the weather can not change when i need.

When i need :D I can make some weather change move or ability failure.

soory my English not good.:(

Prankster is already done by MrDS (though it is not the thread yet).
Regarding Quick Guard, this is an Ability Resource thread not a Move Resource Thread. Also, I'm not hacking actively now for some time since I'm busy. But I may consider doing Quick Guard later.

I haven't researched weather abilities yet.

 

[MrDollSteak]

Thank you.I find it.
Now I have another problem.

No1:About Prankster ability
This link is about Prankster
http://m.ign.com/wikis/pokemon-x-y/Prankster
And I do not know how to make the move quick guard.Could you write a ASM code for EM

And No2:How to change the weather ability round to 5 (like gen6)

Lost problem:About the weather can not change when i need.

When i need :D I can make some weather change move or ability failure.

soory my English not good.:(

As KDS said I'll be uploading Prankster shortly. I've sort of redone the Priority System to use a BL that is called for every Banked Pokemon (same as the Speed Calc).

Again as KDS said, ask about Quick Guard in the Move Resource Thread.

Weather Abilities are called at about 42A18 in Emerald, though I'm rewriting the check for Snow Warning, and Kleenexfeu'ss abilities. I believe the actual endless weather effect is done by the battle script, so it could just be a matter of editing it there to set only five turns.

 

[Trainer 781]

I found the reason of the bug in the Damage Absorbing abilities.
If your HP is full, you will not get the boosts. It is the HP check which is causing the problem.

To disable HP check for non-HP restoring abilities, move #0x2 into r9 instead of #0x1 in their respective routines.

 

[AkimotoBubble]

As KDS said I'll be uploading Prankster shortly. I've sort of redone the Priority System to use a BL that is called for every Banked Pokemon (same as the Speed Calc).

Again as KDS said, ask about Quick Guard in the Move Resource Thread.

Weather Abilities are called at about 42A18 in Emerald, though I'm rewriting the check for Snow Warning, and Kleenexfeu'ss abilities. I believe the actual endless weather effect is done by the battle script, so it could just be a matter of editing it there to set only five turns.

It so nice:D I am waiting you are ASM code I need it

 

[Xencleamas]

I found the reason of the bug in the Damage Absorbing abilities.
If your HP is full, you will not get the boosts. It is the HP check which is causing the problem.

To disable HP check for non-HP restoring abilities, move #0x2 into r9 instead of #0x1 in their respective routines.

Thanks! Lightningrod and the works fine now and I get the stat boosts, as well as the AI does. But another thing I've found out:

If the combatants keep attacking that causes the ability to activate and when a certain stat maxed out, should it be sent to where the script where the and displaying the "User's Ability made Move's useless!" instead of "User's restored HP using its Ability!"? This also causes the AI to suddenly faint.

And also string problems when I'm facing a wild one having these abilities. Sometimes when the AI gains stat due to these, the message error occurs sometimes the player's "User"'s name is displayed. When the wild's message, the name's blank.

Also in Mold Breaker, when the Mold Breaker user is going to attack the opponent which has any of those Type Absorb Abilities, the game freezes after selecting a move.

 

[MrDollSteak]

Thanks! Lightningrod and the works fine now and I get the stat boosts, as well as the AI does. But another thing I've found out:

If the combatants keep attacking that causes the ability to activate and when a certain stat maxed out, should it be sent to where the script where the and displaying the "User's Ability made Move's useless!" instead of "User's restored HP using its Ability!"? This also causes the AI to suddenly faint.

And also string problems when I'm facing a wild one having these abilities. Sometimes when the AI gains stat due to these, the message error occurs sometimes the player's "User"'s name is displayed. When the wild's message, the name's blank.

Also in Mold Breaker, when the Mold Breaker user is going to attack the opponent which has any of those Type Absorb Abilities, the game freezes after selecting a move.

Hrm, okay thanks for finding those bugs. I must be pointing to the wrong place in the jumpifstatchange.

I'm not sure about Mold Breaker, realistically the way its set up it'd have changed the ability to 00, so it shouldn't activate the table and should just jump away.

EDIT: I've fixed the first bug! Still not entirely sure about Mold Breaker, I'll run some tests.

 

[Trainer 781]

Also in Mold Breaker, when the Mold Breaker user is going to attack the opponent which has any of those Type Absorb Abilities, the game freezes after selecting a move.

The reason is that, Mold Breaker sets the target's ability to xFF and absorb table routine reads the last entry to branch to xFFFFFF. To fix this, in the Loop: label ,swap the order of these pair statements 'cmp r0, r1 beq Success' and 'cmp r1, xFF beq End'.

 

[DizzyEgg]

There was a report mentioning problems with the Magic Bounce Ability in MrDS's Rombase, so I decided it to implement this myself from scratch, and it is working fine in Trainer Battles and Doubles.
Here it is posted with Moxie.

Magic Bounce

Spoiler:

Fire Red

For MrDS's base 1.5a at x1D8D6 insert, 18 01 80 18 00 78 C0 06 88 46 before applying the new routines to remove branch to the old routine.

Spoiler:

Routine At XXXXXX:

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global magicbounce
.align 2
     
        mov r9, r2
        ldr r1, freeRAMLoc
        ldrb r1, [r1, #0x0]
        cmp r1, #0x0
        bne nobouncing
        cmp r0, #0x0
        bge magicbouncecheck
        
        ldr r2, moveTable
        ldr r1, =0x0801D8E9
        bx r1

magicbouncecheck:
        ldr r2, =0x02023C04
        ldr r1, =0x02023D6C
        ldrb r3, [r1, #0x0]
        mov r1, #0x58
        mul r1, r3
        add r1, r1, r2
        ldrb r1, [r1, #0x0]
        cmp r1, [U]#0x9D[/U]
        bne nobouncing

        ldr r2, =0x02023DFC
        lsl r1, r3, #0x02
        add r1, r1, r2
        ldr r1, [r1, #0x0]
        ldr r0, =0x000400C0
        and r0, r1
        cmp r0, #0x0
        bne nobouncing

        ldr r2, moveTable
        ldr r0, =0x02023D4A
        ldrh r1, [r0, #0x0]
        lsl r0, r1, #0x01
        add r0, r0, r1
        lsl r0, r0, #0x02
        add r0, r0, r2
        ldrb r1, [r0, #0x8]
        mov r0, #0x4
        and r0, r1
        cmp r0, #0x0
        beq nobouncing 

        ldr r0, =0x02023D6B
        ldrb r0, [r0, #0x0]
        ldr r2, =0x00000115
        add r1, r3, #0x0
        bl pressure

        bl returnSetter

        ldr r1, =0x02023D74
        ldr r0, MBScript
        str r0, [r1, #0x0]
        ldr r0, =0x0801DAFD
        bx r0

nobouncing:
        ldr r1, =0x0801D94D
        bx r1

pressure:
        ldr r3, =0x08016EC9
        bx r3

returnSetter:
        ldr r1, =0x08017545
        bx r1

.align 2
freeRAMLoc: .word 0x0203C030
moveTable: .word 0x08250C04
MBScript: .word [B]0x08VVVVVV[/B]

@At 1D8E0, insert: 00 49 08 47 XX+1 XX XX 08

Routine At YYYYYY:

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global bounceflagclear
.align 2

ldr r3, freeRAMLoc
ldrb r0, [r3, #0x0]
cmp r0, #0x0
beq exit
sub r0, r0, #0x1
strb r0, [r3, #0x0]

exit:
add sp, #0x4
pop {r3, r4}
mov r8, r3
mov r9, r4
pop {r4-r7}
pop {r0}
bx r0

.align 2
freeRAMLoc: .word 0x0203C030

@At 1DAFC, insert: 00 48 00 47 YY+1 YY YY 08

Routine At ZZZZZZ:

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global setbouncereflectionflag

main:    
    push {lr}
    ldr r0, freeRAMLoc
    ldr r1, =0x02023BCC
    ldrb r1, [r1, #0x0]
    cmp r1, #0x2
    beq oneexit

    ldr r2, =0x02023D4A
    ldr r1, moveTable
    mov r3, #0xC
    ldrb r2, [r2, #0x0]
    mul r3, r2
    add r1, r1, r3
    ldrb r1, [r1, #0x6]
    cmp r1, #0x8
    bne oneexit

    ldr r2, =0x02023D6D
    ldrb r2, [r2, #0x0]
    mov r1, #0x58
    mul r1, r2
    ldr r3, =0x02023C0C
    add r3, r3, r1
    ldrh r3, [r3, #0x0]
    cmp r3, #0x0
    beq oneexit

    mov r1, #0x2
    strb r1, [r0, #0x0]
    pop {r0}
    bx r0

oneexit:
    mov r1, #0x1
    strb r1, [r0, #0x0]
    pop {r0}
    bx r0

.align 2
freeRAMLoc: .word 0x0203C030
moveTable: .word 0x08250C04

Magic Coat Script (At UUUUUU):

Spoiler:

At x1D934, insert in reverse hex: UU UU UU 08

02 03 39 20 00 10 BE 00 12 40 00 F8 [B]ZZ+1 ZZ ZZ 08[/B] 35 D0 3D 02 02 00 0C 80 00 76 01 01 3C

Magic Bounce Script (At VVVVVV):

Spoiler:

02 03 39 20 00 FA 20 C0 03 02 [B]SS SS SS 08[/B] 10 84 01 12 40 00 F8 [B]ZZ+1 ZZ ZZ 08[/B] 35 D0 3D 02 02 00 0C 80 00 76 01 01 3C

String At SSSSSS:

FD 13 B4 E7 00 FD 14 FE EB D5 E7 00 D6 E3 E9 E2 D7 D9 D8 00 D6 D5 D7 DF 00 D6 ED 00 FD 1B AB FF

Notes to understand this:

Spoiler:

+ If for some stupid reason, Magic Coat is used on a Magic Bounce pokemon, then Magic coat activates before Magic bounce.
+ Magic Bounce does not activate, if the mon with Magic Bounce is in a semi-invulnerable state (fly, dive etc.).
+ Added a special Flag to ensure that Magic Bounce does not re-reflect a move reflected by Magic Bounce/Magic Coat. Otherwise, a infinite ping-pong loop happens between two Magic Bounce pokemon.
+ A free RAM location is used for this Flag. Initially, it is set to 0. When the condition for Magic Coat or Magic Bounce is met, it is set to 1 (e.g, always the case in singles, reflected spore in doubles) or 2 (e.g reflected growl in doubles), according to the no. of mons the rebounded Move can affect, and then the Rebound is executed.
+ If the value of the Flag is non-zero, the Magic Bounce and Magic Coat checks are automatically skipped to avoid the re-reflection situation and the Flag is decremented by 1 and this Step is repeated until the Flag is cleared to 0.
+ This to try to ensure that during the Rebound itself, the Flag is successfully cleared to 0.
+ The free RAM location refered in the 3 routines MUST BE SAME.
+ Will port to Emerald soon.

Your Magic Bounce routine works perfectly fine except one little thing. Instead of printing: "Pokemon's attack was bounced back by Magic Bounce" it says "Pokemon's attack was bounced back by X" where X is the attacking Pokmon's ability.

EDIT:

Tinted Lens, Solid Rock, Filter (+ Expert Belt)

Spoiler:

Routine I does the actual Damage Manipulation and Routine II makes the AI recognize
Damage Modification due to these Abilities.

Replace KK with Held Item Effect Byte of Expert Belt.

Fire Red:-

Spoiler:

Routine I:

.text
.align 2
.thumb
.thumb_func
.global tintedlenssolidrockexpertbelt

EffectivnessCheck:
       ldrb r1, [r0, #0x0]
       mov r0, #0x8
       and r0, r1
       cmp r0, #0x0
       bne NotEffective
       
MissCheck:
       mov r0, #0x31
       and r0, r1
       cmp r0, #0x0
       bne Exit

NotVeryEffectiveCheck:       
       mov r0, #0x4
       and r0, r1
       cmp r0, #0x0
       beq SuperEffectiveCheck
       ldr r0, .UserBank
       ldr r1, .BattleStruct
       mov r2, #0x58
       ldrb r0, [r0]
       mul r2, r0
       add r1, r1, r2
       ldrb r1, [r1]
       cmp r1, [B][U]#0x6F[/U][/B]
       bne Exit

HasTintedLens:
       ldr r0, .Damage
       ldrh r1, [r0]
       lsl r1, r1, #0x1
       strh r1, [r0]
       b Exit

SuperEffectiveCheck:
       mov r0, #0x2
       and r0, r1
       cmp r0, #0x0       
       beq Exit
       ldr r0, .TargetBank
       ldr r4, .BattleStruct
       mov r3, #0x58
       ldrb r0, [r0]
       mul r0, r3
       add r1, r0, r4
       ldrb r0, [r1]
       cmp r0, [B][U]#0x75[/U][/B]
       beq HasSolidRock
       cmp r0, [B][U]#0x70[/U][/B]
       bne ExpertBeltCheck
HasSolidRock:
       ldr r0, .Damage
       ldrh r1, [r0]
       lsl r2, r1, #0x1
       add r1, r1, r2
       lsr r1, r1, #0x2
       cmp r1, #0x0
       bne NotZero
       mov r1, #0x1

NotZero:
       strh r1, [r0]

ExpertBeltCheck:
       ldr r0, .UserBank
       ldrb r0, [r0]
       mul r0, r3
       add r1, r0, r4
       add r1, #0xE
       ldrh r0, [r1]
       bl EffectGetter
       cmp r0, [U][B]#0xKK[/B][/U]
       bne Exit
       ldr r4, .Damage
       ldrh r0, [r4]
       mov r2, #0x6
       mul r0, r2
       mov r1, #0x5
       bl Divider
       strh r0, [r4]
Exit:
       ldr r1, =0x0801EA71
       bx r1

NotEffective:
       ldr r1, =0x0801EA5F
       bx r1

EffectGetter:
       ldr r1, =0x0809A925
       bx r1
      
Divider:
       ldr r2, =0x081E4019
       bx r2

.align 2
.UserBank: .word 0x02023D6B
.TargetBank: .word 0x02023D6C
.BattleStruct: .word 0x02023C04
.Damage: .word 0x02023D50

/* 1EA54: 00 49 08 47 XX+1 XX XX 08 00 00*/

Routine II:

.text
.align 2
.thumb
.thumb_func
.global tintedlenssolidrockexpertbeltai

StruggleCheck:
       mov r1, r10
       cmp r1, #0xA5
       beq Quit

EffectivnessCheck:
       ldrb r1, [r0, #0x0]
       mov r0, #0x39
       and r0, r1
       cmp r0, #0x0
       bne Exit

NotVeryEffectiveCheck:       
       mov r0, #0x4
       and r0, r1
       cmp r0, #0x0
       beq SuperEffectiveCheck
       ldr r0, .UserBank
       ldr r1, .BattleStruct
       mov r2, #0x58
       ldrb r0, [r0]
       mul r2, r0
       add r1, r1, r2
       ldrb r1, [r1]
       cmp r1, [B][U]#0x6F[/U][/B]
       bne Exit

HasTintedLens:
       ldr r0, .Damage
       ldrh r1, [r0]
       lsl r1, r1, #0x1
       strh r1, [r0]
       b Exit

SuperEffectiveCheck:
       mov r0, #0x2
       and r0, r1
       cmp r0, #0x0       
       beq Exit
       ldr r0, .TargetBank
       ldr r4, .BattleStruct
       mov r3, #0x58
       ldrb r0, [r0]
       mul r0, r3
       add r1, r0, r4
       ldrb r0, [r1]
       cmp r0, [B][U]#0x75[/U][/B]
       beq HasSolidRock
       cmp r0, [B][U]#0x70[/U][/B]
       bne ExpertBeltCheck
HasSolidRock:
       ldr r0, .Damage
       ldrh r1, [r0]
       lsl r2, r1, #0x1
       add r1, r1, r2
       lsr r1, r1, #0x2
       cmp r1, #0x0
       bne NotZero
       mov r1, #0x1

NotZero:
       strh r1, [r0]

ExpertBeltCheck:
       ldr r0, .UserBank
       ldrb r0, [r0]
       mul r0, r3
       add r1, r0, r4
       add r1, #0xE
       ldrh r0, [r1]
       bl EffectGetter
       cmp r0, [B][U]#0xKK[/U][/B]

       bne Exit
       ldr r4, .Damage
       ldrh r0, [r4]
       mov r2, #0x6
       mul r0, r2
       mov r1, #0x5
       bl Divider
       strh r0, [r4]
Exit:
       mov r0, sp
       ldrb r0, [r0, #0x0]
Quit:
       add sp, #0x10
       pop {r3-r5}
       mov r8, r3
       mov r9, r4
       mov r10, r5
       pop {r4-r7}
       pop {r1}
       bx r1

EffectGetter:
       ldr r1, =0x0809A925
       bx r1
      
Divider:
       ldr r2, =0x081E4019
       bx r2

.align 2
.UserBank: .word 0x02023D6B
.TargetBank: .word 0x02023D6C
.BattleStruct: .word 0x02023C04
.Damage: .word 0x02023D50

/* 1EFAC: 00 00 00 00 00 49 08 47 XX+1 XX XX 08*/

Emerald:-

Spoiler:

Routine I:

.text
.align 2
.thumb
.thumb_func
.global tintedlenssolidrockexpertbelt

EffectivnessCheck:
       ldrb r1, [r0, #0x0]
       mov r0, #0x8
       and r0, r1
       cmp r0, #0x0
       bne NotEffective
       
MissCheck:
       mov r0, #0x31
       and r0, r1
       cmp r0, #0x0
       bne Exit

NotVeryEffectiveCheck:       
       mov r0, #0x4
       and r0, r1
       cmp r0, #0x0
       beq SuperEffectiveCheck
       ldr r0, .UserBank
       ldr r1, .BattleStruct
       mov r2, #0x58
       ldrb r0, [r0]
       mul r2, r0
       add r1, r1, r2
       ldrb r1, [r1]
       cmp r1, [B][U]#0x6F[/U][/B]
       bne Exit

HasTintedLens:
       ldr r0, .Damage
       ldrh r1, [r0]
       lsl r1, r1, #0x1
       strh r1, [r0]
       b Exit

SuperEffectiveCheck:
       mov r0, #0x2
       and r0, r1
       cmp r0, #0x0       
       beq Exit
       ldr r0, .TargetBank
       ldr r4, .BattleStruct
       mov r3, #0x58
       ldrb r0, [r0]
       mul r0, r3
       add r1, r0, r4
       ldrb r0, [r1]
       cmp r0, [B][U]#0x75[/U][/B]
       beq HasSolidRock
       cmp r0, [B][U]#0x70[/U][/B]
       bne ExpertBeltCheck
HasSolidRock:
       ldr r0, .Damage
       ldrh r1, [r0]
       lsl r2, r1, #0x1
       add r1, r1, r2
       lsr r1, r1, #0x2
       cmp r1, #0x0
       bne NotZero
       mov r1, #0x1

NotZero:
       strh r1, [r0]

ExpertBeltCheck:
       ldr r0, .UserBank
       ldrb r0, [r0]
       mul r0, r3
       add r1, r0, r4
       add r1, #0xE
       ldrh r0, [r1]
       bl EffectGetter
       cmp r0, [B][U]#0xKK[/U][/B]
       bne Exit
       ldr r4, .Damage
       ldrh r0, [r4]
       mov r2, #0x6
       mul r0, r2
       mov r1, #0x5
       bl Divider
       strh r0, [r4]
Exit:
       ldr r1, =0x08047261
       bx r1

NotEffective:
       ldr r1, =0x0804724F
       bx r1

EffectGetter:
       ldr r1, =0x080D74DD
       bx r1
      
Divider:
       ldr r2, =0x082E7541
       bx r2

.align 2
.UserBank: .word 0x0202420B
.TargetBank: .word 0x0202420C
.BattleStruct: .word 0x020240A4
.Damage: .word 0x020241F0

/* 47244: 00 49 08 47 XX+1 XX XX 08 00 00*/

Routine II:

.text
.align 2
.thumb
.thumb_func
.global tintedlenssolidrockexpertbeltai

StruggleCheck:
       mov r1, r10
       cmp r1, #0xA5
       beq Quit

EffectivnessCheck:
       ldrb r1, [r0, #0x0]
       mov r0, #0x39
       and r0, r1
       cmp r0, #0x0
       bne Exit

NotVeryEffectiveCheck:       
       mov r0, #0x4
       and r0, r1
       cmp r0, #0x0
       beq SuperEffectiveCheck
       ldr r0, .UserBank
       ldr r1, .BattleStruct
       mov r2, #0x58
       ldrb r0, [r0]
       mul r2, r0
       add r1, r1, r2
       ldrb r1, [r1]
       cmp r1, [B][U]#0x6F[/U][/B]
       bne Exit

HasTintedLens:
       ldr r0, .Damage
       ldrh r1, [r0]
       lsl r1, r1, #0x1
       strh r1, [r0]
       b Exit

SuperEffectiveCheck:
       mov r0, #0x2
       and r0, r1
       cmp r0, #0x0       
       beq Exit
       ldr r0, .TargetBank
       ldr r4, .BattleStruct
       mov r3, #0x58
       ldrb r0, [r0]
       mul r0, r3
       add r1, r0, r4
       ldrb r0, [r1]
       cmp r0, [B][U]#0x75[/U][/B]
       beq HasSolidRock
       cmp r0, [B][U]#0x70[/U][/B]
       bne ExpertBeltCheck
HasSolidRock:
       ldr r0, .Damage
       ldrh r1, [r0]
       lsl r2, r1, #0x1
       add r1, r1, r2
       lsr r1, r1, #0x2
       cmp r1, #0x0
       bne NotZero
       mov r1, #0x1

NotZero:
       strh r1, [r0]

ExpertBeltCheck:
       ldr r0, .UserBank
       ldrb r0, [r0]
       mul r0, r3
       add r1, r0, r4
       add r1, #0xE
       ldrh r0, [r1]
       bl EffectGetter
       cmp r0, [B][U]#0xKK[/U][/B]
       bne Exit
       ldr r4, .Damage
       ldrh r0, [r4]
       mov r2, #0x6
       mul r0, r2
       mov r1, #0x5
       bl Divider
       strh r0, [r4]
Exit:
       mov r0, sp
       ldrb r0, [r0, #0x0]
Quit:
       add sp, #0x10
       pop {r3-r5}
       mov r8, r3
       mov r9, r4
       mov r10, r5
       pop {r4-r7}
       pop {r1}
       bx r1

EffectGetter:
       ldr r1, =0x080D74DD
       bx r1
      
Divider:
       ldr r2, =0x082E7541
       bx r2

.align 2
.UserBank: .word 0x0202420B
.TargetBank: .word 0x0202420C
.BattleStruct: .word 0x020240A4
.Damage: .word 0x020241F0

/* 4779C: 00 00 00 00 00 49 08 47 XX+1 XX XX 08 00 00*/

I have slightly updated Mold Breaker using MrDS's Emerald Ports for this routine. The old routines also work perfectly fine but the new one's are optimized and more understandable.

I also tested these abilities and they change damage correctly however the messages "it's super effective" and "it's not very effective" no loner appear if you attack a pokemon with Solid Rock and Filter. And if a pokemon with Tinted Lens attacks you with a not very effective move the message will not appear neither.

 

[Trainer 781]

Your Magic Bounce routine works perfectly fine except one little thing. Instead of printing: "Pokemon's attack was bounced back by Magic Bounce" it says "Pokemon's attack was bounced back by X" where X is the attacking Pokmon's ability.

EDIT:


I also tested these abilities and they change damage correctly however the messages "it's super effective" and "it's not very effective" no loner appear if you attack a pokemon with Solid Rock and Filter. And if a pokemon with Tinted Lens attacks you with a not very effective move the message will not appear neither.

I'll look into Magic Bounce. Just a matter of changing the string.

Try testing Solid Rock etc. on a blank FR ROM. The messages did appear in my testing.

 

[DizzyEgg]

I'll look into Magic Bounce. Just a matter of changing the string.

Try testing Solid Rock etc. on a blank FR ROM. The messages did appear in my testing.

Looks like you're right. Do you know, by any chance, why the message wouldn't show up in Mr.DollSteak's Patch? Maybe it's because these abilities were present in the rombase in the first place and now they're called two times?

 

[Trainer 781]

Looks like you're right. Do you know, by any chance, why the message wouldn't show up in Mr.DollSteak's Patch? Maybe it's because these abilities were present in the rombase in the first place and now they're called two times?

Looks like this is the case.

 

[MrDollSteak]

The reason is that, Mold Breaker sets the target's ability to xFF and absorb table routine reads the last entry to branch to xFFFFFF. To fix this, in the Loop: label ,swap the order of these pair statements 'cmp r0, r1 beq Success' and 'cmp r1, xFF beq End'.

All fixed!

I've actually made Simple now! I'll also update this post to include Contrary in the future!

Simple

Spoiler:

Fire Red

Spoiler:

Routine I: Negative Stat Boost

Spoiler:

.text
.align 2
.thumb
.thumb_funcs
.global simplenegativestatboost

BufferAbility:
	mov r2, #0x1
	lsr r6, r0, #0x18
	ldr r0, .Bank
	ldrb r0, [r0]
	mov r1, #0x58
	mul r0, r1
	ldr r1, .BattleData
	add r0, r0, r1
	ldrb r0, [r0]
SimpleCheck:
	cmp r0, #0x57
	bne DetermineNegativeStage
Simple:
	lsl r0, r6, #0x19
	lsr r6, r0, #0x18
DetermineNegativeStage:
	cmp r6, #0xFE
	beq Harshly
	cmp r6, #0xFF
	beq Fell
Severely:
	strb r4, [r3, #0x1]
	mov r0, #0x85
	strb r0, [r3, #0x2]
	mov r0, #0x1
	strb r0, [r3, #0x3]
	mov r2, #0x4
	b Fell
Harshly:
	strb r4, [r3, #0x1]
	mov r0, #0xD3
	strb r0, [r3, #0x2]
	strb r4, [r3, #0x3]
	mov r2, #0x4
Fell:
	ldr r0, .Return
	bx r0

.align 2
.Bank: .word 0x02023BC4
.BattleData: .word 0x02023C04
.Return: .word 0x08027F12

#Insert 00 4A 10 47 xx xx xx 08 at 27EFC

Routine II: Positive Stat Boost

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global simplepositivestatboost

BufferAbility:
	mov r2, #0x1
	ldr r0, .Bank
	ldrb r0, [r0]
	mov r1, #0x58
	mul r0, r1
	ldr r1, .BattleData
	add r0, r0, r1
	ldrb r0, [r0]
SimpleCheck:
	cmp r0, #0x57
	bne DeterminePositiveStage
Simple:
	lsl r0, r6, #0x19
	lsr r6, r0, #0x18
DeterminePositiveStage:
	cmp r6, #0x2
	beq Sharply
	cmp r6, #0x1
	beq Rose
Drastically:
	strb r4, [r3, #0x1]
	mov r0, #0x86
	strb r0, [r3, #0x2]
	mov r0, #0x1
	strb r0, [r3, #0x3]
	mov r2, #0x4
	b Rose
Sharply:
	strb r4, [r3, #0x1]
	mov r0, #0xD1
	strb r0, [r3, #0x2]
	strb r4, [r3, #0x3]
	mov r2, #0x4
Rose:
	ldr r0, .Return
	bx r0

.align 2
.Bank: .word 0x02023BC4
.BattleData: .word 0x02023C04
.Return: .word 0x08027F87

#Insert 01 4A 10 47 00 00 xx xx xx 08 at 27F76

Routine III: Display Stat Stage Message

Spoiler:

.text
.text
.align 2
.thumb
.thumb_func
.global displaystatstagemessage

BufferMessage:
	ldr r0, .Index
	cmp r0, r1
	beq BufferSeverely
	add r0, #0x1
	cmp r0, r1
	bne Normal
BufferDrastically:
	ldr r1, .DrasticallyString
	b Return
BufferSeverely:
	ldr r1, .SeverelyString
	b Return
Normal:
	ldr r0, .MessageTable
	sub r1, #0xC
	lsl r1, r1, #0x2
	add r1, r1, r0
	ldr r1, [r1]
Return:
	ldr r0, .Return
	bx r0

.align 2

.Index: .word 0x00000185
.DrasticallyString: .word 0x08[B]DDDDDD[/B]
.SeverelyString: .word 0x08[B]EEEEEE[/B]
.MessageTable: .word 0x083FDF3C
.Return: .word 0x080D8491

#Insert 01 48 00 47 00 00 xx xx xx 08 at 080D8486

DDDDDD refers to the following string

D8 E6 D5 E7 E8 DD D7 D5 E0 E0 ED 00 FF

EEEEEE refers to the following string.

E7 D9 EA D9 E6 D9 E0 ED 00 FF

Emerald

Spoiler:

Routine I: Negative Stat Boost

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global simplenegativestatboost

BufferAbility:
	mov r2, #0x1
	lsr r6, r0, #0x18
	ldr r0, .Bank
	ldrb r0, [r0]
	mov r1, #0x58
	mul r0, r1
	ldr r1, .BattleData
	add r0, r0, r1
	ldrb r0, [r0]
SimpleCheck:
	cmp r0, #0x57
	bne DetermineNegativeStage
Simple:
	lsl r0, r6, #0x19
	lsr r6, r0, #0x18
DetermineNegativeStage:
	cmp r6, #0xFE
	beq Harshly
	cmp r6, #0xFF
	beq Fell
Severely:
	strb r4, [r3, #0x1]
	mov r0, #0x85
	strb r0, [r3, #0x2]
	mov r0, #0x1
	strb r0, [r3, #0x3]
	mov r2, #0x4
	b Fell
Harshly:
	strb r4, [r3, #0x1]
	mov r0, #0xD3
	strb r0, [r3, #0x2]
	strb r4, [r3, #0x3]
	mov r2, #0x4
Fell:
	ldr r0, .Return
	bx r0

.align 2
.Bank: .word 0x02024064
.BattleData: .word 0x020240A4
.Return: .word 0x08050D33

#Insert 00 4A 10 47 xx xx xx 08 at 50D1C

Routine II: Positive Stat Boost

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global simplepositivestatboost

BufferAbility:
	mov r2, #0x1
	ldr r0, .Bank
	ldrb r0, [r0]
	mov r1, #0x58
	mul r0, r1
	ldr r1, .BattleData
	add r0, r0, r1
	ldrb r0, [r0]
SimpleCheck:
	cmp r0, #0x57
	bne DeterminePositiveStage
Simple:
	lsl r0, r6, #0x19
	lsr r6, r0, #0x18
DeterminePositiveStage:
	cmp r6, #0x2
	beq Sharply
	cmp r6, #0x1
	beq Rose
Drastically:
	strb r4, [r3, #0x1]
	mov r0, #0x86
	strb r0, [r3, #0x2]
	mov r0, #0x1
	strb r0, [r3, #0x3]
	mov r2, #0x4
	b Rose
Sharply:
	strb r4, [r3, #0x1]
	mov r0, #0xD1
	strb r0, [r3, #0x2]
	strb r4, [r3, #0x3]
	mov r2, #0x4
Rose:
	ldr r0, .Return
	bx r0

.align 2
.Bank: .word 0x02024064
.BattleData: .word 0x020240A4
.Return: .word 0x08050DA7

#Insert 01 4A 10 47 00 00 xx xx xx 08 at 50D96

Routine III: Display Stat Stage Message

Spoiler:

.text
.text
.align 2
.thumb
.thumb_func
.global displaystatstagemessage

BufferMessage:
	ldr r0, .Index
	cmp r0, r1
	beq BufferSeverely
	add r0, #0x1
	cmp r0, r1
	bne Normal
BufferDrastically:
	ldr r1, .DrasticallyString
	b Return
BufferSeverely:
	ldr r1, .SeverelyString
	b Return
Normal:
	ldr r0, .MessageTable
	sub r1, #0xC
	lsl r1, r1, #0x2
	add r1, r1, r0
	ldr r1, [r1]
Return:
	ldr r0, .Return
	bx r0

.align 2

.Index: .word 0x00000185
.DrasticallyString: .word 0x08[B]DDDDDD[/B]
.SeverelyString: .word 0x08[B]EEEEEE[/B]
.MessageTable: .word 0x085CC270
.Return: .word 0x0814F6C1

#Insert 01 48 00 47 00 00 xx xx xx 08 at 0814F6B6

DDDDDD refers to the following string

D8 E6 D5 E7 E8 DD D7 D5 E0 E0 ED 00 FF

EEEEEE refers to the following string.

E7 D9 EA D9 E6 D9 E0 ED 00 FF

 

[kleenexfeu]

All fixed! Just try the routines now and they'll work. Kleenex was right with all of them except Heatproof.

I'm reserving this spot for Magic Guard. Although there are already a few Magic Guard routines I'll try and link them all in this post. This is where things start getting annoying as more and more abilities need to be hooked in multiple places with multiple other routines.

Magic Guard

Spoiler:

Fire Red

Spoiler:

Emerald

Spoiler:

Routine I: Prevent Sandstorm Damage (Also contains Overcoat, Sand Rush and Sand Force)

Spoiler:

.text
.text
.align 2
.thumb
.thumb_func
.global preventsandstormdamage

BufferAbility:
	mov r0, r3
	add r0, #0x20
	ldrb r0, [r0]
SandVeilCheck:
	cmp r0, #0x8
	beq NoDamage
MagicGuardCheck:
	cmp r0, #0x63
	beq NoDamage
OvercoatCheck:
	cmp r0, #0x8F
	beq NoDamage
SandRushCheck:
	cmp r0, #0x93
	beq NoDamage
SandForceCheck:
	cmp r0, #0xA0
	beq NoDamage
Return:
	ldr r0, .Return
	bx r0
NoDamage:
	ldr r1, .Return2
	bx r1

.align 2

.Return: .word 0x08051B95
.Return2: .word 0x08051BD5

Insert 01 48 00 47 00 00xx xx xx 08 at 08051B8A

Routine II: Prevent Hail Damage

Spoiler:

Contained in this post under Snow Cloak. If you have already inserted it you don't need to do it again.

Routine III: Prevent Leech Seed Damage

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global preventleechseeddamage

BufferAbility:
	ldrb r0, [r6]
	mul r0, r1
	add r0, r0, r3
	push {r0}
	add r0, #0x20
	ldrb r0, [r0]
MagicGuardCheck:
	cmp r0, #0x63
	bne LeechSeedDamage
MagicGuard:
	pop {r0}
	mov r0, #0x0
	b StoreDamage
LeechSeedDamage:
	pop {r0}
	ldrh r0, [r0, #0x2C]
	lsr r0, r0, #0x3
CheckIfZero:
	cmp r0, #0x0
	bne StoreDamage
SetDamage:
	mov r0, #0x1
StoreDamage:
	ldr r1, .Return
	bx r1

.align 2

.Return: .word 0x08040B1D

Insert 01 48 00 47 00 00 xx xx xx 08 at 08040B0A

Routine IV: Prevent Poison Damage (also contains Poison Heal)

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global preventpoisondamage

BufferAbility:
	mov r0, r1
	add r0, #0x20
	ldrb r0, [r0]
PoisonHealCheck:
	cmp r0, #0x5B
	beq NoDamage
MagicGuardCheck:
	cmp r0, #0x63
	bne PoisonDamage
NoDamage:
	mov r0, #0x0
	b StoreDamage
PoisonDamage:
	ldrh r0, [r0, #0x2C]
	lsr r0, r0, #0x3
CheckIfZero:
	cmp r0, #0x0
	bne StoreDamage
SetDamage:
	mov r0, #0x1
StoreDamage:
	ldr r1, .Return
	bx r1

.align 2

.Return: .word 0x08040B79

Insert 00 48 00 47 xx xx xx 08 at 08040B6C

Routine V: Prevent Toxic Damage (also contains Poison Heal)

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global preventtoxicdamage

BufferAbility:
	mov r0, r1
	add r0, #0x20
	ldrb r0, [r0]
PoisonHealCheck:
	cmp r0, #0x5B
	beq NoDamage
MagicGuardCheck:
	cmp r0, #0x63
	bne PoisonDamage
NoDamage:
	mov r0, #0x0
	b StoreDamage
PoisonDamage:
	ldrh r0, [r0, #0x2C]
	lsr r0, r0, #0x4
CheckIfZero:
	cmp r0, #0x0
	bne StoreDamage
SetDamage:
	mov r0, #0x1
StoreDamage:
	ldr r1, .Return
	bx r1

.align 2

.Return: .word 0x08040BC3

Insert 01 48 00 47 00 00 xx xx xx 08 at 08040BB6

Routine VI: Prevent Burn Damage

Spoiler:

Contained in this post under Heatproof Routine II. If you have already inserted it you don't need to do it again.

Routine VII: Prevent Nightmare Damage

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global preventnightmaredamage

BufferAbility:
	mov r0, r3
	add r0, #0x20
	ldrb r0, [r0]
MagicGuardCheck:
	cmp r0, #0x63
	bne NightmareDamage
MagicGuard:
	mov r0, #0x0
	b StoreDamage
NightmareDamage:
	ldrh r0, [r3, #0x2C]
	lsr r0, r0, #0x2
CheckIfZero:
	cmp r0, #0x0
	bne StoreDamage
SetDamage:
	mov r0, #0x1
StoreDamage:
	ldr r2, .Return
	bx r2

.align 2

.Return: .word 0x08040C99

Insert 00 48 00 47 xx xx xx 08 at 08040C8C

Routine VIII: Prevent Curse Damage

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global preventcursedamage

BufferAbility:
	mov r0, r1
	add r0, #0x20
	ldrb r0, [r0]
MagicGuardCheck:
	cmp r0, #0x63
	bne CurseDamage
MagicGuard:
	mov r0, #0x0
	b StoreDamage
CurseDamage:
	ldrh r0, [r1, #0x2C]
	lsr r0, r0, #0x2
CheckIfZero:
	cmp r0, #0x0
	bne StoreDamage
SetDamage:
	mov r0, #0x1
StoreDamage:
	ldr r1, .Return
	bx r1

.align 2

.Return: .word 0x08040CEF

Insert 01 48 00 47 00 00 xx xx xx 08 at 08040CE2

Routine IX: Prevent Trap Damage (also contains Binding Band)

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global bindingband
 
BufferTarget:
	ldrb r0, [r6]
	mul r0, r3
	add r0, r8
BufferAbility:
	push {r0}
	add r0, #0x20
	ldrb r0, [r0]
MagicGuardCheck:
	cmp r0, #0x63
	bne BufferUser
MagicGuard:
	pop {r0}
	mov r0, #0x0
	b StoreDamage
BufferUser:
	pop {r0}
	push {r0-r7}
	ldrb r0, [r6]
	mov r1, #0x1
	and r0, r1
	cmp r0, #0x0
	beq CheckFoe
CheckUser:
	mov r0, #0x0
	mov r6, #0x0
CheckUserLoop:
	mul r0, r3
	add r0, r8
CheckUserBindingBand:
	ldrh r0, [r0, #0x2E]
	bl GetItemByte
	cmp r0, #0x4C
	beq BindingBand
EndUserLoop:
	ldr r0, .BattleType
	ldrb r0, [r0]
	cmp r0, #0x0
	beq BufferHP
	cmp r6, #0x1
	beq BufferHP
	mov r0, #0x2
	add r6, #0x1
	b CheckUserLoop
CheckFoe:
	mov r0, #0x1
	mov r6, #0x0
CheckFoeLoop:
	mul r0, r3
	add r0, r8
CheckFoeBindingBand:
	ldrh r0, [r0, #0x2E]
	bl GetItemByte
	cmp r0, #0x4C
	beq BindingBand
EndFoeLoop:
	ldr r0, .BattleType
	ldrb r0, [r0]
	cmp r0, #0x0
	beq BufferHP
	cmp r6, #0x1
	beq BufferHP
	mov r0, #0x3
	add r6, #0x1
	b CheckFoeLoop
BindingBand:
	pop {r0-r7}
	ldrh r0, [r0, #0x2C]
	push {r1-r4}
	mov r1, #0x6
	bl DivMod
	pop {r1-r4}
	b CheckIfZero
BufferHP:
	pop {r0-r7}
	ldrh r0, [r0, #0x2C]
NormalDamage:
	lsr r0, r0, #0x3
CheckIfZero:
	cmp r0, #0x0
	bne StoreDamage
SetDamage:
	mov r0, #0x1
StoreDamage:
	str r0, [r2]
Return:
	ldr r0, .Return
	bx r0
GetItemByte:
	ldr r1, .GetItemByteBL
	bx r1
DivMod:
	ldr r2, .DivideBL
	bx r2

.align 2
.BattleType: .word 0x2022FEC
.Return: .word 0x08040DED
.GetItemByteBL: .word 0x080D74DD
.DivideBL: .word 0x082E7541

#insert 00 48 00 47 xx xx xx 08 at 040D88

4C refers to the effect index of the Binding Band. Change that depending on where you choose to put it.

There are still a few extra checks I need to add within some Battle Scripts. Namely; Recoil Damage, Crash Damage and Entry Hazard Damage. This post will link to the respective Battle Scripts in the Move Resource Thread once they're completed.

Overcoat and Bulletproof

Spoiler:

Fire Red

Emerald

Spoiler:

Prerequisites

Spoiler:

Overcoat Table

Spoiler:

Insert this table into Free Space and take note of its location. It contains the indexes of Powder moves.

4D 00 4E 00 4F 00 93 00 B2 00 58 02 FF FF 00 00

58 02 refers to Powder's Gen 6 move index as taken from Bulbapedia. If you have inserted Powder elsewhere change that.

Bulletproof Table

Spoiler:

Insert this table into Free Space and take note of its location. It contains the indexes of Ball and Bomb moves.

79 00 8C 00 BC 00 BE 00 C0 00 F7 00 28 01 2D 01
37 01 4B 01 68 01 8C 01 92 01 9B 01 9C 01 AA 01
B7 01 BB 01 E6 01 EB 01 FF FF 00 00

The move indexes from 68 01 onwards refer to all Ball and Bomb moves added after Gen 3. Replace them with whatever indexes you have used.

Routines

Spoiler:

Routine I: Prevent Powder moves and Bulletproof

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global overcoatbulletproof

BufferAbility:
	ldrb r0, [r7]
SoundproofCheck:
	cmp r0, #0x2B
	bne OvercoatCheck
Soundproof:
	ldr r0, .Return
	bx r0
OvercoatCheck:
	cmp r0, #0x8F
	bne BulletproofCheck
Overcoat:
	ldr r0, .OvercoatTable
	b StartLoop
BulletproofCheck:
	cmp r0, #0xAC
	bne Return
Bulletproof:
	ldr r0, .BulletproofTable
StartLoop:
	mov r4, #0x0
	ldr r2, .Return2
	bx r2
Return:
	ldr r1, .Return3
	bx r1
	
Loop:

.align 2
.Return: .word 0x08042F03
.OvercoatTable: .word 0x08AAAAAA
.BulletproofTable: .word 0x08BBBBBB
.Return2: .word 0x08042F07
.Return3: .word 0x08042F11

#insert 00 48 00 47 xx xx xx 08 at 042EF8

AAAAAA refers to the offset of the table that contains Powder moves.
BBBBBB refers to the offset of the table that contains Bomb and Ball moves.

Routine II: Prevent Effect Spore from Activating

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global overcoat

BufferHealth:
	mov r0, #0x58
	mul r0, r2
	add r0, r0, r1
	ldrh r0, [r0, #0x28]
	cmp r0, #0x0
	beq NoEffectSpore
OvercoatCheck:
	cmp r0, #0x8F
	bne Return
NoEffectSpore:
	ldr r1, .Return
	bx r1
Return:
	ldr r0, .Return2
	bx r0

	
Loop:

.align 2
.Return: .word 0x08043433
.Return2: .word 0x08043437

#insert 01 48 00 47 00 00 xx xx xx 08 at 043426

To prevent weather damage from affecting Pokemon with Overcoat, look at Magic Guard's prevent Sandstorm and prevent Hail damage routines just above.

For magic guard : You can prevent recoil (maybe crash too) by hooking at the same place I used for Contrary in the second routine. For the recoil/eventual crash effect, if the pokemon has magic guard ability and the said effect is used, set the byte 02024335 (in emerald) to 0

 

[Trainer 781]

For magic guard : You can prevent recoil (maybe crash too) by hooking at the same place I used for Contrary in the second routine. For the recoil/eventual crash effect, if the pokemon has magic guard ability and the said effect is used, set the byte 02024335 (in emerald) to 0

Alternatively, you can directly go to recoil routine specified by the table at x48F88 (Emerald). You can also make proper Head Smash there (By adding a Move ID check).

The crash damage can be handled by pure Battle Scripting.

Magic Guard

Overcoat and Bulletproof

You can also expand Overcoat to emulate Grass Type's immunity to Powder Moves.
Nevermind, it is already covered in the Veil Abilities.

Though you will need to edit the Battle Scripts in the Veil Abilities to enable Sap Sipper Grass Types getting Stat Boosts from Grass-type powder moves like Stun Spore, Spore, Sleep Powder and Cotton Spore.

The Effect Spore Routine can be expanded to accommodate Grass-types though.

 

[MrDollSteak]

Alternatively, you can directly go to recoil routine specified by the table at x48F88 (Emerald). You can also make proper Head Smash there (By adding a Move ID check).

The crash damage can be handled by pure Battle Scripting.


You can also expand Overcoat to emulate Grass Type's immunity to Powder Moves.
Nevermind, it should be done elsewhere.

Yeah actually I might do what you suggest and just make another check at 49390.
See what annoys me is, is that Struggle sets Recoil damage to 1/2, but it seems to be hardcoded elsewhere as well, so it doesn't work with Head Smash, so I'll do that too.

Powder moves I've just handled in the battle scripts. The only one that really needs ASM is Overcoat users and Grass-type users ignoring Rage Powder. But that also means that Rage Powder needs to set something different to Follow Me (but only slightly).

I'm reserving this post to upload some of my end of turn abilities up here.

 

[Exodrake]

I'm having an issue with Simple. After implementing it, the ability itself works perfectly fine but when something which doesn't have simple has its stats modified, the game freezes if the stats are modified by one stage and resets when modified by two stages. The issue seems to be that it cannot display the text strings anymore.

 

[mamamama]

Just noticed that Keen Eye should also be added as an ability that has changed effect since Gen III.

Also, in the OP it says that Oblivious is updated but I can't find the update for it. The link leads to Leaf Guard/Aroma Veil etc.

 

[Trainer 781]

Just noticed that Keen Eye should also be added as an ability that has changed effect since Gen III.

Also, in the OP it says that Oblivious is updated but I can't find the update for it. The link leads to Leaf Guard/Aroma Veil etc.

It is in the Taunt Battle Script.

 

[DizzyEgg]

1. Mold Breaker, Teravolt and Turboblaze:

Spoiler:

Fire Red:

Spoiler:

Step I

Spoiler:

Mold Breaker Table:-

00 00 00 00 01 01 00 01 01 00 01 01 01 00 00 01 
00 02 01 01 01 01 00 00 00 01 02 00 00 01 00 00 
00 00 00 00 00 00 00 01 01 01 00 01 00 00 00 01 
00 00 00 01 01 00 00 00 00 00 00 00 01 00 00 01 
00 00 00 00 00 00 00 00 01 01 00 01 00 00 01 01 
00 00 01 00 00 00 01 01 01 00 00 00 00 00 00 00 
00 00 00 00 00 00 00 02 00 00 00 00 00 00 01 00 
01 00 00 00 00 01 00 00 00 00 00 01 00 00 00 01 
00 00 00 00 00 00 00 01 01 01 00 00 00 01 00 01 
00 00 01 00 01 00 00 00 00 00 00 00 00 01 01 00 
00 00 00 00 00 00 00 00 00 00 01 00 01 00 00 00 
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

Insert this table if your ROM has Ability Indices in the same order as that mentioned in the OP (Otherwise you need to modify the table using the Info given below)
There are 256 entries in this table which equal to the maximum No. of abilities that can be accommodated in a GBA rom.

An entry for each ability takes one byte of space and there are entries for every ability. The entry is set to 00 if Mold Breaker does not negate the Ability, 01 (or a non-zero value) if Mold Breaker is able to negate it and 02 if the Ability is negated by Mold Breaker to simulate the Gen V hazard effect.

For e.g, the first entry is for Ability ID 0x0, the Blank Ability, so it does not need to be checked against Mold Breaker and therefore its entry should be set to 00. The second entry is for Stench (ID = 0x1) so set to 00. The 6th entry is set to 01 because MB negates Sturdy (ID = 0x5).

There are some abilities that are not supported by this implementation and require specific explicit Mold Breaker checks. Hence, their entry is set to 00 to avoid wastage of time.

Spoiler:

1. Damp (It checks the whole battle field for presence of Damp rather than a single target, so the 'faintifnotdamp' battlescript command needs to be modified for this. I'm leaving this for now because I'm lazy

2. Lightning and Storm Drain (Mold Breaker should allow redirection of move).

3. Friend Guard, Aroma Veil, Sweet Veil, Flower Veil (The target's boosts are sometimes by virtue of its Ally's Ability).

Modify the table accordingly if there is a need to.

Step II

Spoiler:

1a. Replace x8TTTTTT in the routines with the offset of the Mold breaker table.
1b. Insert these routines with byte changes in the respective code comments.

Routine I (Checks for user's Mold Breaker prior to move execution and then disables Abilities that are negated by Mold Breaker)

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global moldbreaker
     
AbilityBufferUser:
         push {r2-r4}
    ldr r0, .Bank
    ldr r0, [r0]
    mov r1, #0x58
    ldr r2, .BattleData
    mul r0, r1
    add r0, r0, r2
    ldrb r0, [r0]
MoldBreakerCheck:
    cmp r0, [B][U]#0x69[/U][/B]
       beq MoldBreaker
        cmp r0, [B][U]#0xA4[/U][/B]
        beq MoldBreaker
        cmp r0, [B][U]#0xA5[/U][/B]
        bne Return
MoldBreaker:
AbilityBufferTarget:
         ldr r0, .Bank
    add r0, #0x1
         ldrb r4, [r0]
    mul r1, r4 
    add r1, r1, r2 
         ldrb r3, [r1]
LoadTable:
         ldr r0, .MoldBreakerTable
       add r2, r0, r3
         ldrb r0, [r2]
CheckIfAffected:
        cmp r0, #0x0
         beq Return
Affected:
         mov r0, #0xFF
         strb r0, [r1]
         ldr r0, .DisabledAbilityLoc
         add r0, r4
         strb r3, [r0]
Return:
        pop {r2-r4}
         bl Canceler
         lsl r0, r0, #0x18
         lsr r2, r0, #0x18
         cmp r2, #0x0
         beq Continue
         ldr r0, .Return
         bx r0
Continue:
         ldr r0, .Return2
         bx r0

Canceler:
         ldr r0, .Return3
         bx r0

.align 2

.Bank: .word 0x02023D6B
.BattleData: .word 0x02023C04
.MoldBreakerTable: .word 0x08TTTTTT
.DisabledAbilityLoc: .word 0x0203C034
.Return: .word 0x0801DAFD
.Return2: .word 0x0801D7D7
.Return3: .word 0x080192D5

@At 1D7C8: 00 48 00 47 XX+1 XX XX 08

Routine II (Checks for user's Mold Breaker in target iterating moves like Earthquake and then disables abilities that negate damage)

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global moldbreakermultipletargets
     
AbilityBufferUser:
         push {r1-r4}
    ldr r0, .Bank
    ldr r0, [r0]
    mov r1, #0x58
    ldr r2, .BattleData
    mul r0, r1
    add r0, r0, r2
    ldrb r0, [r0]
MoldBreakerCheck:
    cmp r0, [B][U]#0x69[/U][/B]
       beq MoldBreaker
        cmp r0, [B][U]#0xA4[/U][/B]
        beq MoldBreaker
        cmp r0, [B][U]#0xA5[/U][/B]
        bne Return
MoldBreaker:
AbilityBufferTarget:
         ldr r0, .Bank
    add r0, #0x1
         ldrb r4, [r0]
    mul r1, r4 
    add r1, r1, r2 
         ldrb r3, [r1]
LoadTable:
         ldr r0, .MoldBreakerTable
       add r2, r0, r3
         ldrb r0, [r2]
CheckIfAffected:
        cmp r0, #0x0
         beq Return
Affected:
         mov r0, #0xFF
         strb r0, [r1]
         ldr r0, .DisabledAbilityLoc
         add r0, r4
         strb r3, [r0]
Return:
        pop {r1-r4}
         ldr r0, [r1]
    add r0, #0x1
    str r0, [r1]
    pop {r0}
    bx r0

.align 2

.Bank: .word 0x02023D6B
.BattleData: .word 0x02023C04
.MoldBreakerTable: .word 0x08TTTTTT
.DisabledAbilityLoc: .word 0x0203C034

@At 225E0: 00 48 00 47 XX+1 XX XX 08

Routine III and its associated Battle Script (Generation V effect. Makes the foe affected by entry hazards even if it has an ability to negate the hazards effect (except Magic Guard))

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global moldbreakerhazards
     
AbilityBufferUser:
         push {lr}
    ldr r0, .Bank
    ldrb r0, [r0]
    mov r1, #0x58
    ldr r2, .BattleData
    mul r0, r1
    add r0, r0, r2
    ldrb r0, [r0]
MoldBreakerCheck:
    cmp r0, [B][U]#0x69[/U][/B]
       beq MoldBreaker
        cmp r0, [B][U]#0xA4[/U][/B]
        beq MoldBreaker
        cmp r0, [B][U]#0xA5[/U][/B]
        bne Return
MoldBreaker:
AbilityBufferTarget:
         ldr r0, .Bank
    add r0, #0x1
         ldrb r4, [r0]
    mul r1, r4 
    add r1, r1, r2 
         ldrb r3, [r1]
LoadTable:
         ldr r0, .MoldBreakerTable
       add r2, r0, r3
         ldrb r0, [r2]
CheckIfAffected:
        cmp r0, #0x0
         beq Return
Affected:
         mov r0, #0xFF
         strb r0, [r1]
         ldr r0, .DisabledAbilityLoc
         add r0, r4
         strb r3, [r0]
Return:
    pop {r0}
    bx r0

.align 2

.Bank: .word 0x02023D6B
.BattleData: .word 0x02023C04
.MoldBreakerTable: .word 0x08TTTTTT
.DisabledAbilityLoc: .word 0x0203C034

.align 2
moldBreakerTable: .word 0x08TTTTTT

Battle Script at YYYYYY:

09 0A E2 00 58 00 3A 2B 04 4C 2B 02 02 08 00 00 00 [B]ZZ ZZ ZZ 08[/B] 2E 8A 3E 02 02 05 F6

Battle Script at ZZZZZZ:

4C 00 4D 00 4E 00 00 3A 10 54 01 F8 [B]XX+1 XX XX[/B] 28 52 00 28 4E 69 1D 08

At x28308 insert YY YY YY 08 in reverse hex

Routine IV (Restores disabled abilities at the end of move execution)

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global moldbreakerhazards
     
AbilityBufferUser:
         push {lr}
    ldr r0, .Bank
    ldrb r0, [r0]
    mov r1, #0x58
    ldr r2, .BattleData
    mul r0, r1
    add r0, r0, r2
    ldrb r0, [r0]
MoldBreakerCheck:
    cmp r0, #0x69
       beq MoldBreaker
        cmp r0, #0xA4
        beq MoldBreaker
        cmp r0, #0xA5
        bne Return
MoldBreaker:
AbilityBufferTarget:
         ldr r0, .Bank
    add r0, #0x1
         ldrb r4, [r0]
    mul r1, r4 
    add r1, r1, r2 
         ldrb r3, [r1]
LoadTable:
         ldr r0, .MoldBreakerTable
       add r2, r0, r3
         ldrb r0, [r2]
CheckIfAffected:
        cmp r0, #0x0
         beq Return
Affected:
         mov r0, #0xFF
         strb r0, [r1]
         ldr r0, .DisabledAbilityLoc
         add r0, r4
         strb r3, [r0]
Return:
    pop {r0}
    bx r0

.align 2

.Bank: .word 0x02023D6B
.BattleData: .word 0x02023C04
.MoldBreakerTable: .word 0x08TTTTTT
.DisabledAbilityLoc: .word 0x0203C034
[B]
.align 2
disablity: .word 0x0203C034[/B]

@ Go to your Battle Script command table, search for CD 2C 02 08 and replace it by XX+1 XX XX 08 (We are replacing the 'End' Battle Script Command. Not the case in Emerald).

Replacing the end command with the pointer to fourth routine freezes my game. Now, I have Life Orb routine inserted but I don't think it matters since we're replacing the end command anyway. Also look at the bottom of 4th routine, there seems to be some leftovers of code(bolded text). Also, is asm3 necessary or can I just ignore it?

 

[Trainer 781]

Replacing the end command with the pointer to fourth routine freezes my game. Now, I have Life Orb routine inserted but I don't think it matters since we're replacing the end command anyway. Also look at the bottom of 4th routine, there seems to be some leftovers of code(bolded text). Also, is asm3 necessary or can I just ignore it?

You can remove these bolded lines.
Asm 3 is for that situation when you have Spikes set up for the opposing team and if using the move Roar to brings out a Levitate Pokemon then it is damaged by Spiked. Thr routines 1,2 and 3 are independent of each other though i.e. do not require insertion of one or the other.