[Scripting Question] Changing moveset mid battle

[AmineFifty]

Hi, I made a Pokemon that changes forms depending on a certain weather like Castform. I want to make it change its moveset when the form is changed mid battle and then revert back to the moveset it had previously when it's back to the original form.
So far here's what I have done:
Changes the form when the weather is changed in PokeBatlle_Battler

Spoiler:

    if isConst?(self.species,PBSpecies,:FAKEMON) 
      if @battle.pbWeather==PBWeather::SUNNYDAY && self.form!=1
        self.form=1; transformed=true
      elsif @battle.pbWeather!=PBWeather::SUNNYDAY && self.form!=0
          self.form=0; transformed=true
      end
    end

Revert back to the original form

Spoiler:

  def pbResetForm
    if !@effects[PBEffects::Transform]
      if isConst?(self.species,PBSpecies,:CASTFORM) ||
         isConst?(self.species,PBSpecies,:CHERRIM) ||
         isConst?(self.species,PBSpecies,:DARMANITAN) ||
         isConst?(self.species,PBSpecies,:MELOETTA) ||
         isConst?(self.species,PBSpecies,:AEGISLASH) ||
         isConst?(self.species,PBSpecies,:XERNEAS) ||
         isConst?(self.species,PBSpecies,:FAKEMON)
        self.form=0
      end
    end
    pbUpdate(true)
  end

Changing forms works perfectly so far. My issue is with the moveset, I need the Pokemon to reset its moveset when it changes forms like it was caught in the wild. The only thing I was able to do is this.
In Pokemon_Forms

MultipleForms.register(:FAKEMON,{
"onSetForm"=>proc{|pokemon,form|
  if form>0
   pokemon.resetMoves
  end
}
})

This made the moveset reset but only in the summary screen, the battle menu is still showing the old moves. So I'm missing a line that updates the moves menu in real time this is my first problem.
My second problem is I don't know how to make a temporary array that stores the old moves before the form changes and then give it back to the Pokemon when it returns to its original form.
I hope someone can help me.

 

[mgriffin]

I don't know any precise answers, but I guess the thing to look into is how learning a level-up move mid-battle works.

 

[WolfPP]

Adapt what I did for legendaries wolves:
https://www.pokecommunity.com/showthread.php?p=10109969#post10109969

P.S: you'll need to store its actual moveset, in _Form script to turn back after battle.

 

[AmineFifty]

Here's what I tried, I put this in PokeBattle_Battler:

Spoiler:

    if isConst?(self.species,PBSpecies,:FAKEMON) 
      moves=[
        ]
      for i in 0...4
        moves[i]=self.moves[i]                                            # To store the current moves before changing
      end
      if @battle.pbWeather==PBWeather::SUNNYDAY && self.form!=1
        self.form=1; transformed=true
      elsif @battle.pbWeather!=PBWeather::SUNNYDAY && self.form!=0
        for i in 0...4
          self.moves[i]=moves[i]                                        # I didn't have this loop at first but I added it to see if something changes
        end
          self.form=0; transformed=true
      end
    end

and this when the Pokemon revert back to it's original form in pbResetForm:

Spoiler:

      if isConst?(self.species,PBSpecies,:FAKEMON)
        for i in 0...4
          p "move=#{moves[i].name}, i=#{i}"       #   This printed the old moves names correctly
          [COLOR="Red"]self.moves[i]=moves[i][/COLOR]
        end
        self.form=0
      end

Still nothing changed I have the exact same problems unfortunately, I also tried putting the script in Pokemon_Form but it didn't work.
I tried many things for the red line in the second script but nothing changed, here's what I tried:

self.moves[i]=PokeBattle_Move.pbFromPBMove(self,moves[i]) # From pbLearnMove, No error but nothing changed
self.moves[i]=PBMove.new(moves[i])                                              # Also from pbLearnMove, it gave me an error
self.moves[i]=PBMove.new(getID(PBMoves,newmove))               # From the thread mentioned by WolfPP, this gave an error aswell

Something to note when I added another print for self.moves names to see if it changed it showed the same results as the other print command whether I placed it before or after the red line.
I'm sorry if this script is a mess, my Ruby knowledge is very limited and I feel like it should be something easy I just can't seem to find how to accomplish it 😭

 

[AmineFifty]

Bump

 

[AmineFifty]

I managed to make it work, here's how I did it:

Spoiler:

In PokeBattle_Battler I added this line first

 attr_accessor :moves2

Then this block in pbCheckForm

    if isConst?(self.species,PBSpecies,:FAKEMON) 
      if @battle.pbWeather==PBWeather::SUNNYDAY&& self.form!=1
        @moves2 = [
        PokeBattle_Move.pbFromPBMove(@battle,@pokemon.moves[0]),
        PokeBattle_Move.pbFromPBMove(@battle,@pokemon.moves[1]),
        PokeBattle_Move.pbFromPBMove(@battle,@pokemon.moves[2]),
        PokeBattle_Move.pbFromPBMove(@battle,@pokemon.moves[3])
        ]
        for i in 0...4
          @moves2[i][email protected][i].pp
          @moves2[i][email protected][i].totalpp
        end
        self.form=1; transformed=true
      elsif @battle.pbWeather!=PBWeather::SUNNYDAY&& self.form!=0
          self.form=0; transformed=true
      end

And this in pbResetForm

      if isConst?(self.species,PBSpecies,:FAKEMON) && self.form!=0
        self.form=0
        for i in 0...4
          @pokemon.moves[i]=@moves2[i]
          #@pokemon.moves[i].pp=@moves2[i].pp
          #@pokemon.moves[i].totalpp=@moves2[i].totalpp
        end
      end

And finally in Pokemon_Forms

MultipleForms.register(:FAKEMON,{
"onSetForm"=>proc{|pokemon,form|
  if form>0
    pokemon.resetMoves
  end
}
})

Storing and resetting the moves worked fine however the only issue is that it won't update at the fight menu when choosing the command, it'll still show the old moves before changing the form, but when I check the summary menu it shows the correct moves.
I think I'm missing a line in the first block that updates/refresh the moveset mid battle. I tried adding these lines both in the first and last block but none of them worked

@buttons.refresh(self.index,moves,@megaButton)
@buttons.update(self.index,moves,@megaButton)
@scene.pbRefresh

From what I saw, the refresh/update methods are used in either PokeBattle_Battle or PokeBattle_Scene so I should probably use it there but I couldn't find any mentions of specific Pokemon forms.
If I didn't explain it very well let me know and I'll post screenshots or a video to explain better, any help is appreciated!
Edit: nvm the problem was something else completely, it have nothing to do with refreshing.