Red hack: Shin Pokemon Red/Blue/Green/JP builds (Bugfix, AI, and QoL patch)

[LinkNinjaMaster]

Hey, yes, I was referring to the Exp. boost that traded Pokémon receive and turns out that, according to my tests, they are not getting the boosted EXP. when receiving Exp via the Exp. All.

Video example of Exp. received not being boosted:
View attachment VID_20220822_001142.mp4

Calculations:

As far as I understand it, the base Exp that the active Pokémon receives is 50%, and the remaining 50% is divided by the number of Pokémon in the party (6 in this instance) and then distributed evenly. As you said, the traded Pokémon should get the boost applied even if the text doesn't reflect it, but I've done a couple of tests and it doesn't seem to be the case. You might want to look into it.

 

[jojobear13]

You might want to look into it.

I did an experiment on my latest development branch:
- Party of 6 with no fainted 'mons.
- Exp. All in the bag.
- Party slot 3 is a level 45 pidgeot with a different trainer ID and 84,251 experience.
- Main pokemon KOs Giovanni's level 45 rhyhorn.
- Main pokemon receives 645 experience.
- Pidgeot receives 157 experience.
- The other 5 pokemon receive 105 experience.

Looks okay from the perspective of the next update.

 

[LinkNinjaMaster]

Ok so maybe it wasn't updated in the regular version yet. Forget about it then 😅

 

[Жека]

How can I edit the code to make it have auto 60 fps and display genders/caught status. Then disable the difficulty trigger from the npc as well.

 

[jojobear13]

How can I edit the code to make it have auto 60 fps

60 fps is controlled by this bit:
https://github.com/jojobear13/shinp...a8122e338e6fefb25feab258f1462f/wram.asm#L3113

and display genders/caught status

Controlled by this event bit:
https://github.com/jojobear13/shinp...258f1462f/constants/event_constants.asm#L2321

Then disable the difficulty trigger from the npc as well.

Modify this text script:
https://github.com/jojobear13/shinp...fefb25feab258f1462f/scripts/oakslab.asm#L1303

 

[JulianoFdeS]

If the B button is press while a dialogue is running in instant speed option, it turns in fast speed (not a major problem, just something I realized)
Hey, could you add somehow to buy casino coins faster? Also, how about Pokémon Black 2 White 2 Repel system? Both would be a really nice quality of life update.
Did you fixed this glitch? https://www.youtube.com/watch?v=qHegthpAzhs (if not, you intend?)

Suggestion: Evolution Oak Aide! If toggled ON, the player's Pokémon refuse to evolve, no matter if it is an level, stone or trade evolution.
If you add this, my next PokéShin journey will use it as an option to make it even harder.

I noticed that I didn't got to fight against any gastly on my ShinPokeRed until find one wild in lavander, but I'm playing with randomizer toggled ON from the very beginning, did you blocked Gastly? My opponents already used lots of Haunter, but they never did used one single Gastly when my team was low level and I took more than 24 hours with lots of rematches before step inside Lavender Town. Just coincidence?

Damn, I already have +30 hours, that's not common for me playing RomHacks, I'm very addicted, it's a pity I don't have lots of free time to play it even more, but I can fully enjoy each fight. Don't let this hack die! Keep improving! Someday this will be recognized as one of the top best Gen 1 hack game to anyone play.

 

[jojobear13]

If the B button is press while a dialogue is running in instant speed option, it turns in fast speed (not a major problem, just something I realized)

I'll look into it.

Hey, could you add somehow to buy casino coins faster?

I have some ideas.

Also, how about Pokémon Black 2 White 2 Repel system?

The game engine does not track the kind of repel used, so this is an annoying feature to implement.

Did you fixed this glitch? https://www.youtube.com/watch?v=qHegthpAzhs (if not, you intend?)

Not a glitch. It's one of several intentional battle mechanics that gen 1 has that got removed in later generations.

Suggestion: Evolution Oak Aide! If toggled ON, the player's Pokémon refuse to evolve, no matter if it is an level, stone or trade evolution.

Features that replace the need for simply pressing B are low on the priority list.

I noticed that I didn't got to fight against any gastly on my ShinPokeRed until find one wild in lavander, but I'm playing with randomizer toggled ON from the very beginning, did you blocked Gastly? My opponents already used lots of Haunter, but they never did used one single Gastly when my team was low level and I took more than 24 hours with lots of rematches before step inside Lavender Town. Just coincidence?

The trainer randomizer evolves the opposing mons by level if appropriate.

Don't let this hack die!

There will come a time when I stop working on this. But it cannot truly die. Even when I stop work, someone else will just build upon it with a new project. That's the beauty of open source.

 

[JulianoFdeS]

The game engine does not track the kind of repel used, so this is an annoying feature to implement.

Nevermind, I thought it would be easy but actually I understand nothing about coding, so if this is hard I retire my suggestion.

Features that replace the need for simply pressing B are low on the priority list.

As far as I know, you can't stop stone or trade evolution. But this is not a must to have feature, just something I guess it would make the game fun and interesting for a few people (like me).

The trainer randomizer evolves the opposing mons by level if appropriate.

Yeah, but I thought is was weird I couldn't fight any randomized gastly before my team reaches level 25, not a problem, just a curiosity, I know the opponents is not intended to send any legendary mon, so the legendary mons aren't programmed to be randomized, but I questioned myself if Gastly wasn't allowed as well for balance purposes (if randomized in early game, like viridian forest, the player probably couldn't hit him, due the majority damage moves available are Normal-Type) or if it was just coincidence that I couldn't fight any at all.

There will come a time when I stop working on this. But it cannot truly die. Even when I stop work, someone else will just build upon it with a new project. That's the beauty of open source.

That's right, I guess Pokémon Prism is a good example of this (not sure), but it's sad that most hacks are unfinished and abandonned, but I hope you can complete your project with everything you have in mind.

One last suggestion, I know the customized teams like Leaders, Rival and Elite are untouched by randomizer feature, but how about the randomizer affect the order they are sent? so, for example, Rival in Lavander Tower could send his kadabra instead of pidgeotto, this would prevent the player to put an Super-Effective Pokémon (like graveler) against Pidgeotto just to force Rival to switch.

 

[jojobear13]

Yeah, but I thought is was weird I couldn't fight any randomized gastly before my team reaches level 25, not a problem, just a curiosity, I know the opponents is not intended to send any legendary mon, so the legendary mons aren't programmed to be randomized, but I questioned myself if Gastly wasn't allowed as well for balance purposes (if randomized in early game, like viridian forest, the player probably couldn't hit him, due the majority damage moves available are Normal-Type) or if it was just coincidence that I couldn't fight any at all.

I think it's just bad luck. This is the list of pokemon that are used.

but I hope you can complete your project with everything you have in mind.

I already did a year or two ago. Everything else is extra gravy.

One last suggestion, I know the customized teams like Leaders, Rival and Elite are untouched by randomizer feature, but how about the randomizer affect the order they are sent? so, for example, Rival in Lavander Tower could send his kadabra instead of pidgeotto, this would prevent the player to put an Super-Effective Pokémon (like graveler) against Pidgeotto just to force Rival to switch.

Interesting. I'll see what I can do.

 

[MStern]

- When starting a new game with an existing file, the text speed setting resets to default. This only happens if you press "new game" straight after booting up the rom - if you press "options" on the main menu beforehand to take a look, it carries over fine.
- If you have the Bike Voucher in your not-currently-active bag item list, it doesn't get removed when you receive the Bicycle. You end up with both the Bicycle and Bike Voucher in your inventories.

 

[jojobear13]

- When starting a new game with an existing file, the text speed setting resets to default. This only happens if you press "new game" straight after booting up the rom - if you press "options" on the main menu beforehand to take a look, it carries over fine.

Not a bug. Per the vanilla release, starting a regular New Game should initialize with the default options unless re-initialized to something else upon exiting the Options screen.

- If you have the Bike Voucher in your not-currently-active bag item list, it doesn't get removed when you receive the Bicycle. You end up with both the Bicycle and Bike Voucher in your inventories.

Acknowledged. Issue ticket #217 has been created.

 

[MStern]

Not a bug. Per the vanilla release, starting a regular New Game should initialize with the default options unless re-initialized to something else upon exiting the Options screen.
[/URL]

That's not how it behaves right now. Nuzlocke, level limit, and 60 fps mode all carry over automatically, while everything else resets. The other settings only carry over if you examine the settings menu before starting a new game, which is not intuitive.

 

[jojobear13]

That's not how it behaves right now. Nuzlocke, level limit, and 60 fps mode all carry over automatically, while everything else resets. The other settings only carry over if you examine the settings menu before starting a new game, which is not intuitive.

Ah, I see now. Resolved via issue ticket 220.

 

[MStern]

The "secret" house holding the Fly HM on Route 16 always bothered me. You find two NPCs there, both congratulating you for the feat of reaching it. This is despite the location being completely trivial to find - it's impossible to miss the Cut tree on the main path leading there. I was thinking of how to make the map more consistent with the lore, and came up this:

Something like this wouldn't let see the way in from the main path. You'd actually have to explore to find the entrance, just like finding the gift Eevee.

 

[JulianoFdeS]

Hey, the glitch that occured with LinkNinjaMaster also happened to me, but with my Pikachu! One letter got weirdly corrupted, I didn't played Pokémon Stadium neither traded with any other version, can't say when it happened, when LinkNinjaMaster reported it, I checked my nickname "Belwick" with all my Pokémon and my OT name was correct with all of them, even Pikachu. I didn't checked if any Pokémon in PC got one letter corrupted as well, I'll check it soon and update my comment.

https://postimg.cc/MXzjL8pq

 

[jojobear13]

Hey, the glitch that occured with LinkNinjaMaster also happened to me, but with my Pikachu! One letter got weirdly corrupted, I didn't played Pokémon Stadium neither traded with any other version, can't say when it happened, when LinkNinjaMaster reported it, I checked my nickname "Belwick" with all my Pokémon and my OT name was correct with all of them, even Pikachu. I didn't checked if any Pokémon in PC got one letter corrupted as well, I'll check it soon and update my comment.

https://postimg.cc/MXzjL8pq

Go to the name rater and pick a pokemon to change its nickname. When you get to the naming screen, is the ED character corrupted?

Edit: also, I need some additional information.
- version info of your game from the main screen.
- point in the game that you noticed everything was fine.
- point (and map) in the game you noticed the error.
- description of the activities you engaged in between those times and the general order in which you did them. Particularly any custom features of the rom hack. Was your pikachu always in your party for this duration?
- if possible, the name of the emulator core that your device is using.

I suspect this has to do with a memory-banking inaccuracy know to crop up in many emulators, but confirming and narrowing is always a challenge.

 

[jojobear13]

Now, I started playing Shin Red Lite (v1. 23 hotfix) to get an extra copy of Dig, but decided to trade and transfer some 'mons from my Blue save (using Pokémon Stadium on an android emulator) to obtain some other TM copies, but I just noticed that SOMEHOW my OT in my Butterfree and ONLY my Butterfree got its last letter corrupted. I don't know when it happened, probably when I transferred it with Stadium, but it's the only one that suffered that glitch. It doesn't seem to have any adverse effect, but I find it pretty weird. I have no idea if it has something to do with the hack, the saving process when using Stadium, or the emulators I used (M64Plus FZ for android, GameYob on the DS), but it happened.

Real quick. What's the history on this butterfree? It's only level 23, so that's not a lot of time for the corruption to happen. Did you catch it early and box it? Or was it in your party and you were doing some side-grinding? I'm trying to narrow down when this could occur.

 

[SPazzzi95]

It seems in the latest beta patch, whenever you start a battle the game freezes. Another thing i encountered is when you walk down the other npcs near you mpve in the same direction. Also when you wait for the starter mon on the title screen to slide out the game also freezes. Im also using the Pizzaboy emulator for android. Im assuming this has to do with the 60 fps mode changes?

 

[jojobear13]

It seems in the latest beta patch,

I tweaked a thing and re-uploaded the beta patches. Try it now.

whenever you start a battle the game freezes. Another thing i encountered is when you walk down the other npcs near you mpve in the same direction. Also when you wait for the starter mon on the title screen to slide out the game also freezes.

The problems you saw are likely caused by the new RNG system. It initializes a seed value from startup data within the hram when the game boots-up, but this seed value must be non-zero in order for the RNG to function. What you describe sounds like a non-functioning RNG.

Im also using the Pizzaboy emulator for android. Im assuming this has to do with the 60 fps mode changes?

Pizzaboy specifically has been known to have compatibility issues. On real hardware and on the BGB emulator, the startup data within the hram is all random garbage. There's no worry about ever having a zero seed value. But my guess is that Pizzaboy starts the hram as all zero, so you end up with a zero seed value and a non-functioning RNG.

 

[MStern]

There's a visual glitch with the man by the grass to the south of the Route 3 Mt Moon entrance / Pokemon center. When the player walks right, the tile beneath him flashes. This is on the dev patch.