Simple Modifications Directory

[Lunos]

Display Mugshots/Other Images In The Overworld (Emerald / Firered)

This modification allows you to load images onto BG0 from a script. It can only show one 16-color image at a time.

1. Installation

Spoiler:

1. Create mugshot.c in the src folder and copy the following code to it:

Spoiler:

#include "global.h"
#include "blit.h"
#include "window.h"
#include "menu.h"
#include "palette.h"
#include "event_data.h"
#include "constants/mugshots.h"

#define MUGSHOT_PALETTE_NUM 13

struct Mugshot{
    u8 x;
    u8 y;
    u8 width;
    u8 height;
    const u32* image;
    const u16* palette;
};

void DrawMugshot(void); //VAR_0x8000 = mugshot id
void DrawMugshotAtPos(void); //VAR_0x8000 = mugshot id, VAR_0x8001 = x, VAR_0x8002 = y
void ClearMugshot(void);


static const struct Mugshot sMugshots[] = {
    //ADD YOUR MUGSHOTS HERE
};


//WindowId + 1, 0 if window is not open
static EWRAM_DATA u8 sMugshotWindow = 0;

void ClearMugshot(void){
    if(sMugshotWindow != 0){
        ClearStdWindowAndFrameToTransparent(sMugshotWindow - 1, 0);
        CopyWindowToVram(sMugshotWindow - 1, 3);
        RemoveWindow(sMugshotWindow - 1);
        sMugshotWindow = 0;
    }
}

static void DrawMugshotCore(const struct Mugshot* const mugshot, int x, int y){
    struct WindowTemplate t;
    u16 windowId;
    
    if(sMugshotWindow != 0){
        ClearMugshot();
    }
    
    #if GAME_VERSION==VERSION_EMERALD
    SetWindowTemplateFields(&t, 0, x, y, mugshot->width/8, mugshot->height/8, MUGSHOT_PALETTE_NUM, 0x40);
    #else
    t = SetWindowTemplateFields(0, x, y, mugshot->width/8, mugshot->height/8, MUGSHOT_PALETTE_NUM, 0x40);
    #endif
    windowId = AddWindow(&t);
    sMugshotWindow = windowId + 1;
    
    LoadPalette(mugshot->palette, 16 * MUGSHOT_PALETTE_NUM, 32);
    CopyToWindowPixelBuffer(windowId, (const void*)mugshot->image, 0, 0);
    PutWindowRectTilemap(windowId, 0, 0, mugshot->width/8, mugshot->height/8);
    CopyWindowToVram(windowId, 3);
}

void DrawMugshot(void){
    const struct Mugshot* const mugshot = sMugshots + VarGet(VAR_0x8000);
    DrawMugshotCore(mugshot, mugshot->x, mugshot->y);
}

void DrawMugshotAtPos(void){
    DrawMugshotCore(sMugshots + VarGet(VAR_0x8000), VarGet(VAR_0x8001), VarGet(VAR_0x8002));
}

2. Create mugshots.h in include/constants/ and copy the following to it:

Spoiler:

#ifndef GUARD_CONSTANTS_MUGSHOTS_H
#define GUARD_CONSTANTS_MUGSHOTS_H

//Add your mugshot constants here

#endif

3. Open ld_script.txt and add .text and .rodata for mugshot.o:
Add this somewhere among the other src files' text sections (for example here):

src/mugshot.o(.text);

Add this somewhere among the other src files' rodata sections (for example here):

src/mugshot.o(.rodata);

4. Open sym_ewram.txt and add this to the end:

.include "src/mugshot.o"

5. Open data/event_scripts.s and add this after the includes at the top of the file:

#include "constants/mugshots.h"

2. Adding new mugshots

Spoiler:

Your mugshot images need to be 16-color indexed PNGs. Their width and height must be multiples of 8.

(OPTIONAL). Make a new folder called "mugshots" in the graphics folder for your images, you could also just place them in some other folder.

1. Add a constant for each image in include/constants/mugshots.h, each with a number one higher than the last:

#ifndef GUARD_CONSTANTS_MUGSHOT_H
#define GUARD_CONSTANTS_MUGSHOT_H

//Add your mugshot constants here
[COLOR="Lime"]#define MUGSHOT_BLAINE 0[/COLOR]
[COLOR="Lime"]#define MUGSHOT_MAZE 1[/COLOR]

#endif

2. Load the image's tiles and palette in src/mugshot.c, above the definition of sMugshots

[COLOR="Lime"]static const u32 sMugshotImg_Blaine[] = INCBIN_U32("graphics/mugshots/blaine.4bpp.lz");
static const u16 sMugshotPal_Blaine[] = INCBIN_U16("graphics/mugshots/blaine.gbapal");

static const u32 sMugshotImg_Maze[] = INCBIN_U32("graphics/mugshots/maze.4bpp.lz");
static const u16 sMugshotPal_Maze[] = INCBIN_U16("graphics/mugshots/maze.gbapal");
[/COLOR]

The path in the incbin is the path to your image except "png" is replaced with "4bpp.lz" for the tiles and "gbapal" for the palette.


3. Create mugshot templates in sMugshots in src/mugshot.c using the images and palettes from the last step and the constants from the first step

static const struct Mugshot sMugshots[] = {
    //ADD YOUR MUGSHOTS HERE
    [COLOR="Lime"][MUGSHOT_BLAINE] = {.x = 16, .y = 5, .width = 80, .height = 72, .image = sMugshotImg_Blaine, .palette = sMugshotPal_Blaine},[/COLOR]
    [COLOR="Lime"][MUGSHOT_MAZE] = {.x = 6, .y = 1, .width = 144, .height = 96, .image = sMugshotImg_Maze, .palette = sMugshotPal_Maze},[/COLOR]
};

Note that x & y are tile coordinates, so the mugshot will be drawn at (8*x, 8*y).

3. Using mugshots in a script

Spoiler:

There are 3 new functions, which you can call with the callnative command:
DrawMugshot: draws mugshot that's id is in VAR_0x8000
DrawMugshotAtPos: draws mugshot that's id is in VAR_0x8000, at coordinates stored in VAR_0x8001 and VAR_0x8002
ClearMugshot: clears drawn mugshot

If a mugshot is drawn while one is already on the screen, the previous one is automatically cleared.

Example script:

setvar VAR_0x8000, MUGSHOT_BLAINE
callnative DrawMugshot
msgbox SomeText, MSGBOX_NPC
callnative ClearMugshot
end

SomeText:
.string "hi.$"

I made a quick macro to use this feature in a prettier and more convenient manner.
Dropping it here in case anyone's interested:

	@ Calls a msgbox with a desired mugshot, string and msgbox type.
	.macro msgbox_mugshot msgText:req, msgType:req, mugshot:req
	setvar VAR_0x8000, \mugshot
	callnative DrawMugshot
	msgbox \msgText, \msgType
	callnative ClearMugshot
	.endm

Example of usage:

InsideOfTruck_EventScript_MovingBox::
	msgbox_mugshot InsideOfTruck_Text_BoxPrintedWithMonLogo, MSGBOX_SIGN, MUGSHOT_GREEN
	end

EDIT: It goes in asm/macros/event.inc like any other overworld scripting macro, by the way.

EDIT2: I made a few additions for those who may want a way to retain the mugshots on screen:

	@ Calls a msgbox with a desired mugshot, string and msgbox type.
	CLEAR_MUGSHOT = TRUE
	DONT_CLEAR_MUGSHOT = FALSE
	.macro msgbox_mugshot msgText:req, msgType:req, mugshot:req, clear=CLEAR_MUGSHOT
	setvar VAR_0x8000, \mugshot
	callnative DrawMugshot
	msgbox \msgText, \msgType
	.if \clear == CLEAR_MUGSHOT
		callnative ClearMugshot
	.endif
	.endm

Example of usage:

InsideOfTruck_EventScript_MovingBox::
	msgbox_mugshot InsideOfTruck_Text_BoxPrintedWithMonLogo, MSGBOX_SIGN, MUGSHOT_GREEN, DONT_CLEAR_MUGSHOT
	end

 

[Jaizu]

[pokéemerald] Checking how much ash you collected with the Soot Sack

If you're looking to get all the items the glass workshop on route 113 can make, you'll have to walk through a lot of volcanic ash – the pretty desk requires 8000 steps! I remember back when I repeatedly walked back and forth collecting ash, I wish I had an easy way to check how much I've collected without going back to the workshop and talking to the glass maker. Well, thanks to disassembly, we can make that happen. It's real simple too, as the code is based on what is used for the coin case and powder jar.

In scr/item_use.c, add the following functions (I added mine after ItemUseOutOfBattle_PowderJar). The first function displays the message when the soot sack is used and the second function gets the ash count for the first function to use.

void ItemUseOutOfBattle_SootSack(u8 taskId)
{
	ConvertIntToDecimalStringN(gStringVar1, GetAshCount(), STR_CONV_MODE_LEFT_ALIGN, 4);
	StringExpandPlaceholders(gStringVar4, gText_AshQty);
	if (!gTasks[taskId].tUsingRegisteredKeyItem)
	{
		DisplayItemMessage(taskId, 1, gStringVar4, BagMenu_InitListsMenu);
	}
	else
	{
		DisplayItemMessageOnField(taskId, gStringVar4, Task_CloseCantUseKeyItemMessage);
	}
}		

u16 GetAshCount(void)
{
	u16 *ashGatherCount;
	ashGatherCount = GetVarPointer(VAR_ASH_GATHER_COUNT);
	return *ashGatherCount;
}

Then in include/item_use.h, declare the functions we just added:

void ItemUseOutOfBattle_SootSack(u8);
u16 GetAshCount(void);

Now in src/strings.c, add the following string. This is the message the 1st function will display.

const u8 gText_AshQty[] = _("ASH QTY:\n{STR_VAR_1}{PAUSE_UNTIL_PRESS}");

Next, add the declaration for the new string in include/strings.h:

extern const u8 gText_AshQty[];

Finally, in src/data/items.h change .fieldUseFunc for the Soot Sack to use the first new function we created. It should look like this when you're done:

[ITEM_SOOT_SACK] =
    {
        .name = _("SOOT SACK"),
        .itemId = ITEM_SOOT_SACK,
        .price = 0,
        .description = sSootSackDesc,
        .importance = 1,
        .pocket = POCKET_KEY_ITEMS,
        .type = 4,
        .fieldUseFunc = ItemUseOutOfBattle_SootSack,
        .secondaryId = 0,
    },

And you're done! Pressing on use with the soot sack will show you the quantity of ash you have. It's simple but I'm proud of it cause I'm new to disassembly stuff and since I haven't seen it listed here yet so I thought, Wynaut add it?

Video example:
turns out I can't post links yet, but put this in your address bar on youtube, after the dot com /watch?v=E0rngXrOUb4

This won't compile on an up-to-date repo.
Use this function instead:

void ItemUseOutOfBattle_SootSack(u8 taskId)
{
	ConvertIntToDecimalStringN(gStringVar1, GetAshCount(), STR_CONV_MODE_LEFT_ALIGN, 4);
	StringExpandPlaceholders(gStringVar4, gText_AshQty);
	if (!gTasks[taskId].tUsingRegisteredKeyItem)
		DisplayItemMessage(taskId, FONT_NORMAL, gStringVar4, CloseItemMessage);
	else
		DisplayItemMessageOnField(taskId, gStringVar4, Task_CloseCantUseKeyItemMessage);
}

 

[Lunos]

Adding Hyper Training Stats [Em]
So, earlier, Jaizu was looking into adding the variables for Hyper Training to one of his projects.
These values signal the function used for stat calculations that the IVs of a Pokémon should be calculated as if they were maxed out.
The feature was originally added in Pokémon Sun/Moon.
I decided to give it a go myself because I was bored enough.
I got a working implementation, but I made some extra changes that were not needed at first.
So, after optimizing that out with Jaizu's help, I decided to come and post what I made here because why not.
It'd be a waste not to since I don't intend to use this myself anytime soon.

It's hard to showcase it, but in the following sheet, you can see the stats of a Torchic and a Magikarp before (top) and after (bottom) their stats' HYPER_TRAINED variables were flipped to TRUE.

To implement this, you can track my GitHub repository via git remote and pull the branch hyperTraining which is where I'm hosting the code:

git remote add lunos https://github.com/LOuroboros/pokeemerald
git pull lunos hyperTraining

Or you can implement things manually.
https://github.com/pret/pokeemerald/compare/master...LOuroboros:hyperTraining

Setting each hyper trained stat's parameters to TRUE is naturally up to the user.
For testing purposes, I made a field special that I invoked in a script via callnative to set the hyper trained stats for the 1st Pokémon in the party.

void HyperTrainPartyLeaderStats(void)
{
    u8 value = TRUE;
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_HP, &value);
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_ATK, &value);
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_DEF, &value);
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_SPEED, &value);
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_SPATK, &value);
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_SPDEF, &value);
    CalculateMonStats(&gPlayerParty[0]);
}

And that's pretty much it.​

 

[OPPAIDAISUKI]

Increase bag item capacity(em)

When I increase TMHM capacity,I discover this code:
#define MAX_BAG_ITEM_CAPACITY 99
So I try to increase bag item capacity.

Firstly,open include/constants/items.h,and change MAX_BAG_ITEM_CAPACITY to 999,change BAG_ITEM_CAPACITY_DIGITS to 3.

Then,open src/item.c,search AddPyramidBagItem,Change "*newquantities" in this function to u16.

Finally,open include/shop.h,In the "shopdata",change maxquantity to u16.

I haven't found any bugs yet.

Hi Sir!!! i have a question on shopdata is it shopdata c or h?...and if its shop.c where is this "maxquantity" located...sorry im just a newbie... im having a hard time to find this because of quick or just shortcut guide... thanks!!!!

 

[OPPAIDAISUKI]

in my rom there was this error according to the image because I'm using the expanded bag, I don't know if it would have a link or not, it's the only thing I think could cause a problem. Even when it disappears from this black screen, it goes straight to another screen and freezes the game, but if you register the item as in Key items, nothing happens.

Hi Sir!!! how and where did you change the last part.. (Finally,open include/shop.h,In the "shopdata",change maxquantity to u16.) Thank you!!

 

[Ryurs]

Trainer Class-Based Poké Balls (Emerald)

Trainers in the gen VII games send out their Pokemon in different balls depending what class they are, so I've implemented that in Emerald.

First, go to include\battle_main.h and add a new struct like so:

struct TrainerBall
{
    u8 classId;
    u8 Ball; // make this a u16 if needed
};

Then add a table of these to src\battle_main.c:

Spoiler:

const struct TrainerBall gTrainerBallTable[] = {
    {TRAINER_CLASS_TEAM_AQUA, ITEM_NET_BALL},
    {TRAINER_CLASS_AQUA_ADMIN, ITEM_NET_BALL},
    {TRAINER_CLASS_AQUA_LEADER, ITEM_MASTER_BALL},
    {TRAINER_CLASS_AROMA_LADY, ITEM_FRIEND_BALL},
    {TRAINER_CLASS_RUIN_MANIAC, ITEM_DUSK_BALL},
    {TRAINER_CLASS_INTERVIEWER, ITEM_REPEAT_BALL},
    {TRAINER_CLASS_TUBER_F, ITEM_DIVE_BALL},
    {TRAINER_CLASS_TUBER_M, ITEM_DIVE_BALL},
    {TRAINER_CLASS_SIS_AND_BRO, ITEM_POKE_BALL},
    {TRAINER_CLASS_COOLTRAINER, ITEM_ULTRA_BALL},
    {TRAINER_CLASS_HEX_MANIAC, ITEM_DUSK_BALL},
    {TRAINER_CLASS_LADY, ITEM_LUXURY_BALL},
    {TRAINER_CLASS_BEAUTY, ITEM_LOVE_BALL},
    {TRAINER_CLASS_RICH_BOY, ITEM_LUXURY_BALL},
    {TRAINER_CLASS_POKEMANIAC, ITEM_MOON_BALL},
    {TRAINER_CLASS_SWIMMER_M, ITEM_DIVE_BALL},
    {TRAINER_CLASS_BLACK_BELT, ITEM_HEAVY_BALL},
    {TRAINER_CLASS_GUITARIST, ITEM_FAST_BALL},
    {TRAINER_CLASS_KINDLER, ITEM_POKE_BALL},
    {TRAINER_CLASS_CAMPER, ITEM_NEST_BALL},
    {TRAINER_CLASS_OLD_COUPLE, ITEM_POKE_BALL},
    {TRAINER_CLASS_BUG_MANIAC, ITEM_NET_BALL},
    {TRAINER_CLASS_PSYCHIC, ITEM_DREAM_BALL},
    {TRAINER_CLASS_GENTLEMAN, ITEM_LUXURY_BALL},
    {TRAINER_CLASS_ELITE_FOUR, ITEM_ULTRA_BALL},
    {TRAINER_CLASS_LEADER, ITEM_ULTRA_BALL},
    {TRAINER_CLASS_SCHOOL_KID, ITEM_POKE_BALL},
    {TRAINER_CLASS_SR_AND_JR, ITEM_POKE_BALL},
    {TRAINER_CLASS_POKEFAN, ITEM_POKE_BALL},
    {TRAINER_CLASS_EXPERT, ITEM_ULTRA_BALL},
    {TRAINER_CLASS_YOUNGSTER, ITEM_POKE_BALL},
    {TRAINER_CLASS_CHAMPION, ITEM_CHERISH_BALL},
    {TRAINER_CLASS_FISHERMAN, ITEM_LURE_BALL},
    {TRAINER_CLASS_TRIATHLETE, ITEM_FAST_BALL},
    {TRAINER_CLASS_DRAGON_TAMER, ITEM_ULTRA_BALL},
    {TRAINER_CLASS_BIRD_KEEPER, ITEM_QUICK_BALL},
    {TRAINER_CLASS_NINJA_BOY, ITEM_QUICK_BALL},
    {TRAINER_CLASS_BATTLE_GIRL, ITEM_HEAVY_BALL},
    {TRAINER_CLASS_PARASOL_LADY, ITEM_POKE_BALL},
    {TRAINER_CLASS_SWIMMER_F, ITEM_DIVE_BALL},
    {TRAINER_CLASS_PICNICKER, ITEM_FRIEND_BALL},
    {TRAINER_CLASS_TWINS, ITEM_POKE_BALL},
    {TRAINER_CLASS_SAILOR, ITEM_DIVE_BALL},
    {TRAINER_CLASS_COLLECTOR, ITEM_REPEAT_BALL},
    {TRAINER_CLASS_PKMN_TRAINER_3, ITEM_PREMIER_BALL},
    {TRAINER_CLASS_PKMN_BREEDER, ITEM_TIMER_BALL},
    {TRAINER_CLASS_PKMN_RANGER, ITEM_SAFARI_BALL},
    {TRAINER_CLASS_TEAM_MAGMA, ITEM_NEST_BALL},
    {TRAINER_CLASS_MAGMA_ADMIN, ITEM_NEST_BALL},
    {TRAINER_CLASS_MAGMA_LEADER, ITEM_MASTER_BALL},
    {TRAINER_CLASS_LASS, ITEM_POKE_BALL},
    {TRAINER_CLASS_BUG_CATCHER, ITEM_NET_BALL},
    {TRAINER_CLASS_HIKER, ITEM_HEAVY_BALL},
    {TRAINER_CLASS_YOUNG_COUPLE, ITEM_LOVE_BALL},
    {TRAINER_CLASS_WINSTRATE, ITEM_GREAT_BALL},
    {TRAINER_CLASS_PKMN_TRAINER_2, ITEM_HEAVY_BALL},
    {0xFF, ITEM_POKE_BALL},
};

Finally, add the code in bold to the end of the first for loop in the function CreateNPCTrainerParty, which is also in src\battle_main.c, like so:

Spoiler:

                for (j = 0; j < MAX_MON_MOVES; j++)
                {
                    SetMonData(&party[i], MON_DATA_MOVE1 + j, &partyData[i].moves[j]);
                    SetMonData(&party[i], MON_DATA_PP1 + j, &gBattleMoves[partyData[i].moves[j]].pp);
                }
                break;
            }
[B]            }
// New code starts here
            for (j = 0; gTrainerBallTable[j].classId != 0xFF; j++)
            {
                if (gTrainerBallTable[j].classId == gTrainers[trainerNum].trainerClass)
                    break;
            }
            SetMonData(&party[i], MON_DATA_POKEBALL, &gTrainerBallTable[j].Ball);[/B]
        }

Hello good! I tried this and the truth is that it works very well, I like it. But I found that for Battle Frontier battles this doesn't apply, and all trainers will still throw normal pokeballs. Would it be possible to make this addition?

 

[Buffel Saft]

Hello good! I tried this and the truth is that it works very well, I like it. But I found that for Battle Frontier battles this doesn't apply, and all trainers will still throw normal pokeballs. Would it be possible to make this addition?

It's 100% possible. The frontier trainers use separate trainer classes with the same names as the normal trainer classes (I don't know why), so that's why they're unaffected by this change. You could do something similar to this to the code that generates frontier Pokémon to get it working there too.

 

[Lunos]

Generation III+ sets the power of these moves to 1 if the formula spits out 0. As it is implemented right now, the summary screen can report 0 as the power. Calculating the power first and then setting it to 1 if it's 0 before printing is the fix.

Read the 2 posts below that one.

 

[Deokishisu]

This has been fixed in ghoulslash's repo, so I've spoilered my original post to save people scrolling space.

Spoiler:

It's been a while since I've posted anything, so here's a small feature from fire red:

[Pokeemerald] Auto-read signposts

This feature allows the player to read a signpost by walking up to it, rather than needing to press A. The player is also able to walk away while the script is running.

How to add more signposts:

• Currently, your tile must have behavior "MB_SIGNPOST" in order for this feature to work. Keep reading if you want to add new behaviors that the player can auto-read from
• You can add a new signpost type based on these defines
• Add your metatile behavior check here
• Add your custom script in the switch statement here

How to add this feature:

• git remote add ghoul https://github.com/ghoulslash/pokeemerald/
• git pull ghoul signpost

This omits some functionality from FRLG that is needed to prevent bugs. For example, with the current implementation, dismissing a multi-page signpost that you've auto-read without advancing it and then immediately trying to save will glitch out your start menu. FRLG prevents this behavior by setting the current msgbox's text to EOS when cancelling it. Additionally, this implementation closes the textbox early when start is pressed, but doesn't open the start menu like in FRLG.

To fix the first one, in EventScript_CancelMessageBox, do this:

EventScript_CancelMessageBox::
[COLOR="Green"]+	special DoPicboxCancel[/COLOR]
	release
	end

Then, add this new special to data\specials.inc:

[COLOR="Green"]+	def_special DoPicboxCancel[/COLOR]

Then, in field_specials.c, add the functionality:

[COLOR="Green"]+void DoPicboxCancel(void)
+{
+    u8 t = EOS;
+    AddTextPrinterParameterized(0, FONT_NORMAL, &t, 0, 1, 0, NULL);
+    ScriptMenu_HidePokemonPic();
+}[/COLOR]

Alternatively, if you don't want to waste a special, you can just callnative DoPicboxCancel in EventScript_CancelMessageBox. I made it a special because this is what FRLG does.

To have it mimic FRLG in opening the start menu in addition to cancelling the textbox when start is pressed, add this to field_control_avatar.c:

[COLOR="Green"]+static void Task_OpenStartMenu(u8 taskId)
+{
+    if (!ArePlayerFieldControlsLocked())
+    {
+        PlaySE(SE_WIN_OPEN);
+        ShowStartMenu();
+        DestroyTask(taskId);
+    }
+}[/COLOR]

void FieldInput_HandleCancelSignpost(struct FieldInput *input)
{
    if (ScriptContext_IsEnabled() == TRUE)
    {
        if (gWalkAwayFromSignInhibitTimer != 0)
        {
            gWalkAwayFromSignInhibitTimer--;
        }
        else if (CanWalkAwayToCancelMsgBox() == TRUE)
        {
            //ClearMsgBoxCancelableState();
            if (input->dpadDirection != 0 && GetPlayerFacingDirection() != input->dpadDirection)
            {
                ScriptContext_SetupScript(EventScript_CancelMessageBox);
                LockPlayerFieldControls();
            }
            else if (input->pressedStartButton)
            {
                ScriptContext_SetupScript(EventScript_CancelMessageBox);
                LockPlayerFieldControls();[COLOR="Green"]
+                if (!FuncIsActiveTask(Task_OpenStartMenu))
+                    CreateTask(Task_OpenStartMenu, 8);[/COLOR]
            }
        }
    }
}

 

[PerceptioN95]

Faster Soft Resets (Emerald)

This modification makes soft resetting faster by taking the player straight to the continue/new game screen after a soft reset.

How to:

Spoiler:

1. Open src/main.c and make the following changes:

1.1. Add these #includes at the top of the file:

#include "main_menu.h"
#include "save.h"
#include "new_game.h"

1.2. Declare gSoftResetFlag and CB2_PostSoftResetInit somewhere after the #includes:

EWRAM_DATA u8 gSoftResetFlag;

static void CB2_PostSoftResetInit(void);

1.3. Remove this line from the start of AgbMain:

[COLOR="Red"]RegisterRamReset(RESET_ALL);[/COLOR]

1.4. Replace this line in InitMainCallbacks:

[COLOR="Red"]SetMainCallback2(CB2_InitCopyrightScreenAfterBootup);[/COLOR]

with this:

[COLOR="Lime"]if(gSoftResetFlag){
    SetMainCallback2(CB2_PostSoftResetInit);
}else{
    SetMainCallback2(CB2_InitCopyrightScreenAfterBootup);
}[/COLOR]

1.5. Paste this function at the end of the file

static void CB2_PostSoftResetInit(void){
    SetSaveBlocksPointers(GetSaveBlocksPointersBaseOffset());
    ResetMenuAndMonGlobals();
    Save_ResetSaveCounters();
    Save_LoadGameData(SAVE_NORMAL);
    if (gSaveFileStatus == SAVE_STATUS_EMPTY || gSaveFileStatus == SAVE_STATUS_CORRUPT)
        Sav2_ClearSetDefault();
    SetPokemonCryStereo(gSaveBlock2Ptr->optionsSound);
    SetMainCallback2(CB2_InitMainMenu);
}

2. Open libagbsyscall/libagbsyscall.s and find the SoftReset function. Add these 3 commands between the svc commands at the end of the function.

...
svc #1
[COLOR="Lime"]ldr r0, =gSoftResetFlag
movs r1, #1
strb r1, [r0][/COLOR]
svc #0
...

BONUS: Removing the dry battery message on soft resets
1. Open src/main_menu.c, add an extern declaration for gSoftResetFlag somewhere after the #includes:

extern u8 gSoftResetFlag;

2. Change this line in Task_MainMenuCheckBattery to:

if ([COLOR="Lime"]gSoftResetFlag || [/COLOR]!(RtcGetErrorStatus() & RTC_ERR_FLAG_MASK))

EDIT: updated sub_815355C to GetSaveBlocksPointersBaseOffset

sorry to bump,

i get the following error, after copying everything you did 1:1

tools/agbcc/bin/agbcc <flags> -o build/emerald/src/main.o src/main.c
agbcc: warnings being treated as errors
src/main.c: In function `CB2_PostSoftResetInit':
src/main.c:458: warning: implicit declaration of function `Save_LoadGameData'
make: *** [Makefile:342: build/emerald/src/main.o] Error 1
make: *** Deleting file 'build/emerald/src/main.o'


edit: seem to have fixed the issue

replaced
Save_LoadGameData(SAVE_NORMAL);

with
LoadGameSave(SAVE_NORMAL);

leaving this here incase anyone needs it :)

 

[Robinlukke]

[pokeemerald] Berries grow faster

Very simple edit, in "src/berry.c" go to:

static u16 GetStageDurationByBerryType(u8 berry)
{
    return GetBerryInfo(berry)->stageDuration * [COLOR="Red"]60[/COLOR];
}

And replace 60 with the number of your choice (that's the number of minutes a growth stage lasts).

(I usually change it to 10).

 

[snaid1]

[Pokeemerald] Rock Climb

This adds the gen 4 rock climb field effect to scale cliffs.

How to add:

• git remote add ghoul https://github.com/ghoulslash/pokeemerald
• git pull ghoul rock-climb

How to use:

• Give your rock-climbable metatile the MB_ROCK_CLIMB behavior. That's it!

Please report any bugs.

I'm trying to implement your rock climb branch and, mechanically, it works great. However I'm having some graphical glitches that I can't seem to figure out (See attachment). any ideas how I can fix this?

 

[Robinlukke]

Spoiler:

[Pokeemerald] Use Fly/Flash from party menu if Pokémon is compatible

The following changes allow Fly and/or Flash to be used in the field if the Pokémon is able to learn the relevant HMs, without them needing to be taught. Of course, the necessary gym badges are still required.

All of the changes are made in src\party_menu.c (SetPartyMonFieldSelectionActions) and can be found in this commit:
https://github.com/Scyrous/pokeemerald/commit/2b263a419784b63252ecdd3f576472ee0b3ce136

Demonstration:

Both Xatu and Latios are compatible with Fly/Flash. Because Latios already knows 3 HM moves, only Fly is added to the action list.

Notes:
If the Pokémon already knows fly or flash, the moves will show up as usual.
If the Pokémon already knows 4 field moves, no new moves will be added to the action list.
If the Pokémon knows less than 4 field moves, Fly will be prioritized over Flash.

Extra code you can add (lines highlighted in RED):

    if (sPartyMenuInternal->numActions < 5 && CanMonLearnTMHM(&mons[slotId], ITEM_HM02 - ITEM_TM01)
		[COLOR="Red"]&& (Overworld_MapTypeAllowsTeleportAndFly(gMapHeader.mapType) == TRUE))[/COLOR] [COLOR="SeaGreen"]// If map allows FLY[/COLOR]
        AppendToList(sPartyMenuInternal->actions, &sPartyMenuInternal->numActions, 5 + MENU_FIELD_MOVES);
    if (sPartyMenuInternal->numActions < 5 && CanMonLearnTMHM(&mons[slotId], ITEM_HM05 - ITEM_TM01)
		[COLOR="Red"]&& (gMapHeader.cave == TRUE) && (!FlagGet(FLAG_SYS_USE_FLASH)))[/COLOR] [COLOR="SeaGreen"]// If map allows FLASH and it wasn't used already[/COLOR]
        AppendToList(sPartyMenuInternal->actions, &sPartyMenuInternal->numActions, 1 + MENU_FIELD_MOVES);

With this, you can use FLY/FLASH only where it's possible, otherwise they won't appear on the list.

 

[WiserVisor]

Display Mugshots/Other Images In The Overworld (Emerald / Firered)
............

Is there anyway to place the mugshot with more precision? I've been working on a project that uses this code, but the mugshot is always a little above the message box, leaving some space between the box and the mugshot, or it's clipping into the box. Changing the y-position shifts it by a lot, it seems. I know of other sprite-displaying functions like CreateMonSprite_PicBox that have a lot more precision, but I haven't been able to get the mugshot to display properly using one of those functions.

 

[Anon822]

Is there anyway to place the mugshot with more precision? I've been working on a project that uses this code, but the mugshot is always a little above the message box, leaving some space between the box and the mugshot, or it's clipping into the box. Changing the y-position shifts it by a lot, it seems. I know of other sprite-displaying functions like CreateMonSprite_PicBox that have a lot more precision, but I haven't been able to get the mugshot to display properly using one of those functions.

The mugshots are drawn to a tiled background, limiting you to the 8x8 tile grid. You could probably do some blitting to get more precision, or you could use sprites, but that might not be necessary if your only concern is the space above message boxes.

The easiest solution is to edit the message box graphic so that it doesn't have empty pixels above the textbox.
Another option is to use a HBlank callback:

--- a/src/mugshot.c
+++ b/src/mugshot.c
@@ -7,6 +7,8 @@
 #include "palette.h"
 #include "event_data.h"
 #include "constants/mugshots.h"
+#include "main.h"
+#include "gpu_regs.h"
 
 #define MUGSHOT_PALETTE_NUM 13
 
@@ -42,6 +44,7 @@ void ClearMugshot(void){
         CopyWindowToVram(sMugshotWindow - 1, 3);
         RemoveWindow(sMugshotWindow - 1);
         sMugshotWindow = 0;
+        DisableInterrupts(INTR_FLAG_HBLANK);
     }
 }
 
@@ -76,3 +79,12 @@ void DrawMugshotAtPos(void){
     DrawMugshotCore(sMugshots + VarGet(VAR_0x8000), VarGet(VAR_0x8001), VarGet(VAR_0x8002));
 }
 
+void HBlank_Mugshot(void){
+    REG_BG0VOFS = REG_VCOUNT > 113 ? 0 : -3;
+}
+
+void DrawShiftedMugshot(void){ //Use this in your script instead of DrawMugshot
+    DrawMugshot();
+    SetHBlankCallback(HBlank_Mugshot);
+    EnableInterrupts(INTR_FLAG_HBLANK);
+}

The DrawShiftedMugshot function basically shifts everything above the textbox on BG0 down by three pixels. Obviously this will only work if you're not already using the HBlank callback for something else, and your mugshot doesn't touch the top of the screen.

 

[AlmightyK]

Then, we go to src/data/party_menu.h and we add:

MENU_MOVES,

Anywhere in the the enum section with the menus. It's the one with "MENU_SUMMARY".

After that, we search for "[MENU_SUMMARY] = {gText_Summary5, CursorCb_Summary}," and we add underneath:

[MENU_MOVES] = {gText_Moves_Menu, CursorCb_Moves},

The ENUM list no longer exists in party_menu.h
Is there something else I should do instead or is this just dead?

 

[Lunos]

The ENUM list no longer exists in party_menu.h
Is there something else I should do instead or is this just dead?

The enum was moved src/party_menu.c.
https://github.com/pret/pokeemerald/blob/master/src/party_menu.c#L76-L97

 

[セケツ]

[PokeEmerald] Make Cycling Music not get itself faded when stepping into another map.

It has been a long time since my last post here, and here is another tiny & little discovery of myself, which I couldn't find in either here or the Pret's wiki site.
It's known to us that in the original PokeEmerald, when player rides the bike and steps into a new map. Despite the player him(her)self is still on the bike, the cycling music in the background has been faded & changed into nothing but the music of the newmap itself.
And today here, for anyone who wants to keep it still playing in background (Just like how the SURFING music did in the original game). Here are some tiny & simple changes for getting it works.
Since it's a change for the music, for anyone still can't get what I'm saying, please take a clear comparison of the difference of how the music playing in the background between the SURFING & the CYCLING. Sorry there is no way to put up a explanation picture here.
First, open the source code file named "overworld.c" laid in the src folder. And find the function named "TransitionMapMusic" in here, which takes the control of the music when it comes to the map transition. Just as its name said.

Next, do some changes at those two if & else lines, as the picture I showed below.

Then save your code & test.

I haven't found any bug yet, Moreover, if anyone else found it had been posted in any other place, please leave a comment or at least send a message, Then I will delete it in time. And certainly, if you find any bug, glitch, or something wrong with this tutorial. Please contact me as well.
Thanks everyone for reading & really sorry for my poor English.

 

[AlmightyK]

Adding Hyper Training Stats [Em]

Or you can implement things manually.
https://github.com/pret/pokeemerald/compare/master...LOuroboros:hyperTraining

Setting each hyper trained stat's parameters to TRUE is naturally up to the user.
For testing purposes, I made a field special that I invoked in a script via callnative to set the hyper trained stats for the 1st Pokémon in the party.

void HyperTrainPartyLeaderStats(void)
{
    u8 value = TRUE;
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_HP, &value);
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_ATK, &value);
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_DEF, &value);
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_SPEED, &value);
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_SPATK, &value);
    SetMonData(&gPlayerParty[0], MON_DATA_HYPER_TRAINED_SPDEF, &value);
    CalculateMonStats(&gPlayerParty[0]);
}

And that's pretty much it.​

Attempted to add manually and received errors

Spoiler:

src/pokemon.c: In function `CreateBoxMon':
src/pokemon.c:3631: `MON_DATA_HYPER_TRAINED_ATTACK' undeclared (first use in this function)
src/pokemon.c:3631: (Each undeclared identifier is reported only once
src/pokemon.c:3631: for each function it appears in.)
src/pokemon.c:3632: `MON_DATA_HYPER_TRAINED_DEFENSE' undeclared (first use in this function)
src/pokemon.c:3634: `MON_DATA_HYPER_TRAINED_SP_ATTACK' undeclared (first use in this function)
src/pokemon.c:3635: `MON_DATA_HYPER_TRAINED_SP_DEFENSE' undeclared (first use in this function)

and further

Spoiler:

src/recorded_battle.c:34: size of array `RecordedBattleSaveFreeSpace' is negative

 

[Lunos]

Attempted to add manually and received errors

Spoiler:

src/pokemon.c: In function `CreateBoxMon':
src/pokemon.c:3631: `MON_DATA_HYPER_TRAINED_ATTACK' undeclared (first use in this function)
src/pokemon.c:3631: (Each undeclared identifier is reported only once
src/pokemon.c:3631: for each function it appears in.)
src/pokemon.c:3632: `MON_DATA_HYPER_TRAINED_DEFENSE' undeclared (first use in this function)
src/pokemon.c:3634: `MON_DATA_HYPER_TRAINED_SP_ATTACK' undeclared (first use in this function)
src/pokemon.c:3635: `MON_DATA_HYPER_TRAINED_SP_DEFENSE' undeclared (first use in this function)

Make sure you did declare those MON_DATA variables at include/pokemon.h.

and further

Spoiler:

src/recorded_battle.c:34: size of array `RecordedBattleSaveFreeSpace' is negative

That one's unrelated.
Your project's struct RecordedBattleSave is bigger than its maximum allocated size, so the Assert put in place to notify the user of this prevents the compiler from building a ROM.