I'm usually very unlucky with shinies, for example back when I used to play Crystal, I found a shiny Sentret when I had no pokeballs right at the beginning of the game, then when I found the red Gyarados... yup...made it faint. In Diamond however I have come across a shiny Machop, Geodude and Kricketune. Luckily I caught them all :)