[Other] Tile script problem

[BCTElite]

Okay, so I turned the level script into a tile script and im getting another few issues.

SCRIPT BELOW

Spoiler:

#dynamic 0x800000
#org @start
lockall
setvar 0x4005 0x0
goto @begin
end

#org @begin
applymovement 0x4 0x8808E36
applymovement MOVE_PLAYER 0x8808E41
waitmovement 0x4
waitmovement 0xFF
msgbox 0x8808E59 MSG_NORMAL '"Hawthorn: [player], congrats on ge..."
applymovement 0x4 0x8808E4B
waitmovement 0x4
msgbox 0x8809388 MSG_NORMAL '"Hawthorn: ..., I see."
applymovement 0x4 @profmove
Waitmovement 0x4
msgbox @oak 0x6
release
end

'---------
' Strings
'---------
#org 0x808E59
= Hawthorn: [player], congrats on getting\na Pokémon. I remeber my first\lPokémon, my partner gave it to me\las a birthday gift a long time ago\lnow. Anyway, I have asked here to\l...

#org 0x809388
= Hawthorn: ..., I see.

#org @oak
= Hawthorn: Ah, sorry about that. I\nrecieved a message from\lLuxborough. I ordered a parcel a\lfew weeks ago and it finally\larrived. Could you pop over to the\lPokémart and get it for me?

'-----------
' Movements
'-----------
#org 0x808E36
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x0 'Face Down
#raw 0xFE 'End of Movements

#org 0x808E41
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0xFE 'End of Movements

#org 0x808E4B
#raw 0x62 'Exclamation Mark (!)
#raw 0x12 'Step Left (Normal)
#raw 0x12 'Step Left (Normal)
#raw 0x12 'Step Left (Normal)
#raw 0x12 'Step Left (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0xFE 'End of Movements

#org @profmove
#raw 0x13
#raw 0x13
#raw 0x13
#raw 0x13
#raw 0x10
#raw 0xFE

Basically, the issues I have are as follows

The script activates as soon as you step on it (It is found in the prof's lab) despite on the prof being in the lab or not. I want it to follow on from the Oak taking you to the lab script. Do I need to use a checkflag here?

The script also actiaves as soon as I step on it, every time I step on it. I can step on it once and get the script to activate, and it does, but then I walk back and try to leave and it starts again. And again. and Again. Is there a way to make it a one time only thing.

Also all the text it black, can I change it to all be the same blue as Oak?

 

[Yvtq8K3n]

U need to free the flag after u step on it.(in order to only happen once), i cant help u alot because i forget great part of the xse.

 

[BCTElite]

U need to free the flag after u step on it.(in order to only happen once), i cant help u alot because i forget great part of the xse.

This is all I have at the moment.
It doesn't activate every time I try to leave, but If I re-enter the lab it activates again. So I go in, it activates if I go off the tile and back on, then it plays through the script, then it allows me to leave. If I walk back in then the script just starts back up again.

Spoiler:

#dynamic 0x800000
#org @start
lockall
setvar 0x4005 0x0
checkflag 0x840
if 0x0 goto @done
checkflag 0x2C
if 0x0 goto @done
goto @begin
end

#org @done
release
end

#org @begin
textcolor 0x00
applymovement 0x4 0x8808E36
applymovement MOVE_PLAYER 0x8808E41
waitmovement 0x4
waitmovement 0xFF
msgbox 0x8808E59 MSG_NORMAL '"Hawthorn: [player], congrats on ge..."
applymovement 0x4 0x8808E4B
waitmovement 0x4
msgbox 0x8809388 MSG_NORMAL '"Hawthorn: ..., I see."
applymovement 0x4 @profmove
Waitmovement 0x4
msgbox @oak 0x6
setvar 0x4005 0x1
setflag 0x840
release
end

'---------
' Strings
'---------
#org 0x808E59
= Hawthorn: [player], congrats on getting\na Pokémon. I remeber my first\lPokémon, my partner gave it to me\las a birthday gift a long time ago\lnow. Anyway, I have asked here to\l...

#org 0x809388
= Hawthorn: ..., I see.

#org @oak
= Hawthorn: Ah, sorry about that. I\nrecieved a message from\lLuxborough. I ordered a parcel a\lfew weeks ago and it finally\larrived. Could you pop over to the\lPokémart and get it for me?

'-----------
' Movements
'-----------
#org 0x808E36
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x0 'Face Down
#raw 0xFE 'End of Movements

#org 0x808E41
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0xFE 'End of Movements

#org 0x808E4B
#raw 0x62 'Exclamation Mark (!)
#raw 0x12 'Step Left (Normal)
#raw 0x12 'Step Left (Normal)
#raw 0x12 'Step Left (Normal)
#raw 0x12 'Step Left (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0xFE 'End of Movements

#org @profmove
#raw 0x13
#raw 0x13
#raw 0x13
#raw 0x13
#raw 0x10
#raw 0xFE

Any ideas on why this still doesn't work 100%

 

[0]

This is all I have at the moment.
It doesn't activate every time I try to leave, but If I re-enter the lab it activates again. So I go in, it activates if I go off the tile and back on, then it plays through the script, then it allows me to leave. If I walk back in then the script just starts back up again.

Spoiler:

#dynamic 0x800000
#org @start
lockall
setvar 0x4005 0x0
checkflag 0x840
if 0x0 goto @done
checkflag 0x2C
if 0x0 goto @done
goto @begin
end

#org @done
release
end

#org @begin
textcolor 0x00
applymovement 0x4 0x8808E36
applymovement MOVE_PLAYER 0x8808E41
waitmovement 0x4
waitmovement 0xFF
msgbox 0x8808E59 MSG_NORMAL '"Hawthorn: [player], congrats on ge..."
applymovement 0x4 0x8808E4B
waitmovement 0x4
msgbox 0x8809388 MSG_NORMAL '"Hawthorn: ..., I see."
applymovement 0x4 @profmove
Waitmovement 0x4
msgbox @oak 0x6
setvar 0x4005 0x1
setflag 0x840
release
end

'---------
' Strings
'---------
#org 0x808E59
= Hawthorn: [player], congrats on getting\na Pokémon. I remeber my first\lPokémon, my partner gave it to me\las a birthday gift a long time ago\lnow. Anyway, I have asked here to\l...

#org 0x809388
= Hawthorn: ..., I see.

#org @oak
= Hawthorn: Ah, sorry about that. I\nrecieved a message from\lLuxborough. I ordered a parcel a\lfew weeks ago and it finally\larrived. Could you pop over to the\lPokémart and get it for me?

'-----------
' Movements
'-----------
#org 0x808E36
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x0 'Face Down
#raw 0xFE 'End of Movements

#org 0x808E41
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0xFE 'End of Movements

#org 0x808E4B
#raw 0x62 'Exclamation Mark (!)
#raw 0x12 'Step Left (Normal)
#raw 0x12 'Step Left (Normal)
#raw 0x12 'Step Left (Normal)
#raw 0x12 'Step Left (Normal)
#raw 0x11 'Step Up (Normal)
#raw 0xFE 'End of Movements

#org @profmove
#raw 0x13
#raw 0x13
#raw 0x13
#raw 0x13
#raw 0x10
#raw 0xFE

Any ideas on why this still doesn't work 100%

Alrighty. I reviewed your code and made two sectons. One has notations of my examinations and what should be changed or edited and the other would be my solution to your issue. My solution doesn't include any of the movements or text, just fixing what you are trying to achieve. Hope this helps. Pm me if you have any questions.

Notes:

Spoiler:

#dynamic 0x800000
#org @start 'begin
lockall 'lock all players
setvar 0x4005 0x0 'I assume this is to remove the script, or to choose one square or another. You don't necessarily need this for removing the script, as when we check the flag, it'll just release us, but to each their own.
checkflag 0x920 ' I changed this to 920. You should patch the flags code found here https://www.pokecommunity.com/showthread.php?t=302476 It looks like this will be helpful to you in the long run. Also, in my testing, I found out that it needs to be a permanent flag.
if 0x0 goto @done 'it should be checking for (1) not (0), that is the mistake. When our flag is set, then we should release the player. Otherwise we should run our prof. script.
checkflag 0x2C 'It looks like this was for setting prof oak so he doesn't appear on the map. You can replace this flag, but that is for you to decide.
if 0x0 goto @done ' We do not need this. In advance map, when this flag is set, prof oak (Hawthorn) will be removed from the map.
goto @begin 'goto our main script.
end

#org @done 'exit our script.
release
end

#org @begin
textcolor 0x00
applymovement 0x4 0x8808E36
applymovement MOVE_PLAYER 0x8808E41
waitmovement 0x4
waitmovement 0xFF
msgbox 0x8808E59 MSG_NORMAL '"Hawthorn: [player], congrats on ge..."
applymovement 0x4 0x8808E4B
waitmovement 0x4
msgbox 0x8809388 MSG_NORMAL '"Hawthorn: ..., I see."
applymovement 0x4 @profmove
Waitmovement 0x4
msgbox @oak 0x6
setvar 0x4005 0x1
setflag 0x920
release 'you could also put goto @done here. This will make managing large scripts that need clearing or setting a lot of flags easier.
end

And Solution:

Spoiler:

#dynamic 0x800000
#org @start
lockall
setvar 0x4005 0x0 'dont need this, because we are checking the flag, not removing the script.
checkflag 0x920 ' If we've run the script, then well just leave the player alone.
if 0x1 goto @done 'when = 1, release the player.
goto @begin 'otherwise, start the script.
end

#org @done
releaseall 'releaseall is important
end

#org @begin 'our script
textcolor 0x00
applymovement 0x4 0x8808E36
applymovement MOVE_PLAYER 0x8808E41
waitmovement 0x4
waitmovement 0xFF
msgbox 0x8808E59 MSG_NORMAL '"Hawthorn: [player], congrats on ge..."
applymovement 0x4 0x8808E4B
waitmovement 0x4
msgbox 0x8809388 MSG_NORMAL '"Hawthorn: ..., I see."
applymovement 0x4 @profmove
Waitmovement 0x4
msgbox @oak 0x6 'change oak to hawthorn, maybe.
setvar 0x4005 0x1 ' Probably for removing script. Not needed, as we are checking for a flag.
setflag 0x2C 'we set this, to remove prof hawthorne so he doesn't appear on the map. You can replace this flag with any other flag, but that is for you to decide.
setflag 0x920 'set our flag so that this script is not executed again.
releaseall 'releaseall is imporant
end

One more note is that if you use the lockall command, you should then use the releaseall command instead of release.