Report bugs and errors in unmodified Essentials version 21

[mej71]

I'm possibly wrong, but I don't believe I've edited anything in my base v14, and when you define an individual trainer with specific moves, it does not give them that first move.

 

[kcgcrazy]

I'm possibly wrong, but I don't believe I've edited anything in my base v14, and when you define an individual trainer with specific moves, it does not give them that first move.

it works fine for me whenever i give trainers a defined move set

 

[Florio]

Problems with Bulk Up, Coil, Work Up and Growth. Source: http://www.pokecommunity.com/showthread.php?t=338880

This may or may not be related, but I'm seeming to have problems with Charge Beam. It was a Meowstic vs. Meowstic battle and mine knew Charge Beam, the other knew Reflect, Light Screen, Psyshock and Fake Out. I was faster and used Charge Beam and for some reason the opponent kept skipping the turn (as in I would use charge beam, and then it would just go right back to picking my next move before my opponent even went). This happened on most the turns, but the other Meowstic did manage to actually get a turn a few times before I KOed it.

I'm thinking it could have to do with stat boosts. I am not sure if it was skipping on the same turn I was getting the boost from Charge Beam or not (since I wasn't paying attention), but I am pretty sure it was because of the boosts, since all the moves that FL posted also boost an attacking stat, or maybe this could have to do with the fact that multiple messages are displayed? Not sure.

 

[mej71]

This may or may not be related, but I'm seeming to have problems with Charge Beam. It was a Meowstic vs. Meowstic battle and mine knew Charge Beam, the other knew Reflect, Light Screen, Psyshock and Fake Out. I was faster and used Charge Beam and for some reason the opponent kept skipping the turn (as in I would use charge beam, and then it would just go right back to picking my next move before my opponent even went). This happened on most the turns, but the other Meowstic did manage to actually get a turn a few times before I KOed it.

I'm thinking it could have to do with stat boosts. I am not sure if it was skipping on the same turn I was getting the boost from Charge Beam or not (since I wasn't paying attention), but I am pretty sure it was because of the boosts, since all the moves that FL posted also boost an attacking stat, or maybe this could have to do with the fact that multiple messages are displayed? Not sure.

Turn your internal flag on (you can do this from the bottom of the debug menu), and recreate the battle. It will create a log of it's AI decisions in your data folder, and you can determine from that if it's the AI causing the error, or something else.

 

[Nickalooose]

Rest is definitely broken and it's the "ignorestatus" part of pbCanSleep?... So any move that will use this is going to be broken... I don't quite understand the point to ignoring a status, I suppose there are moves out there which don't override other statuses quite like Rest does... But it will have to be changed, I've noticed in some cases, that if a def has a condition that has more than 1 or 2 true's, false's, 0's or nil's, for example:

def myNewDef(index,self=false,opponent=true)
end

Only in some cases though and this is one of them... I've recently created a def where this has happened and I worked around it nonetheless, but it will need to be worked around here or removed...

 

[SoulfulLex]

Have a couple of bugs to report. Both of which can be replicated in Vanilla Essentials v14.

The first occurs when you select an item to use on a Pokemon, and then cancel the use of the item once you're on the Pokemon Selection screen (i.e. Bag > Select Healing Item to Use (like Full Restore) > Cancel [at Pokemon Screen]).

In Vanilla Essentials, it doesn't go back to the bag when I cancel the item's use, but acts as if I used it anyway.

In the game I'm working on, however, this Error shows up with the Internal Flag set (I was trying to see what was the cause and fix it myself at the time):

Spoiler:

Exception: NoMethodError
Message: undefined method `hypermode' for nil:NilClass
PokemonShadowPokemon:501:in `pbUseItemOnPokemon'
PokeBattle_Battle:2602:in `pbAttackPhase'
PokeBattle_Battle:2592:in `each'
PokeBattle_Battle:2592:in `pbAttackPhase'
PokeBattle_Battle:2357:in `pbStartBattleCore'
PokeBattle_Battle:2356:in `logonerr'
PokeBattle_Battle:2356:in `pbStartBattleCore'
PokeBattle_Battle:2342:in `loop'
PokeBattle_Battle:2365:in `pbStartBattleCore'
PokeBattle_Battle:2175:in `pbStartBattle'
PokemonTrainers:428:in `pbTrainerBattle'
PokemonTrainers:427:in `pbSceneStandby'
PokemonTrainers:429:in `pbTrainerBattle'
PokemonTrainers:426:in `pbBattleAnimation'
PokemonTrainers:426:in `pbTrainerBattle'
PokemonDebug:786:in `pbDebugMenu'
PokemonDebug:297:in `loop'
PokemonDebug:824:in `pbDebugMenu'
PokemonPauseMenu:244:in `pbStartPokemonMenu'
PokemonPauseMenu:243:in `pbFadeOutIn'
PokemonPauseMenu:243:in `pbStartPokemonMenu'
PokemonPauseMenu:144:in `loop'
PokemonPauseMenu:264:in `pbStartPokemonMenu'
Scene_Map:191:in `call_menu'
Scene_Map:162:in `update'

In both cases, normally it doesn't present problems (other than both sides skipping a turn), but when a Pokemon on either side is Poisoned, Burned, or some other condition that activates between turns, it causes them to activate.


The second error has to do with Mirror Move. The message that shows up when there is no move to mirror shows up fine, but a NoMethodError occurs when a Pokemon tries to use it:

Spoiler:

Exception: NoMethodError
Message: undefined method `canMirrorMove?' for #<PBMoveData:0x992d918>
PokeBattle_MoveEffects:4075:in `pbEffect'
PokeBattle_Battler:2178:in `pbProcessMoveAgainstTarget'
PokeBattle_Battler:2141:in `each'
PokeBattle_Battler:2141:in `pbProcessMoveAgainstTarget'
PokeBattle_Battler:2514:in `pbUseMove'
PokeBattle_Battler:2488:in `loop'
PokeBattle_Battler:2517:in `pbUseMove'
PokeBattle_Battler:2649:in `pbProcessTurn'
PokeBattle_Battler:2648:in `logonerr'
PokeBattle_Battler:2648:in `pbProcessTurn'
PokeBattle_Battle:2544:in `pbAttackPhase'
PokeBattle_Battle:2543:in `each'
PokeBattle_Battle:2543:in `pbAttackPhase'
PokeBattle_Battle:2281:in `pbStartBattleCore'
PokeBattle_Battle:2280:in `logonerr'
PokeBattle_Battle:2280:in `pbStartBattleCore'
PokeBattle_Battle:2266:in `loop'
PokeBattle_Battle:2289:in `pbStartBattleCore'
PokeBattle_Battle:2099:in `pbStartBattle'
PokemonField:1019:in `pbWildBattle'
PokemonField:1018:in `pbSceneStandby'
PokemonField:1020:in `pbWildBattle'
PokemonField:1017:in `pbBattleAnimation'
PokemonField:1017:in `pbWildBattle'
PokemonField:1473:in `pbBattleOnStepTaken'

 

[mej71]

In this method

Spoiler:

def Kernel.pbStartOver(gameover=false)
if pbInBugContest?
Kernel.pbBugContestStartOver
return
end
pbHealAll()
if $PokemonGlobal.pokecenterMapId && $PokemonGlobal.pokecenterMapId>=0
if gameover
Kernel.pbMessage(_INTL("\\w[]\\wm\\c[8]\\l[3]After the unfortunate defeat, {1} scurried to a Pokémon Center.",$Trainer.name))
else
Kernel.pbMessage(_INTL("\\w[]\\wm\\c[8]\\l[3]{1} scurried to a Pokémon Center, protecting the exhausted and fainted Pokémon from further harm.",$Trainer.name))
end
Kernel.pbCancelVehicles
pbRemoveDependencies()
$game_switches[STARTING_OVER_SWITCH]=true
$game_temp.player_new_map_id=$PokemonGlobal.pokecenterMapId
$game_temp.player_new_x=$PokemonGlobal.pokecenterX
$game_temp.player_new_y=$PokemonGlobal.pokecenterY
$game_temp.player_new_direction=$PokemonGlobal.pokecenterDirection
$scene.transfer_player
$game_map.refresh
else
homedata=pbGetMetadata(0,MetadataHome)
if (homedata && !pbRxdataExists?(sprintf("Data/Map%03d",homedata[0])) )
if $DEBUG
Kernel.pbMessage(_ISPRINTF("Can't find the map 'Map{1:03d}' in the Data folder. The game will resume at the player's position.",homedata[0]))
end
pbHealAll()
return
end
if gameover
Kernel.pbMessage(_INTL("\\w[]\\wm\\c[8]\\l[3]After the unfortunate defeat, {1} scurried home.",$Trainer.name))
else
Kernel.pbMessage(_INTL("\\w[]\\wm\\c[8]\\l[3]{1} scurried home, protecting the exhausted and fainted Pokémon from further harm.",$Trainer.name))
end
if homedata
Kernel.pbCancelVehicles
pbRemoveDependencies()
$game_switches[STARTING_OVER_SWITCH]=true
$game_temp.player_new_map_id=homedata[0]
$game_temp.player_new_x=homedata[1]
$game_temp.player_new_y=homedata[2]
$game_temp.player_new_direction=homedata[3]
$scene.transfer_player if $scene.is_a?(Scene_Map)
$game_map.refresh
else
pbHealAll()
end
end
pbEraseEscapePoint
end

the lines

$scene.transfer_player

should be

$scene.transfer_player if $scene.is_a?(Scene_Map)

To prevent crashes when losing battles from the Debug Menu

 

[mej71]

Slight AI bug for Roar, Whirlwind, Dragon Tail, etc.

In the AI on lines 1935 and 1942

score+=50 if opponent.pbOwnSide.effects[PBEffects::StealthRock]>0

should be

score+=50 if opponent.pbOwnSide.effects[PBEffects::StealthRock]==true

since Stealth Rock is a boolean. This will cause the opponent to not make a move.


Fix for Mirror Move usage

In class PokeBattle_Move_0AE

replace

if opponent.lastMoveUsed<=0 || 
         !PBMoveData.new(opponent.lastMoveUsed).canMirrorMove?

with

if opponent.lastMoveUsed<=0 || 
         !PokeBattle_Move.pbFromPBMove(@battle,PBMove.new(opponent.lastMoveUsed)).canMirrorMove?

This same thing must be done in the AI around the 1700s (when 0xAE)

It seems to be failing because opponent.lastMovedUsed is just a move's id, and PBMoveData does not have the method canMirrorMove? , so we must make it an actual instance of PokeBattle_Move , where this method resides.

 

[mej71]

Just another small mistake I found.
The check for Mummy winds up being done after the pokemon with Mummy has fainted, so if you one-shot it with a physical move you won't be mummified. We simply need to change the new target.hasWorkingAbility? check back to the v13 way of checking, since this check always returns false if the user is fainted.

Change

if target.hasWorkingAbility(:MUMMY) && !user.isFainted?
          if !isConst?(user.ability,PBAbilities,:MULTITYPE) &&
             !isConst?(user.ability,PBAbilities,:WONDERGUARD) &&
             !isConst?(user.ability,PBAbilities,:MUMMY)
            user.ability=getConst(PBAbilities,:MUMMY) || 0
            @battle.pbDisplay(_INTL("{1} was mummified by {2}!",
               user.pbThis,target.pbThis(true)))
          end
        end

to

if isConst?(target.ability,PBAbilities,:MUMMY) && !target.effects[PBEffects::GastroAcid] && !user.isFainted?
          if !isConst?(user.ability,PBAbilities,:MULTITYPE) &&
             !isConst?(user.ability,PBAbilities,:WONDERGUARD) &&
             !isConst?(user.ability,PBAbilities,:MUMMY)
            user.ability=getConst(PBAbilities,:MUMMY) || 0
            @battle.pbDisplay(_INTL("{1} was mummified by {2}!",
               user.pbThis,target.pbThis(true)))
          end
        end

Edit: This is a problem for many similar abilities also (Effect Spore, Iron Barbs, etc)
Also, I accidentally put this here instead of Bug Reporting, can you please move it?

 

[SoulfulLex]

Not a bug, per se, but the message for Pressure at the beginning of a battle is missing from Vanilla Essentials. Very easy fix for it, though:

    # Pressure
    if self.hasWorkingAbility(:PRESSURE) && onactive
      @battle.pbDisplay(_INTL("{1} is exerting its Pressure!",pbThis))
    end

This goes in PokeBattle_Battler. Put it before # Trace on line 828 (but after the "end" of the Cloud Nine prompt).

 

[venom12]

Also Dragon Dance have problems. replace

      when 0x26
        score+=40 if attacker.turncount==0 # Dragon Dance tends to be popular
        if attacker.pbTooHigh?(PBStats::ATTACK) &&
           attacker.pbTooHigh?(PBStats::SPEED)
          score-=90
        else
          score-=attacker.stages[PBStats::ATTACK]*10
          score-=attacker.stages[PBStats::SPEED]*10
          if skill>=PBTrainerAI.mediumSkill
            hasphysicalattack=false
            for thismove in attacker.moves
              if thismove.id!=0 && thismove.basedamage>0 &&
                 thismove.pbIsPhysical?(thismove.type)
                hasphysicalattack=true
              end
            end
            if hasphysicalattack
              score+=20
            elsif skill>=PBTrainerAI.highSkill
              score-=90
            end
          end
          if skill>=PBTrainerAI.highSkill
            aspeed=pbRoughStat(attacker,PBStats::SPEED,skill)
            ospeed=pbRoughStat(opponent,PBStats::SPEED,skill)
            if aspeed<ospeed && aspeed*2>ospeed
              score+=20
            end
          end
        end

 

[FL]

I can't edit/save HiddenAbility on editor.

 

[AmethystRain]

A couple other AI issues:

Beat-Up AI also causes opponent inaction. Change

      when 0xC1 # Beat Up
        party=pbParty(attacker.index)
        mult=0
        for i in 0...party.length
          [COLOR="Red"]multi[/COLOR]+=1 if party[i] && !party[i].egg? &&
                      party[i].hp>0 && party[i].status==0
        end
        basedamage*=mult

to

    when 0xC1 # Beat Up
        party=pbParty(attacker.index)
        mult=0
        for i in 0...party.length
          [COLOR="red"]mult[/COLOR]+=1 if party[i] && !party[i].egg? &&
                      party[i].hp>0 && party[i].status==0
        end
        basedamage*=mult

More importantly, let's talk about this section of the AI

 def pbRoughAccuracy(move,attacker,opponent,skill)
    # Get base accuracy
    [COLOR="RoyalBlue"]accuracy[/COLOR]=move.accuracy
    if skill>=PBTrainerAI.mediumSkill
      if pbWeather==PBWeather::SUNNYDAY &&
         (move.function==0x08 || move.function==0x15) # Thunder, Hurricane
        [COLOR="RoyalBlue"]accuracy[/COLOR]=50
      end
    end
    # Accuracy stages
    accstage=attacker.stages[PBStats::ACCURACY]
    accstage=0 if opponent.hasWorkingAbility(:UNAWARE)
    [COLOR="Purple"]accuracy[/COLOR]=(accstage>=0) ? (accstage+3)*100.0/3 : 300.0/(3-accstage)
    evastage=opponent.stages[PBStats::EVASION]
    evastage-=2 if @field.effects[PBEffects::Gravity]>0
    evastage=-6 if evastage<-6
    evastage=0 if opponent.effects[PBEffects::Foresight] ||
                  opponent.effects[PBEffects::MiracleEye] ||
                  move.function==0xA9 || # Chip Away
                  attacker.hasWorkingAbility(:UNAWARE)
    evasion=(evastage>=0) ? (evastage+3)*100.0/3 : 300.0/(3-evastage)
    [COLOR="Red"]accuracy/=evasion[/COLOR]
    # Accuracy modifiers

Please correct me if I'm misunderstanding this part, but from playing around with it a little bit, my understanding is as follows:
Firstly, the blue sections start by getting the accuracy and changing it for weather, but then just below that the accuracy variable seems to be set according to the stages. To me, this appears to overwrite the previous changes in blue.
Then, with the line in red below, if I'm not completely mistaken, this returns a result of 1 with no stage alterations. This is later going to feed back out to the main AI function here:

        accuracy=pbRoughAccuracy(move,attacker,opponent,skill)
        basedamage*=accuracy/100

...which means we get the basedamage calculation chopped to /100. Since some of the other accuracy modifiers also set that variable to 100 or thereabouts, it makes sense to me to multiply accuracy by 100 after the red-lighted part in the previous code block, otherwise the AI thinks the base damage is a -lot- lower than it should.

 

[KillerMapper]

I noticed that when you use any ball trying to catch a pokémon in double battles, when both wild pokémon are still up, you got the message that you can't aim when there are 2 pokémons (which is ok) but the ball is still consumed (is it the case in official games? I'm not sure but I don't think it is).

Was already in v14, I found it yesterday before the release of v15.

 

[Pumone]

I was battling in a double battle against Diglett and Remoraid

I'm sure the problem is Remoraid because when it attacks I get the following error

Exception: NoMethodError
Message: undefined method `pbType' for #<PokeBattle_Battle:0xaa9dcd8>
PokeBattle_AI:3498:in `pbRoughAccuracy'
PokeBattle_AI:2569:in `pbGetMoveScore'
PokeBattle_AI:3577:in `pbChooseMoves'
PokeBattle_AI:3575:in `each'
PokeBattle_AI:3575:in `pbChooseMoves'
PokeBattle_AI:4058:in `pbDefaultChooseEnemyCommand'
PokeBattle_ActualScene:2729:in `pbChooseEnemyCommand'
PokeBattle_Battle:2344:in `pbCommandPhase'
PokeBattle_Battle:2339:in `each'
PokeBattle_Battle:2339:in `pbCommandPhase'

 

[Boeing747]

I noticed that upon updating my game to Essentials 15, the opponent Pokemon failed to make a move and instead reset my Pokemon to the command screen directly after attacking. Upon investigation of the base Essentials, I noted the same problem.

Here's the battle log in my game:

***Round 1***
[The wild Diggersby: Odor Sleuth=100, Flail=100, Dig=100, Bounce=100]
[Using two-turn attack]
***Round 2***
[reusing commands for the wild Diggersby]
[Continuing move]
[Lauren lost 17 HP, now has 116 HP]
***Round 3***
[The wild Diggersby: Odor Sleuth=100, Flail=100, Dig=100, Bounce=100] (Diggersby does not move)
***Round 4***
[The wild Diggersby: Odor Sleuth=100, Flail=100, Dig=100, Bounce=100] (Diggersby does not move)
***Round 5***
[The wild Diggersby: Odor Sleuth=100, Flail=100, Dig=100, Bounce=100]
[Lauren lost 5 HP, now has 111 HP]
***Round 6***
[The wild Diggersby: Odor Sleuth=100, Flail=100, Dig=100, Bounce=100]
[The wild Diggersby lost 141 HP, now has 0 HP]
[The wild Diggersby fainted]

And for base Essentials:

***Round 1***
[The wild Rattata: Tail Whip=100, Quick Attack=100, Focus Energy=100, Bite=100]
[Pikachu lost 9 HP, now has 37 HP]
***Round 2***
[The wild Rattata: Tail Whip=100, Quick Attack=100, Focus Energy=100, Bite=100]
***Round 3***
[The wild Rattata: Tail Whip=100, Quick Attack=100, Focus Energy=100, Bite=100] (Rattata does not move)
***Round 4***
[The wild Rattata: Tail Whip=100, Quick Attack=100, Focus Energy=100, Bite=100]
[The wild Rattata lost 30 HP, now has 0 HP]
[The wild Rattata fainted]

The second battle was done with the unmodified scripts, and I'm not sure what's causing this.

 

[Savordez]

The issue above happens to me as well. I'll see if I can find out more.

 

[Maruno]

I'm sure you should have gotten an error message. I don't know why you wouldn't have.

 

[Boeing747]

I'm sure you should have gotten an error message. I don't know why you wouldn't have.

An error message doesn't show up and I can't imagine why it doesn't; I feel like something in the code might be syntactically correct but functionally incorrect.

 

[Savordez]

I'm sure you should have gotten an error message. I don't know why you wouldn't have.

As you can see, the Pidgey does not do anything after my first Quick Attack. And this is from the unmodified version. No error messages.