Gen III. It had both of my favorite regions (Hoenn and Kanto), the best OST (RSE), my favorite Pokes (again, from Hoenn and Kanto), and among other things.
My second favorite gen is Gen I. There is a certain charm to those games that will never fade from my memories.