[Scripting Question] More help please...

I have defined this ability called Infected Fur, which badly poisons the attacker on contact but also prevents the user from being poisoned. The way it prevents the user from being poisoned works but the bad poisoning on contact doesn't!

I also want it to be a 100% chance of badly poisoning the target on contact!

Here's the code:
if user.hasWorkingAbility(:INFECTEDFUR,true) && @battle.pbRandom(10)==10 &&
target.pbCanPoison?(nil,true)
PBDebug.log("[Ability triggered] #{user.pbThis}'s Infected Fur")
target.pbPoison(user,_INTL("{1}'s {2} poisoned {3}!",user.pbThis,
PBAbilities.getName(user.ability),target.pbThis(true)),toxic)
end

What am I doing wrong?

The problem is with this condition:

@battle.pbRandom(10)==10

That code means that the effect will only work if the random number equal ten. You have two problems. If you use == the ability will not work if the random number is anything but 10.
That leads to your second problem. pbRandom starts at 0. So pbRandom 10 is generating a number between 0 and 9. It will never equal 10.
If you want your ability to work 100% of the time, either change the == to < OR just remove that condition entirely. It's only there to handle a chance of failing, but you don't even want that.

I think you can replace everything after target.pbPoison with (target, nil, true) to get that kind of effect of harsh poisoning.

Poq said:

The problem is with this condition:

@battle.pbRandom(10)==10

That code means that the effect will only work if the random number equal ten. You have two problems. If you use == the ability will not work if the random number is anything but 10.
That leads to your second problem. pbRandom starts at 0. So pbRandom 10 is generating a number between 0 and 9. It will never equal 10.
If you want your ability to work 100% of the time, either change the == to < OR just remove that condition entirely. It's only there to handle a chance of failing, but you don't even want that.

Click to expand...

Oh!

Arachnee said:

I think you can replace everything after target.pbPoison with (target, nil, true) to get that kind of effect of harsh poisoning.

Click to expand...

But will I get an error?

clawort said:

But will I get an error?

Click to expand...

I don't think so.

I don't think so.

Arachnee said:

I don't think so.

Click to expand...

Okay!

Arachnee said:

I don't think so.

Click to expand...

Alright but what do I do again?

Something like this I think:

Arachnee said:

Something like this I think:

Code:

if user.hasWorkingAbility(:INFECTEDFUR,true) && target.pbCanPoison?(nil,false)
target.pbPoison(target,nil,true)
end

Click to expand...

Okay, I'll try.

But if I get an error, it's back to square one!

Arachnee said:

Something like this I think:

Code:

if user.hasWorkingAbility(:INFECTEDFUR,true) && target.pbCanPoison?(nil,false)
target.pbPoison(target,nil,true)
end

Click to expand...

Nevermind, it doesn't work!

But will this work (it won't be a 100% toxic poisoning though)?

if user.hasWorkingAbility(:INFECTEDFUR,true) &&
target.pbCanPoison?(nil,false) && @battle.pbRandom(10)<3
PBDebug.log("[Ability triggered] #{user.pbThis}'s Infected Fur")
target.pbPoison(user,_INTL("{1}'s {2} poisoned {3}!",user.pbThis,
PBAbilities.getName(user.ability),target.pbThis(true)),toxic)
end

That should work. Poq said to remove the condition "&&@battle.pbRandom(10)<3" for the ability to always work.

Arachnee said:

That should work. Poq said to remove the condition "&&@battle.pbRandom(10)<3" for the ability to always work.

Click to expand...

Okay!