[Scripting Question] Ability help (Again)

WolfPP said:

Well, did you try to copy Parental Bond's code and edit to hit three times?

Click to expand...

clawort said:

Idk how to do that, especially if I want only biting moves to hit three times.

Click to expand...

mgriffin said:

Well look at the code and tell us what ideas you have about what to change. You can also take inspiration from Strong Jaw (or other abilities that care about particular kinds of moves) for how to limit it only to biting moves.

Click to expand...

clawort said:

Well, the code for Parental Bond is this:

Spoiler:

def pbNumHits(attacker)
# Parental Bond goes here (for single target moves only)
if attacker.hasWorkingAbility(:PARENTALBOND)
if pbIsDamaging? && !pbTargetsMultiple?(attacker) &&
!pbIsMultiHit && !pbTwoTurnAttack(attacker)
exceptions=[0x6E, # Endeavor
0xE0, # Selfdestruct/Explosion
0xE1, # Final Gambit
0xF7] # Fling
if !exceptions.include?(@function)
attacker.effects[PBEffects::ParentalBond]=3
return 2
end
end
end
# Need to record that Parental Bond applies, to weaken the second attack
return 1
end

What do I change?

Click to expand...

mgriffin said:

What do you think you'd change to make the move do three hits instead of two? Then try changing it, then try using a Pokémon with Parental Bond and see if it works. Then if it doesn't try something else.

Click to expand...

WolfPP said:

It's time for you to burn neurons to make own abilities. Like MrGriffin said, copy like Strong Jaw abilities works to recognize if the move is Biting Move. Maybe something like this (you need to find all PARENTALBOND instead and copy and edit to your Triple Terror):

Code:

    if attacker.hasWorkingAbility(:TRIPLETERROR)
      if pbIsDamaging? && [COLOR="Red"]!isBitingMove?[/COLOR] && !pbTargetsMultiple?(attacker) &&
         !pbIsMultiHit && !pbTwoTurnAttack(attacker)
        exceptions=[0x6E,   # Endeavor
                    0xE0,   # Selfdestruct/Explosion
                    0xE1,   # Final Gambit
                    0xF7]   # Fling
        if !exceptions.include?(@function)
          attacker.effects[PBEffects::TripleTerror]=[COLOR="Red"]4[/COLOR]
          return [COLOR="red"]3[/COLOR]
        end
      end
    end

Some trial and error you can get it.

Click to expand...

clawort said:

The only Pokemon with Parental Bond is Mega Kangaskhan!

Click to expand...

mgriffin said:

So either test with Mega Kanga or alter the PBS file to give Parental Bond to another Pokémon? How do you normally check if the changes you've made work?

In any case Wolf pretty much gave you the answer, so…
(I think it's slightly wrong, but if you test it should be pretty obvious what's going on and what kind of thing you would need to look for in the code to fix it).

Click to expand...

WolfPP said:

Focus: you ability works correctly (hit 3 times) or not?

Click to expand...

WolfPP said:

So you need to create a animation to your ability, like Parental Bond:

Code:

  def pbShowAnimation(id,attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    return if !showanimation
    if attacker.effects[PBEffects::ParentalBond]==1
      [COLOR="Red"]@battle.pbCommonAnimation("ParentalBond",attacker,opponent)[/COLOR]
      return
    end
    @battle.pbAnimation(id,attacker,opponent,hitnum)
  end

Or try to create a pbAnimation to your ability using bite animation:

Code:

@battle.pbAnimation(getConst(PBMoves,:[COLOR="red"]XXX[/COLOR]),[COLOR="red"]self[/COLOR],[COLOR="red"]nil[/COLOR])

Change the red words to correct one. I think 'self' could be 'attacker' and 'nil' is 'opponent'. Anyway, Trial and Error. Good luck.

Click to expand...

WolfPP said:

So you need to create a animation to your ability, like Parental Bond:

Code:

  def pbShowAnimation(id,attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    return if !showanimation
    if attacker.effects[PBEffects::ParentalBond]==1
      [COLOR="Red"]@battle.pbCommonAnimation("ParentalBond",attacker,opponent)[/COLOR]
      return
    end
    @battle.pbAnimation(id,attacker,opponent,hitnum)
  end

Or try to create a pbAnimation to your ability using bite animation:

Code:

@battle.pbAnimation(getConst(PBMoves,:[COLOR="red"]XXX[/COLOR]),[COLOR="red"]self[/COLOR],[COLOR="red"]nil[/COLOR])

Change the red words to correct one. I think 'self' could be 'attacker' and 'nil' is 'opponent'. Anyway, Trial and Error. Good luck.

Click to expand...