[Scripting Question] Stealth Rock changes help

StCooler said:

I have trouble understanding how type effectiveness works, so I can relate.

Fortunately, the module PBTypes has useful functions:

Code:

  def PBTypes.ineffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.notVeryEffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.resistant?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.normalEffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.superEffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)

and all these functions can take the result of PBTypes.getCombinedEffectiveness() in place of attackType.

I suggest the following code:

Code:

      if pkmn.pbOwnSide.effects[PBEffects::StealthRock] && !pkmn.fainted?
        if !(pkmn.hasWorkingAbility(:MAGICGUARD) ||
            pkmn.hasWorkingItem(:HEAVYDUTYBOOTS))
          atype=getConst(PBTypes,:ROCK) || 0
          eff=PBTypes.getCombinedEffectiveness(atype,pkmn.type1,pkmn.type2,pkmn.effects[PBEffects::Type3])
          if eff>0
            PBDebug.log("[Entry hazard] #{pkmn.pbThis} triggered Stealth Rock")
            @scene.pbDamageAnimation(pkmn,0)
            if PBTypes.resistant?(eff)
              pkmn.pbReduceHP((pkmn.totalhp/16).floor)
            elsif PBTypes.superEffective?(eff)
              pkmn.pbReduceHP((pkmn.totalhp/4).floor)
            else # Normal effective 
              pkmn.pbReduceHP((pkmn.totalhp/8).floor)
            end
            pbDisplayPaused(_INTL("Pointed stones dug into {1}!",pkmn.pbThis))
          end
        end
      end

PS: Also, when you have several "if" and "elsif", it's good practice to leave one of these as a default case, just in case ^^

Click to expand...

      if pkmn.pbOwnSide.effects[PBEffects::StealthRock] && !pkmn.fainted?
        if !(pkmn.hasWorkingAbility(:MAGICGUARD) ||
            pkmn.hasWorkingItem(:HEAVYDUTYBOOTS))
          atype=getConst(PBTypes,:ROCK) || 0
          eff=PBTypes.getCombinedEffectiveness(atype,pkmn.type1,pkmn.type2,pkmn.effects[PBEffects::Type3])
          if eff>0
            PBDebug.log("[Entry hazard] #{pkmn.pbThis} triggered Stealth Rock")
            @scene.pbDamageAnimation(pkmn,0)
            if PBTypes.[COLOR="Red"]isNotVeryEffective?[/COLOR](eff)
              pkmn.pbReduceHP((pkmn.totalhp/16).floor)
            elsif PBTypes.[COLOR="Red"]isSuperEffective?[/COLOR](eff)
              pkmn.pbReduceHP((pkmn.totalhp/4).floor)
            else # Normal effective 
              pkmn.pbReduceHP((pkmn.totalhp/8).floor)
            end
            pbDisplayPaused(_INTL("Pointed stones dug into {1}!",pkmn.pbThis))
          end
        end
      end

StCooler said:

Ah, v17, of course.
Check the module PBTypes, and check if there is any function that looks like those that I mentioned.

Click to expand...

Tommaniacal said:

I only see PBTypes_Extra, not PBTypes. It does have functions for PBTypes.isNotVeryEffective?, PBTypes.isNormalEffective?, and PBTypes.isSuperEffective?, which is what I based the last script I posted on, but they give me argument errors.

Click to expand...

StCooler said:

What what arguments do they expect? Please post the "def XXX.isSuperEffective?" and such.
What errors do they show? How do you call these functions?

Click to expand...

  def PBTypes.isIneffective?(attackType,opponentType1,opponentType2=nil,opponentType3=nil)
    e = PBTypes.getCombinedEffectiveness(attackType,opponentType1,opponentType2,opponentType3)
    return e==0
  end

  def PBTypes.isNotVeryEffective?(attackType,opponentType1,opponentType2=nil,opponentType3=nil)
    e = PBTypes.getCombinedEffectiveness(attackType,opponentType1,opponentType2,opponentType3)
    return e>0 && e<8
  end

  def PBTypes.isNormalEffective?(attackType,opponentType1,opponentType2=nil,opponentType3=nil)
    e = PBTypes.getCombinedEffectiveness(attackType,opponentType1,opponentType2,opponentType3)
    return e==8
  end

StCooler said:

Ok, it's because the new functions in v18 can take the "eff" as a parameter, while the old functions from v17 cannot.

The good news is that it's easy to fix:

Code:

      if pkmn.pbOwnSide.effects[PBEffects::StealthRock] && !pkmn.fainted?
        if !(pkmn.hasWorkingAbility(:MAGICGUARD) ||
            pkmn.hasWorkingItem(:HEAVYDUTYBOOTS))
          atype=getConst(PBTypes,:ROCK) || 0
          eff=PBTypes.getCombinedEffectiveness(atype,pkmn.type1,pkmn.type2,pkmn.effects[PBEffects::Type3])
          if eff>0
            PBDebug.log("[Entry hazard] #{pkmn.pbThis} triggered Stealth Rock")
            @scene.pbDamageAnimation(pkmn,0)
            if eff < 8
              pkmn.pbReduceHP((pkmn.totalhp/16).floor)
            elsif eff > 8
              pkmn.pbReduceHP((pkmn.totalhp/4).floor)
            else # Normal effective 
              pkmn.pbReduceHP((pkmn.totalhp/8).floor)
            end
            pbDisplayPaused(_INTL("Pointed stones dug into {1}!",pkmn.pbThis))
          end
        end
      end

Click to expand...

Tommaniacal said:

This works! Thank you! I have a question, if I've already implemented all of the gen 7 mechanics into V17, would it still be worth it to update to 18? I only hesitate because I have quite a few custom scripts that would probably break

Click to expand...

StCooler said:

I would update to v18 if and only if I needed gen 8 stuff + some scripts that don't exist for v17 (Mid Battle Dialogue, Z-moves/Dynamax...).

However, v17 and v18 seem to be quite close, as far as I can tell. Some functions are altered, but it should be easy to debug.

You will spend a hard time making those changes though.

Click to expand...

Tommaniacal said:

This works! Thank you! I have a question, if I've already implemented all of the gen 7 mechanics into V17, would it still be worth it to update to 18? I only hesitate because I have quite a few custom scripts that would probably break

Click to expand...

NettoHikari said:

The two versions are relatively close if you're NOT talking about battle scripts. For battle scripts, they are leagues apart (v18 broke nearly ALL battle scripts that used to be on v17).

Click to expand...