[Essentials v17.2]Fixing some abilities that triggered into the end of turn

WolfPP · Sep 30, 2019

Am using this script for Power Construct. Install for Zygarde.

Am using some part of that script for Shields Down (Battle Effect script, Move Effect script, etc). Install for Minior and check which code you will replace with mine.

Now let's go:

Into 'class PokeBattle_Battler', add 'attr_accessor :startform' below 'attr_accessor :captured', like this:

Spoiler:

Now, 'def pbInitPokemon(pkmn,pkmnIndex)', add '@startform = @form':

Spoiler:

Inside 'def pbCheckForm', delete what you have for Darmanitan, Zygarde, Wishiwashi and Minior.

Then, add Wishiwashi and Minior inside 'def pbResetForm', like:

Spoiler:

Above Imposter's code (from PokeBattle_Battler), to change its forms when start the battle, paste:

Spoiler:

And now, to check into the end of round to change its forms or not, go to 'PokeBattle_Battle' script. below '# Slow Start's end message', paste:

Spoiler:

Code:

# Slow Start's end message
    if i.hasWorkingAbility(:SLOWSTART) && i.turncount==6
      pbDisplay(_INTL("{1} finally got its act together!",i.pbThis))
    end
    # Zen Mode/ Power Construct / Schooling / Shields Down
    for i in priority
      next if i.fainted?
      if i.hasWorkingAbility(:ZENMODE) && isConst?(i.species,PBSpecies,:DARMANITAN)
        if i.hp<=((i.totalhp/2).floor) && i.form!=1
          i.form=1
          i.pbUpdate(true)
          scene.pbChangePokemon(i,i.pokemon)
          PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
        elsif i.hp>((i.totalhp/2).floor) && i.form!=0
          i.form=0
          i.pbUpdate(true)
          scene.pbChangePokemon(i,i.pokemon)
          PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
        end
      end
      if i.hasWorkingAbility(:POWERCONSTRUCT) && isConst?(i.species,PBSpecies,:ZYGARDE) 
        if i.hp<=((i.totalhp/2).floor) && i.form!=2 
          $zygardeform=i.form
          i.form=2
          pbDisplay(_INTL("You sense the presence of many!"))
          i.pbUpdate(true)
          scene.pbChangePokemon(i,i.pokemon)
          pbDisplay(_INTL("{1} transformed into its Complete Forme!",i.pbThis))
          PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
        end
      end
      if i.hasWorkingAbility(:SCHOOLING) && isConst?(i.species,PBSpecies,:WISHIWASHI) && i.level>19
        if i.hp>((i.totalhp/4).floor) && i.form!=1
          i.form=1
          i.pbUpdate(true)
          scene.pbChangePokemon(i,i.pokemon)
          @battle.pbDisplay(_INTL("{1} formed a school!",pbThis))
          PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
        elsif i.hp<((i.totalhp/4).floor) && i.form!=0
          i.form=0
          i.pbUpdate(true)
          scene.pbChangePokemon(i,i.pokemon)
         @battle.pbDisplay(_INTL("{1} stopped schooling!",pbThis))
          PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
        end
      end
      if i.hasWorkingAbility(:SHIELDSDOWN) && isConst?(i.species,PBSpecies,:MINIOR)
        if i.hp>=((i.totalhp/2).floor) && i.form!=0
          i.form=0
          i.pbUpdate(true)
          scene.pbChangePokemon(i,i.pokemon)
          pbDisplay(_INTL("{1} deactivated!",PBAbilities.getName(i.ability)))
          PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
        elsif i.hp<=((i.totalhp/2).floor) && i.form==0
          if i.startform>0
            i.form=i.startform
            i.pbUpdate(true)
            scene.pbChangePokemon(i,i.pokemon)
            pbDisplay(_INTL("{1} activated!",PBAbilities.getName(i.ability)))
            PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
          else
            i.form=1+rand(7)
            i.startform=i.form
            i.pbUpdate(true)
            scene.pbChangePokemon(i,i.pokemon)
            pbDisplay(_INTL("{1} activated!",PBAbilities.getName(i.ability)))
            PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
          end
        end
      end
    end

Now, add Minior to 'Forms' script, below HOOPA (or whatever):

Code:

MultipleForms.register(:MINIOR,{
"getFormOnCreation"=>proc{|pokemon|
   next 1+rand(7)
}
})

And finally, to put Meteor Form for Wild Minior, look for 'PField_Encounters' script, and inside 'def pbGenerateWildPokemon(species,level,isroamer=false)', paste above 'Events.onWildPokemonCreate.trigger(nil,genwildpoke)':

Code:

  if isConst?(genwildpoke.species,PBSpecies,:MINIOR); genwildpoke.form=0; end

For breeding case about Minior, go to 'PField_DayCare' and replace the code below '# Inheriting form':

Code:

  # Inheriting form
  if isConst?(babyspecies,PBSpecies,:BURMY) ||
     isConst?(babyspecies,PBSpecies,:SHELLOS) ||
     isConst?(babyspecies,PBSpecies,:BASCULIN) ||
     isConst?(babyspecies,PBSpecies,:FLABEBE) ||
     isConst?(babyspecies,PBSpecies,:PUMPKABOO) ||
     isConst?(babyspecies,PBSpecies,:ORICORIO) ||
     isConst?(babyspecies,PBSpecies,:MINIOR)
    egg.form=mother.form
    egg.form=father.form if pbIsDitto?(mother)
  end 
  # Inheriting Moves

And done :D
Cya!

CharizardThree3 · Oct 1, 2019

Thanks dude!

WolfPP · Oct 1, 2019

If you caught Wild Minior (Meteor Form, using Master Ball i.e.), when you turn back to Overworld, that pokémon won't change its form to Core Form. I fixed it:
Inside 'def pbResetForm' replace Minior'code for:

Code:

      if isConst?(self.species,PBSpecies,:MINIOR)
        if startform>0; self.form=startform; else; self.form=1+rand(7); startform=self.form; end
      end

Atted the main post.

EDIT 7 Oct: Changed when HP '<=' or '>=' insted only '<' or '>' for all abilities, except Schooling; level for Schooling, '>19' instead '>=20'.

Citric · Jan 17, 2020

Hey, thanks for making the code and don't know if you're still working on this, but I keep getting "NoMethodError" on "pbUpdate(true)" of
" def pbResetForm
if !@effects[PBEffects::Transform]
isConst?(self.species,PBSpecies,:CASTFORM) || isConst?(self.species,PBSpecies,:CHERRIM) ||
isConst?(self.species,PBSpecies,:DARMANITAN) || isConst?(self.species,PBSpecies,:MELOETTA) ||
isConst?(self.species,PBSpecies,:AEGISLASH) || isConst?(self.species,PBSpecies,:XERNEAS) ||
isConst?(self.species,PBSpecies,:WISHIWASHI)
self.form=0
end
if isConst?(self.species,PBSpecies,:MINIOR)
if startform>0; self.form=startform; else; self.form=1+rand(7); startform=self.form; end
end
end
pbUpdate(true)
end "

WolfPP · Jan 17, 2020

Citric said:
Hey, thanks for making the code and don't know if you're still working on this, but I keep getting "NoMethodError" on "pbUpdate(true)" of
" def pbResetForm
if !@effects[PBEffects::Transform]
isConst?(self.species,PBSpecies,:CASTFORM) || isConst?(self.species,PBSpecies,:CHERRIM) ||
isConst?(self.species,PBSpecies,:DARMANITAN) || isConst?(self.species,PBSpecies,:MELOETTA) ||
isConst?(self.species,PBSpecies,:AEGISLASH) || isConst?(self.species,PBSpecies,:XERNEAS) ||
isConst?(self.species,PBSpecies,:WISHIWASHI)
self.form=0
end
if isConst?(self.species,PBSpecies,:MINIOR)
if startform>0; self.form=startform; else; self.form=1+rand(7); startform=self.form; end
end
end
pbUpdate(true)
end "

Vanilla Essentials 17.2 already have 'pbUpdate(true)' and works perfectly. You just need to add Wishiwashi where we have Aegislash to turn back into its original form. Also about Minior it is just a new 'if' for that pokémon.

neckpunch73 · Feb 12, 2020

Hey thanks for making this script. I just installed it and it mostly works. However, if Wishiwashi is already in Solo form because HP is low, and then recovers health to get back over 25%, it changes him to Schooling Form, but the text says "Wishiwashi stopped schooling". I copy and pasted the exact script you posted, any idea what I might've done wrong?

mgriffin · Feb 12, 2020

neckpunch73 said:
Hey thanks for making this script. I just installed it and it mostly works. However, if Wishiwashi is already in Solo form because HP is low, and then recovers health to get back over 25%, it changes him to Schooling Form, but the text says "Wishiwashi stopped schooling". I copy and pasted the exact script you posted, any idea what I might've done wrong?

I wonder if the messages are the wrong way around?

Code:

        if i.hp>((i.totalhp/4).floor) && i.form!=1
          i.form=1
          i.pbUpdate(true)
          scene.pbChangePokemon(i,i.pokemon)
          pbDisplay(_INTL("{1} stopped schooling!",i.pbThis))
          PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
        elsif i.hp<((i.totalhp/4).floor) && i.form!=0
          i.form=0
          i.pbUpdate(true)
          scene.pbChangePokemon(i,i.pokemon)
          pbDisplay(_INTL("{1} formed a school!",i.pbThis))
          PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
        end

This kinda looks like "when HP > 25% and not form 1 switch to form 1 and say we stopped schooling". So maybe swap the pbDisplays in the bit I quoted. (Assuming form 0 is normal, and 1 is schooling)

WolfPP · Feb 12, 2020

Just swap the phrases. I edited the main post.

WolfPP · Feb 17, 2020

For breeding case about Minior, go to 'PField_DayCare' and replace the code below '# Inheriting form':

Code:

  # Inheriting form
  if isConst?(babyspecies,PBSpecies,:BURMY) ||
     isConst?(babyspecies,PBSpecies,:SHELLOS) ||
     isConst?(babyspecies,PBSpecies,:BASCULIN) ||
     isConst?(babyspecies,PBSpecies,:FLABEBE) ||
     isConst?(babyspecies,PBSpecies,:PUMPKABOO) ||
     isConst?(babyspecies,PBSpecies,:ORICORIO) ||
     isConst?(babyspecies,PBSpecies,:MINIOR)
    egg.form=mother.form
    egg.form=father.form if pbIsDitto?(mother)
  end 
  # Inheriting Moves

Edited the main post.

Seenit45 · Apr 16, 2020

WolfPP said:

https://www.pokecommunity.com/showthread.php?p=9968664#post9968664

Code:

      if i.hasWorkingAbility(:SCHOOLING) && isConst?(i.species,PBSpecies,:WISHIWASHI) && i.level>19
        if i.hp>((i.totalhp/4).floor) && i.form!=1
          i.form=1
          i.pbUpdate(true)
          scene.pbChangePokemon(i,i.pokemon)
          @battle.pbDisplay(_INTL("{1} formed a school!",pbThis))
          PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
        elsif i.hp<((i.totalhp/4).floor) && i.form!=0
          i.form=0
          i.pbUpdate(true)
          scene.pbChangePokemon(i,i.pokemon)
         @battle.pbDisplay(_INTL("{1} stopped schooling!",pbThis))
          PBDebug.log("[Form changed] #{i.pbThis} changed to form #{i.form}")
        end
      end

Hello, I'm trying to use your Schooling script for my game,but, when Wishiwashi is below 1/4 of its health and needs to transform back into its solo form, an error box appears which say that "PBThis is not defined", even though I have the "def PBThis" script in PokeBattle_Battlers.Do you know what could cause this?

mgriffin · Apr 16, 2020

Seenit45 said:
Hello, I'm trying to use your Schooling script for my game,but, when Wishiwashi is below 1/4 of its health and needs to transform back into its solo form, an error box appears which say that "PBThis is not defined", even though I have the "def PBThis" script in PokeBattle_Battlers.Do you know what could cause this?

Just checking, it probably isn't this, but do you know pbThis and PBThis are different? Capitalization matters.

Seenit45 · Apr 16, 2020

mgriffin said:
Just checking, it probably isn't this, but do you know pbThis and PBThis are different? Capitalization matters.

Yeah, it's pbThis in my script, and it still giving me an error message. There's also an error saying that pbIsOpposing is also an undefined value. I don't know why it says that, since both pbThis and pbIsOpposing are defined in my script editor.

Seenit45 · Apr 16, 2020

If it helps, this is the error message that I get (It doesn't crash the game,but I still need to get rid of it):

Code:

Exception: NoMethodError
Message: undefined method `pbIsOpposing?' for nil:NilClass
PokeBattle_Battle:423:in `pbThis'
PokeBattle_Battle:3867:in `__clauses__pbEndOfRoundPhase'
PokeBattle_Battle:3854:in `each'
PokeBattle_Battle:3854:in `__clauses__pbEndOfRoundPhase'
PokeBattle_Clauses:42:in `pbEndOfRoundPhase'
PokeBattle_Battle:2551:in `pbStartBattleCore'
PokeBattle_Battle:2550:in `logonerr'
PokeBattle_Battle:2550:in `pbStartBattleCore'
PokeBattle_Battle:2532:in `loop'
PokeBattle_Battle:2555:in `pbStartBattleCore'
[Pokémon Essentials version 17.2]
Exception: NoMethodError
Message: undefined method `pbIsOpposing?' for nil:NilClass
PokeBattle_Battle:423:in `pbThis'
PokeBattle_Battle:3867:in `__clauses__pbEndOfRoundPhase'
PokeBattle_Battle:3854:in `each'
PokeBattle_Battle:3854:in `__clauses__pbEndOfRoundPhase'
PokeBattle_Clauses:42:in `pbEndOfRoundPhase'
PokeBattle_Battle:2551:in `pbStartBattleCore'
PokeBattle_Battle:2550:in `logonerr'
PokeBattle_Battle:2550:in `pbStartBattleCore'
PokeBattle_Battle:2532:in `loop'
PokeBattle_Battle:2555:in `pbStartBattleCore'

WolfPP · Apr 17, 2020

Unfortunately I tested my script on the battle (again) and everything looks fine.
Please double check the tutorial and add the script again, maybe you forgot to add some 'attr' or something.

SuperSpyroDragon64 · Aug 2, 2020

Does the Schooling script work yet? Where's the working one?

SuperSpyroDragon64 · Aug 2, 2020

a Syntax error at line 483 is keeping my game from compiling and turning on.

MultipleForms.register(:MINIOR,{
"getFormOnCreation"=>proc{|pokemon|
next 1+rand(7)
}
},
"onSetForm"=>proc{|pokemon,form|
pokemon.formTime=(form>0) ? pbGetTimeNow.to_i : nil
}
})

That last line with the }) is causing the error. How can it be fixed?

Turn20Negate · Aug 2, 2020

Remove the marked part. :)

Spoiler:

ArchyTheArc · Aug 3, 2020

Really handy script helps fixes them as you stated, only issue is, wild minior wont become shield form but stay the random core color,

now my forms are ordered different with the shield form being form 7 with the colours being 0-6, i adjusted the scripts accordingly (any mention of 0 was made into 7 and removed the 1+ in the rand bits)

i do have the genwildpoke bit but nothing.

[Essentials v17.2]Fixing some abilities that triggered into the end of turn

More options

WolfPP

Spriter/ Pixel Artist

CharizardThree3

WolfPP

Spriter/ Pixel Artist

Citric

WolfPP

Spriter/ Pixel Artist

neckpunch73

mgriffin

WolfPP

Spriter/ Pixel Artist

WolfPP

Spriter/ Pixel Artist

Seenit45

mgriffin

Seenit45

Seenit45

WolfPP

Spriter/ Pixel Artist

SuperSpyroDragon64

SuperSpyroDragon64

Turn20Negate

ArchyTheArc