[Scripting Question] Ability help (Again)

[clawort]

Hi! I am having some trouble with another ability. It's called Triple Terror and it allows biting moves to hit three times in a row. You see, Idk how to do that and will someone help me?

The move is similar to Parental Bond BTW, except it's three times instead of two times.

 

[WolfPP]

Well, did you try to copy Parental Bond's code and edit to hit three times?

 

[clawort]

Well, did you try to copy Parental Bond's code and edit to hit three times?

Idk how to do that, especially if I want only biting moves to hit three times.

 

[mgriffin]

Idk how to do that, especially if I want only biting moves to hit three times.

Well look at the code and tell us what ideas you have about what to change. You can also take inspiration from Strong Jaw (or other abilities that care about particular kinds of moves) for how to limit it only to biting moves.

 

[clawort]

Well look at the code and tell us what ideas you have about what to change. You can also take inspiration from Strong Jaw (or other abilities that care about particular kinds of moves) for how to limit it only to biting moves.

Well, the code for Parental Bond is this:

Spoiler:

def pbNumHits(attacker)
# Parental Bond goes here (for single target moves only)
if attacker.hasWorkingAbility(:PARENTALBOND)
if pbIsDamaging? && !pbTargetsMultiple?(attacker) &&
!pbIsMultiHit && !pbTwoTurnAttack(attacker)
exceptions=[0x6E, # Endeavor
0xE0, # Selfdestruct/Explosion
0xE1, # Final Gambit
0xF7] # Fling
if !exceptions.include?(@function)
attacker.effects[PBEffects::ParentalBond]=3
return 2
end
end
end
# Need to record that Parental Bond applies, to weaken the second attack
return 1
end

What do I change?

 

[mgriffin]

Well, the code for Parental Bond is this:

Spoiler:

def pbNumHits(attacker)
# Parental Bond goes here (for single target moves only)
if attacker.hasWorkingAbility(:PARENTALBOND)
if pbIsDamaging? && !pbTargetsMultiple?(attacker) &&
!pbIsMultiHit && !pbTwoTurnAttack(attacker)
exceptions=[0x6E, # Endeavor
0xE0, # Selfdestruct/Explosion
0xE1, # Final Gambit
0xF7] # Fling
if !exceptions.include?(@function)
attacker.effects[PBEffects::ParentalBond]=3
return 2
end
end
end
# Need to record that Parental Bond applies, to weaken the second attack
return 1
end

What do I change?

What do you think you'd change to make the move do three hits instead of two? Then try changing it, then try using a Pokémon with Parental Bond and see if it works. Then if it doesn't try something else.

 

[WolfPP]

It's time for you to burn neurons to make own abilities. Like MrGriffin said, copy like Strong Jaw abilities works to recognize if the move is Biting Move. Maybe something like this (you need to find all PARENTALBOND instead and copy and edit to your Triple Terror):

    if attacker.hasWorkingAbility(:TRIPLETERROR)
      if pbIsDamaging? && [COLOR="Red"]!isBitingMove?[/COLOR] && !pbTargetsMultiple?(attacker) &&
         !pbIsMultiHit && !pbTwoTurnAttack(attacker)
        exceptions=[0x6E,   # Endeavor
                    0xE0,   # Selfdestruct/Explosion
                    0xE1,   # Final Gambit
                    0xF7]   # Fling
        if !exceptions.include?(@function)
          attacker.effects[PBEffects::TripleTerror]=[COLOR="Red"]4[/COLOR]
          return [COLOR="red"]3[/COLOR]
        end
      end
    end

Some trial and error you can get it.

 

[clawort]

What do you think you'd change to make the move do three hits instead of two? Then try changing it, then try using a Pokémon with Parental Bond and see if it works. Then if it doesn't try something else.

The only Pokemon with Parental Bond is Mega Kangaskhan!

 

[clawort]

It's time for you to burn neurons to make own abilities. Like MrGriffin said, copy like Strong Jaw abilities works to recognize if the move is Biting Move. Maybe something like this (you need to find all PARENTALBOND instead and copy and edit to your Triple Terror):

    if attacker.hasWorkingAbility(:TRIPLETERROR)
      if pbIsDamaging? && [COLOR="Red"]!isBitingMove?[/COLOR] && !pbTargetsMultiple?(attacker) &&
         !pbIsMultiHit && !pbTwoTurnAttack(attacker)
        exceptions=[0x6E,   # Endeavor
                    0xE0,   # Selfdestruct/Explosion
                    0xE1,   # Final Gambit
                    0xF7]   # Fling
        if !exceptions.include?(@function)
          attacker.effects[PBEffects::TripleTerror]=[COLOR="Red"]4[/COLOR]
          return [COLOR="red"]3[/COLOR]
        end
      end
    end

Some trial and error you can get it.

But how the heck to I make it a three hit move?

 

[mgriffin]

The only Pokemon with Parental Bond is Mega Kangaskhan!

So either test with Mega Kanga or alter the PBS file to give Parental Bond to another Pokémon? How do you normally check if the changes you've made work?

In any case Wolf pretty much gave you the answer, so…
(I think it's slightly wrong, but if you test it should be pretty obvious what's going on and what kind of thing you would need to look for in the code to fix it).

 

[clawort]

So either test with Mega Kanga or alter the PBS file to give Parental Bond to another Pokémon? How do you normally check if the changes you've made work?

In any case Wolf pretty much gave you the answer, so…
(I think it's slightly wrong, but if you test it should be pretty obvious what's going on and what kind of thing you would need to look for in the code to fix it).

Okay but how do I make it a three hit ability limited to biting moves?

 

[clawort]

Okay I am having a slight problem.

Every time I try using a biting move to test out the ability, it plays other animations other than the biting animation. Why?

 

[WolfPP]

Focus: your ability works correctly (hit 3 times) or not?

 

[clawort]

Focus: you ability works correctly (hit 3 times) or not?

Yes.

 

[WolfPP]

So you need to create a animation to your ability, like Parental Bond:

  def pbShowAnimation(id,attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    return if !showanimation
    if attacker.effects[PBEffects::ParentalBond]==1
      [COLOR="Red"]@battle.pbCommonAnimation("ParentalBond",attacker,opponent)[/COLOR]
      return
    end
    @battle.pbAnimation(id,attacker,opponent,hitnum)
  end

Or try to create a pbAnimation to your ability using bite animation:

@battle.pbAnimation(getConst(PBMoves,:[COLOR="red"]XXX[/COLOR]),[COLOR="red"]self[/COLOR],[COLOR="red"]nil[/COLOR])

Change the red words to correct one. I think 'self' could be 'attacker' and 'nil' is 'opponent'. Anyway, Trial and Error. Good luck.

 

[clawort]

So you need to create a animation to your ability, like Parental Bond:

  def pbShowAnimation(id,attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    return if !showanimation
    if attacker.effects[PBEffects::ParentalBond]==1
      [COLOR="Red"]@battle.pbCommonAnimation("ParentalBond",attacker,opponent)[/COLOR]
      return
    end
    @battle.pbAnimation(id,attacker,opponent,hitnum)
  end

Or try to create a pbAnimation to your ability using bite animation:

@battle.pbAnimation(getConst(PBMoves,:[COLOR="red"]XXX[/COLOR]),[COLOR="red"]self[/COLOR],[COLOR="red"]nil[/COLOR])

Change the red words to correct one. I think 'self' could be 'attacker' and 'nil' is 'opponent'. Anyway, Trial and Error. Good luck.

Okay! I'll try...

 

[clawort]

So you need to create a animation to your ability, like Parental Bond:

  def pbShowAnimation(id,attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    return if !showanimation
    if attacker.effects[PBEffects::ParentalBond]==1
      [COLOR="Red"]@battle.pbCommonAnimation("ParentalBond",attacker,opponent)[/COLOR]
      return
    end
    @battle.pbAnimation(id,attacker,opponent,hitnum)
  end

Or try to create a pbAnimation to your ability using bite animation:

@battle.pbAnimation(getConst(PBMoves,:[COLOR="red"]XXX[/COLOR]),[COLOR="red"]self[/COLOR],[COLOR="red"]nil[/COLOR])

Change the red words to correct one. I think 'self' could be 'attacker' and 'nil' is 'opponent'. Anyway, Trial and Error. Good luck.

Didn't work.