[Scripting Question] Aurora Veil and Innards Out bugs

[Tommaniacal]

Hello, I recently implemented the scripts from Marin's gen 7 thread: https://www.pokecommunity.com/threads/387706 and I noticed 2 bugs (that are unrelated to one another). I would post on that thread but it was closed.

The first is that Aurora Veil only lasts til the end of the turn. I'm nearly positive I pasted everything in correctly, but here's everything:

EDIT: Found the problem! In Pokebattle_Battle, this:

    # Aurora Veil
    for i in 0...2
      if sides[i].effects[PBEffects::AuroraVeil]>0
        sides[i].effects[PBEffects::AuroraVeil]-=1
       [COLOR="Red"] if sides[i].effects[PBEffects::AuroraVeil]=0[/COLOR]
          pbDisplay(_INTL("Your team's Aurora Veil faded!")) if i==0
          pbDisplay(_INTL("The opposing team's Aurora Veil faded!")) if i==1
          PBDebug.log("[End of effect] Aurora Veil ended on the player's side") if i==0
          PBDebug.log("[End of effect] Aurora Veil ended on the opponent's side") if i==1
        end
      end
    end

should be changed to this:

    # Aurora Veil
    for i in 0...2
      if sides[i].effects[PBEffects::AuroraVeil]>0
        sides[i].effects[PBEffects::AuroraVeil]-=1
        [COLOR="Red"]if sides[i].effects[PBEffects::AuroraVeil]==0[/COLOR]
          pbDisplay(_INTL("Your team's Aurora Veil faded!")) if i==0
          pbDisplay(_INTL("The opposing team's Aurora Veil faded!")) if i==1
          PBDebug.log("[End of effect] Aurora Veil ended on the player's side") if i==0
          PBDebug.log("[End of effect] Aurora Veil ended on the opponent's side") if i==1
        end
      end
    end

The second bug is that Innards Out activates twice once you faint pyukumuku:

Spoiler:

In Pokebattle_Battler underneath Aftermath:

        if target.hasWorkingAbility(:INNARDSOUT,true) && target.isFainted? &&
           !user.isFainted?
            PBDebug.log("[Ability triggered] #{target.pbThis}'s Innards Out")
            @battle.scene.pbDamageAnimation(user,0)
            user.pbReduceHP(target.lastHPLost)
            @battle.pbDisplay(_INTL("{1} was hurt by {2}'s {3}!",user.pbThis,
               target.pbThis,PBAbilities.getName(target.ability)))
        end

Has anyone experienced this/know how to fix this?

 

[WolfPP]

About Innards Out, dig here:
https://www.pokecommunity.com/threads/417343

 

[Tommaniacal]

About Innards Out, dig here:
https://www.pokecommunity.com/threads/417343

Found it, thanks! In case anyone stumbles here searching for an updated innards out code:

Spoiler:

in Pokebattler_Battler, underneath aftermath:

        # Innards Out
        if target.ability==PBAbilities::INNARDSOUT && target.fainted? && 
           thismove.basedamage>0 && !target.effects[PBEffects::GastroAcid] &&
           !user.hasWorkingAbility(:MAGICGUARD)
          if target.effects[PBEffects::FutureSight]>0
            for i in 0...4
              if target.effects[PBEffects::FutureSightUser][email protected][i].pokemonIndex &&
                 [email protected][i].fainted?
                PBDebug.log("[Ability triggered] #{target.pbThis}'s Innards Out")
                user.pbReduceHP(turneffects[PBEffects::TotalDamage])
                @battle.pbDisplay(_INTL("{1} is hurt!",user.pbThis))
                break
              end
            end
          else
            PBDebug.log("[Ability triggered] #{target.pbThis}'s Innards Out")
            user.pbReduceHP(turneffects[PBEffects::TotalDamage])
            @battle.pbDisplay(_INTL("{1} is hurt!",user.pbThis))
          end
        end

 

[WolfPP]

Found it, thanks! In case anyone stumbles here searching for an updated innards out code:

Spoiler:

in Pokebattler_Battler, underneath aftermath:

        # Innards Out
        if target.ability==PBAbilities::INNARDSOUT && target.fainted? && 
           thismove.basedamage>0 && !target.effects[PBEffects::GastroAcid] &&
           !user.hasWorkingAbility(:MAGICGUARD)
          if target.effects[PBEffects::FutureSight]>0
            for i in 0...4
              if target.effects[PBEffects::FutureSightUser][email protected][i].pokemonIndex &&
                 [email protected][i].fainted?
                PBDebug.log("[Ability triggered] #{target.pbThis}'s Innards Out")
                user.pbReduceHP(turneffects[PBEffects::TotalDamage])
                @battle.pbDisplay(_INTL("{1} is hurt!",user.pbThis))
                break
              end
            end
          else
            PBDebug.log("[Ability triggered] #{target.pbThis}'s Innards Out")
            user.pbReduceHP(turneffects[PBEffects::TotalDamage])
            @battle.pbDisplay(_INTL("{1} is hurt!",user.pbThis))
          end
        end

Also remember to give credits for the scripters that wrote the code.