[Battle] Difficulty with Move Names (PokeRed)

[eshasunrise]

Listing under battle, but more to do with move names.

Making a Rom Hack of Pokemon Red and Blue using Pokered Assembly and bits of code from Shin Pokered. Currently having trouble with move names. When the pokemon learns a new move past move 200, it's name shows up as a TM. The move itself generally works fine. I tried editing the TM macros a la Shin Pokered, but this causes the game to crash upon learning a new move. Any ideas what to do from here? I'm hoping this won't require me to make heavy constant, data, and engine edits...

 

[jojobear13]

Listing under battle, but more to do with move names.

Making a Rom Hack of Pokemon Red and Blue using Pokered Assembly and bits of code from Shin Pokered. Currently having trouble with move names. When the pokemon learns a new move past move 200, it's name shows up as a TM. The move itself generally works fine. I tried editing the TM macros a la Shin Pokered, but this causes the game to crash upon learning a new move. Any ideas what to do from here? I'm hoping this won't require me to make heavy constant, data, and engine edits...

I think I know what's going on here. You are trying to add moves in excess of the value of constant HM_01. As a result, you are running into a minor coding oversight left by Gamefreak. Please direct your attention to the GetName:: function in the home.asm file. You will probably notice the comment "BUG: This applies to all names instead of just items." followed by something like "cp HM_01" on a proceeding line. What this is doing is testing how the main argument of the function, held in register A, relates to the constant value HM_01. What this ends up doing is that if the value in A is < HM_01 then the function defaults to returning the item-list name of the machine that matches the argument. Even if you really wanted the name of a move or something else. This was never an issue during Pokemon's development because no other name lists had over 195 entries.

Please see the attached side-by-side text report for a possible fix.

 

[eshasunrise]

So funny thing, I literally just fixed this. You were right, it was absolutely the GetName TM Macro. My current fix is as follows.

Spoiler:

; returns pointer to name in de
ld a, [wd0b5]
ld [wd11e], a

; TM names are separate from item names.
; BUG: This applies to all names instead of just items. ;Eilenenote, hopefully fixed
cp THUNDERKICK ; is this a move?
jp nc, .StartNaming
cp HM01
jp nc, GetMachineName
.StartNaming
ldh a, [hLoadedROMBank]

I'm a bit worried about TM names generating properly, but I'm playtesting now. If the fix doesn't work, I'll look to your solution.

Thanks again for all the help!