[Scripting Question] Give STAB to a type that isn't the move's type?

[Keundt]

EDIT: Fixed! I changed the code to work on a pokemon-by-pokemon basis, rather than type.

Spoiler:

################################################################################
# Magma Sauce, Gell/Fire Type Damage
################################################################################
class PokeBattle_Move_160 < PokeBattle_Move
def pbModifyDamage(damagemult,attacker,opponent)
if isConst?(attacker.species,PBSpecies,:SLUGMA)
return (damagemult*1.5).round
elsif !attacker.pbHasType?(:MAGCARGO)
return (damagemult*1.5).round
end
return damagemult
end

def pbAdditionalEffect(attacker,opponent)
return if opponent.damagestate.substitute
if opponent.pbCanBurn?(attacker,false,self)
opponent.pbBurn(attacker)
end
end
end

Hi,

I made a Gell type, and I'm in the process of making a signature move (Magma Sauce) for Slugma/Magcargo and a gravy fakemon. I wanted it to be a Gell type move that dealt Fire type damage instead. Originally I was going to try for dual-typing, but Gell and Fire cancelled out on pretty much all the 2x and 0.5x modifiers. So I want this move to be Gell type and deal Fire type damage instead.

I made a separate type (and gave its graphic a half-red half-green color), but now I want to make sure that Gell type pokemon get stab. It's still a Gell move. Slugma though, loses its Fire/Gell typing when it evolves to Magcargo for Fire/Rock, so I also want it to have stab through Fire.

Magma Sauce's Description:
"Deals Fire type damage instead. The power is boosted if the user is Fire or Gell type. May leave a burn." 65 Power, Special.

I tested it out on a rattata with slugma. I can't tell if it has 1.5x or not, but ember seems to be stronger.

I want to know if I did the coding correctly (I don't code, I just thought this would work):

Spoiler:

################################################################################
# Magma Sauce, Gell/Fire Type Damage
################################################################################
class PokeBattle_Move_160 < PokeBattle_Move
def pbModifyDamage(damagemult,attacker,opponent)
if USENEWBATTLEMECHANICS && attacker.pbHasType?(:GELL)
return (damagemult*1.5).round
elsif USENEWBATTLEMECHANICS && attacker.pbHasType?(:FIRE)
return (damagemult*1.5).round
end
return damagemult
end

def pbAdditionalEffect(attacker,opponent)
return if opponent.damagestate.substitute
if opponent.pbCanBurn?(attacker,false,self)
opponent.pbBurn(attacker)
end
end
end

Thanks. :)