Hello, new and need some help

[Ezee03]

I installed pokered, and i want to create Japanese pokemon red/green/blue title screen from an English pokemon blue, but when i edit the files it doesnt work, am i doing something wrong? can somebody point me in the right direction please, as ive been trying to do this for a while, just cannot seem to get this right, thankyou if you can help!

 

[Anon822]

I installed pokered, and i want to create Japanese pokemon red/green/blue title screen from an English pokemon blue, but when i edit the files it doesnt work, am i doing something wrong? can somebody point me in the right direction please, as ive been trying to do this for a while, just cannot seem to get this right, thankyou if you can help!

There's not much anyone can do since you haven't actually described what the issue you're having is.
Did you compile the rom after editing the files? If you are running into an error while compiling you should post the error message.

 

[Ezee03]

There's not much anyone can do since you haven't actually described what the issue you're having is.
Did you compile the rom after editing the files? If you are running into an error while compiling you should post the error message.

So far I have tried editing the files in pokered itself, like this

IF _GREEN
db $62,$63,$64,$7F,$65,$66,$67,$68,$69,"@" ; "Green Version"
ENDC

but when I put that in the file, it doesn't work
and I have also tried doing it through a tile editor, still no luck.

 

[Anon822]

So far I have tried editing the files in pokered itself, like this

IF _GREEN
db $62,$63,$64,$7F,$65,$66,$67,$68,$69,"@" ; "Green Version"
ENDC

but when I put that in the file, it doesn't work
and I have also tried doing it through a tile editor, still no luck.

You still haven't explained what the problem is (or which files you have changed), "it doesn't work" doesn't tell me anything.
Based on the code snippet I'm assuming you're editing the end of engine/move/title.asm

If I copy-paste your code onto line 407, I get the error:

ERROR: main.asm(10) -> engine/movie/title.asm(407):
    Expected constant expression: '_GREEN' is not constant at assembly time
error: Assembly aborted (1 error)!
make: *** [Makefile:89: main_red.o] Error 1

This is because the _GREEN is not inside a DEF function like the other version checks are, changing the first line to

IF DEF(_GREEN)

causes the code to compile fine (but it won't actually do anything since _GREEN is never defined anywhere).

If I copy-paste

db $62,$63,$64,$7F,$65,$66,$67,$68,$69,"@" ; "Green Version"

to the IF DEF(_RED) block, I get a red rom with the text "green version" on the title screen, which is what I assume you wanted to happen.

 

[Ezee03]

You still haven't explained what the problem is (or which files you have changed), "it doesn't work" doesn't tell me anything.
Based on the code snippet I'm assuming you're editing the end of engine/move/title.asm

If I copy-paste your code onto line 407, I get the error:

ERROR: main.asm(10) -> engine/movie/title.asm(407):
    Expected constant expression: '_GREEN' is not constant at assembly time
error: Assembly aborted (1 error)!
make: *** [Makefile:89: main_red.o] Error 1

This is because the _GREEN is not inside a DEF function like the other version checks are, changing the first line to

IF DEF(_GREEN)

causes the code to compile fine (but it won't actually do anything since _GREEN is never defined anywhere).

If I copy-paste

db $62,$63,$64,$7F,$65,$66,$67,$68,$69,"@" ; "Green Version"

to the IF DEF(_RED) block, I get a red rom with the text "green version" on the title screen, which is what I assume you wanted to happen.

It works on IF RED, but not on IF BLUE ?

 

[Ezee03]

that works mate! btw do you know how to change the color of red/blue/green sgb (meaning when starting up the game its in a certain color)

 

[Anon822]

It works on IF RED, but not on IF BLUE ?

The tiles for "green" seem to only be in the graphic used in red. If you search for its filename, you will find it mentioned in gfx/version.asm, which you can modify to make blue use the same graphic.

that works mate! btw do you know how to change the color of red/blue/green sgb (meaning when starting up the game its in a certain color)

I don't but you can probably find the data by searching for "sgb" or by looking at the files in the folder called "sgb".

 

[Ezee03]

The tiles for "green" seem to only be in the graphic used in red. If you search for its filename, you will find it mentioned in gfx/version.asm, which you can modify to make blue use the same graphic.


I don't but you can probably find the data by searching for "sgb" or by looking at the files in the folder called "sgb".

i found the files in pokered i think, but what would the numbers be for green, as only blue and red are shown, do you know where i could find the numbers for green?