- 12
- Posts
- 1
- Years
- California, USA
- Seen Aug 14, 2023
Hello! I'm working on a hack which takes every battle in SoulSilver and makes them into double battles. The last thing I did was go through all of the trainers and mark them as doubles battles. I also gave an extra Pokemon to trainers which previously only had one. However, when I booted up the ROM to test it, this simple change seems to have broken all trainer encounters.
Here is a screenshot of the tool I've been using (DSPRE) with Youngster Joey's settings (All I did was mark it as a double battle and give him a second Rattata):
https://drive.google.com/file/d/19gc7SYSnLF5i5xGzFOqErlbnoSd3Hqqx/preview
Here is a video of the issue in action:
https://www.youtube.com/watch?v=qvRySRbFnHk
You'll see near the end that Youngster Mikey has the same issue. The only change to him was setting him as a double battle.
Does anyone know why this is happening? Is the tool I'm using not good for trainer edits? Or maybe the game just doesn't like the double battle setting?? I've hunted for hours to see if there is a script file or anything that sets a flag for doubles, but when I compare to a working example (Twins on the route south of Ecruteak), nothing seems different.
Things I've tried and notes:
- Turning Joey into the "Twins" trainer class doesn't solve it
- Changing everything back to how it was still seems to cause the issue (This is why I'm sus on the tool I'm using)
- Setting Joey as "Partner" doesn't change anything
- I have no idea why the trainer quotes are broken
- I triple checked that both me and Joey had 2 Pokemon (And the battle functions if I talk to him manually, just without proper text. The exclamation mark animation softlocks)
- I've messed around with this in a fresh, unedited ROM trying to isolate the issue, and the game still softlocks, though sometimes in different ways
-- Sometimes it freezes me in place when I should be spotted, but it hangs there. My following Pokemon animates and I can tap touch screen buttons, but nothing works.
-- Sometimes I can speak to Joey, but the game lags heavily for multiple seconds before returning to normal without showing any text
-- Sometimes I can't interact with Joey at all (But I can with other non-trainer NPCs)
In case it's the fault of the tool I'm using, does anyone have suggestions for ones that are known to work for editing trainers?
Any ideas/theories/advice is appreciated!
EDIT: I've now tried the following:
- Used Spiky's DS Map Editor to edit Joey (I edited a fresh, untouched backup of the ROM). Literally all I did was give Joey an extra Pokemon and set him as a double battle, and the game now refuses to load at all in MelonDS lol.
- Tried DeSmuME, in case it was an emulation issue. I had the same problem as MelonDS, so I think emulation issues can be ruled out here. Although DeSmuME actually loaded the ROM I created with Spiky's tool. It still locks up (and crashes the program) when I walk into Joey's vision range.
Seems like Spiky's editor is even worse than what I've been using lolol. I'm kinda glad it isn't MelonDS' fault, but at the same time, life would be so much easier if it was just an emulation bug. ;-;
Here is a screenshot of the tool I've been using (DSPRE) with Youngster Joey's settings (All I did was mark it as a double battle and give him a second Rattata):
https://drive.google.com/file/d/19gc7SYSnLF5i5xGzFOqErlbnoSd3Hqqx/preview
Here is a video of the issue in action:
https://www.youtube.com/watch?v=qvRySRbFnHk
You'll see near the end that Youngster Mikey has the same issue. The only change to him was setting him as a double battle.
Does anyone know why this is happening? Is the tool I'm using not good for trainer edits? Or maybe the game just doesn't like the double battle setting?? I've hunted for hours to see if there is a script file or anything that sets a flag for doubles, but when I compare to a working example (Twins on the route south of Ecruteak), nothing seems different.
Things I've tried and notes:
- Turning Joey into the "Twins" trainer class doesn't solve it
- Changing everything back to how it was still seems to cause the issue (This is why I'm sus on the tool I'm using)
- Setting Joey as "Partner" doesn't change anything
- I have no idea why the trainer quotes are broken
- I triple checked that both me and Joey had 2 Pokemon (And the battle functions if I talk to him manually, just without proper text. The exclamation mark animation softlocks)
- I've messed around with this in a fresh, unedited ROM trying to isolate the issue, and the game still softlocks, though sometimes in different ways
-- Sometimes it freezes me in place when I should be spotted, but it hangs there. My following Pokemon animates and I can tap touch screen buttons, but nothing works.
-- Sometimes I can speak to Joey, but the game lags heavily for multiple seconds before returning to normal without showing any text
-- Sometimes I can't interact with Joey at all (But I can with other non-trainer NPCs)
In case it's the fault of the tool I'm using, does anyone have suggestions for ones that are known to work for editing trainers?
Any ideas/theories/advice is appreciated!
EDIT: I've now tried the following:
- Used Spiky's DS Map Editor to edit Joey (I edited a fresh, untouched backup of the ROM). Literally all I did was give Joey an extra Pokemon and set him as a double battle, and the game now refuses to load at all in MelonDS lol.
- Tried DeSmuME, in case it was an emulation issue. I had the same problem as MelonDS, so I think emulation issues can be ruled out here. Although DeSmuME actually loaded the ROM I created with Spiky's tool. It still locks up (and crashes the program) when I walk into Joey's vision range.
Seems like Spiky's editor is even worse than what I've been using lolol. I'm kinda glad it isn't MelonDS' fault, but at the same time, life would be so much easier if it was just an emulation bug. ;-;
Last edited: