[Scripting Question] How to allow player to jump up ledges + steal Pokemon from other Trainers if outfit is set to 1 [v18.1]

[0maewam0ushindeiru]

I am planning a game where the player joins Team Rocket and obtains a uniform for the team, setting their outfit to 1.
I want to make two things only accessible to this outfit: stealing Pokemon from NPC Trainers, and jumping up ledges that you normally can only jump down.
Any help is appreciated, and I think I am already slowly figuring out the theft aspect. I will provide the code I have for the theft aspect so far, and you can point out what I did wrong.

if trainerBattle? && !pbIsSnagBall?(ball)
      @scene.pbThrowAndDeflect(ball,1)
      pbDisplay(_INTL("The Trainer blocked your Poké Ball! Don't be a thief!"))
      return
    end
    if trainerBattle? && (pbIsSnagBall?(ball) && $Trainer.outfit=1)
      idxTarget = idxBattler
      idxBattler = idxBattler.index if idxBattler.respond_to?("index")
      pkmn = battler.pokemon
      @criticalCapture = false
      numShakes = pbCaptureCalc(pkmn,battler,rareness,ball)
      PBDebug.log("[Threw Poké Ball] #{itemName}, #{numShakes} shakes (4=capture)")
      return
    end

NOTE: It is all positioned correctly in the scripts.

 

[Pokeminer20]

I am planning a game where the player joins Team Rocket and obtains a uniform for the team, setting their outfit to 1.
I want to make two things only accessible to this outfit: stealing Pokemon from NPC Trainers, and jumping up ledges that you normally can only jump down.
Any help is appreciated, and I think I am already slowly figuring out the theft aspect. I will provide the code I have for the theft aspect so far, and you can point out what I did wrong.

if trainerBattle? && !pbIsSnagBall?(ball)
      @scene.pbThrowAndDeflect(ball,1)
      pbDisplay(_INTL("The Trainer blocked your Poké Ball! Don't be a thief!"))
      return
    end
    if trainerBattle? && (pbIsSnagBall?(ball) && $Trainer.outfit=1)
      idxTarget = idxBattler
      idxBattler = idxBattler.index if idxBattler.respond_to?("index")
      pkmn = battler.pokemon
      @criticalCapture = false
      numShakes = pbCaptureCalc(pkmn,battler,rareness,ball)
      PBDebug.log("[Threw Poké Ball] #{itemName}, #{numShakes} shakes (4=capture)")
      return
    end

NOTE: It is all positioned correctly in the scripts.

looking at your code, both conditions would return true, and that might be a problem. try this instead:

    if trainerBattle? && !pbIsSnagBall?(ball)
     if $Trainer.outfit==1
      idxTarget = idxBattler
      idxBattler = idxBattler.index if idxBattler.respond_to?("index")
      pkmn = battler.pokemon
      @criticalCapture = false
      numShakes = pbCaptureCalc(pkmn,battler,rareness,ball)
      PBDebug.log("[Threw Poké Ball] #{itemName}, #{numShakes} shakes (4=capture)")
      return
     else
      @scene.pbThrowAndDeflect(ball,1)
      pbDisplay(_INTL("The Trainer blocked your Poké Ball! Don't be a thief!"))
      return
     end
    end

 

[0maewam0ushindeiru]

looking at your code, both conditions would return true, and that might be a problem. try this instead:

    if trainerBattle? && !pbIsSnagBall?(ball)
     if $Trainer.outfit==1
      idxTarget = idxBattler
      idxBattler = idxBattler.index if idxBattler.respond_to?("index")
      pkmn = battler.pokemon
      @criticalCapture = false
      numShakes = pbCaptureCalc(pkmn,battler,rareness,ball)
      PBDebug.log("[Threw Poké Ball] #{itemName}, #{numShakes} shakes (4=capture)")
      return
     else
      @scene.pbThrowAndDeflect(ball,1)
      pbDisplay(_INTL("The Trainer blocked your Poké Ball! Don't be a thief!"))
      return
     end
    end

Thanks, the corrected code works out.