[Script] Need some help adding a new pokemon species. RHH's Pokemon-expansion

[tldr_coder]

Hey there!

Been struggling for some hours now and just can't seem to figure out where I'm going wrong.
Trying to add in a new pokemon species (David Spade, it's a meme for testing).

Following along with rh-hideout's tutorial: https://github.com/rh-hideout/pokeemerald-expansion/wiki/How-to-add-a-new-Pokémon-species
Some parts where the codebase has seemingly changed since this was written is in section 6 (defining the cry) since cry_ids.h doesn't exist.

For testing I've changed the pokemon that pops up in the start screen to be the new species.

Everything I've done can be seen in the following commits:

Commit with the code changes I've made:
https://github.com/David-vz/pokeemerald-expansion/commit/3ed9b1fc7bd00e1697a47909b39cde7870b14e41

Commit with the sprites added in:
https://github.com/David-vz/pokeemerald-expansion/commit/838ca91fa2de3c94bd1bf52d384fc306ce6f461c

Any help would be super appreciated.

--edit--
Forgot to mention. The pokeemerald.gba builds fine, however either encountering the pokemon in the wild, or showing it in the new game screen crashes to desktop:

 

[Anon822]

Hey there!

Been struggling for some hours now and just can't seem to figure out where I'm going wrong.
Trying to add in a new pokemon species (David Spade, it's a meme for testing).

Following along with rh-hideout's tutorial: https://github.com/rh-hideout/pokeemerald-expansion/wiki/How-to-add-a-new-Pokémon-species
Some parts where the codebase has seemingly changed since this was written is in section 6 (defining the cry) since cry_ids.h doesn't exist.

For testing I've changed the pokemon that pops up in the start screen to be the new species.

Everything I've done can be seen in the following commits:

Commit with the code changes I've made:
https://github.com/David-vz/pokeemerald-expansion/commit/3ed9b1fc7bd00e1697a47909b39cde7870b14e41

Commit with the sprites added in:
https://github.com/David-vz/pokeemerald-expansion/commit/838ca91fa2de3c94bd1bf52d384fc306ce6f461c

Any help would be super appreciated.

--edit--
Forgot to mention. The pokeemerald.gba builds fine, however either encountering the pokemon in the wild, or showing it in the new game screen crashes to desktop:

You need to add animations for it in gMonFrontAnimsPtrTable in src/data/pokemon_graphics/front_pic_anims.h

 

[tldr_coder]

You need to add animations for it in gMonFrontAnimsPtrTable in src/data/pokemon_graphics/front_pic_anims.h

You're a lifesaver @anon822!
That was it.
I thought the anims part was optional when reading through, but it seems you really need to define those to.

For future reference, anyone coming across this post in futureland:

Added in:
static const union AnimCmd sAnim_DAVID_SPADE_1[] =
{
ANIMCMD_FRAME(1, 50),
ANIMCMD_FRAME(1, 50),
ANIMCMD_FRAME(0, 10),
ANIMCMD_END,
};

static const union AnimCmd *const sAnims_DAVID_SPADE[] ={
sAnim_GeneralFrame0,
sAnim_DAVID_SPADE_1,
};

and inside of const union AnimCmd *const *const gMonFrontAnimsPtrTable[] =

ANIM_CMD_FULL(DAVID_SPADE, sAnims_DAVID_SPADE),