• Just a reminder that providing specifics on, sharing links to, or naming websites where ROMs can be accessed is against the rules. If your post has any of this information it will be removed.
  • Ever thought it'd be cool to have your art, writing, or challenge runs featured on PokéCommunity? Click here for info - we'd love to spotlight your work!
  • Our weekly protagonist poll is now up! Vote for your favorite Trading Card Game 2 protagonist in the poll by clicking here.
  • Welcome to PokéCommunity! Register now and join one of the best fan communities on the 'net to talk Pokémon and more! We are not affiliated with The Pokémon Company or Nintendo.

[Script] [Pokered] Newly added trainers don't work, what did I do wrong?

  • 14
    Posts
    11
    Years
    • Seen Jan 1, 2025
    In Viridian Forest I want to add Yellow's trainers to give more trainers to battle before Brock. However, while the trainers are in the proper location, they don't say what they're supposed to say and only the trainer with the 2 Caterpies battles me. I followed the following tutorial (only I figured out the part of adding a custom party myself): https://github.com/pret/pokered/wiki/How-to-Add-a-New-Trainer

    As for what precisely I did:

    In constants\event_constants.asm, of course under the Viridian Forest events, I continued from the existing const EVENT_BEAT_VIRIDIAN_FOREST_TRAINER_2 (so, the same line 5x with numbers 3 to 7)

    In data\maps\objects\ViridianForest.asm, under object_event 27, 40, SPRITE_YOUNGSTER, STAY, NONE, 8 ; person I added the following:
    Spoiler:


    In text\ViridianForest.asm at the end of the file I added the following (note: Frst is not a typo, I followed the disassembly's example which does that in all the AfterBattleText):
    Spoiler:


    In scripts\ViridianForest.asm, first under ViridianForest_TextPointers, under dw ViridianForestText14 I added new lines going from 15 to 19. Then under ViridianForestTrainerHeaders I added the following after the 3 TrainerHeaders that are already there (but before db -1 of course):
    Spoiler:


    And still in the same file, at the end of it I also added this:
    Spoiler:


    Finally, in data\trainers\parties.asm I added the following at the end of BugCatcherData (parties 15-18 in the BugCatcherData list) and LassData (party 19 in the LassData list) (in this comment, I separate the 2 by --- to not overflow this topic with spoiler buttons). MEW is a custom Metapod with Tackle and String Shot (I used the Mew data for that for simplicity's sake since I'm not using Mew in my hack anyway), in case anyone's wondering why that's there:

    Spoiler:


    EDIT: OK, I've made some progress. Apparantly in scripts/ViridianForest.asm I had to put the text poiners (15-19) between 8 and 9. Now I can battle the trainers and they say what they're supposed to say. However, only the first new trainer with the 2 lvl 7 Caterpies actually spots me with an exclamation mark: the others don't. Also, that first new trainer does so infinitely.
    EDIT2: Ah, something is really wrong. The signs act as doubles for the trainers now. Clearly some pointer issue but I don't know what, the guide says nothing about position and stuff.
     
    Last edited:
    Back
    Top